From nobody Sun Feb 8 17:48:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76345+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76345+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1623365189; cv=none; d=zohomail.com; s=zohoarc; b=VYRZsEsBwtFl20PCwh9IWZYXli2XVnjzN//ag3VzNEXKQ1BjZ6xCb0khPbJAHFos+lVMEurnECgj5ZP4BiepPZqiFm0BLXU/GlsBGiV+ugIEDjHJmzgtVBGo5o99AFJXFrpwz/w8ixCLtNHUcrZFqewkZ9vzOLAm7ckM1jRRybc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623365189; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=L0j0VOxqbQUngsPMv1fBk8XVoL2MtO+7gp5S2SHc8ms=; b=aLvmj5KW/ekoWEzSblp96zBrKPbIVDWCGErWeFgMX+L0RVmdeXt7I+O2zoFcwynwxsc1j7NKRXMY5sWlJjFZ7B4pQn2qPPlguXlGzS1bqdciI2dx+zloyESVt2ozk3DqfW2LbwGZKZFDJgSxnHW1R/TfwmITcEv4OBAfx89AANg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76345+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623365189149381.1010138386205; Thu, 10 Jun 2021 15:46:29 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VZiwYY1788612xA2c1L7R1Gd; Thu, 10 Jun 2021 15:46:28 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web10.1057.1623365182124167839 for ; Thu, 10 Jun 2021 15:46:22 -0700 IronPort-SDR: witH/TXGxCguUr/V+sKyVuGpvwTn9/DIwnU1E0scNT3xU2Xrh2is4pQXgSrZLMvhkjrWhVEurI WAhQXXsm6N6g== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="291051494" X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="291051494" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 15:46:09 -0700 IronPort-SDR: nz4U6abkWRozlJH9NXdE6t9OwFqErBw4mEMsPOFMJ8xmxPbShYa8oLFGEM3n/MF3Proe/cpeYp evR8DCGzcQaw== X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="419883431" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.9.161]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 15:46:08 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-devel] [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value Date: Thu, 10 Jun 2021 15:45:49 -0700 Message-Id: <20210610224550.855-3-michael.d.kinney@intel.com> In-Reply-To: <20210610224550.855-1-michael.d.kinney@intel.com> References: <20210610224550.855-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: NPr6cEnt3Vda0HSQMONi3o54x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623365188; bh=38LS7bKlxG/+8bp4kDeE8W+CxOK5fYh0CAZS83Jm/lU=; h=Cc:Date:From:Reply-To:Subject:To; b=vJo9ttbpm3lWEY74vf0l0yZDX1uHxzvq7Afn9tZOkvLQNAGpkBFlfHqy0vs0xwiVZ7W le1WhXlLqOy0xNsde6DmerzjHxA0n205WW/Qj7FNIKpGSrUXKWRBgr6QOq0bWZ5E7vpRG kYtgB63G6vHQYd/dHJhIayAYMJAQYqld8e8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3451 Update SmBusSendByte() to write value to Command Register instead of Host Data registers. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael D Kinney Reviewed-by: Chasel Chiu --- .../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 +++++++++++++------ 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/Base= SmbusLib.c b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/Base= SmbusLib.c index 5d09e18613..68dc698aaf 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLi= b.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLi= b.c @@ -201,14 +201,24 @@ InternalSmBusNonBlock ( HostControl |=3D B_PCH_SMBUS_PEC_EN; } // - // Set Host Commond Register. + // We do not need Data Register for SendByte Command // - IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HCMD, (UINT8) SMBUS_LIB_COMMAN= D (SmBusAddress)); - // - // Write value to Host Data 0 and Host Data 1 Registers. - // - IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD0, (UINT8) Value); - IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD1, (UINT8) (Value >> 8)); + if ((HostControl =3D=3D V_PCH_SMBUS_SMB_CMD_BYTE) && ((SmBusAddress & BI= T0) =3D=3D B_PCH_SMBUS_WRITE)) { + // + // Set Host Command Register. + // + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HCMD, (UINT8)Value); + } else { + // + // Set Host Command Register. + // + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HCMD, (UINT8) SMBUS_LIB_COMM= AND (SmBusAddress)); + // + // Write value to Host Data 0 and Host Data 1 Registers. + // + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD0, (UINT8) Value); + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD1, (UINT8) (Value >> 8)); + } // // Set Auxiliary Control Regiester. // --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76345): https://edk2.groups.io/g/devel/message/76345 Mute This Topic: https://groups.io/mt/83456851/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-