From nobody Wed May 15 09:01:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76222+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76222+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1623162100; cv=none; d=zohomail.com; s=zohoarc; b=f6Og+V4hsogjm2lyZb9CqRzM+pJhyXDzh9xYjNsN1CNNESTtJSAjnKRzTLgqPxZPE1wWGzPKbdvJuuwQ+AhMPVYmYMmtvSpxfgnaKqVZMXB6vV0OJ9J79eRYCxG9hdJGrt6FQzDBBPq4BSnuxk1WYrNHJs3P8T1yGQQFj36uv8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623162100; h=Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=4FtqiKMjSNC8t2eBPDm/XrGuQGyI673vMOJCJiY54lc=; b=YvI+i9WoWDWEvjraDowH34FbsYE34SJHzp30ODdCXccnuV5hi3ySoCXiMBV2LTVilVKeFJn15ncg0qfezRds8ckLNR1DfXDY6sxAo1ORdRTVW2QbM6I8sWjFcFH7yfa4OmJcWZOdsp6gu18KzisH+u0ZD1Zd271swFmi9CTU9nU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76222+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623162100272416.0168379103052; Tue, 8 Jun 2021 07:21:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 77NNYY1788612xV5u8dIQXnr; Tue, 08 Jun 2021 07:21:39 -0700 X-Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by mx.groups.io with SMTP id smtpd.web08.12849.1623162099089651619 for ; Tue, 08 Jun 2021 07:21:39 -0700 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R801e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=huangming@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Ubmd1wR_1623162073; X-Received: from 842effaa37a8.tbsite.net(mailfrom:huangming@linux.alibaba.com fp:SMTPD_---0Ubmd1wR_1623162073) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Jun 2021 22:21:25 +0800 From: "Ming Huang" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, sami.mujawar@arm.com, jiewen.yao@intel.com, supreeth.venkatesh@arm.com Cc: guoheyi@linux.alibaba.com, Ming Huang Subject: [edk2-devel] [Patch] StandaloneMmPkg: Fixed communicating from TF-A failed issue Date: Tue, 8 Jun 2021 22:21:12 +0800 Message-Id: <20210608142112.87183-1-huangming@linux.alibaba.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,huangming@linux.alibaba.com X-Gm-Message-State: aZaooRz2XIhwFjwmck7GEXVSx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623162099; bh=VGuO6o13y9ixJS+n97O99r9TS1/Vh4c0+P6VnXwLY4I=; h=Cc:Date:From:Reply-To:Subject:To; b=SK8kelecXlaAXnA2odI+xgdZMLoq03zUvRjH8yyEu+7G1fDPesfRTctJlNor+q6yazR HnXIzYeWrz5CETx/9c6Kkht3E6GUhYNcWRoi9fesqi/LRpn708j0W29ebqmngikYTpIir o3T7heMU05gpKEhysAgUBde7ed4petUtl90= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" TF-A: TrustedFirmware-a SPM: Secure Partition Manager(MM) For AArch64, when SPM enable in TF-A, TF-A may communicate to MM with buffer address (PLAT_SPM_BUF_BASE). The address is different from PcdMmBufferBase which use in edk2. Checking address will let TF-A communicate failed to MM. So remove below checking code: if (NsCommBufferAddr < mNsCommBuffer.PhysicalStart) { return EFI_ACCESS_DENIED; } Signed-off-by: Ming Huang --- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c = b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c index 63fbe26642..fe98d3181d 100644 --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c @@ -103,10 +103,6 @@ PiMmStandaloneArmTfCpuDriverEntry ( return EFI_INVALID_PARAMETER; } =20 - if (NsCommBufferAddr < mNsCommBuffer.PhysicalStart) { - return EFI_ACCESS_DENIED; - } - if ((NsCommBufferAddr + sizeof (EFI_MM_COMMUNICATE_HEADER)) >=3D (mNsCommBuffer.PhysicalStart + mNsCommBuffer.PhysicalSize)) { return EFI_INVALID_PARAMETER; --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76222): https://edk2.groups.io/g/devel/message/76222 Mute This Topic: https://groups.io/mt/83396678/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-