From nobody Sun Feb 8 21:21:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76203+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76203+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623154395; cv=none; d=zohomail.com; s=zohoarc; b=m5EiXTrJDcskD8KSvJW1nNIZb54odMS2bGd5Al8/leyXxfKwsN3grYWcVzZRdFySYfqEEju32yPsJceTN1B/U0QPf+jW2vFQllE2Ymctm6HWJidEjW5VO4HmPDuLaywSE4Gr+UY5zkIQUop5S81iOCS2X43io8eVYl0Wo6e4fvY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623154395; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=KFTWJ6lu1G4yjUklmOBkwI1UnL6zttgIfZSC7Xk1qm8=; b=OqfVPkefe7gV+N85+jEc2skOwqNjINBdiBRGpzkfCnMmoUkzRwU5XszUc691LRleziIoBUxoDfo8/tJd2fvSZaD73X1j5Lqw2xNRrYuen1IAWh0mCAjv/boa08XEPE6AAEURl76Nvg5ZQlva9QhF9N+7u+gKBsk3vFohUxClZFI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76203+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623154395053406.1530273902698; Tue, 8 Jun 2021 05:13:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ub3yYY1788612xrHtedYqbd0; Tue, 08 Jun 2021 05:13:14 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.11302.1623154393564749252 for ; Tue, 08 Jun 2021 05:13:13 -0700 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-548-HJXzoRlPN26t7uU-r346yw-1; Tue, 08 Jun 2021 08:13:09 -0400 X-MC-Unique: HJXzoRlPN26t7uU-r346yw-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 57518BBEE1; Tue, 8 Jun 2021 12:13:08 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-27.ams2.redhat.com [10.36.113.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D9AE1349A; Tue, 8 Jun 2021 12:13:06 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Maciej Rabeda , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Siyuan Fu Subject: [edk2-devel] [PUBLIC edk2 PATCH v2 04/10] NetworkPkg/IScsiDxe: clean up library class dependencies Date: Tue, 8 Jun 2021 14:12:53 +0200 Message-Id: <20210608121259.32451-5-lersek@redhat.com> In-Reply-To: <20210608121259.32451-1-lersek@redhat.com> References: <20210608121259.32451-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: b3rPQ9wqrnDOVIiDxBNL0NG6x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623154394; bh=KFTWJ6lu1G4yjUklmOBkwI1UnL6zttgIfZSC7Xk1qm8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=NPUF3pqBjt+7IhUUMzHaVVYICwT9PSQ//w8rs3WQwdiBga4dfjsAwM3P2WsMIyZdmn1 QuBn+xq8D4H7ykX6SDnRUPvfIKaMIsh/0VoGCYS3STEZKQ2thdLmGt0fFlkrLochVcFQr Pj7UUAGYy0S+9ylDDDPx26DtrYfLgZ4PHcw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Sort the library class dependencies in the #include directives and in the INF file. Remove the DpcLib class from the #include directives -- it is not listed in the INF file, and IScsiDxe doesn't call either DpcLib API (QueueDpc(), DispatchDpc()). No functional changes. Cc: Jiaxin Wu Cc: Maciej Rabeda Cc: Philippe Mathieu-Daud=C3=A9 Cc: Siyuan Fu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3356 Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Maciej Rabeda --- NetworkPkg/IScsiDxe/IScsiDxe.inf | 6 +++--- NetworkPkg/IScsiDxe/IScsiImpl.h | 17 ++++++++--------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDx= e.inf index 0ffb340ce05e..543c4083026a 100644 --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf @@ -49,53 +49,53 @@ [Sources] IScsiDriver.c IScsiDriver.h IScsiExtScsiPassThru.c IScsiIbft.c IScsiIbft.h IScsiInitiatorName.c IScsiImpl.h IScsiMisc.c IScsiMisc.h IScsiProto.c IScsiProto.h =20 [Packages] MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec CryptoPkg/CryptoPkg.dec NetworkPkg/NetworkPkg.dec =20 [LibraryClasses] + BaseCryptLib BaseLib BaseMemoryLib DebugLib DevicePathLib HiiLib MemoryAllocationLib NetLib - TcpIoLib PrintLib + TcpIoLib UefiBootServicesTableLib UefiDriverEntryPoint + UefiHiiServicesLib UefiLib UefiRuntimeServicesTableLib - UefiHiiServicesLib - BaseCryptLib =20 [Protocols] gEfiAcpiTableProtocolGuid ## SOMETIMES_CONSUMES ## S= ystemTable gEfiDriverBindingProtocolGuid ## SOMETIMES_PRODUCES gEfiPciIoProtocolGuid ## SOMETIMES_CONSUMES gEfiDhcp4ProtocolGuid ## SOMETIMES_CONSUMES gEfiDhcp6ProtocolGuid ## SOMETIMES_CONSUMES gEfiDhcp4ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES gEfiDhcp6ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES gEfiDns4ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES gEfiDns4ProtocolGuid ## SOMETIMES_CONSUMES gEfiDns6ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES gEfiDns6ProtocolGuid ## SOMETIMES_CONSUMES gEfiIp4Config2ProtocolGuid ## SOMETIMES_CONSUMES gEfiIp6ConfigProtocolGuid ## SOMETIMES_CONSUMES gEfiTcp4ProtocolGuid ## TO_START gEfiTcp6ProtocolGuid ## TO_START gEfiTcp4ServiceBindingProtocolGuid ## TO_START gEfiTcp6ServiceBindingProtocolGuid ## TO_START diff --git a/NetworkPkg/IScsiDxe/IScsiImpl.h b/NetworkPkg/IScsiDxe/IScsiImp= l.h index 387ab9765e9e..d895c7feb947 100644 --- a/NetworkPkg/IScsiDxe/IScsiImpl.h +++ b/NetworkPkg/IScsiDxe/IScsiImpl.h @@ -19,53 +19,52 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include =20 #include #include #include #include #include #include #include #include #include =20 #include #include #include #include #include =20 -#include -#include -#include -#include +#include #include #include +#include +#include +#include #include +#include #include +#include #include -#include +#include #include -#include -#include -#include -#include +#include =20 #include #include #include =20 #include "IScsiConfigNVDataStruc.h" #include "IScsiDriver.h" #include "IScsiProto.h" #include "IScsiCHAP.h" #include "IScsiDhcp.h" #include "IScsiDhcp6.h" =20 #include "IScsiIbft.h" #include "IScsiMisc.h" #include "IScsiDns.h" #include "IScsiConfig.h" =20 #define ISCSI_AUTH_INITIAL 0 =20 --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76203): https://edk2.groups.io/g/devel/message/76203 Mute This Topic: https://groups.io/mt/83394113/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-