From nobody Mon Feb 9 17:24:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76117+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76117+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1623052487; cv=none; d=zohomail.com; s=zohoarc; b=V4TaGCpLPB3dfE985WDeRGXf9ij8pIL1wfmw9wLGFqzMUIuF3d9ahV5++IebsxVSfVn2s26jJu4XLxOuEZbXiL7OBORwp81lrIvb74OBf/1O+/jdMValeXTF63d6fh2jzxNvpg3M639D8K+i3PD3s8GfWZZcM27IskuNEdBclow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623052487; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=3aPtR9pmJrTWgS86R6aIOfoK8UG0RFkhut5fS19wPoU=; b=cawa3JQWc5i1kHt1k77+GcbEoXM3GkJXsoiQxTtLryOoPGgAd62ruyLrv1nb4L8p/BLMmMCD6n30qepeG5PCJ4XPVc9dgxz338RrKkuSX5XrjLmGvc/WE+nrNG1QyurLYRIfrRF2+nAJBEQHKBjjehGReNxGXboH5uUmFtzfHtQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76117+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16230524875171021.3431368811421; Mon, 7 Jun 2021 00:54:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id M2cQYY1788612xJJhQxPhgtV; Mon, 07 Jun 2021 00:54:47 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.33300.1623052486501340902 for ; Mon, 07 Jun 2021 00:54:46 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D6A231B; Mon, 7 Jun 2021 00:54:46 -0700 (PDT) X-Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2004D3F719; Mon, 7 Jun 2021 00:54:43 -0700 (PDT) From: "Sunny Wang" To: devel@edk2.groups.io Cc: Sunny Wang , Samer El-Haj-Mahmoud , Sami Mujawar , Jeremy Linton , Pete Batard , Ard Biesheuvel , =?UTF-8?q?Mario=20B=C4=83l=C4=83nic=C4=83?= , Sunny Wang Subject: [edk2-devel] [PATCH v4 2/3] Silicon/Broadcom/Bcm283x: Clean up GpioPinSet function Date: Mon, 7 Jun 2021 15:53:38 +0800 Message-Id: <20210607075339.342-3-Sunny.Wang@arm.com> In-Reply-To: <20210607075339.342-1-Sunny.Wang@arm.com> References: <20210607075339.342-1-Sunny.Wang@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Sunny.Wang@arm.com X-Gm-Message-State: e2OVI685KAiIvgGFs3l3vnzPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623052487; bh=DpXcP2ZoKWzGJeDPBZclcMLZaUErfsh4s9zeAWQG51g=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Qgpep8UWASy1nc1/nmc1WRYooGu3IhWzqXponwhh8eNnEGdHGqwZcpqaZbqRrmyukzR aWZ2oZE2bGLC95VbAMtY8acsDj4zHzZSHJBg9fQn49ROCBktlcF4cioK/Ub3kQoHL+NM0 MaGx7RYDdHWhuSzur36M+1MplxjvTKiLn8g= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Make the changes below for making it clearer. - Rename GpioPinSet() to GpioPinConfigure() - Rename parameter Val to Config and change its type to BOOLEAN Cc: Samer El-Haj-Mahmoud Cc: Sami Mujawar Cc: Jeremy Linton Cc: Pete Batard Cc: Ard Biesheuvel Cc: Mario B=C4=83l=C4=83nic=C4=83 Signed-off-by: Sunny Wang Reviewed-by: Pete Batard --- Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h | 10 +++++++--- Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c | 9 +++++---- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h b/Silicon/B= roadcom/Bcm283x/Include/Library/GpioLib.h index 75c2c8be51..1f7d2204e0 100644 --- a/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h +++ b/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h @@ -3,6 +3,7 @@ * GPIO manipulation. * * Copyright (c) 2018, Andrei Warkentin + * Copyright (c) 2021, ARM Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -13,6 +14,9 @@ =20 #include =20 +#define CLEAR_GPIO 0 +#define SET_GPIO 1 + VOID GpioPinFuncSet ( IN UINTN Pin, @@ -25,9 +29,9 @@ GpioPinFuncGet ( ); =20 VOID -GpioPinSet ( - IN UINTN Pin, - IN UINTN Val +GpioPinConfigure ( + IN UINTN Pin, + IN BOOLEAN Config ); =20 UINTN diff --git a/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c b/Silicon/B= roadcom/Bcm283x/Library/GpioLib/GpioLib.c index a4b4af59eb..eaf53e5369 100644 --- a/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c +++ b/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c @@ -4,6 +4,7 @@ * * Copyright (c) 2020, Pete Batard * Copyright (c) 2018, Andrei Warkentin + * Copyright (c) 2021, ARM Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -85,9 +86,9 @@ GpioPinFuncGet ( } =20 VOID -GpioPinSet ( - IN UINTN Pin, - IN UINTN Val +GpioPinConfigure ( + IN UINTN Pin, + IN BOOLEAN Config ) { EFI_PHYSICAL_ADDRESS Reg; @@ -102,7 +103,7 @@ GpioPinSet ( // // Different base addresses are used for clear and set // - Reg =3D (Val =3D=3D 0) ? GPIO_GPCLR0 : GPIO_GPSET0; + Reg =3D (Config =3D=3D CLEAR_GPIO) ? GPIO_GPCLR0 : GPIO_GPSET0; Reg +=3D RegIndex * sizeof (UINT32); MmioWrite32 (Reg, 1 << SelIndex); } --=20 2.31.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76117): https://edk2.groups.io/g/devel/message/76117 Mute This Topic: https://groups.io/mt/83365132/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-