From nobody Thu Dec 18 12:28:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75956+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75956+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1622621538; cv=none; d=zohomail.com; s=zohoarc; b=WRQT5G0Y3KxxzDAy+rnhSEl0zsd88U4cj2N0NnSC4hC1LTSOWV417FtT5kjwjssMOhJIqHYK8meuDtIkTk3po0/VG80vVd3P1BOLHDeA1XDqcVcEhxpIVijtA1zheCtB6TQhQpSWEoRCnNXrzTiaRykEvN9UrHWtUlofjmSkk0A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622621538; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=O/YgoPdBZlgZ2RR+FvJFG2fkxW4l78y/uHD8RZkRe74=; b=gUtLA0yAfJRhDULby+8VPSXVirfHoWwHelsYevwlQLPuKrhwMeCiPE+seVL3MF/kofKhBj2a28KbmYAAzLw8ZDjmRytNb+/k/G89nBA5zBsWvvPwYggyXoi/kfg8IbiJZtD2Y3S7f2aSGxNHmivGvuopP5tLCqdSymrj+gqn63I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75956+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1622621538266942.4608251197882; Wed, 2 Jun 2021 01:12:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id TukeYY1788612xzNpyTf2b6t; Wed, 02 Jun 2021 01:12:17 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.10224.1622621531196528142 for ; Wed, 02 Jun 2021 01:12:11 -0700 IronPort-SDR: Rsx76C1KZcxhhOUYbyed78QQc/babsE7UFMCABsvMD6QapjaQ2Pg3l/KqZ4KpAe4vEa+nLxBOt //gxNc9jvMwQ== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="267609206" X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="267609206" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2021 01:12:10 -0700 IronPort-SDR: aUdIdz75m0WPz5d+X4XJM52zGM/DaAkRJzDeR1h2M/Us2V5UepevsiN34GDdU8YTyHjKLJBDxZ TK0AGYZRizNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="479617445" X-Received: from ray-dev.ccr.corp.intel.com ([10.239.158.87]) by orsmga001.jf.intel.com with ESMTP; 02 Jun 2021 01:12:09 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Liming Gao , Feng Bob C Subject: [edk2-devel] [PATCH v2 2/6] BaseTools GenFw: Support CLANG8ELF with conversion ELF to PE/COFF image Date: Wed, 2 Jun 2021 16:11:41 +0800 Message-Id: <20210602081145.265-3-ray.ni@intel.com> In-Reply-To: <20210602081145.265-1-ray.ni@intel.com> References: <20210602081145.265-1-ray.ni@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com X-Gm-Message-State: 78ZtSID3DXFCtIDbRfpm4zmDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1622621537; bh=XIqyNlIWb0FqDK9hqvG5XEIxcO/wSC31RDYPXQPJqjQ=; h=Cc:Date:From:Reply-To:Subject:To; b=gZHSBCD0clTrZZSrpo9IGD9HuUa+ecFOlj/yI7njDune0lNCkK7glmLQQThVljunnfU iM6kXJagqYi7bqr96g0tG5x9pjJsR1qZ5hrW1R3wSseshRkByU2XH45vZUQX3eGiTHis+ 5hlkQwsP3Plg1YIvkN6k5yCGCmkLkVCALC0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Liming Gao CLANG8ELF tool chain generated ELF image with the different attributes in section. Update GenFw to handle them. 1. .text section with writable attribute (support) 2. .reloc section has the symbol for *ABS* (skip) Signed-off-by: Liming Gao Reviewed-by: Feng Bob C --- BaseTools/Source/C/GenFw/Elf32Convert.c | 12 +++--------- BaseTools/Source/C/GenFw/Elf64Convert.c | 5 +++-- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c b/BaseTools/Source/C/G= enFw/Elf32Convert.c index 2485b2cb7a..7c8a065678 100644 --- a/BaseTools/Source/C/GenFw/Elf32Convert.c +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c @@ -238,7 +238,7 @@ IsTextShdr ( Elf_Shdr *Shdr ) { - return (BOOLEAN) ((Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D SHF_= ALLOC); + return (BOOLEAN) ((Shdr->sh_flags & (SHF_EXECINSTR | SHF_ALLOC)) =3D=3D = (SHF_EXECINSTR | SHF_ALLOC)); } =20 STATIC @@ -261,7 +261,7 @@ IsDataShdr ( if (IsHiiRsrcShdr(Shdr)) { return FALSE; } - return (BOOLEAN) (Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D (SHF_= ALLOC | SHF_WRITE); + return (BOOLEAN) (Shdr->sh_flags & (SHF_EXECINSTR | SHF_WRITE | SHF_ALLO= C)) =3D=3D (SHF_ALLOC | SHF_WRITE); } =20 STATIC @@ -749,13 +749,7 @@ WriteSections32 ( if (SymName =3D=3D NULL) { SymName =3D (const UINT8 *)""; } - - Error (NULL, 0, 3000, "Invalid", - "%s: Bad definition for symbol '%s'@%#x or unsupported sy= mbol type. " - "For example, absolute and undefined symbols are not supp= orted.", - mInImageName, SymName, Sym->st_value); - - exit(EXIT_FAILURE); + continue; } SymShdr =3D GetShdrByIndex(Sym->st_shndx); =20 diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/G= enFw/Elf64Convert.c index d097db8632..8fe672e984 100644 --- a/BaseTools/Source/C/GenFw/Elf64Convert.c +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c @@ -246,7 +246,7 @@ IsTextShdr ( Elf_Shdr *Shdr ) { - return (BOOLEAN) ((Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D SHF_= ALLOC); + return (BOOLEAN) ((Shdr->sh_flags & (SHF_EXECINSTR | SHF_ALLOC)) =3D=3D = (SHF_EXECINSTR | SHF_ALLOC)); } =20 STATIC @@ -269,7 +269,7 @@ IsDataShdr ( if (IsHiiRsrcShdr(Shdr)) { return FALSE; } - return (BOOLEAN) (Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D (SHF_= ALLOC | SHF_WRITE); + return (BOOLEAN) (Shdr->sh_flags & (SHF_EXECINSTR | SHF_WRITE | SHF_ALLO= C)) =3D=3D (SHF_ALLOC | SHF_WRITE); } =20 STATIC @@ -1060,6 +1060,7 @@ WriteSections64 ( =20 exit(EXIT_FAILURE); } + continue; } SymShdr =3D GetShdrByIndex(Sym->st_shndx); =20 --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75956): https://edk2.groups.io/g/devel/message/75956 Mute This Topic: https://groups.io/mt/83253913/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-