From nobody Mon Feb 9 04:44:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75911+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75911+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1622555463; cv=none; d=zohomail.com; s=zohoarc; b=lCfXuyoUpuI0vnEH2RJ4Tl29RGr600NNMQiJEvSELdEbg+kqlPfAeb0c4vm8bS98w5NiWDSOaOwMYW3JX3tzqbLEEVJOQVo3Dad/+1oHvElcg8snp6IJCOFxhnaX5RElPdVeR66ml1uYKRH9EnDY4y9DPD5a2edFHj1g9tRmLOQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622555463; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=NKzRudX28qnvSJH061QMBwbb1n+Z1loPR7Oo2XocAaw=; b=Vqai3ZpELlMKUsM6X7Vkir/jxWJCZORqtbUG6TOEVOm3UnvO6mEKcIVNUib+Gd6TWT4Q0A5eezKgEybV4Wowj5YcvhrmtQdFgRi5mQLJ1XSA9nyY9mAIwx9hw4MVDbQNFASINO0InIApsPxKnZOkrDANKnFfvyaf5snpLU7U3ic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75911+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 162255546329476.3168412845888; Tue, 1 Jun 2021 06:51:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VJgsYY1788612xTmUBXibykm; Tue, 01 Jun 2021 06:51:02 -0700 X-Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.58156.1622555452337649422 for ; Tue, 01 Jun 2021 06:50:52 -0700 X-Received: by mail-pf1-f173.google.com with SMTP id u18so1236427pfk.11 for ; Tue, 01 Jun 2021 06:50:52 -0700 (PDT) X-Gm-Message-State: 8BccZOp5zmOSWu0SMBDQgLd7x1787277AA= X-Google-Smtp-Source: ABdhPJyH0o2riUtgt12rVvI37383MomI8rwZemwmobtZbVP4rUv5D9UXDy42m7cgXRRi+j9j1hJgnw== X-Received: by 2002:aa7:8ecc:0:b029:2e8:df63:9bc3 with SMTP id b12-20020aa78ecc0000b02902e8df639bc3mr22178684pfr.5.1622555451658; Tue, 01 Jun 2021 06:50:51 -0700 (PDT) X-Received: from embedded-PC.puresoft.int ([125.63.92.170]) by smtp.gmail.com with ESMTPSA id d22sm14504798pgb.15.2021.06.01.06.50.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Jun 2021 06:50:51 -0700 (PDT) From: "Vikas Singh via groups.io" To: devel@edk2.groups.io Cc: sami.mujawar@arm.com, leif@nuviainc.com, meenakshi.aggarwal@nxp.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com, Sunny.Wang@arm.com Subject: [edk2-devel] [PATCH V0 1/4] Platform/NXP: Add generic log in CM to print SoC version Date: Tue, 1 Jun 2021 19:20:31 +0530 Message-Id: <20210601135034.22386-2-vikas.singh@puresoftware.com> In-Reply-To: <20210601135034.22386-1-vikas.singh@puresoftware.com> References: <20210601135034.22386-1-vikas.singh@puresoftware.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,vikas.singh@puresoftware.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1622555462; bh=eAgycqWe1OU38iQK7LWq0Y9ql29TbGUw9cxYF+bI8vY=; h=Cc:Date:From:Reply-To:Subject:To; b=n0/EdgsjkrHI+XddWcwtKhA47eBumM1aaOocLzMVM98qXlizRzeW77hKxgVbF+bDwTN 62NJoszIUkjB6V+1nL7R9AzlWkHVbcy8XEXMvHCj6xYgibX+g2vWY7ewWf5rW4vrwPoH7 oOaC4+6KRF30fdXrgIR8Rs5EFp8F41AYRLs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Summary - 1.Configuration Manager(CM) is a common implementation and should not evaluate the SoC version using macro's However CM must directly consume SoC ver string from platfrom who is extending CM services for ACPI table generation. 2.Platforms who extends CM services for themselves must notify their SoC details to CM. 3.This patch will update the lx2160ardb platform header also with PLAT_SOC_NAME, this will be consumed by CM. Signed-off-by: Vikas Singh --- .../ConfigurationManagerDxe/ConfigurationManager.c | 10 +++------- Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 5 ++--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/C= onfigurationManager.c b/Platform/NXP/ConfigurationManagerPkg/ConfigurationM= anagerDxe/ConfigurationManager.c index 80ce8412c4..dc1a7f5f85 100644 --- a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configur= ationManager.c +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configur= ationManager.c @@ -2,7 +2,7 @@ Configuration Manager Dxe =20 Copyright 2020 NXP - Copyright 2020 Puresoftware Ltd + Copyright 2020-2021 Puresoftware Ltd =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -170,12 +170,8 @@ InitializePlatformRepository ( PlatformRepo =3D This->PlatRepoInfo; =20 Svr =3D SocGetSvr (); - if (SVR_SOC_VER(Svr) =3D=3D SVR_LX2160A) { - PlatformRepo->FslBoardRevision =3D SVR_MAJOR(Svr); - DEBUG ((DEBUG_INFO, "Fsl : SoC LX2160A Rev =3D 0x%x\n", PlatformRepo->= FslBoardRevision)); - } else { - DEBUG ((DEBUG_INFO, "Fsl : SoC Unknown Rev =3D 0x%x\n", PlatformRepo->= FslBoardRevision)); - } + PlatformRepo->FslBoardRevision =3D SVR_MAJOR(Svr); + DEBUG ((DEBUG_INFO, "Fsl : SoC =3D %s Rev =3D 0x%x\n", PLAT_SOC_NAME, Pl= atformRepo->FslBoardRevision)); =20 return EFI_SUCCESS; } diff --git a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h b/Platform/NXP/L= X2160aRdbPkg/Include/Platform.h index 76a41d4369..c18faf28cd 100644 --- a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h +++ b/Platform/NXP/LX2160aRdbPkg/Include/Platform.h @@ -2,7 +2,7 @@ * Platform headers * * Copyright 2020 NXP - * Copyright 2020 Puresoftware Ltd + * Copyright 2020-2021 Puresoftware Ltd * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -15,12 +15,11 @@ #define EFI_ACPI_ARM_OEM_REVISION 0x00000000 =20 // Soc defines +#define PLAT_SOC_NAME "LX2160ARDB" #define SVR_SOC_VER(svr) (((svr) >> 8) & 0xFFFFFE) #define SVR_MAJOR(svr) (((svr) >> 4) & 0xf) #define SVR_MINOR(svr) (((svr) >> 0) & 0xf) =20 -#define SVR_LX2160A 0x873600 - // PCLK #define DCFG_BASE 0x1E00000 #define DCFG_LEN 0x1FFFF --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75911): https://edk2.groups.io/g/devel/message/75911 Mute This Topic: https://groups.io/mt/83233132/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-