From nobody Thu May 16 09:49:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75757+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75757+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1622103473; cv=none; d=zohomail.com; s=zohoarc; b=N6bsSTRDz8FgvvacU3ZH+BDXpTkvDJija8ajw9o3l8KRszqJs08TLOQ47A2QshtqPYv70uFviujTzz+V4YBibBYyzPI7OmNi5SNCmWWOmUdRq7REe4R+AiZiMn9Hx2lzt95s5Cs33Gf52GKLXX9FJa/yE2C7VuxPtA5pc6UAS+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622103473; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=W5eBgBKrOBiG6h+2UnsnVDHAwXpb30yJuLjIiMXHpnA=; b=AGDNHniRD4UQfoI9vKjZeUlxqz8FEyd2VsZwS95f+UONIrQnQHg+WxnaPjsuM3XEMz5g5CZgTkA4IvT18GfyNn5DT7JmEhy5q1SZsfUDUXOermdMnxFEd3YNVOWsRPjNQ/y6Vs3zafEdP6ktUHqg7WWresDzvfgJI5UGu3dLRuQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75757+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1622103473506639.0620627777547; Thu, 27 May 2021 01:17:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id u2zxYY1788612xvq1zhhucCO; Thu, 27 May 2021 01:17:53 -0700 X-Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web09.4159.1622103467655428414 for ; Thu, 27 May 2021 01:17:47 -0700 X-Received: by mail-pj1-f50.google.com with SMTP id f8so25354pjh.0 for ; Thu, 27 May 2021 01:17:47 -0700 (PDT) X-Gm-Message-State: 9Tew6m28UOqLwznfuESqvVIvx1787277AA= X-Google-Smtp-Source: ABdhPJy5yWMp4ILLJ+JNZyPGPD/GjphZDJrquCh1HeVxZkABWmVVP+bElsGrwBZv80O/jtMGDzXr9Q== X-Received: by 2002:a17:90b:1217:: with SMTP id gl23mr464018pjb.137.1622103467123; Thu, 27 May 2021 01:17:47 -0700 (PDT) X-Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id c130sm1223252pfc.51.2021.05.27.01.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 01:17:46 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: MmControl: Fix function and structure definition mismatches Date: Thu, 27 May 2021 01:17:23 -0700 Message-Id: <20210527081723.1934-2-kuqin12@gmail.com> In-Reply-To: <20210527081723.1934-1-kuqin12@gmail.com> References: <20210527081723.1934-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1622103473; bh=F6NKJLJcG+m4HSRKwElCDuMtRwIttc4b9773kif7JEc=; h=Cc:Date:From:Reply-To:Subject:To; b=PYRqjYBFW0xVlDRW/yVuC6B4UY862V37tki0TtyrjaCtBXkWyQy5A3zUemqnrAmIaMN xfDB72kJ3egouv5JedxNegd2VvUt6u6h9V5Inkhicnz09vML/DeMxJv1pXS1OBNKr1cIN 277AyobVQSTGym48mZ+MhxzLmWyDHlVWHic= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3397 Current Ppi/MmControl.h file has structure definition of "struct _PEI_MM_CONTROL_PPI". This name mismatches with its definition in PI Specification v1.7 (Errata) as "struct _EFI_PEI_MM_CONTROL_PPI". In addition, field types "PEI_MM_ACTIVATE" and "PEI_MM_DEACTIVATE" used in "struct _PEI_MM_CONTROL_PPI" mismatches with the definition of "EFI_PEI_MM_ACTIVATE" and "EFI_PEI_MM_DEACTIVATE" in the PI spec. This change fixes these mismatches by using the PI spec defined names. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Fixes: 6f33f7a262314af35e2b99c849e08928ea49aa55 Signed-off-by: Kun Qin Reviewed-by: Liming Gao --- MdePkg/Include/Ppi/MmControl.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Ppi/MmControl.h b/MdePkg/Include/Ppi/MmControl.h index 983ed95cd53d..17586f437b4b 100644 --- a/MdePkg/Include/Ppi/MmControl.h +++ b/MdePkg/Include/Ppi/MmControl.h @@ -69,7 +69,7 @@ EFI_STATUS **/ typedef EFI_STATUS -(EFIAPI *PEI_MM_DEACTIVATE) ( +(EFIAPI *EFI_PEI_MM_DEACTIVATE) ( IN EFI_PEI_SERVICES **PeiServices, IN EFI_PEI_MM_CONTROL_PPI * This, IN BOOLEAN Periodic OPTIONAL @@ -80,9 +80,9 @@ EFI_STATUS /// platform hardware that generates an MMI. There are often I/O ports th= at, when accessed, will /// generate the MMI. Also, the hardware optionally supports the periodic= generation of these signals. /// -struct _PEI_MM_CONTROL_PPI { - PEI_MM_ACTIVATE Trigger; - PEI_MM_DEACTIVATE Clear; +struct _EFI_PEI_MM_CONTROL_PPI { + EFI_PEI_MM_ACTIVATE Trigger; + EFI_PEI_MM_DEACTIVATE Clear; }; =20 extern EFI_GUID gEfiPeiMmControlPpiGuid; --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75757): https://edk2.groups.io/g/devel/message/75757 Mute This Topic: https://groups.io/mt/83120218/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-