From nobody Mon Feb 9 16:45:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75479+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75479+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1621834183; cv=none; d=zohomail.com; s=zohoarc; b=HplT82v3sqc33QhZdNN6nG49l7tntwCMhtXqsVsRTzptF04FvLLRmsCa/FJipJJ+UTxmMQUDAz4yCksINVRiUYxnQwPktUVjenOqKpkU50jv8SN1Ebslvur47sO8r/9fzlgfz1MMGDQDcNkPAJzfypS7/VzB+OIuqN0SXInDpGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621834183; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=eV+ExjKdN1crG2lK27XcbP5Mod8nWzfwD1RvdObBbPU=; b=ViP3pTsOVFYIMX5Ppuk/gQ471jjgtU7HIbugEXEo/f4jZq2pJakyVkOR1ixox3dAOBXNuCcIzJUjCiMKo2nZ5b/gg3wmSfnfItr2VeiSVjGgRghrlAh2U1dr4lDxtTVe6PgHhBb40H/pDBJg8SPff986UEFxm0ZqmUyB1Q1pDj4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75479+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16218341838411014.9667243989505; Sun, 23 May 2021 22:29:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VSdpYY1788612xSbEoV6Kddp; Sun, 23 May 2021 22:29:43 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web08.19183.1621834177517179038 for ; Sun, 23 May 2021 22:29:37 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id p20so31949358ljj.8 for ; Sun, 23 May 2021 22:29:37 -0700 (PDT) X-Gm-Message-State: zZFPL7PjdspP7hvePDDKZQO4x1787277AA= X-Google-Smtp-Source: ABdhPJzRS8LOzxQ3wpMgVBczTOGEvax+1OVf4HhtrWenLp2XCKNMkEdYp2mBSn7DtJIpXBODhQ7PHA== X-Received: by 2002:a2e:a553:: with SMTP id e19mr15526405ljn.280.1621834175802; Sun, 23 May 2021 22:29:35 -0700 (PDT) X-Received: from gilgamesh.semihalf.com (host-193.106.246.138.static.3s.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id w17sm90739lfp.300.2021.05.23.22.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 22:29:35 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: leif@nuviainc.com, ardb+tianocore@kernel.org, Samer.El-Haj-Mahmoud@arm.com, sunny.Wang@arm.com, gjb@semihalf.com, upstream@semihalf.com, Marcin Wojtas Subject: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 Date: Mon, 24 May 2021 07:29:16 +0200 Message-Id: <20210524052919.2496579-4-mw@semihalf.com> In-Reply-To: <20210524052919.2496579-1-mw@semihalf.com> References: <20210524052919.2496579-1-mw@semihalf.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621834183; bh=FUBWYCtfzQgUfL92Hit8ep4y4tEm1PrwOxyIypH8+ZY=; h=Cc:Date:From:Reply-To:Subject:To; b=IJ0aRMr7P7Tn00n9p8Dz3b0JwauNNGzya9+lqs2JOB93wSpqX0VWUAVNckXrR6pzn4o WWkQyuLy6yYq/cR7+NOF9r1RslL/d4nS1ma+z1VEY64LmlllvqqQsaYrDQE5WoZyidtel 9AvuO/rhhGu4wB7nK1IMnsspg9MGEmszoOc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" DBG2 ACPI table description [1] specifies three subtypes related to 16550 UART: 0x0 - 16550 compatible 0x1 - 16550 subset 0x12 - 16550 compatible with parameters defined in Generic Address Structure (GAS) It turned out however, that the Windows OS treats 0x0 subtype as legacy x86 UART with 8-bit access. ARM SoCs can use types 0x1 (16550 with fixed mmio32 access) or 0x12 (16550 with fully respected GAS contents). Switch Marvell SoCs ACPI UART subtype to 0x1 - thanks to that the same firmware can run properly with UART output in Windows 10, Linux and ESXI hypervisor. [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-= debug-port-table Signed-off-by: Marcin Wojtas Reviewed-by: Sunny Wang --- Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc | 2 +- Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc b/Silicon/Marv= ell/Armada7k8k/AcpiTables/Spcr.aslc index 438cf7880e..6efc175bdf 100644 --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc @@ -22,7 +22,7 @@ EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION ), - EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550, //= InterfaceType + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450, //= InterfaceType { EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE }, //= Reserved1[3] diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc b/Silicon/Ma= rvell/OcteonTx/AcpiTables/T91/Spcr.aslc index f663d8ade8..2a3415f0a6 100644 --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc @@ -22,7 +22,7 @@ EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION ), - EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550, //= InterfaceType + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450, //= InterfaceType { EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE }, //= Reserved1[3] --=20 2.29.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75479): https://edk2.groups.io/g/devel/message/75479 Mute This Topic: https://groups.io/mt/83044529/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-