From nobody Mon Feb 9 19:53:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75477+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75477+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1621834177; cv=none; d=zohomail.com; s=zohoarc; b=dnuTJEdgXkVlsPsBNrXMJdZCrKpw70uC+z4lds5v1IrU1ZnD+MkOx/09QPd3YHTQInRHR4d+lMOXjLJwvPHiyJyGrD7uS3ytrJPT56CiJOBl5YE922ox8z20hDMdRKEZ+wQYCLxRUYJRfsAgbKZIDq2msnMUFQ2PFJ3A5lupr4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621834177; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=V7d+dy6F8YatkajZtVrv27yldRPY0lYqbtH2KkZf1iM=; b=e5rbDD8FhDi/RqzduGA0VrY8gdOwbS3U476pPcguOCwzb9wq9KSYwt4aMG7HLgxUzx5X69b4gQARcqETsYE9oj/BZA3IOW+3SHG4/KopvdNMldmgrvCy+ZR8iu/QwkMO/lrgVVpAKHh88LlyMkMNNtRedHAuyH0W9GFfc1dPAek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75477+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16218341778041019.1050184663094; Sun, 23 May 2021 22:29:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id F6FtYY1788612xh4Rk5a7dfJ; Sun, 23 May 2021 22:29:37 -0700 X-Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mx.groups.io with SMTP id smtpd.web12.19101.1621834175452641485 for ; Sun, 23 May 2021 22:29:35 -0700 X-Received: by mail-lj1-f178.google.com with SMTP id a4so17128676ljd.5 for ; Sun, 23 May 2021 22:29:35 -0700 (PDT) X-Gm-Message-State: 7uOXZNrXXGdsMi0uJIJgh4k8x1787277AA= X-Google-Smtp-Source: ABdhPJyV/ra0e4ivfcxOpICeN0f8+BSJyVsMtZC31yC47dJlWHkFPfvlhfMdhKfAY04/GYxz+Vm6jw== X-Received: by 2002:a2e:9a90:: with SMTP id p16mr15773621lji.7.1621834173767; Sun, 23 May 2021 22:29:33 -0700 (PDT) X-Received: from gilgamesh.semihalf.com (host-193.106.246.138.static.3s.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id w17sm90739lfp.300.2021.05.23.22.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 22:29:33 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: leif@nuviainc.com, ardb+tianocore@kernel.org, Samer.El-Haj-Mahmoud@arm.com, sunny.Wang@arm.com, gjb@semihalf.com, upstream@semihalf.com, Marcin Wojtas Subject: [edk2-devel] [edk2-platforms PATCH 1/6] Marvell/Drivers: SmbiosPlatformDxe: Align Type17 to SMBIOS v3.2 Date: Mon, 24 May 2021 07:29:14 +0200 Message-Id: <20210524052919.2496579-2-mw@semihalf.com> In-Reply-To: <20210524052919.2496579-1-mw@semihalf.com> References: <20210524052919.2496579-1-mw@semihalf.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621834177; bh=Pr2zfjLyeGBUBSW/FtERUXn89LZK7SCsUKII8O3lmrw=; h=Cc:Date:From:Reply-To:Subject:To; b=gBarzLi1AEazebsFCq8VtLjSleUzpbrJB/jHSMUg69KuwDR0CFUKGnIXs9q7l/1k8dz O6WvQIEbdZ7z4Bh6AQVfwXT8s3xHVrvZjpfosxIcCAVoGE7JSNnnaWu45YGHcbGPtZLH/ bffdny6iD+nsNkIs1Hhl8bFbWn31ZpGSoKc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This patch adds missing entries required for SMBIOS v3.2 compliance of the Type17 table. On the occasion improve Type4 table contents. Signed-off-by: Marcin Wojtas Reviewed-by: Samer El-Haj-Mahmoud --- Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 39 +++++++= +++++++++++-- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c = b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c index 2ecaec2af5..a99291e902 100644 --- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -181,7 +181,7 @@ STATIC SMBIOS_TABLE_TYPE4 mArmadaDefaultType4 =3D { 3, //version {0,0,0,0,0,1}, //voltage 0, //external clock - 2000, //max speed + 2200, //max speed 0, //current speed - requires update 0x41, //status ProcessorUpgradeOther, @@ -196,6 +196,9 @@ STATIC SMBIOS_TABLE_TYPE4 mArmadaDefaultType4 =3D { 4, //threads per socket 0xEC, //processor characteristics ProcessorFamilyARM, //ARM core + 0, // CoreCount2; + 0, // EnabledCoreCount2; + 0, // ThreadCount2; }; =20 STATIC CHAR8 CONST *mArmadaDefaultType4Strings[] =3D { @@ -457,7 +460,7 @@ STATIC SMBIOS_TABLE_TYPE17 mArmadaDefaultType17 =3D { 0, //Memory size obtained dynamically MemoryFormFactorRowOfChips, //Memory factor 0, //Not part of a set - 1, //Right side of board + 1, //Location 2, //Bank 0 MemoryTypeDdr4, //DDR4 {0,0,0,0,0,0,0,0,0,0,0,0,0,0,1}, //unbuffered @@ -467,10 +470,36 @@ STATIC SMBIOS_TABLE_TYPE17 mArmadaDefaultType17 =3D { 0, //asset tag 0, //part number 0, //rank + 0, // ExtendedSize; (since Size < 32GB-1) + 0, // ConfiguredMemoryClockSpeed - initialized at runtime + 0, // MinimumVoltage; (unknown) + 0, // MaximumVoltage; (unknown) + 0, // ConfiguredVoltage; (unknown) + MemoryTechnologyDram, // MemoryTechnology + {{ // MemoryOperatingModeCapability + 0, // Reserved :1; + 0, // Other :1; + 0, // Unknown :1; + 1, // VolatileMemory :1; + 0, // ByteAccessiblePersistentMemory :1; + 0, // BlockAccessiblePersistentMemory :1; + 0 // Reserved :10; + }}, + 0, // FirwareVersion + 0, // ModuleManufacturerID (unknown) + 0, // ModuleProductID (unknown) + 0, // MemorySubsystemControllerManufacturerID (unknown) + 0, // MemorySubsystemControllerProductID (unknown) + 0, // NonVolatileSize + 0, // VolatileSize - initialized at runtime + 0, // CacheSize + 0, // LogicalSize + 0, // ExtendedSpeed, + 0 // ExtendedConfiguredMemorySpeed }; =20 STATIC CHAR8 CONST *mArmadaDefaultType17Strings[] =3D { - "RIGHT SIDE\0", /* location */ + "DIMM SLOT\0", /* location */ "BANK 0\0", /* bank description */ NULL }; @@ -735,9 +764,10 @@ SmbiosMemoryInstall ( } =20 // - // Update TYPE17 memory size field + // Update TYPE17 memory size fields // mArmadaDefaultType17.Size =3D (UINT16)(MemorySize >> 20); + mArmadaDefaultType17.VolatileSize =3D MemorySize; =20 return EFI_SUCCESS; } @@ -767,6 +797,7 @@ SmbiosInstallAllStructures ( mArmadaDefaultType0.SystemBiosMinorRelease =3D FirmwareMinorRevisionNumb= er; mArmadaDefaultType4.CurrentSpeed =3D SampleAtResetGetCpuFrequency (); mArmadaDefaultType17.Speed =3D SampleAtResetGetDramFrequency (); + mArmadaDefaultType17.ConfiguredMemoryClockSpeed =3D SampleAtResetGetDram= Frequency (); =20 // // Generate memory descriptors. --=20 2.29.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75477): https://edk2.groups.io/g/devel/message/75477 Mute This Topic: https://groups.io/mt/83044527/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-