From nobody Sun May 19 03:54:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75449+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75449+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621629652; cv=none; d=zohomail.com; s=zohoarc; b=FuJ2B1wj8YV9Xn4heB640YP8HQIfoTDnpYXiKvFitGxRGmlxY+JmmWLoDSMNS5WqPoTWsUGoFlwdV0fy55GwAINugAiHqzgv+p8DbfD6LRjXtT3LLk92KRgoDik9AzDnIXaeXXYSoUK1bpRAg/gIjN/Q/Tg+mPIhH9NWxx+C3Po= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621629652; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=IFYl9Wi9nKnW5npjMwPWCo+0fLB9LQ2c2NtUDw2iA/k=; b=Bqjuo9RAycyR2iKN/cmqukJhLvb4YhQx/OB4+ElL5iCVNCbLGwP3SYzliSP/Lo639triz++nuNCSArWgnwAFhn1e7O3HbXE22o3ngPdlbggBR+S7DC/I5J1/p8J8s0Tviv49c78R8TZjE4TDYC86W10MWLfxPXjNBDbFCSikhJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75449+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621629652529982.1081227745194; Fri, 21 May 2021 13:40:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tKi7YY1788612xLhJRnMzhs0; Fri, 21 May 2021 13:40:52 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.150.1621629646434984525 for ; Fri, 21 May 2021 13:40:46 -0700 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-x-2FrSXjOZi5_c3qQTf22g-1; Fri, 21 May 2021 16:40:42 -0400 X-MC-Unique: x-2FrSXjOZi5_c3qQTf22g-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 916AC801106; Fri, 21 May 2021 20:40:40 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-154.ams2.redhat.com [10.36.114.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id A33E15C648; Fri, 21 May 2021 20:40:38 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Bret Barkelew , Hao A Wu , Jian J Wang , Liming Gao , Michael D Kinney , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [edk2-devel] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN Date: Fri, 21 May 2021 22:40:37 +0200 Message-Id: <20210521204037.11980-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: 3LU4zqzLLFUIgBiwYy2shFoZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621629652; bh=IFYl9Wi9nKnW5npjMwPWCo+0fLB9LQ2c2NtUDw2iA/k=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=abH4lljagsrX7gtCYZUuhW+4MY62tp7hz0gfrpTngWJC5w73cIKhgD2obMNP6ExRMjp NDHsGwDe84fmulaliBFh320REHmPzjs4NlPBFwiTJg+LfySgXTdtSNcOuE+Q0n4a3FQ/p vD52rfHMewPiFwHDOGKsidybmow39pcCBZE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Commit a18a9bde36d2 ("MdeModulePkg/Variable/RuntimeDxe: Restore Variable Lock Protocol behavior", 2020-12-15), for bug 3111, added two such sets of debug messages that: (a) are relevant for developers, (b) yet should not necessarily poke end-users, because no functionality suffers in practice. Both message sets are in function VariableLockRequestToLock(): the first is a generic interface deprecation warning; the second is the double-locking situation, which we permit for compatibility (return status EFI_SUCCESS). Both message sets should be emitted with the DEBUG_WARN mask, not the most serious DEBUG_ERROR mask. On some platforms, the serial console carries both terminal traffic, and grave (DEBUG_ERROR-only) log messages. On such platforms, both message sets may be perceived as a nuisance by end-users, as there is nothing they can do, and there's nothing they *should* do -- in practice, nothing malfunctions. (Such a platform is ArmVirtQemu, built with "-D DEBUG_PRINT_ERROR_LEVEL=3D0x80000000".) Cc: Bret Barkelew Cc: Hao A Wu Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Cc: Philippe Mathieu-Daud=C3=A9 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3410 Fixes: a18a9bde36d2ffc12df29cdced1efa1f8f9f2021 Signed-off-by: Laszlo Ersek Reviewed-by: Bret Barkelew bret.barkelew@microsoft.com --- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.c | 1= 0 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequest= ToLock.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestTo= Lock.c index 7d87e50efdcd..4e1efef9a7e4 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.c @@ -48,9 +48,9 @@ VariableLockRequestToLock ( EFI_STATUS Status; VARIABLE_POLICY_ENTRY *NewPolicy; =20 - DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! %a() will go away soo= n!\n", __FUNCTION__)); - DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! Please move to use Va= riable Policy!\n")); - DEBUG ((DEBUG_ERROR, "!!! DEPRECATED INTERFACE !!! Variable: %g %s\n", V= endorGuid, VariableName)); + DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! %a() will go away soon= !\n", __FUNCTION__)); + DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! Please move to use Var= iable Policy!\n")); + DEBUG ((DEBUG_WARN, "!!! DEPRECATED INTERFACE !!! Variable: %g %s\n", Ve= ndorGuid, VariableName)); =20 NewPolicy =3D NULL; Status =3D CreateBasicVariablePolicy( @@ -69,13 +69,13 @@ VariableLockRequestToLock ( // // If the error returned is EFI_ALREADY_STARTED, we need to check the // current database for the variable and see whether it's locked. If i= t's - // locked, we're still fine, but also generate a DEBUG_ERROR message s= o the + // locked, we're still fine, but also generate a DEBUG_WARN message so= the // duplicate lock can be removed. // if (Status =3D=3D EFI_ALREADY_STARTED) { Status =3D ValidateSetVariable (VariableName, VendorGuid, 0, 0, NULL= ); if (Status =3D=3D EFI_WRITE_PROTECTED) { - DEBUG ((DEBUG_ERROR, " Variable: %g %s is already locked!\n", Ven= dorGuid, VariableName)); + DEBUG ((DEBUG_WARN, " Variable: %g %s is already locked!\n", Vend= orGuid, VariableName)); Status =3D EFI_SUCCESS; } else { DEBUG ((DEBUG_ERROR, " Variable: %g %s can not be locked!\n", Ven= dorGuid, VariableName)); --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75449): https://edk2.groups.io/g/devel/message/75449 Mute This Topic: https://groups.io/mt/82995877/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-