From nobody Sun Feb 8 05:08:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75324+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75324+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1621396841; cv=none; d=zohomail.com; s=zohoarc; b=ZU30R0f9MC9wZUFEOAEzwUdZw1c4lKZCn0qnb2JfMPvsKN51Y/Su6yOF/kLULe+hhSmSd7DeM+sxQ+yFpBA/Ho+HGa0okfeysW3DKDmSny8N+Uv6Iq2F86/1VwBj054odldW/DNFWPq8dhgRXVnBmb6Ei6RT5htuYUzL1fvEe8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621396841; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=jEl/0Ar01LMK6SQKtcPeIaIDUqxvbVnf/ONyuFG4MJs=; b=URyjwmRQo2LQDZS+ftjUfcuix5wV8QzV9nYHkpO2dbHt7Fbtotln5B4IwXfErXqVP13zqA5NLISKYM9pmyTzHVRBNHNNN1gM/r6LPe0bRDV1ZAwEsE6+x36dUs9C3XiBkJvClSwFtiqq88GF97clb+FRWFOMjbUJ4az3+CV/ThU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75324+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621396841533778.6675289924463; Tue, 18 May 2021 21:00:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9c8tYY1788612xjHchHdHhZI; Tue, 18 May 2021 21:00:41 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.6921.1621396835735610198 for ; Tue, 18 May 2021 21:00:35 -0700 X-Received: from localhost.localdomain (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 7DB1D20B7178; Tue, 18 May 2021 21:00:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7DB1D20B7178 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Agyeman Prince Subject: [edk2-devel] [edk2-platforms][PATCH v2 18/35] SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs Date: Tue, 18 May 2021 20:59:30 -0700 Message-Id: <20210519035947.1234-19-mikuback@linux.microsoft.com> In-Reply-To: <20210519035947.1234-1-mikuback@linux.microsoft.com> References: <20210519035947.1234-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: EtFwTYGS6y1JMQwNpQMHZO4gx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621396841; bh=9UU1zlPziNHM7UR7E6EjafyQrqB6os56/6GZGGtgwAU=; h=Cc:Date:From:Reply-To:Subject:To; b=eK0UCD43kUzILAXrAOWjDqte9G1lQezkgXiaCm+lkprQTBT0UyDmL0BN9qF4H/xSbns 15yAwQ4GUJRhm/IcYqjo2JzojUzpahsnuZedEOwRGyqqelERgq3vaS/r/SItp1GG6ZzI/ K18N/ZxsJSnMGb+I4Bq1lWWahocps2TsBmU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. The previous PCDs are removed from Ich10Pkg.dec. Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.= c | 2 +- Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec = | 6 ------ Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchSpi= CommonLib.inf | 5 +++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLi= b/SpiCommon.c b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommo= nLib/SpiCommon.c index 3e7dffedfbe9..f2907ef53bfc 100644 --- a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= mmon.c +++ b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= mmon.c @@ -69,7 +69,7 @@ SpiProtocolConstructor ( SpiInstance->WritePermissi= on)); =20 // - SpiInstance->TotalFlashSize =3D PcdGet32(PcdFlashAreaSize); + SpiInstance->TotalFlashSize =3D PcdGet32 (PcdBiosSize); DEBUG ((DEBUG_INFO, "Total Flash Size : %0x\n", SpiInstance->TotalFlashS= ize)); return EFI_SUCCESS; } diff --git a/Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec b/Silicon/Intel/Simi= csIch10Pkg/Ich10Pkg.dec index 0eb2e5530c3a..8d395a8b4370 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec +++ b/Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec @@ -16,11 +16,5 @@ [Includes] =20 [Ppis] =20 -[Guids] - gEfiPchTokenSpaceGuid =3D { 0x89a1b278, 0xa1a1, 0x4df7, { 0xb1, 0x37, 0x= de, 0x5a, 0xd7, 0xc4, 0x79, 0x13 } } [Protocols] gEfiSmmSpiProtocolGuid =3D {0xbd75fe35, 0xfdce, 0x49d7, {0xa9, 0xdd, 0xb= 2, 0x6f, 0x1f, 0xc6, 0xb4, 0x37}} - -[PcdsFixedAtBuild] - gEfiPchTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFFE00000|UINT32|0x100000= 01 - gEfiPchTokenSpaceGuid.PcdFlashAreaSize|0x00200000|UINT32|0x10000002 \ No newline at end of file diff --git a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLi= b/BasePchSpiCommonLib.inf b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/Bas= ePchSpiCommonLib/BasePchSpiCommonLib.inf index df1da274a642..b5aa13c1c56d 100644 --- a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BaseP= chSpiCommonLib.inf +++ b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BaseP= chSpiCommonLib.inf @@ -20,6 +20,7 @@ [Sources] =20 [Packages] MdePkg/MdePkg.dec + IntelSiliconPkg/IntelSiliconPkg.dec SimicsIch10Pkg/Ich10Pkg.dec =20 [LibraryClasses] @@ -27,5 +28,5 @@ [LibraryClasses] DebugLib =20 [Pcd] - gEfiPchTokenSpaceGuid.PcdFlashAreaBaseAddress ## CONSUMES - gEfiPchTokenSpaceGuid.PcdFlashAreaSize ## CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress ## CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize ## CONSUMES --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75324): https://edk2.groups.io/g/devel/message/75324 Mute This Topic: https://groups.io/mt/82929227/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-