From nobody Mon Feb 9 15:46:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75264+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75264+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.net ARC-Seal: i=1; a=rsa-sha256; t=1621354626; cv=none; d=zohomail.com; s=zohoarc; b=hXpV7taKPSoRVTPOpqJye3wdWn3HR44nzuaW+5zDTRxSKwQp18w95rKCb/5vdcN/ZG988C4OA+M+lHcJYaeTIpAgF4cVpZgldPbkoAH9tUFQU59DYcq8ctM4PlI5gsKDkc4L869/dO3HcsoUgLqtwvWIVMJ5ocA8HB+xIuh4B0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621354626; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=epl2lKoPGvqh+zJ8/8eG0gkb3A58I9p8bo80gaj+HWA=; b=mrBpvIIP4jDCMQZfffxmo6pCD/eFE0IxKlXu3XvqjhzQRr0eyLslU43Qz56xYayP0Ybtc1aHT+58DSbE1cdQF1SzQQYwyPHUdO1SDJnXv9xxKzABDIkg0crF/g1BAF0D8NtIgbXeoWvDmxlZBS1eWsbnqrOcGG9W6N8uVSkEL2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75264+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621354626890602.834899028057; Tue, 18 May 2021 09:17:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ULyOYY1788612xYINoY37KgR; Tue, 18 May 2021 09:17:01 -0700 X-Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web10.322.1621354205323275239 for ; Tue, 18 May 2021 09:10:05 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9D21A24002A for ; Tue, 18 May 2021 18:09:53 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fl1DJ4fvgz9rxL; Tue, 18 May 2021 18:09:52 +0200 (CEST) From: "Sergei Dmitrouk" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang Subject: [edk2-devel] [PATCH v2 3/3] CryptoPkg/BaseCryptLib: Fix possible uninitialized use Date: Tue, 18 May 2021 16:09:42 +0000 Message-Id: <20210518160942.17634-4-sergei@posteo.net> In-Reply-To: <20210518160942.17634-1-sergei@posteo.net> References: <20210518160942.17634-1-sergei@posteo.net> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sergei@posteo.net X-Gm-Message-State: gIZvoZAWmo3j3a2ROuU5VJfyx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621354621; bh=adgQ9tQuX/hCqLTQT9FMQCdO7L8Tw8BcMhvbcUN0fdg=; h=Cc:Date:From:Reply-To:Subject:To; b=QINqw8+xgZVn2nCV+0/S2nK6EtV4M8QYWJCK+8b2Qb9Vpmo6xWW5oukk9ahX5JkhHta i8vOjzMnW+cyYjJuGlVqROlSW2AaawzuB0Ppq+d+7yQPGl3tD40tqEnPm9FAOjNRj5nA9 quJrebshkFJmcdNrkgIhx48Yjp8Lrm+A588= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" `Result` can be used uninitialized in both functions after following either first or second `goto` statement. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Sergei Dmitrouk --- CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c | 1 + CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c | 1 + 2 files changed, 2 insertions(+) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c b/CryptoPkg/Li= brary/BaseCryptLib/Pk/CryptRsaPss.c index 4009d37d5f91..0b2960f06c4c 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c @@ -82,6 +82,7 @@ RsaPssVerify ( EVP_PKEY_CTX *KeyCtx; CONST EVP_MD *HashAlg; =20 + Result =3D FALSE; EvpRsaKey =3D NULL; EvpVerifyCtx =3D NULL; KeyCtx =3D NULL; diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c b/CryptoPk= g/Library/BaseCryptLib/Pk/CryptRsaPssSign.c index b66b6f7296ad..ece765f9ae0a 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c @@ -97,6 +97,7 @@ RsaPssSign ( EVP_PKEY_CTX *KeyCtx; CONST EVP_MD *HashAlg; =20 + Result =3D FALSE; EvpRsaKey =3D NULL; EvpVerifyCtx =3D NULL; KeyCtx =3D NULL; --=20 2.17.6 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75264): https://edk2.groups.io/g/devel/message/75264 Mute This Topic: https://groups.io/mt/82915566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-