From nobody Sun May 19 07:31:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75262+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75262+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.net ARC-Seal: i=1; a=rsa-sha256; t=1621354654; cv=none; d=zohomail.com; s=zohoarc; b=lhjIh00XN1/YsQ8Vyms++0NCK1X/Fm7I2J7YamSQJ49ZdBAwmLd6MvqThnsHK3J7sZv3rXZbEJSaj1rhlqHd4XlzGCmFiFHv9WuKLENq3LV0sPLVqJg+sm0Uvw4ErVIYeaIVJE3ESA0G8uyTFTnBe8R6keD8FLYf3fXT1e+sUdI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621354654; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=E86t72JKYABwvdYMzrdFpSOFxaLbLOvYEu1b69YG17Q=; b=Joa/22bp7xmWCv+j1PCq0i1Ee3EA4xSnJD5eCXmN3yBkGocCmDJ+gSIqufV0a/nkUnQzHMSzFdMFc98uK9qOjT9MvNxbMRPkhPfYJynW1EmB37zEOLWm+05GsWeJEkJPsMd48W6lOs8KNYUyJQAA88adh1P7t2k9D4UQE6siTn0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75262+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 162135465448330.748364420391454; Tue, 18 May 2021 09:17:34 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rP13YY1788612xrIRYegSstS; Tue, 18 May 2021 09:17:32 -0700 X-Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web12.309.1621354193876726220 for ; Tue, 18 May 2021 09:09:54 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 43A852400FC for ; Tue, 18 May 2021 18:09:52 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fl1DH3x2cz9rxG; Tue, 18 May 2021 18:09:51 +0200 (CEST) From: "Sergei Dmitrouk" To: devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH v2 1/3] ShellPkg/HttpDynamicCommand: Fix possible uninitialized use Date: Tue, 18 May 2021 16:09:40 +0000 Message-Id: <20210518160942.17634-2-sergei@posteo.net> In-Reply-To: <20210518160942.17634-1-sergei@posteo.net> References: <20210518160942.17634-1-sergei@posteo.net> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sergei@posteo.net X-Gm-Message-State: PkeWpHCjhmU7Zw9ThwgRytzZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621354652; bh=qdhYLSD8w2JXviIo7DSqGWsrB+vW5GPsBi/9fYqWXAc=; h=Cc:Date:From:Reply-To:Subject:To; b=lLmzK/NDKtitE3XBDGXHhzca4HJP+ES5/VNuSUFoCRBMrbK2mEf4T1WxH/KrSozq1iU Se9lqQEuyAJUWNRF15UIKL19f6XzddSPKV8iwMXRkUjE3gHsVhI1yW1teQ8FcXz9uzm6A iYPHZc4/0P9/HrjL0fpPfaDMQ1mDzd1sq9M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" `Status` can be used uninitialized: /* Evaluates to FALSE */ if (ShellGetExecutionBreakFlag ()) { Status =3D EFI_ABORTED; break; } /* Evaluates to FALSE */ if (!Context->ContentDownloaded && !Context->ResponseToken.Event) { Status =3D ...; ASSERT_EFI_ERROR (Status); } else { ResponseMessage.Data.Response =3D NULL; } /* UNINITIALIZED USE */ if (EFI_ERROR (Status)) { break; } Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sergei Dmitrouk Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao --- ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c b/ShellPkg/D= ynamicCommand/HttpDynamicCommand/Http.c index 3735a4a7e645..7b9b2d238015 100644 --- a/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c +++ b/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c @@ -1524,6 +1524,7 @@ GetResponse ( Context->ResponseToken.Message =3D &ResponseMessage; Context->ContentLength =3D 0; Context->Status =3D REQ_OK; + Status =3D EFI_SUCCESS; MsgParser =3D NULL; ResponseData.StatusCode =3D HTTP_STATUS_UNSUPPORTED_STATUS; ResponseMessage.Data.Response =3D &ResponseData; --=20 2.17.6 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75262): https://edk2.groups.io/g/devel/message/75262 Mute This Topic: https://groups.io/mt/82915562/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 07:31:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75263+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75263+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.net ARC-Seal: i=1; a=rsa-sha256; t=1621354653; cv=none; d=zohomail.com; s=zohoarc; b=npPcgtv+iTW6csE2CQwLWM2RLdBLK+1HjlX/EQUAFUaluwm7RsUusIEIx381G3Blj83xmN8LT4CMT3v2EBYAKBvACmGsDsoBu1luTVsMzm+ny9/cGlI3g4wuK0CDFIudMHTJu2qMYQIkUltszv9snbx3IUtQ9MsX5pshA6irE+4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621354653; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=N/YDTlPumCPOoHVvRCnFse9Dvn4Pru07HaLWzOScOTw=; b=PnRL8Hr0sb3tRB4Vz329+tcNgh/ZGPBkcAay3eU7qCQ+ggMe05Po+NUBt1LdOUVf7jgxKIz9g7qwIdlUcTHGl+wQbTDTvswAsH5k3ILQgriFl5Z1LajaTqa4HaSODcyCUC9X0BgqUHatv9Qdp0Bg3HEEweDcce+h3ozu6Qiknsc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75263+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621354653765857.7916414223373; Tue, 18 May 2021 09:17:33 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id IQh3YY1788612xttY1kD8Hm6; Tue, 18 May 2021 09:17:32 -0700 X-Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web11.321.1621354194443895099 for ; Tue, 18 May 2021 09:09:54 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C425B240102 for ; Tue, 18 May 2021 18:09:52 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fl1DJ0zv6z9rxP; Tue, 18 May 2021 18:09:52 +0200 (CEST) From: "Sergei Dmitrouk" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Ray Ni Subject: [edk2-devel] [PATCH v2 2/3] MdeModulePkg/PciBusDxe: Fix possible uninitialized use Date: Tue, 18 May 2021 16:09:41 +0000 Message-Id: <20210518160942.17634-3-sergei@posteo.net> In-Reply-To: <20210518160942.17634-1-sergei@posteo.net> References: <20210518160942.17634-1-sergei@posteo.net> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sergei@posteo.net X-Gm-Message-State: jY0BMc0nYER0BH8PSGvgqWv9x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621354652; bh=Q9mLvwK3Zw9MdUyHmjSUVHDqmQP7utSsZqv6yxRZhlo=; h=Cc:Date:From:Reply-To:Subject:To; b=HGF2xwQOBePmYs9rAVA+4zO7Bz1tpq4n96/6jpZagU/aBwGv3NKPfzXmJplqkedwJYu C7TWGHMyRmXB2BmueXcGsSwdAZ4wlaGqqMIDSszoJIaGpfN9PFOv7YU1EhJjPd/5a0IJP VaXLlW4dtghNjmwCyJSTOTM9nv13pd4pi+g= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If the function gets invalid value for the `ResizableBarOp` parameter and asserts are disabled, `Bit` can be used uninitialized. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Sergei Dmitrouk Reviewed-by: Hao A Wu --- Notes: v2: - simplify if-statement to avoid unused branches MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci= /PciBusDxe/PciLib.c index 6bba28367165..4caac56f1dcd 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c @@ -1778,10 +1778,9 @@ PciProgramResizableBar ( =20 if (ResizableBarOp =3D=3D PciResizableBarMax) { Bit =3D HighBitSet64(Capabilities); - } else if (ResizableBarOp =3D=3D PciResizableBarMin) { + } else { + ASSERT (ResizableBarOp =3D=3D PciResizableBarMin); Bit =3D LowBitSet64(Capabilities); - } else { - ASSERT ((ResizableBarOp =3D=3D PciResizableBarMax) || (ResizableBarO= p =3D=3D PciResizableBarMin)); } =20 ASSERT (Bit >=3D 0); --=20 2.17.6 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75263): https://edk2.groups.io/g/devel/message/75263 Mute This Topic: https://groups.io/mt/82915563/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 07:31:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75264+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75264+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.net ARC-Seal: i=1; a=rsa-sha256; t=1621354626; cv=none; d=zohomail.com; s=zohoarc; b=hXpV7taKPSoRVTPOpqJye3wdWn3HR44nzuaW+5zDTRxSKwQp18w95rKCb/5vdcN/ZG988C4OA+M+lHcJYaeTIpAgF4cVpZgldPbkoAH9tUFQU59DYcq8ctM4PlI5gsKDkc4L869/dO3HcsoUgLqtwvWIVMJ5ocA8HB+xIuh4B0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621354626; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=epl2lKoPGvqh+zJ8/8eG0gkb3A58I9p8bo80gaj+HWA=; b=mrBpvIIP4jDCMQZfffxmo6pCD/eFE0IxKlXu3XvqjhzQRr0eyLslU43Qz56xYayP0Ybtc1aHT+58DSbE1cdQF1SzQQYwyPHUdO1SDJnXv9xxKzABDIkg0crF/g1BAF0D8NtIgbXeoWvDmxlZBS1eWsbnqrOcGG9W6N8uVSkEL2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75264+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621354626890602.834899028057; Tue, 18 May 2021 09:17:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ULyOYY1788612xYINoY37KgR; Tue, 18 May 2021 09:17:01 -0700 X-Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web10.322.1621354205323275239 for ; Tue, 18 May 2021 09:10:05 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9D21A24002A for ; Tue, 18 May 2021 18:09:53 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fl1DJ4fvgz9rxL; Tue, 18 May 2021 18:09:52 +0200 (CEST) From: "Sergei Dmitrouk" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang Subject: [edk2-devel] [PATCH v2 3/3] CryptoPkg/BaseCryptLib: Fix possible uninitialized use Date: Tue, 18 May 2021 16:09:42 +0000 Message-Id: <20210518160942.17634-4-sergei@posteo.net> In-Reply-To: <20210518160942.17634-1-sergei@posteo.net> References: <20210518160942.17634-1-sergei@posteo.net> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sergei@posteo.net X-Gm-Message-State: gIZvoZAWmo3j3a2ROuU5VJfyx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621354621; bh=adgQ9tQuX/hCqLTQT9FMQCdO7L8Tw8BcMhvbcUN0fdg=; h=Cc:Date:From:Reply-To:Subject:To; b=QINqw8+xgZVn2nCV+0/S2nK6EtV4M8QYWJCK+8b2Qb9Vpmo6xWW5oukk9ahX5JkhHta i8vOjzMnW+cyYjJuGlVqROlSW2AaawzuB0Ppq+d+7yQPGl3tD40tqEnPm9FAOjNRj5nA9 quJrebshkFJmcdNrkgIhx48Yjp8Lrm+A588= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" `Result` can be used uninitialized in both functions after following either first or second `goto` statement. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Sergei Dmitrouk --- CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c | 1 + CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c | 1 + 2 files changed, 2 insertions(+) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c b/CryptoPkg/Li= brary/BaseCryptLib/Pk/CryptRsaPss.c index 4009d37d5f91..0b2960f06c4c 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c @@ -82,6 +82,7 @@ RsaPssVerify ( EVP_PKEY_CTX *KeyCtx; CONST EVP_MD *HashAlg; =20 + Result =3D FALSE; EvpRsaKey =3D NULL; EvpVerifyCtx =3D NULL; KeyCtx =3D NULL; diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c b/CryptoPk= g/Library/BaseCryptLib/Pk/CryptRsaPssSign.c index b66b6f7296ad..ece765f9ae0a 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c @@ -97,6 +97,7 @@ RsaPssSign ( EVP_PKEY_CTX *KeyCtx; CONST EVP_MD *HashAlg; =20 + Result =3D FALSE; EvpRsaKey =3D NULL; EvpVerifyCtx =3D NULL; KeyCtx =3D NULL; --=20 2.17.6 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75264): https://edk2.groups.io/g/devel/message/75264 Mute This Topic: https://groups.io/mt/82915566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-