From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75078+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75078+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863207887945.6570896904337; Wed, 12 May 2021 16:46:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4s0oYY1788612xLLnvnFso0X; Wed, 12 May 2021 16:46:47 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web09.6108.1620863205852451842 for ; Wed, 12 May 2021 16:46:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mfRIIKMsfmNvzBjnIguUkl3R6rk5BPcMYwU8+n4bKs2CBWELaNnotsYGpiPol90lLnNfETWhRfIkKIZHzPsztgRHSSbhri3PTYLCyXjgAcXrmnkn8laVKkZHXeF4oNmOGsFgU0grgqX1PUzEiWuujUsKVFkcu9lspMYfuNFqf73OLHpNGxyoyhw6ZZSi+Gz5d+dLKSsSqwaYd1PyAJuU3SHJ6ZXHNOST3R7blik2/gp72FWyxrtyHiuSYUz8p53gcoTVE+mh41eC/2rPqGGGF9BC4S6tHaSGdhK4YowYx4rLGOXw4xCifxlJ090LdslxYgEfqix0i+aQRqecHZz4Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/iWLAyzv1rDMl7eS3XN1gv1kWhC/MgUk8otFi7ogzgQ=; b=Y0CLbO6mtzZuWlEPA39WnaLfmTVPIsfDIAj3zWIpWVmOG1xbf4XOD3mSHRIqR+9tIncd3vk0ivcH8M1Zlmt2WC6yVgScYAc+a3CWgDf1jVFKyt97LfzytwfRHiS5xPD2lyKE50VCUzkDRunp8FT6WETb+EzqJhF/iJLBxnHdOz60e+12RsnoYhzAn5CzeYaN89XbZfiyZTYYHYLBYYiAS39VlVrCeqO50zDBqCSWWcVqyX9Q6G9lmWQbhgnGpHzDThz+0FmxhJKrekB3w4Y5bJsM3Fwhc/W48ufGiWd2H/09fESJAWQnDKQdBPMx2mRmYMeGzHHYIpacEPywFmHY3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:40 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:40 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 01/13] MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition Date: Wed, 12 May 2021 18:46:03 -0500 Message-ID: <20210512234615.1726-2-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3463e0f-1f09-4343-1dcc-08d915a0306a X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:813; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: pnY0vo5J1Crp0LLWEPBYos3IBQoKLRz+GZEDYko/B6sXxLAMBb3kJ6mRjLJlLoxk71Cu0Uk24myzxZX1y6lIt0J4zX7aw5c5BNeHlqa8lcNu3M6RNbd5ZicA/VAqpg8UF68YhqvB1oJvN93rQly5cCQhzAd4jRlb8g1wlhj8XiluFGqCwBD3MDGNNdcC2ckNfXNvDAtLcX8J/Uz/XA4ARNgwn3+l8naJxDiX2jnHjAgWcHfFu+y9kC6Y9uBKi53P0WYLOkV7MOqpjqO+F/ezRd5HAIwuQniqOitKU/rFfmc/41lYot6Pc9OlBykyISqhGlZMzTNZNAWFqzwiX3qyKNnY/RLl0nE9xmRm2QeuIgGGkbqxw0cmpMOglBd6GufkBgMo7JO2/tQU3/WV5GzGJXn8CYyX8pJFtI6SjwEGNC1wpZn6sXs9hoPNeI8zaMaVo9IHe54WCeHutgy2VxbFvTDZyXSYMD34Z8R4KA2RVwJ/RkU+7aw8KUJjps48wuZIQWbX9k7api3GBsiSvnTVr8sIAS2waHGUHViLTv2VphbMO2LHhwqUHuorjNZd3ZTed2JYxocVE6Js71ZhgTbSikHEAwZOHtTz+w/9by5ZOXKeAGjQuB9raRaFBVTZzpf5syZvLu73LUmO9lTLT5DB+polAJ6HHsUbMTjgAZyDNMFZjluP80nSKrKHjP3MRhNw6gartdQaCL0+oTn0ArdPxXO+lpOGgxwWv7tsVHHEGLEifH4FYhLHLR7XR4A2zYYM X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?UZm2QcXzdlfhu96B8/dhQCe0kRPQvTByN3n7Bu5OO7YfuTNJEtT59P6kS+Wx?= =?us-ascii?Q?EObaFeS+s9k9RzUHF0L0AvvsN7xnRMvnm5Z+m9pBg+SC4NsuGHZvjf4r/sro?= =?us-ascii?Q?n93gD+2YMmTRIWmYbTffBbWCwN45wvdOox13bdpcjjS8ea57BNc9Q6iuMOJA?= =?us-ascii?Q?DUooOIjiOyukiGnY3lG10724673Is1ecd/HeLY7r8YG0AL9GFJ/5g3BHN/1s?= =?us-ascii?Q?KRDyHZySAK2oPRfoAGhwb9rYFWDSZ0zaH8A9gVC4+AwItvg84rek5QKASqZV?= =?us-ascii?Q?0X2kJQN0lZ7OIEA2D0vzjc4NBVl26bIFYmsCJe/beTrQAaZYIQxKzOuw+7z4?= =?us-ascii?Q?SKNW8HbUl6qQUEDGnNfXfRrh0CC88sU4qZ5Oh1LFd4U29czrpcOyKR6iwaa1?= =?us-ascii?Q?4xuzZ2u2AUNnpr1zjb1qt4fI6HlRfzRsNSFDPQII+1U6bNAmms+30YLvVsDB?= =?us-ascii?Q?cye6p5ISlFTub5BPJrrdZrvtMwuxjmU9MX3LL/cj+AgSq6L6bsTmNf76rQyK?= =?us-ascii?Q?CPs2cWAm8qEh9jRFrnKBaX6mNJUcRxYZyT0c5sXY+/xCUs4tASLs+8Jh7/Ks?= =?us-ascii?Q?19orZPTDb7M8LJsKcj4hQwfpbVN79t0h0rUkDesYDC66L16Xfqmalu9dxZQ7?= =?us-ascii?Q?hSTFHtfsqx//Xh3i/iXVw59v9cp9C7ZWuBxPU3AEnRbF8erRgplDWzhyceyG?= =?us-ascii?Q?LpwDEhgN0aW70vqVuY41GR4We+ezVBVn6TSdeWX3xDdN0McnNkAaaCSl5D5Q?= =?us-ascii?Q?shc3cmVaYZ3y0IXdkILcjqCtLfMUiBD8ehfF1ZDBqUagvLC3jIkkTmYYRjX8?= =?us-ascii?Q?fZ/kfQqzOSH8T4Ce3tFxrPJGrZLJJQT7Kpa9Pq+UUYcr90GnO7LqSOMH7Nlr?= =?us-ascii?Q?yuK4c9GbPh60F26FYmKUclK5pT2Uak/mp3VIy80vVrNH1y5IJsAm9TBxnP3A?= =?us-ascii?Q?UfTJQDskw3WA5KogZbNTJXpiAF0JCLGcdPwc5dQyvQJGRvBV7EG5bdhbRsJ4?= =?us-ascii?Q?OZNeQID6GXfbFC9/VfkexOGqB1TuqQvosQ9zelb5XpcINyq3c8fGU34YSCiW?= =?us-ascii?Q?CB9jY/AHVTJkD0WnEpbjxRC+IumDtgh5FftqaC+/FBmfouUkKY7CJVm7Pk/t?= =?us-ascii?Q?Tbrz8vSzC26YTm/LTDUnRCj/LfzL9rDridDotLmEhfQ0T4TDgiVxDLywHAjg?= =?us-ascii?Q?Xipky6KDimQHJXH1xgDi7ntz8u1+eL88nIdRG8EoMkO3rpQA/I0MFAmux8NR?= =?us-ascii?Q?q1ktDetwxbvQw+TXx2BH8goUErJe9Erd/HDPCAIZNUn/ZkiGG7Aun9R7y63Y?= =?us-ascii?Q?7bJ0WVyi9h9oUiFt9JIZFGAv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3463e0f-1f09-4343-1dcc-08d915a0306a X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:40.2926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q++4xCxpaflOr3AAvCbEBqy/ZY610Fq181TDfGvFwCPF/FO9aQBPFm6VsftJJm8AehyZJBl9lhYoIhhHsBJW/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: AT55IfE0QRkWhHrk9CYAfClwx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863207; bh=Wjr5+XlVwp6BrFBJstRGvY1OsS0TeOUhuIJWPqplc8c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=MyYMSng71jswTf5xxSGR6MsmoMaNPJBBPvMA9Il4omhFIsVNc8AnCxtVuKTlZAEO+4Y rnGXGysm8r607qH0RAmwGkX7qeNE0NSaN5u49pU54iYgd6hyXOyktbRjvMXqU6SmjgN5D 6rs8eNwNCcgYQj/GajXWvN5+hvMqPdsoIlE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Define the SEV-SNP MSR bits. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Brijesh Singh --- MdePkg/Include/Register/Amd/Fam17Msr.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Regist= er/Amd/Fam17Msr.h index e4db09c5184c..716d52fd508d 100644 --- a/MdePkg/Include/Register/Amd/Fam17Msr.h +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h @@ -87,7 +87,12 @@ typedef union { /// UINT32 SevEsBit:1; =20 - UINT32 Reserved:30; + /// + /// [Bit 2] Secure Nested Paging (SevSnp) is enabled + /// + UINT32 SevSnpBit:1; + + UINT32 Reserved2:29; } Bits; /// /// All bit fields as a 32-bit value --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75078): https://edk2.groups.io/g/devel/message/75078 Mute This Topic: https://groups.io/mt/82787283/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75080+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75080+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 162086321883559.74008920604854; Wed, 12 May 2021 16:46:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qunCYY1788612xyLTdrEOSTK; Wed, 12 May 2021 16:46:58 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.89]) by mx.groups.io with SMTP id smtpd.web08.6092.1620863207579547074 for ; Wed, 12 May 2021 16:46:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFY+g3K+hwwG5cHKQXbnkoU+M5wfhDocNYq2hiX2zKczD4Nr7xOe7xyULAxRcAdajVV1n0awynsVd2NqtTA7VUy1Pk0gqrc0nXdbJjsRiA1H50vBj2JMNgfiChEEU6ngHNO8rbFo/5eOcGFLQuYdGfgVqldKMcezna9KfZmsAjr1JCh+AjM6KuXX1vo5d0OyGrdL16bho8HM5CEFXo9JffpMY4QvJiU9WImnfAtIrIBv4UTh8wsyDXIvRpy8Ehr/jsK1a3AFcyFZ8Thgo02riLD24RMFvwI8iO0q3oWUkeV2vxo/2wgthLaXwsYdWUl46SWtsvnrzqkWWuh+H7D0KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ucll7LZ+tCrr/1hdfNUd5YivsHSPtAuaUgGDCtgkDA=; b=Vw1mLkxfb+VlKEJ7iHu1tQwR0uDfQ7mWSTAdBkQr/kV9cRAH7Cvm2mS9RA980uVsaEF8w0mhw8zYICvZM77IxAn7HPAsgY34S5qdL5+1oE5Cbr1wEqVH8H5FF6/fqUJzJPFG1jBVgY70OXtJd8RLX/5wgKtHvKHws1KG18oGeIF2Qju+5kzUFBXbSIyMJFm6qkmL7x6Lb08aG4o3gjplNWUnFy7pxGNroI69/JJJ23z+hvryfpiWlXTZ1ecrKfeaXCkNNJFVUzhUPF9Xv5JmZ6zQkTviJPmChVhSSATrT+8+kVffDHpftFBFBjbNhyUb+Xt1eYZBe82Av483/CwklA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:41 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:41 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 02/13] MdePkg/Register/Amd: realign macros with more space for future expansion Date: Wed, 12 May 2021 18:46:04 -0500 Message-ID: <20210512234615.1726-3-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e00f5d36-7a21-4c2d-943e-08d915a030d2 X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: f1cAWkyv8Kjx0v+4uS2pRn6YVwSxzF3hPOCxZcA0rqbvM+9MURn108QUq0Ht70uusHxhFSNNqaL7tMQOdVIZ0jDCsDfMdqnNhwSGh7XpG/Z+yIX/H0o9al/voLCQVXJQqsVvIxTMMOvXRoyETBj8wneze6tDuZTBJdPsaq3mub2dtH4aeT9i19jPbYpL1eCJ0LJ9mPXYvUes6z6sQOy+Dld1MmhSTn22a/q0Byohl2oag5JmLD+2oWtKQNBb1JXpuwEhbB9H13E0SXM3FOWkjGBZYND1t+t/EZSs+YB6Z78agaIJVOwgvnD8uzWN7CTbQgyGqv57ch+H9RbN3OUWJ71+gNV2PiVfohplLl4g1ueK1QaqoQsqhcUb3r6wG5+yDw3DAz0gbfCrxRFsQhEQ7cljplDg88MWTo3Bw/bki8kMG1gRvz4pmEuwtc0TEPoBZHh/WXpXBwDrpOKPzfgx6R3wR+vjj8Mg0ynX8lU39cOD2etFbyPMlI6ZncHKkhf8fw0L1V573igSGLjQECgJgAqX4T46mzysSIO3lTNoY9B3aB6hEYvH6FkyMVYA90MUXGztpOhjtnITrhUBsNQ8j3bc3dRd1MVacSd4QqsgSkkKJLhaW/0FyrKOZzCb8hPKoNs67t8pVvkBzEVSHxFmNFs1RdkqtKuN6IEbxw5pxyGNiEEImfvoc93Fr8y66z+Mj+G1+uhcjeTwRd2MWETU3ggVTa6LNsEZD6zU3mX+FtROtUFti0iVYvtIWT8FQTHH X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?AAMA7QIBgS8dXN/92dpoCAv28aC1nR/5ep6RVv72TZLIMOX2Cc/eOKjeRDwI?= =?us-ascii?Q?igGyUim1VaaI4ANGpwp2lO7Je8FStLM53eRJS1OcSCyAMYZnfWkzvFgKBo5E?= =?us-ascii?Q?RP2RKBhZ3PNHiVKENfM6oIqQ7KDC3za/8g0bhhOTZxQXJpDydRo7sVwcpLda?= =?us-ascii?Q?0q2mUgBq4cxk6+/NKludc9Oy4JXFhG4hevhH+jeKQETrrLC0Xph9Tlz8R+Uz?= =?us-ascii?Q?Or+YPPWw2FCz2kA0FNwo02wYnzMpFYD41iIjepjp2u5ODRH+aezk+ZO+q0OX?= =?us-ascii?Q?NkYdRG7TxXy5hwgW6/BWp18aHkrIRY/HGETfShUqj1fBU02QvuOIcYsX/INk?= =?us-ascii?Q?fu+I0T8qoHP4Zbkpjh9X8UHkx/M1b3hQ/fIgQjc/OvYa3ZJHgLEoHAlQKDOp?= =?us-ascii?Q?XUGR04QDMIFGXhJ8LyiPCiUBB0ITEJKQmMBIj4yUvFmDjFfWu/aPhXt1sNmd?= =?us-ascii?Q?uZPKH6QE+0KltAMlUPgYy2CNLiiTui+CGBejcpyeNgCFxFQjUs7ZlS/Vvhfc?= =?us-ascii?Q?5pzeN1LFmYIbkgxOGamozh4gSQ0KygTyEMgoWkTEKogBdhDpu4glzmePINYY?= =?us-ascii?Q?87HKcOSgVckmJJSBYR5MK3iihMrKZBKssHogVF3NBUB3B5wJDDTy9QgyxS0k?= =?us-ascii?Q?SeiwezeC6HUoBcSFCW6Y95iR99OZ4xgrXjFw+E7WeUg3UXuDw8J8GTrvZ2aW?= =?us-ascii?Q?A9Jzplgf3uTYpsS0ciiU01lKg2ggKa6imNJkVsA5+LuajezcevgNpOoF9sGE?= =?us-ascii?Q?wOztGql/VyBhYWw7q8fMXdbobFcG1//EjOSzp7UaQJNRcYTe09vXygwFoiA5?= =?us-ascii?Q?2tvraFTush0P5/eB9+or5cn3ZEJARCH5CkNPd/zuLK2MH4MJywVOv4z/esbN?= =?us-ascii?Q?2gHBJa3lKffHvCmNldIUX9aUvRt/bvDphtNpp/REfOqBhnsRGLm44TOUSila?= =?us-ascii?Q?VroPbogCaTms+BtbdYMeLwvf8LuStLmU0pDiU7lIZitH+E1Bi9VpnX/q6iGc?= =?us-ascii?Q?Q7Ksacw6criN3myEYBJNb6fTjt7MaBxCbwVhzFmf5K6q6Z+7u+Nn17wDNVlR?= =?us-ascii?Q?dUFVEJNpVDiSkZX0dE9PLzw5MubC1B4MNw36YlA+g6Azk8AJZp9Ezn3JLkNb?= =?us-ascii?Q?uNVZNhbDGaWj1hAW5HyradQ6FVdOzjp02RJCoOVHLgd2zB9G86PGf89QjKjZ?= =?us-ascii?Q?Tz0Owh9tUCoBcY4yJXzl5XPoP0ZRbqrK3eXJA2TLjBAQcM2RVOeeyUlrA5aG?= =?us-ascii?Q?Ugz82djEXn7zoxv+LwsMIl2zMxVprr4OQw142CgFKs8Jflmbpw5xmyVcwvIn?= =?us-ascii?Q?RF3ZxscBwwdU5FVE0JR5Hvr9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e00f5d36-7a21-4c2d-943e-08d915a030d2 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:40.9472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O43+IybLAY9OgBuf6KrK3+ENZ/Z5zF/XiBdqegjfSSJZ0SInnS8gI0sXWtr6CnS8YIqar4Jfm0+2D/R2dZriLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: gTie3reKGAJJNodZB5ZD1JTGx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863218; bh=jm1mpH/cQlve7n8FAiFq+AaS8wzZArqs0jd0qlF8MBw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=sz93jrzrv8UWMax5pZBYFeBJ/mBoUr68FG9YhXNtcoyCiW0YzUVHVzZPXj98rGQEhUR vMZhMu1OrVDbjW2Esf06kydogp2OqN+k/6N7AIU0jlRSoeH4gv0G2RpOneVflDhxbverU /p6iwdZJHMA74NcRGx5/+Riq4Ub9VMK/yt8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Version 2 of the GHCB spec introduces several new SNP-specific NAEs. Unfortunately, the names for those NAEs break the alignment. Add some white spaces so that the SNP support patches do not break the alignment. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Brijesh Singh --- MdePkg/Include/Register/Amd/Fam17Msr.h | 10 +++++----- MdePkg/Include/Register/Amd/Ghcb.h | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Regist= er/Amd/Fam17Msr.h index 716d52fd508d..7368ce7af02a 100644 --- a/MdePkg/Include/Register/Amd/Fam17Msr.h +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h @@ -53,11 +53,11 @@ typedef union { UINT64 GhcbPhysicalAddress; } MSR_SEV_ES_GHCB_REGISTER; =20 -#define GHCB_INFO_SEV_INFO 1 -#define GHCB_INFO_SEV_INFO_GET 2 -#define GHCB_INFO_CPUID_REQUEST 4 -#define GHCB_INFO_CPUID_RESPONSE 5 -#define GHCB_INFO_TERMINATE_REQUEST 256 +#define GHCB_INFO_SEV_INFO 1 +#define GHCB_INFO_SEV_INFO_GET 2 +#define GHCB_INFO_CPUID_REQUEST 4 +#define GHCB_INFO_CPUID_RESPONSE 5 +#define GHCB_INFO_TERMINATE_REQUEST 256 =20 #define GHCB_TERMINATE_GHCB 0 #define GHCB_TERMINATE_GHCB_GENERAL 0 diff --git a/MdePkg/Include/Register/Amd/Ghcb.h b/MdePkg/Include/Register/A= md/Ghcb.h index ccdb662af7a7..712dc8e769c0 100644 --- a/MdePkg/Include/Register/Amd/Ghcb.h +++ b/MdePkg/Include/Register/Amd/Ghcb.h @@ -49,12 +49,12 @@ // // VMG Special Exit Codes // -#define SVM_EXIT_MMIO_READ 0x80000001ULL -#define SVM_EXIT_MMIO_WRITE 0x80000002ULL -#define SVM_EXIT_NMI_COMPLETE 0x80000003ULL -#define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL -#define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL -#define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL +#define SVM_EXIT_MMIO_READ 0x80000001ULL +#define SVM_EXIT_MMIO_WRITE 0x80000002ULL +#define SVM_EXIT_NMI_COMPLETE 0x80000003ULL +#define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL +#define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL +#define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL =20 // // IOIO Exit Information --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75080): https://edk2.groups.io/g/devel/message/75080 Mute This Topic: https://groups.io/mt/82787285/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75081+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75081+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863209058917.8420223720699; Wed, 12 May 2021 16:46:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id LooYYY1788612xOd3A3OPhQ8; Wed, 12 May 2021 16:46:48 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web08.6092.1620863207579547074 for ; Wed, 12 May 2021 16:46:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZMx3es/i8ro0cBO6fQYeQKnh52FbNvgtCMa06DT5aBdXe9UAcoeFLfVmFsnNGMXVDCa5w6RHdKCxF4kjOAhjhwqAjHKMzV0gTAHz8ytSIUTXmB3FrVKwbp90MVAJMfWp5P/UcDt3Gu2+r8DHnlb6lHFg5fCArkloIXk+EafLb9IEbEo4qtT6l3AnynmQiJXwvGgEaJNIZbDFtK4R4t2V2k43z57DZ/RqrbJeSddFrEGSRHnrfVzoW4r0vrH0n9ZWlyrP88cnd4cbcg6SyCdu1g/FNKqrRXRpAPDJuoO6PzX2pBhn14cr50OIitrqqDZ9M9+l7kg+A8ACUCqy2mOj8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLtYHQsHIaDsFRMxqxNJFyqiGfLdvpAIY+3+821HXY4=; b=bXS1SNNWtKYQoeX0+4TviAtGvwahJB5gBDfvILPP2P/UoGmiBrA0JfdpK08HTkU+KsGBaxzmbw0p42JioIyOLMGkIKLxIrurhJSuuHPhiIoL9urxomIA07+ps1LTpBqAXdQMMGSqvVLeDAoStYyozx4U77znjuCkQkkExSrqGhahVYp2FpW8jFQXsiUsYjb1NOMzoVuELUuIa0iZAFdjVYCg/GDtjPl3iNaY1NGK95fJam2JuMcmSYuRqs8uY+ZOgub4RgcgbSXbCKFKci2dNm7h8Zru5k9O8DqynWqj9EIyQLZmQ38renj5nS3KqDwDL1MoHFah7i9ik2LzqPaf6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:41 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:41 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 03/13] MdePkg/Register/Amd: define GHCB macros for hypervisor feature detection Date: Wed, 12 May 2021 18:46:05 -0500 Message-ID: <20210512234615.1726-4-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ada6730-0245-4099-2de8-08d915a03134 X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: PeJ8uXH9JjtpQMoCJZIw9y4gGEkpe6o6/DnI7D8UnVuqy+lOP+LziyyN90cGf2Jbu74H2gwjsuwoIoTXVGRa8rt3arlmIvgWBihZEUepF96q9a9TflAEwcMsr1pukXpccS6idkdvWGk/KaVWj6SEdfHSiGzIq456PoVT9QaGFUKB066lkCfxi+SlBQrC4m0Q/LL26///IDyk9CoZu1ETwgyn1U9G96kL0cwti7HN9YE1sQfSgAb/Xo7ohs9Tfh392mVrza6aveSfy9gTT0efVF1Fe/jy2pAavbbTMu1BZgk6rrX/5cFIPB/xNt4Ox7GcLuCk9YwWMR+odz4/F2RV/IMzhq02kQ6b3kFBBn2Zn4ktJQS2denErk2vyKu4upG9AQxxliAKDs8zD5tvjfA8HgJw+S1eYFIBOn8EwSCx+MlXKYR04AhYl1dAZ+F3Je4AODU3cTN1ywOeHtESOTwSp8rFCPMLROefa5t9XurwjjZvsxBpPi+7j1mDIEfdbyLfvLJJKaiJTm4qtd8bPmTVvKZ6z2tlP5ByhcBcvjOGMsIeKQxH3wqZgv0ReTjF7puDEFQ0LLtkRHateLRQo2s/cz5KueUEKeCk07j/CLxxBDHWcUGwiRrRqqkT+nCiPSvmgH0E4GTUeZxtjiWFC7iA0WurDfQ22QxOpLzQvvlb506NoqWUZPhEupcuPdbJTw7C+fIf8351QtULI+eD4uLWqTGDZbjyzkGCPlqzd+0xeVg= X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?i5jL4fEWPNqavHYOHTBJIzTyY9X0jf7IV+mSSKO7NXCgR0L0X+iIfyHxm0Md?= =?us-ascii?Q?j+XWrp6owXHSjFB4LyN4BvNXsQFQrhy1Dwloi7Ahc6tahabbDHc4GnCrY+4a?= =?us-ascii?Q?YKyYzvacqZ1/qehF3WlB1S8dtQ/UXOZOB/2z6kB2p009in2BFbA5RP+Yo4Kn?= =?us-ascii?Q?12cm0ustnbFFdpSb3ZDHQqBqh5W37IzN/TYxqDafklOVUrjp2klzSAGuzzev?= =?us-ascii?Q?sNe67xF5WF56KwAc4VvnpSAPMI2fooTzfyimBiNwUkqfwQ/AuPz2ZW9A7htv?= =?us-ascii?Q?1EUEHtDI9dLdbu6PGxA1h7V60xWabk3ZkfdfVL36jHJA469RXfod/u7eMfAm?= =?us-ascii?Q?BLDGC6nDzeB+6RDaLfPp0K96owgVzxzS9MTv/TZ9+9FmLKmCKNDtJvf3lqLy?= =?us-ascii?Q?48HDDbWK94mn48ntPaPN513dNeLNDnxwyXnJlJ4p5q0Xts8uYTLdceQmKbJE?= =?us-ascii?Q?s+QFyAkr6LNIHSpBw2bXStUuqFcGdLo6qQq6G6UmkDC/3wfr8/PCFu5Lj3tO?= =?us-ascii?Q?rbNx8KHUrijcLVODDmYhOx0PrLfHlU7WNfLz75ZwFw5fYsb/v0fjgvFDWX9V?= =?us-ascii?Q?+Sh2mo7NZ2xN/c14rNqix5p69oWcg1kRur0iMORhtm6Uz64KaSlLz/ozqg6/?= =?us-ascii?Q?KZSs5DUTmWhJ8SMiRQQMDJ+41q9SdVMxgBuGQ5YufoB8B/jr5DXP1fmn62xt?= =?us-ascii?Q?sGBh/VIKKbyLvwc8qLiSww6sA8/ECneV70cQGPdr8Vbg+UqXqLib+Zdrcdgz?= =?us-ascii?Q?S3RF92InS89S5/7y3mSipkdhtPPcLzSsLSPs8CKv/kD3YC3Ic3xPpcTrTAV7?= =?us-ascii?Q?MwOybS9I2qDeUAyvWAKN3qL5lBQcWmbJwqTa2a4QXpZQCE2g+9lhal9EM8lY?= =?us-ascii?Q?gUx8GzLnQdF8VEhE6jyGnq69/KkiOMiscL5qd9p6P7r7QOeTEar6+4mXr4n5?= =?us-ascii?Q?H/ulz2D78JZHoTWimUw1mgNzqCWw+tEv9Z9r9pugLiWooX4CxEh3y4ARaIca?= =?us-ascii?Q?qY+uozUXQ/NVTJjzN3GQVeVUOb9r5F2f+5PiL2frQPkSURT5/diBXbqx0nwS?= =?us-ascii?Q?pvDjhAAvklp7C+ZUh7yWcWLYQkYZ6ys47RjwVlF5xeF5pG+l6+Z85tidOiGh?= =?us-ascii?Q?WVzao52tWnlHL19ufgYvtThoSn6LOj4owoSgIeDlbyPGqcTl2gWyYUHY6C4O?= =?us-ascii?Q?xyqwt1C2KMS1R8liARB7kgoQa7xU7htvYUz+T16RCKx9O/VMrREnBEFGCCFQ?= =?us-ascii?Q?iunjkuBBGHZqc9HGirLsx7b0ArAfKzympERa4M5Yf2JbyVvvUNLrk4kk602D?= =?us-ascii?Q?W70PgVHP0XYM81jcptVogG7u?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ada6730-0245-4099-2de8-08d915a03134 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:41.5928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYqhyGy31KD0h46y/RjeP/ADxhE0EgNMYCmWydZ1+Ukcu2tRlS/mipDf37Ru30KKy8Of/aNqotYtcDra2deWLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: 1OCtfJAF4WuVuvPy0p9y6aGkx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863208; bh=GuLMlOH84L2SPgkAucYIUYDpULA9XEF4xSAJdpY9fE0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Nykk7ZY/uTwcHHQiX4qdD80DK6ZxfmsME9S5cwiYh4Z+byGXovLPvjbixehWvSg+5fP mgCJ4uFIwpR5LZ9EfuUk8zTXzoZuQPZ0FX9yCNOeJTkerkWYFCGcgAwd8Zl3IZclUyGD2 z4GgdmBf+4dyZcE8P9DdjHdotFy7BgmC9A0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Version 2 of GHCB introduces advertisement of features that are supported by the hypervisor. See the GHCB spec section 2.2 for an additional details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Brijesh Singh Reviewed-by: Erdem Aktas --- MdePkg/Include/Register/Amd/Fam17Msr.h | 7 +++++++ MdePkg/Include/Register/Amd/Ghcb.h | 8 ++++++++ 2 files changed, 15 insertions(+) diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Regist= er/Amd/Fam17Msr.h index 7368ce7af02a..cdb8f588ccf8 100644 --- a/MdePkg/Include/Register/Amd/Fam17Msr.h +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h @@ -48,6 +48,11 @@ typedef union { UINT32 Reserved2:32; } GhcbTerminate; =20 + struct { + UINT64 Function:12; + UINT64 Features:52; + } GhcbHypervisorFeatures; + VOID *Ghcb; =20 UINT64 GhcbPhysicalAddress; @@ -57,6 +62,8 @@ typedef union { #define GHCB_INFO_SEV_INFO_GET 2 #define GHCB_INFO_CPUID_REQUEST 4 #define GHCB_INFO_CPUID_RESPONSE 5 +#define GHCB_HYPERVISOR_FEATURES_REQUEST 128 +#define GHCB_HYPERVISOR_FEATURES_RESPONSE 129 #define GHCB_INFO_TERMINATE_REQUEST 256 =20 #define GHCB_TERMINATE_GHCB 0 diff --git a/MdePkg/Include/Register/Amd/Ghcb.h b/MdePkg/Include/Register/A= md/Ghcb.h index 712dc8e769c0..ec232ebd3807 100644 --- a/MdePkg/Include/Register/Amd/Ghcb.h +++ b/MdePkg/Include/Register/Amd/Ghcb.h @@ -54,6 +54,7 @@ #define SVM_EXIT_NMI_COMPLETE 0x80000003ULL #define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL #define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL +#define SVM_EXIT_HYPERVISOR_FEATURES 0x8000FFFDULL #define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL =20 // @@ -154,4 +155,11 @@ typedef union { #define GHCB_EVENT_INJECTION_TYPE_EXCEPTION 3 #define GHCB_EVENT_INJECTION_TYPE_SOFT_INT 4 =20 +// +// Hypervisor features +// +#define GHCB_HV_FEATURES_SNP BIT0 +#define GHCB_HV_FEATURES_SNP_AP_CREATE (GHCB_HV_FEATURE= S_SNP | BIT1) +#define GHCB_HV_FEATURES_SNP_RESTRICTED_INJECTION (GHCB_HV_FEATURE= S_SNP_AP_CREATE | BIT2) +#define GHCB_HV_FEATURES_SNP_RESTRICTED_INJECTION_TIMER (GHCB_HV_FEATURE= S_SNP_RESTRICTED_INJECTION | BIT3) #endif --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75081): https://edk2.groups.io/g/devel/message/75081 Mute This Topic: https://groups.io/mt/82787286/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75079+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75079+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863208293791.008093259126; Wed, 12 May 2021 16:46:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 72DKYY1788612xD52mV1wuIz; Wed, 12 May 2021 16:46:47 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.48]) by mx.groups.io with SMTP id smtpd.web09.6109.1620863207073468706 for ; Wed, 12 May 2021 16:46:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YJikbU768QpjF6XHLlct4nFzReshPOcH0ePJgWFMet57WajFL6g0QA0pKxj6+v2B/THGymN3OMIWWP8qeeRoQgFAZZdylBYprIq8qGwYSRARwDIKZgKJgFwzff8/J/Gif6tCMuAyo9CSFpLL1qdaaDplPdX1sbP/7BFJCKrTmCpG0hASPtQKvMkBY1RA24fWQysN582rdo7jZOAoawoLvg6cDwqvUbDphatccFgbLq9wq5i2QqA99c+XxPiZ6NURMKrFqUCerhCM8M8Q43QnW63xfDzdrAL8CJhegxNNfYEzVCnUpEt7XCRMHabO7I3H8PVD4VPo+At9pF5eFwQEtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YvFeEJiRf8zD4eO5THDmrNW89ps9Brp4vvqhmB0KajQ=; b=bF8IEYAPClz3XwFbwpzD3GqBxcT250tUuNI/D+J97j2LKaDlF1sitkEV8xKnr9VY/UIC6tnEA+Gcz/6rRQrZz40GP8T9FlwBlAv0/o7k8tf+9U6/w0q7aad1dmoQ/yMAJnoCgwFnyIsuTxY65ayYOZOYF8F0eaZss6WVQdvd4VS4l2aXb9paNt4/vwYeIMmZUpRw3tgLUaaJTISk8mlm+6Le9yNtwgPVR7BmOjHhpEslfR6Qcn8ELqoDPlXoBWkBqB7avbRyk4Ub07/LOP63b5r1LNzMbSFQYS5R6J67M6KEIEupWPfbFc7mOgJtsWAjsjMb1SnG1ZYySxVxIrl+xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4575.namprd12.prod.outlook.com (2603:10b6:806:73::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Wed, 12 May 2021 23:46:44 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:44 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure Date: Wed, 12 May 2021 18:46:06 -0500 Message-ID: <20210512234615.1726-5-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e2c794b5-adc1-457e-0083-08d915a0318e X-MS-TrafficTypeDiagnostic: SA0PR12MB4575: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: yjcXLtS+G5EZj3xcIQTcovliNSiZ1j29IYU0p/BRDrAOyy3JTU2lTWzt04+cBCAwj1ksKnoMZXhtW5yer5pnN/x0dfR3aumEDU/TtuKImG6pCyJp/uK9bzbMQ9jyz7Tl7+C7/I6GhyzM5aUS9AroXf+LoRvwdKxs/VeWhv//gvZYaKIUfT6Mp6IZnzj1PFgnzn+YaLDgz775ywFguUUff2LaC2snpY+mMVysycgwADObd6Phy552phys2ArDN23zbTzy0ck0V81QgepY9aqGXglPsjchE2KwiojcBbK9LYj48eb3X73GZOvA1Ga+A+6gdDtV4CjnjsSkfJjjNgiP/iozgLI+5dSZBuhbbFIX84myywf2np58mxXMxYjhw7vhH5i0CHy1N5+20WL5I6QFMJewOc9PYGYuCC6y+W5YtGojZUTWexRlieAa0bzuabJCfjYqOSeknhexJrzBrGpf8TlhLqQqLUV3i67PJ9fxllyeaO86eTSIomyxOXO3Pncc+zW71tqjNOuJnxJNaLKns2PXzoywH9Mp5HYJ99w0lIxYKuJfF9t4EYQC9Rc7igpjtpyveSIw4G+afDG1ePqo5rWO7kiCh+0NmRYTTPZoLYzcYqMS6RWpjH7Ci/8HtVS682v0ZdfcXMcnaFuWmvkxdfxbNPxjf6g/i4/FkIhSEkTPfvjJGr9xeybRRzy9uDjHs/xYwfongXTWDZgbWMZaLY9/fBs4yYgNzIPaCF7YFyQL6AznIv1SnhTUFHM+7CCO X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?FMdSKpvTeL6PXoodsiN8w+kvCV+DKI5KhoLyuxo2fJwZ+tIU+wsVQj7MYxOF?= =?us-ascii?Q?ydXiyYLKfZF3dxIttsKcBHGasVaaEHs8hnIJHThNwiwX4rwYpT6LVXJ36lK9?= =?us-ascii?Q?eIBAt8cmv5T/9H3WU9uUJi64Zrh8SKRKH15KmxTw34RmuOBe6YRugQnoGv/C?= =?us-ascii?Q?FNJbqHB2eGGJARHaEcH2sQ/1naL9umXVO5hNJPCWrD64BY5tZ+odZ3jutx6h?= =?us-ascii?Q?t+o299UaS8zy2DNQdY/DyvX4TvcanFf05m2pn7cdE4sgGhXjCtvbEhryTmiH?= =?us-ascii?Q?IPOaIJmJ4VJw23G75kkX28GuYY7J7XMl/voJmF3owVylJGZHz5ATWiLkx+Ni?= =?us-ascii?Q?Y+oSoP+A35xktM43R7Cycp0csknZ7X6zFwyvYmD1nCWp3q9P4Q57wgKO3PTM?= =?us-ascii?Q?Wqs5j0O43F5PRWQJpD5ziFsCYjbE3sEc1vZnaqaY0SDVc7NCgztn2igpOn8j?= =?us-ascii?Q?SVEb0Lw9YvfZV46r7KhXFtMqFIkO5YdMoOD00JQmdSkNT9VaQgouL4Wd2hGq?= =?us-ascii?Q?DCHh1fywfUOY7VTlWhB2ah9Xv5KzoYOEJ4g6BbxwNkGOK1ckjeQQT0kRDbWi?= =?us-ascii?Q?TxxFnSVFOsOLCT0MD85hNJpTzlaIfw7u57L0OEUVC0a65pwizfeHZRMgAb2v?= =?us-ascii?Q?7RaWnlkQ/y1Ni05SWzyXGWVl4j/N1moFKC7ZzPlgix4CYLoL3kSXgXL1Tdc2?= =?us-ascii?Q?yLiuqulh7M6NV4XdjceM9m7jDKhGqNwdTo4kYzOQssKFKUVOP9Dq80iNbBGW?= =?us-ascii?Q?23dm/JzhrqaVDtPvyH2lwnTclr4fNa5zA77DKGKsMMrCmDgpppDM0lOx4KpC?= =?us-ascii?Q?VfJjKD11twOTxS4YYhxobrAs/ekjcPrIMo04gQZc/WXMuHogXFMQMLyPpiUz?= =?us-ascii?Q?zGaHwNntOWINLG6NCqRsZIJ7kuyFhQmVxo/ej6y2e9mFEizy3Bp2VMhoZVLS?= =?us-ascii?Q?aUeRDVPt/NoFuqoxICMHV7ymSTqmRdg3i9EDzXMTT5ykC/Mk5Qz+7gc1ZKrV?= =?us-ascii?Q?Mn5Q+amWWX7kBbevYwtptBh4eXcGA5rU0pLCxF6cNDf4kf5AjiqYfLp6kFRR?= =?us-ascii?Q?4eWdG4X3oxXbpoJSX+4PuH0AJoGxPvJM45sDGgQUM8bhPywMzElGsGn3tYAN?= =?us-ascii?Q?S/N3FPkvr17HqCVnKh/dKr2aaO2VcRP+uX+QmtKd/UEPmFoxO1v7g6NjoJXF?= =?us-ascii?Q?GdMQ9zzVMOt0aQ7ACCWmbUUSQmqssB004G2DybYDRyqGul54s9XnDt94OWyS?= =?us-ascii?Q?WY6lWbqNE7hxlBymw+lsMDpP3/LfXTs37P9DUIzLSHtVCb1LnrM7eeKcD+fw?= =?us-ascii?Q?If9BkTxk7BkCKCskBZLwEmO1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2c794b5-adc1-457e-0083-08d915a0318e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:42.1775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gY6Zf8lATVgtZXAirrPinyIMFAPVsTdMgKImKoPYj4LnoxXoF/CLHi9hDo16THBmYgM1KUdNOZMMevh0MmDBoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4575 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: bacwavPkLfxoJThrbYHHLhcWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863207; bh=wDwHjst5bFRyk9W4kVoAFQkgDGq/XIiKCk78HD5IsiQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=lTBC+ahwJVZqIRrCdnbgt17XtDm70tGagMuhNeM2RDLKFC+Iv4+Z5Dabl2FyW9S9M24 xL1MXPbEBQXndYaRMHi1NlX5togAqSlonC42WnUDtfnWL/UBVuGwrZpL/7l6B4E4RKXGy OsOYlecV84bF48uZMGAp03WZLBuAQ19Nrr4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 An SEV-SNP guest is required to perform the GHCB GPA registration. See the GHCB specification for further details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Brijesh Singh Reviewed-by: Erdem Aktas --- MdePkg/Include/Register/Amd/Fam17Msr.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Regist= er/Amd/Fam17Msr.h index cdb8f588ccf8..542e4cdf4782 100644 --- a/MdePkg/Include/Register/Amd/Fam17Msr.h +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h @@ -53,6 +53,11 @@ typedef union { UINT64 Features:52; } GhcbHypervisorFeatures; =20 + struct { + UINT64 Function:12; + UINT64 GuestFrameNumber:52; + } GhcbGpaRegister; + VOID *Ghcb; =20 UINT64 GhcbPhysicalAddress; @@ -62,6 +67,8 @@ typedef union { #define GHCB_INFO_SEV_INFO_GET 2 #define GHCB_INFO_CPUID_REQUEST 4 #define GHCB_INFO_CPUID_RESPONSE 5 +#define GHCB_INFO_GHCB_GPA_REGISTER_REQUEST 18 +#define GHCB_INFO_GHCB_GPA_REGISTER_RESPONSE 19 #define GHCB_HYPERVISOR_FEATURES_REQUEST 128 #define GHCB_HYPERVISOR_FEATURES_RESPONSE 129 #define GHCB_INFO_TERMINATE_REQUEST 256 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75079): https://edk2.groups.io/g/devel/message/75079 Mute This Topic: https://groups.io/mt/82787284/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75083+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75083+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863212345511.95341298526887; Wed, 12 May 2021 16:46:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id OFqiYY1788612xt9B2bHrUI6; Wed, 12 May 2021 16:46:51 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web08.6093.1620863210224608460 for ; Wed, 12 May 2021 16:46:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HT6S1KiGMMW65uaGoQfRgQoPG9SUho5uzM6Kmi2RvJG41lhv39rYeimpzzmnjHn0MZDTUguIf9IKd9oO0NTNDbb5az5gNDMFj82B5qP5cTdMzSsXs7oU/2mgs6qq19u6t71kEEH2OrNwouvML062c1vr98QpFtGodpCzz5OXT0g9GMxu7a8d0c2GIqVRU3rX/lnDshfxY9oRwv/DAFdzXQRKzArxnHgIakZi9BqcmevKua0zk2hjKRciAT68PUbcbfoSF/S2d2MM37tdL8VUyjKPStyLdUdnCEngvl6N75lu5DgCAlRoWbHaoUtDt9Urr1rIW4tjFEnsrDfp7K160g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkWLQKUHdlfQWykJ6vVPvb6vot2Pe9/7TYqS9K7uECs=; b=kxxbenCKv/PvOLlO+kNIS7m+N69N+zBb0nrYT94g7EY9SxfaNiWO6e+EwpR399LdQ6UQSRGRyK9fslp5qad3l2EybmLqq8P/ZwLtdg1Lu27Vf7LSjYxC23oi+9dZNi51C905Paiy/MoysadixQdmsZ9ZaQZzyboD59Hy121SF/mtXI3u7Hs2Qrkk206PdAnex4Xd73q+TGDZL6wMoOUtiCwrmiCimzyO5+bOGBMomd9Yf1xfpzC9W9ScObJMu2273MTwYS8kp5N8fQ43/QuYZQ6jlCB7mQyJEuXzN6ZFp0OD1HJBsUSNbCcXU9KqWB5JWRsscNUEROjTn/NnYj8vRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2445.namprd12.prod.outlook.com (2603:10b6:802:31::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:45 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:45 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 05/13] MdePkg/Register/Amd: define GHCB macro for the Page State Change Date: Wed, 12 May 2021 18:46:07 -0500 Message-ID: <20210512234615.1726-6-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8172817b-623e-47e9-3ea6-08d915a031f5 X-MS-TrafficTypeDiagnostic: SN1PR12MB2445: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 2fljVGEOZDFzr3AbJFUMASxPENqzZX+4nFmmhW4ywWXXflVWHXWWQNQiJu4w97zEP6vLrIHh0t9gjKHA306mAWEBwwuOcZUbXjvdTRiCncYqhqlNxUcxoh/KFXkhn2T59Ztw19LHqS60Qp99P2lZi2FrDp1hmOdknnBjuCg7qNv9yqmjgvn57Qz6nKNJRhE9WH28iMGkexclAKns9i0Rck25YsEIYtS3ReBBN7GoOVoj3AgNgUF8fxn1HC9O9SvBFDWtQhf0bajFcDlJtMJh+RH/SG2Qjr1XuC6nhAIj6oDNUENh74sPhFQ3ICIxwKTVwWBwQGzPZ7nQBrqPHILwbHuXPjEObLeqxUmCusF9JdbVNMpln7AZRMO1MfHUgBdfXnBEvBaf9mQC7BjrFFFdTby1D+aS4cgKRbt8r6MlJjISkc0uDSnp4VaUprdYepQezAR6n+5JmkfEloeY7EqXpdQbwXoeg2R2YKU2SCjke02Dm6tcZbkWHrFblckNxP15kCbrJG85RxjyRU+XAq2ucRmlnjfPMPTACZ/DUGDgq1CPzctfnGfqjI8HZEnnJ5L6hQAt9FIvNolZN0drwLL9VzdbCv2HqG2EZTLmvyGFX6Jb7jrIMB0izdrQlFjpzTMbUYNYYjfALke4zhr16Uj+G6fI6/TtulZzqI/jnsEXiqBc/bWdN1ikfaoxzoQH3B6sW8ApDLGPHoJx2dwwGZRwc4CeciR0mNps93a80QqxeVFN4J+phQZknjbed3HUikeY X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?vPsSEu5OC6Hxt5Ir4QYMViVvUT3Dnac7qSda0wrAe5irWgOTR+3m9DvNyoD2?= =?us-ascii?Q?9YXcvUm4DRCVQCemPvLl7gR48NlmgWkRy2S7EYFvh8Gl33MGhRsSFbJKGS+S?= =?us-ascii?Q?Qm3c+zkCf0yCmXt3QZjtslOzuqksUZyA0q+xtgIOboQX4U/RQ9pcnBsKbcbG?= =?us-ascii?Q?kAM7FbAq7PmzVRpHlhoKopfhYZsM2LS2AK3mtsJKJ3UXoD5tZ7KbyhsS1nFA?= =?us-ascii?Q?lxN/HqH1x7L2P1MWFRcjMoInpRabeVEIbtTzRYdPh1SKl1gstlmThjWAl1XQ?= =?us-ascii?Q?EgHGwprHON4gPaXSkKbMHRPSlk54wJr7qhvZ0s9v+MTBxBeGjYCfpuu3mAjC?= =?us-ascii?Q?mEA/DHZcT4cK2m4a6MoSWF6FIfQ3PCmuF9uVu1HSzsqvA6d5BeCh4BWXrvKv?= =?us-ascii?Q?4IW9pT6d1IJJt0CYzdMjp3I+N68WIskZX1QZLzgUjPcq2hKEDqmy+Jll0F8k?= =?us-ascii?Q?Xs20w1Vku3PHjX9eBON76MU9nilWzfQZTe/B0lWANLIiv9bhBBndcRBlmzEe?= =?us-ascii?Q?n6jnnHWwwS0y6f3m9UKXIeunwJYOjHT+oEU8Zz9BwxiijAeuMz0IZoTc7qd5?= =?us-ascii?Q?j5IM4EYWR/5P1ZJTEWF7cA/IHnEWRbB8QhAeR9CSpuZLp1+DLSxrzBOkKpN9?= =?us-ascii?Q?bLyc6Jutdya6prav93My9GL6Z1+nubkPG7EmLz6diqcaYWONyaP89qUtVwLj?= =?us-ascii?Q?wKi5fzUWzBZoGTpDKk/SUD67i0P2kUO4BROE+nfkLx+S7PpwvWChd9oH9Hcg?= =?us-ascii?Q?IyqJqH7huPC5I6ajpSw5YXtIucfMf5fmYT9dEyzwukiCVrmy5e0bbYoyiVgQ?= =?us-ascii?Q?CkBRmfm2Pt089uo0yHPJQvZ81OQCmhrRq/eWUVIFmu21N4WmQdxzGQU/BLTB?= =?us-ascii?Q?XNVmrlg2NVrj9Ji5PCOaUnkuCG/U+zQcoja7g59CW94Y0fCEGpAZwwfjs2RL?= =?us-ascii?Q?Ayvf3pUj45UnrP6y+2iHEK7+mXJDYnN2RcB7gMSbSS7ah/ueDqye5Tm5x+Eg?= =?us-ascii?Q?r+5BHY8B1DOZ70EQiz3eeubENXwY0jH0V3muUhL8TuxePZTvM7SxaF9twZPL?= =?us-ascii?Q?50grWVaJnm/9125S/2iXCmnnknytZeLMV9dDFfpmaTyL9yamyXN7TmbTqnWQ?= =?us-ascii?Q?p1Kw04yFqcE1znPRdIuGUv6lU/rMDcS1g/g5uPKSgIKh3dxO+ae6TFXUX15/?= =?us-ascii?Q?oZ0R0ANVwr3T3mu+GQRT/4ZPSKpVJN13BpDW935nRQ2wbUNQRiiodenmiGEw?= =?us-ascii?Q?ueS54/OoDoJsglAtiXD8jkKzr7IPssxJYMZEeBY5H2NkY5mNKkz1C0sudyl5?= =?us-ascii?Q?R+SFTAKzvTbl7B41KyB6/jgg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8172817b-623e-47e9-3ea6-08d915a031f5 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:42.8381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wd2iRZXyKYsoAAiLgUCW8Xy+kdqSUiBjCJQs3ULuYNqtuuBsJmPNNHYfVm1Tjp6Qzr2hxTngcMcCLfR21cvBWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2445 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: 7sxx8wl2n7TT83K0PcHcrednx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863211; bh=HDqPG9EN8hjK0u0Udle7vK/uJ6H0OHkozqL+4v0+WMo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=wZ85vKQUpET/FfWyLEi3PzZnaOxksS81eHrJLLDK1EmTR/Em6warIg9BRTPLCBSxL2W AsGsZo9kCvdE8MA/GYjBQ31Ck6ugbVt0nenY5xAVBfe1qWGoFUVZsCaPCYihygI2VIa3Z ON8BUQYmaNTi4PiPPuk2Tm7RpqjLmAZOQQw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The Page State Change NAE exit will be used by the SEV-SNP guest to request a page state change using the GHCB protocol. See the GHCB spec section 4.1.6 and 2.3.1 for more detail on the structure definitions. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Brijesh Singh Reviewed-by: Erdem Aktas --- MdePkg/Include/Register/Amd/Fam17Msr.h | 15 ++++++++++++ MdePkg/Include/Register/Amd/Ghcb.h | 33 ++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Regist= er/Amd/Fam17Msr.h index 542e4cdf4782..62014854d9b7 100644 --- a/MdePkg/Include/Register/Amd/Fam17Msr.h +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h @@ -58,6 +58,19 @@ typedef union { UINT64 GuestFrameNumber:52; } GhcbGpaRegister; =20 + struct { + UINT64 Function:12; + UINT64 GuestFrameNumber:40; + UINT64 Operation:4; + UINT64 Reserved:8; + } SnpPageStateChangeRequest; + + struct { + UINT32 Function:12; + UINT32 Reserved:20; + UINT32 ErrorCode; + } SnpPageStateChangeResponse; + VOID *Ghcb; =20 UINT64 GhcbPhysicalAddress; @@ -69,6 +82,8 @@ typedef union { #define GHCB_INFO_CPUID_RESPONSE 5 #define GHCB_INFO_GHCB_GPA_REGISTER_REQUEST 18 #define GHCB_INFO_GHCB_GPA_REGISTER_RESPONSE 19 +#define GHCB_INFO_SNP_PAGE_STATE_CHANGE_REQUEST 20 +#define GHCB_INFO_SNP_PAGE_STATE_CHANGE_RESPONSE 21 #define GHCB_HYPERVISOR_FEATURES_REQUEST 128 #define GHCB_HYPERVISOR_FEATURES_RESPONSE 129 #define GHCB_INFO_TERMINATE_REQUEST 256 diff --git a/MdePkg/Include/Register/Amd/Ghcb.h b/MdePkg/Include/Register/A= md/Ghcb.h index ec232ebd3807..029904b1c63a 100644 --- a/MdePkg/Include/Register/Amd/Ghcb.h +++ b/MdePkg/Include/Register/Amd/Ghcb.h @@ -54,6 +54,7 @@ #define SVM_EXIT_NMI_COMPLETE 0x80000003ULL #define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL #define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL +#define SVM_EXIT_SNP_PAGE_STATE_CHANGE 0x80000010ULL #define SVM_EXIT_HYPERVISOR_FEATURES 0x8000FFFDULL #define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL =20 @@ -162,4 +163,36 @@ typedef union { #define GHCB_HV_FEATURES_SNP_AP_CREATE (GHCB_HV_FEATURE= S_SNP | BIT1) #define GHCB_HV_FEATURES_SNP_RESTRICTED_INJECTION (GHCB_HV_FEATURE= S_SNP_AP_CREATE | BIT2) #define GHCB_HV_FEATURES_SNP_RESTRICTED_INJECTION_TIMER (GHCB_HV_FEATURE= S_SNP_RESTRICTED_INJECTION | BIT3) + +// +// SNP Page State Change. +// +// Note that the PSMASH and UNSMASH operations are not supported when usin= g the MSR protocol. +// +#define SNP_PAGE_STATE_PRIVATE 1 +#define SNP_PAGE_STATE_SHARED 2 +#define SNP_PAGE_STATE_PSMASH 3 +#define SNP_PAGE_STATE_UNSMASH 4 + +typedef struct { + UINT64 CurrentPage:12; + UINT64 GuestFrameNumber:40; + UINT64 Operation:4; + UINT64 PageSize:1; + UINT64 Reserved:7; +} SNP_PAGE_STATE_ENTRY; + +typedef struct { + UINT16 CurrentEntry; + UINT16 EndEntry; + UINT32 Reserved; +} SNP_PAGE_STATE_HEADER; + +#define SNP_PAGE_STATE_MAX_ENTRY 253 + +typedef struct { + SNP_PAGE_STATE_HEADER Header; + SNP_PAGE_STATE_ENTRY Entry[SNP_PAGE_STATE_MAX_ENTRY]; +} SNP_PAGE_STATE_CHANGE_INFO; + #endif --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75083): https://edk2.groups.io/g/devel/message/75083 Mute This Topic: https://groups.io/mt/82787288/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75082+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75082+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863220525338.899179950409; Wed, 12 May 2021 16:47:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id MJZyYY1788612x6wPmwiHOJy; Wed, 12 May 2021 16:47:00 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.82]) by mx.groups.io with SMTP id smtpd.web08.6093.1620863210224608460 for ; Wed, 12 May 2021 16:46:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dqhmUbwNG4GMPcjZCyBMmnZ2tLtMDMuygE047whFWJDaxtnUgPG4tCat1J0zNQA5mjdir9kqePZY/DF44GSvY6/2MBuVfJSCBpZULmiBLdIGUr9K8bAL6Hrcd6b3pgcXosW1Xp1tTrzcvQXw5kLjgdbDNeW8HQduUgzxi6tGf1I51Lat9RxUDw8HqVUrdoFYuWkh9GgfMSw744M3Fiwz2T3EXd9Zq1o0sRcDtw8+6bI24VeJtXQN3dcT7ggXG86vsVi+4CMhbz+QvZSshjJ28u33SiuK+s1+bhubtNHCrcUnZUf0/EGgP9NEy9AtzgrkvkkjWkMUWkkCly+m6bDTag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XoFP9YsRiCGH/6ih31IJyxjnU4Dhok3BK937qsqSGvs=; b=DlsmdxLliQTkdT7sszcJxoa/nqyt8GvhrHeeYpx4qxdC3LaKJ2/y1AEuFN8ln66GNW2yFIVU3ZlUrxDKf2HjcCorE4PyjZeqMSpiN6weQv7uNetrz7O9BERws+7yaT+teExDSEziKfpXFlNpPD5Ajrec0UbRQR1ZxtsZ5kHOYDeztMjyXymW87Si+/q9TAT4elHzpwcy+qdIt0HL2bRWS2wFdzEEq+Naf28veuI1dnhkSTN7Pf/y6aBUvl7LvwRLGoexZDcWIY1sV3/lmW3Pe479EO01fFsq0aQoQ7W4qkIQP7lzdc/sb30FqBlDUQPFrPa5uN3+ckwsFFwQ5fFlKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2445.namprd12.prod.outlook.com (2603:10b6:802:31::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:45 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:45 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Tom Lendacky , James Bottomley , Min Xu , Jiewen Yao , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu , Brijesh Singh Subject: [edk2-devel] [PATCH v2 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation Date: Wed, 12 May 2021 18:46:08 -0500 Message-ID: <20210512234615.1726-7-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe7e56c0-4a76-45f1-dccb-08d915a03254 X-MS-TrafficTypeDiagnostic: SN1PR12MB2445: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 8+MY7CIfqNEj7KAmCZo2ZKBn0xbLErcnOm8dGBkr6c5ZF2tPd6CrdnDeHzpcRhw2XLUkE8xTP86DCUH0fYQtktwkeFyGcpDogCfJSfjtWS31WXtl++JYHI3USYLHHbNKnwOzrSX6yPc+SxRQf+Y7UiFijC/+hOb/Zi5Jh6vGorKW0HM+2QKJLot+wu51B8K9jlFRxdzO/0AKi6ctalGK3mG7PGjJ3D/mNxp6fCbZXUvw5RneCGllKNBzaAuWYHqug6Cc1TILOk3gX8FRiFeq2w6ckwlRXURtXFZ8vZcJ9xhc5uL6yM7m8J+zP3tiMbJ2ZSytopSLeP33l+i6KzZqpQFEjXi45cqZCmrVPuRwYYh/bWYLmz1R9zSa70V7xMWdTUliPNvy3t5yH5U5M1n2O3DF5sfgGKPNN0wHzkBQm8A2U/6KdWqKtBskPacNRmmRa3dDxfmvSZcPQucs049zWB8nuHNZIsZtAWiXXNeGp0id3nBMgEaaxzoIRCrw2jZfka8inuRHdk6OZHhw3BDbgRw8s9rqUUuDAG3s+VgaaGRIt/QzSWVGwPdEJxmEnUtYCl6NKbxTL0LQS4Up2IG309H0C77UmFM1OuGvgy+WBurx29HmisPEywhT3cGz8wPazygf/3/dIdlwd7aVEJMRLdPp/qzcyMaZj/HH5LXnIzg2OO1OXx7B03K4nD7nDv1MtuII1XJOQx0qT8NCK012IS141mfbH3WqskoboniH0IE= X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?MY3KlOBotPwmRsHDE9r4erTKzsH9vBhqwpYXVPsRfo0pZIvSsxpfvTqXuVCE?= =?us-ascii?Q?agLA7qpepCb5PEeTuY8o1tECvdP5HFNtQpEi43UpofQVs47wsUqOOpCA2JCh?= =?us-ascii?Q?oxEO3oyIxytmszZv/3BGpim09+149e9gbKgSkOw/dVDbi8V8oXx+8UKSLVEk?= =?us-ascii?Q?lr4TkHyImgvVP+Cql3PunUf+8hvBD1I2R8cQpPbhweHBiHscI+xU/zC0avcA?= =?us-ascii?Q?8GOt+dDSboDxRouDBTqjFRTSbUgiid3mJrPItJi3uUNSWuyKDhE5UHDsY7DV?= =?us-ascii?Q?VHY6sl4C8K3qYKA2BmuYYEuY9uSSnAexqVV0V71+i2JKYCpCJxQWHQmf1SJ5?= =?us-ascii?Q?2Tyssnq5r8aNwLCZjGiyMNS5ieou46FzAVoHYFv/4VPx8Rcrjic49tSpKgF5?= =?us-ascii?Q?7otRX6EkvgrIzupXHSwVHvjZ9D72CAb1X/9BH156AMgmuEA7kP0T1TTnqWOL?= =?us-ascii?Q?tzFiXXxeExKj/s1Uoy20uaU9BqqW5zZCAeCvgRpV/aIbWHTbGVAt3Ru5BRVl?= =?us-ascii?Q?e+5a/2FgFBwRnZwGFiFU5N3ie+OX0SnNY3cBKrRxwSFT1K/4MWwZNau4POXa?= =?us-ascii?Q?uxwjEReUDOQiES1ECH5N1KAB7MeXCdJdfV86a90/OGT5H4qBBHMV6mVJNQey?= =?us-ascii?Q?nFZn/tpHNqo8GI3K2kpfzwuhVkXz5qGv80YHwY3HgDmlrteWD++X7NtorEBn?= =?us-ascii?Q?Qz3Olu6ACAoEcY1F4Boo6VC0sNyZdenMDzFtUBGRVNMxDCofz4+zEhnV6mKS?= =?us-ascii?Q?C+QwF9DVyxB3QJElogsMclItf1/D2Mymjfk2iehU5xbNX/sk7evdEtDJl5l1?= =?us-ascii?Q?kI4xhpN07D17zRHmoWAShTIxjSdOOv641pG0F7lu4qQ/27OUbDaJ+nyfrH87?= =?us-ascii?Q?vnTxb+wrmTdQr9h/P/AlbtCOUbaIK+nH7O8S6u5RLJnSrA1NSgvRnIAVRRLq?= =?us-ascii?Q?QsobZARBF+cZgUG3g1Hh7tbs1ZXM7mP/w51t03gftbTHme5YfIOgq2t8nO6L?= =?us-ascii?Q?k+4hZu8IXGG4rS6IWvTHz2lBSoqPiCVEZmBKIm9B3BQYakQPzwCSKWE712Ks?= =?us-ascii?Q?H97Q9vavRnpSubyD/nzfIv9ew0dFpGMZ4MvZxNk4zFdpjQ/btAHyxXsvB6F2?= =?us-ascii?Q?OJJH1GxmLvMPR6JStzMTZTnCeDwP4LDGUHKgvbuWxo0eTuzpmsd+c3aFZpsx?= =?us-ascii?Q?Z9mv5Lkx6HKlibqGVYYsqTmq1G3fdEUhIaXezDIHKzBJ6x4RSZXn0cvshYbw?= =?us-ascii?Q?v494uudCFcRWpUjqhknkonnUUw6m1BFxpbPc0miDTR0qgHCO2F54XW30BU9e?= =?us-ascii?Q?athJrryTwyEp10cIZjjCbZ7F?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe7e56c0-4a76-45f1-dccb-08d915a03254 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:43.4877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0JhV+a1TZmO901CR1X/yICgz1ZHzb9TDe9YHeVJ9oioGcI9+Uwlp99jpAEkaJrQvbHyJFxvCDJWoRZcAZ6GNug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2445 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: 8GH2hQ4ZYeqIrndFg9E5QZoux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863220; bh=LvIUo7nvd1ff6jpJuOnlXGKzQiA3AoSWHiiWgUk+Dm4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=hSBcWEz6FMpcDsw+hEY3WLRgPUyW5diNG1zSBR+Wrf5tCSrfdwsxiT2/hv4IIPIXYtN PK8qZQF9hjXzGscpkHs0MNsoqGAwz6lEi1jWrJTE+sj9SZyIkR+a90gv2iPLodTXeMq+S OQKHz7Qi9yuBt5v5sE6S8kxFiZUjJ1/7QWA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3D3275 Version 2 of GHCB introduces NAE for creating AP when SEV-SNP is enabled in the guest VM. See the GHCB specification, Table 5 "List of Supported Non-Automatic Events" and sections 4.1.9 and 4.3.2, for further details. While at it, define the VMSA state save area that is required for creating the AP. The save area format is defined in AMD APM volume 2, Table B-4 (there is a mistake in the table that defines the size of the reserved area at offset 0xc8 as a dword, when it is actually a word). The format of the save area segment registers is further defined in AMD APM volume 2, sections 10 and 15.5. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Liming Gao Signed-off-by: Tom Lendacky Signed-off-by: Brijesh Singh Reviewed-by: Laszlo Ersek --- MdePkg/Include/Register/Amd/Ghcb.h | 76 ++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/MdePkg/Include/Register/Amd/Ghcb.h b/MdePkg/Include/Register/A= md/Ghcb.h index 029904b1c63a..4d1ee29e0a5e 100644 --- a/MdePkg/Include/Register/Amd/Ghcb.h +++ b/MdePkg/Include/Register/Amd/Ghcb.h @@ -55,6 +55,7 @@ #define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL #define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL #define SVM_EXIT_SNP_PAGE_STATE_CHANGE 0x80000010ULL +#define SVM_EXIT_SNP_AP_CREATION 0x80000013ULL #define SVM_EXIT_HYPERVISOR_FEATURES 0x8000FFFDULL #define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL =20 @@ -83,6 +84,12 @@ #define IOIO_SEG_ES 0 #define IOIO_SEG_DS (BIT11 | BIT10) =20 +// +// AP Creation Information +// +#define SVM_VMGEXIT_SNP_AP_CREATE_ON_INIT 0 +#define SVM_VMGEXIT_SNP_AP_CREATE 1 +#define SVM_VMGEXIT_SNP_AP_DESTROY 2 =20 typedef PACKED struct { UINT8 Reserved1[203]; @@ -195,4 +202,73 @@ typedef struct { SNP_PAGE_STATE_ENTRY Entry[SNP_PAGE_STATE_MAX_ENTRY]; } SNP_PAGE_STATE_CHANGE_INFO; =20 +// +// SEV-ES save area mapping structures used for SEV-SNP AP Creation. +// Only the fields required to be set to a non-zero value are defined. +// +#define SEV_ES_RESET_CODE_SEGMENT_TYPE 0xA +#define SEV_ES_RESET_DATA_SEGMENT_TYPE 0x2 + +#define SEV_ES_RESET_LDT_TYPE 0x2 +#define SEV_ES_RESET_TSS_TYPE 0x3 + +#pragma pack (1) +typedef union { + struct { + UINT16 Type:4; + UINT16 Sbit:1; + UINT16 Dpl:2; + UINT16 Present:1; + UINT16 Avl:1; + UINT16 Reserved1:1; + UINT16 Db:1; + UINT16 Granularity:1; + } Bits; + UINT16 Uint16; +} SEV_ES_SEGMENT_REGISTER_ATTRIBUTES; + +typedef struct { + UINT16 Selector; + SEV_ES_SEGMENT_REGISTER_ATTRIBUTES Attributes; + UINT32 Limit; + UINT64 Base; +} SEV_ES_SEGMENT_REGISTER; + +typedef struct { + SEV_ES_SEGMENT_REGISTER Es; + SEV_ES_SEGMENT_REGISTER Cs; + SEV_ES_SEGMENT_REGISTER Ss; + SEV_ES_SEGMENT_REGISTER Ds; + SEV_ES_SEGMENT_REGISTER Fs; + SEV_ES_SEGMENT_REGISTER Gs; + SEV_ES_SEGMENT_REGISTER Gdtr; + SEV_ES_SEGMENT_REGISTER Ldtr; + SEV_ES_SEGMENT_REGISTER Idtr; + SEV_ES_SEGMENT_REGISTER Tr; + UINT8 Reserved1[42]; + UINT8 Vmpl; + UINT8 Reserved2[5]; + UINT64 Efer; + UINT8 Reserved3[112]; + UINT64 Cr4; + UINT8 Reserved4[8]; + UINT64 Cr0; + UINT64 Dr7; + UINT64 Dr6; + UINT64 Rflags; + UINT64 Rip; + UINT8 Reserved5[232]; + UINT64 GPat; + UINT8 Reserved6[320]; + UINT64 SevFeatures; + UINT8 Reserved7[48]; + UINT64 XCr0; + UINT8 Reserved8[24]; + UINT32 Mxcsr; + UINT16 X87Ftw; + UINT8 Reserved9[2]; + UINT16 X87Fcw; +} SEV_ES_SAVE_AREA; +#pragma pack () + #endif --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75082): https://edk2.groups.io/g/devel/message/75082 Mute This Topic: https://groups.io/mt/82787287/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75086+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75086+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863221129501.03712586185384; Wed, 12 May 2021 16:47:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id iEGWYY1788612x8F8Nliueiu; Wed, 12 May 2021 16:47:00 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web08.6093.1620863210224608460 for ; Wed, 12 May 2021 16:46:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iSZuvDs6rEoScXctrQVisWt7PJpWoILkZQintj70nDJhbM6k4ohkwZDyzegnsnMimG6X1a0sllXqonYuHjUS3BFG7F4unbcNVVjC/4UQSNEgKKUQdJgPLBBwZPbOoWeFOfu7W5gZuHO7ozRgj8y1WmhqlYeb2ODksi/m+3ZIz5aaKjwA7fUJ7KDKByGPpDcNltQnfEDLkfWT97h17K1+icIToy+iCNaYwmnEGOLUMsMWA7HKHtOpQe4L9zF+BbRJb9qrgjdynr9woqUu6sZd9tJI8Y2AtMeBRigbIhiEQxm9az2jJqRrbtzWxCT+SXyip8YNYykGgrD/hczhjWFihQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LI1uichFS8SJjgCXla5b56aAT0mDIzIYmz5Pa8o8PZM=; b=m/OOf3wgfCtxiywnduKwsdvz5PSRps3dFj3R1N56JArasYh1KY1x4j9mSnSkdKYEkSQnNJl7PBPpW03BdLooxFW/PvH5nC+sCjUvCtHndniBBtJ1umZxCaVwG5H6THdzcT9HlGNoMkIiYcf8l03CJlblf2/4PX0BQa7Civma0NGcurOnrEsCTtY425IN8+baeoBp1WiYCfSyL5c85vKSjqoCBMpbgrrpiRzQLbGUDnH3+MtJ3gfozZpPdReNiXlECRalHPxxqtorDtKEBYOoVNSDCrw2yxjhgD9oFmqXzxqOZ8FEcc3Y5chTShyFKHH9U3XPp/YmVPrCowSR7xzArw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2445.namprd12.prod.outlook.com (2603:10b6:802:31::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:45 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:45 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v2 07/13] MdePkg/BaseLib: add support for PVALIDATE instruction Date: Wed, 12 May 2021 18:46:09 -0500 Message-ID: <20210512234615.1726-8-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9173be1-a568-4de2-0152-08d915a032b6 X-MS-TrafficTypeDiagnostic: SN1PR12MB2445: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: n0+LhhvvlEP1A6zQfNSfb/TW/SbY+U+laYe5CCwV+GZFsGngcy2Hj501BQqs3j9zcurXlryrIo9rzlqd4NaxFw32yxznne84TnIRcd2ZrQ5uUVwDOaUCgWrCNmoM7hIBXy2ijIEXQoR+H4dzjKF/eAdSMWVfSv95Q/HNYI9buIsIakj0VG6l/Fg5DA5X7QOI0Kl/v8uS3PL5lw5KeuKRN7B1yLa95wgRVVnYOn3A3RIG88IxmXSYGhRGayVVjHbnTRBK1XjgRTLvkligVlVgESkvto2sJNovKkTNAhPkzTPDpyWR/UL1cRHRmyymXxegJZqUElX67frDnzvIINKOon9Ys/QV4Qk4sZzQEVTRoZgPJWdYCWgjADLfdAKOQEMDJZGM0fU3dUfqe3L0MDm3yUWcv9XipVCuV9B9EDKpaoFfLNi3Ig4aDuIlzegOF1Npt+zvA4Rdxh64TBAOHKkyGswVq6K/6Pxb+WgkdmXmdirJcjL8QBVGtr9AzGDPUka97ELCzQ4Y7a1h/cQ/G4fHb0YyzBGxehPqwZsQYkZaJ5zuNEeKHqPa1VvRYNER70bY8+kPiOJ0hu6JS7Sn3IutPlvbm5bZQAb31nwLpiN0d1XoBm874QT6iTjH7em9gOuEGJ3uib/viEgBQwSbWKgrS1oTsSfFOxub5yYlb+biMQMy7S0X8AQpgPOCyPCSrc7KM+91pGoboalpjD46a9GMaYWv0PoS8JXZ7VhD3jx8Vos= X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?8Ek/ubuFMziMbfs53uBadfjC9aq8FAKrwkFnsnAD9CYt9Ju04LNlIAQjSzaF?= =?us-ascii?Q?NeTXSdrbb1+gZcow9uZ2vp2AKZ5RgSS4jSkaWB6a5q/eVGjWmPEdHVlKsoCG?= =?us-ascii?Q?S4UjTMNd8Xk3agPWewxCssJhrYYHGH3gj7iWIDwqrLStSJ19KUFCfInRIJSf?= =?us-ascii?Q?WJ8N35hg1mm7hAF4aIHRPbJkhI6wtCn9uvQJCbAIIbW0UajJVX+4PFMk1Q+K?= =?us-ascii?Q?O5a8znBeRMZOiiH86X8wxSWZPD1emMdTAqa0FXbm7tB9UZAeeQUp7EIvHomq?= =?us-ascii?Q?GNWjvK/p9YwQdwdjB18JCMyZ7a44XjCXDzhQuIhLshBJFQ5RuTBSr7EZXO2t?= =?us-ascii?Q?dO4u576bs2V7A+6z2PXxCbVc/rQf7j3BB69skh5A/m5WZN5+WzlB1piulxuZ?= =?us-ascii?Q?Aex6laZb4UhssA+UZQF8afyK+USdo8CvUYHVBn2GHAhIsiuAcqOd8L3ccb2Z?= =?us-ascii?Q?vfNI/1Al4SL5YA7Z71ghdmlbnx1bRfveKEmuhMDEoi0oR8WEqCv9zLZIh+5r?= =?us-ascii?Q?jqbn5bwxqPhqIA1s29l8/LnR4rae1XfJ4WopZgVYlEAO2802yqwd2oiwdI7U?= =?us-ascii?Q?H6/bg4igGA1/nP6hmCJvw/UeH4INmOwvg44h96Lf71F+lZ3BkuGtqLuUxHva?= =?us-ascii?Q?kLWOGPXHNVDQlTOyPZ2uyXKk1/1q+QCWqaEHdluyIUV6TEUNutEaplm98ZLg?= =?us-ascii?Q?tgb17TpiZ5pffsD08Y1Iw2yp1+CklkSimyjk5pxu/SA6WFIByFs0LQbm6bxS?= =?us-ascii?Q?hF9ZOYKeaKQPSf0VWImNsa4gw0uAXi7hztqDEOFrelQ6pqEgro0sdBjRJ4dW?= =?us-ascii?Q?m2UznZkf0vEz/Wb2Qu7JQFD2KI1MQmJnohlt7r4L2RZIlos5/O0jz2kO/gUW?= =?us-ascii?Q?zFF1KNYpKYMQHI9eVpr0MfbkPoF0hLdL6rveZSrpVUyvGugfgGP4vbnoiP2A?= =?us-ascii?Q?4VHUmw3sKrZyUnyy4PShV5glwsz3Xedzgqo8kvh/W2KolNL5IbNmf9xruADn?= =?us-ascii?Q?c6arTelY78NmxsNyO/vLxzgOCtE/wGLOpYp4cCRaTnV/0js3ph8p514UIZ5G?= =?us-ascii?Q?zWijaSrYqSjoGyx77ciEPoG1bZjT8QLFMFLCKPUZ2m2/J9lwxm16OnJFYayA?= =?us-ascii?Q?fLSNJII8waiMExemvQv+A6eE1W7jAm52tc+FJAL65U+IbzYrtRbqQLPWiZ9D?= =?us-ascii?Q?woaqo6w0CpZg8ExqWtwOgKXEfrOcxLXhSTp9E7VSW7JYWN2bzblqfK5M1Sve?= =?us-ascii?Q?YWEcgIsIC0UROEnRI668bUfwLiF+qSK4bS0a60VuuTz7HtwEZhdItb6XjfFr?= =?us-ascii?Q?Hiz3MopFUYThiADX6AhSKWT6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9173be1-a568-4de2-0152-08d915a032b6 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:44.0884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vVOM1i8UXPfJaCIjS9n8GB24vLFNkycV5GHMmeLDCOq1FqXYfyJwrLjnd60ytznLT+NN8I7ge0Fgf5+nJ+GbOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2445 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: JOvE7zOib8qREHI13EMpExvux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863220; bh=Si9353wIxHuCkrTZ+pGbuL2zwVX0MDNzGcGU18lOPDI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=v/wD2XArw2Xm6tmhKMGWh6sJckowakmQmlH//2LX+mkEENssgUN5m0NAtTZ37ya2W/C WTiVVgqAS6KDisyBKA3LJez/f+dYn9wl3JYhW1MwBDVt6/mQx4+grAed00ztSpAXBwfUK 3pa0F2HPAtWzZm6lSK05EG+dF7SqLhWnqGo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The PVALIDATE instruction validates or rescinds validation of a guest page RMP entry. Upon completion, a return code is stored in EAX, rFLAGS bits OF, ZF, AF, PF and SF are set based on this return code. If the instruction completed succesfully, the rFLAGS bit CF indicates if the contents of the RMP entry were changed or not. For more information about the instruction see AMD APM volume 3. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Liming Gao Signed-off-by: Brijesh Singh Reviewed-by: Laszlo Ersek --- MdePkg/Library/BaseLib/BaseLib.inf | 1 + MdePkg/Include/Library/BaseLib.h | 50 +++++++++++++++++++++++ MdePkg/Include/X64/Nasm.inc | 8 ++++ MdePkg/Library/BaseLib/X64/Pvalidate.nasm | 42 +++++++++++++++++++ 4 files changed, 101 insertions(+) create mode 100644 MdePkg/Library/BaseLib/X64/Pvalidate.nasm diff --git a/MdePkg/Library/BaseLib/BaseLib.inf b/MdePkg/Library/BaseLib/Ba= seLib.inf index b76f3af380ea..89a52f72c08a 100644 --- a/MdePkg/Library/BaseLib/BaseLib.inf +++ b/MdePkg/Library/BaseLib/BaseLib.inf @@ -317,6 +317,7 @@ [Sources.X64] X64/GccInlinePriv.c | GCC X64/EnableDisableInterrupts.nasm X64/DisablePaging64.nasm + X64/Pvalidate.nasm X64/RdRand.nasm X64/XGetBv.nasm X64/XSetBv.nasm diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/Base= Lib.h index 7253997a6f8c..a2cd134bea9a 100644 --- a/MdePkg/Include/Library/BaseLib.h +++ b/MdePkg/Include/Library/BaseLib.h @@ -4813,6 +4813,56 @@ SpeculationBarrier ( VOID ); =20 +#if defined (MDE_CPU_X64) +// +// The page size for the PVALIDATE instruction +// +typedef enum { + PvalidatePageSize4K =3D 0, + PvalidatePageSize2MB, +} PVALIDATE_PAGE_SIZE; + +// +// PVALIDATE Return Code. +// +#define PVALIDATE_RET_SUCCESS 0 +#define PVALIDATE_RET_FAIL_INPUT 1 +#define PVALIDATE_RET_SIZE_MISMATCH 6 + +// +// The PVALIDATE instruction did not make any changes to the RMP entry. +// +#define PVALIDATE_RET_NO_RMPUPDATE 255 + +/** + Execute a PVALIDATE instruction to validate or to rescinds validation of = a guest + page's RMP entry. + + The instruction is available only when CPUID Fn8000_001F_EAX[SNP]=3D1. + + The function is available on X64. + + @param[in] PageSize The page size to use. + @param[in] Validate If TRUE, validate the guest virtual address + otherwise invalidate the guest virtual add= ress. + @param[in] Address The guest virtual address. + + @retval PVALIDATE_RET_SUCCESS The PVALIDATE instruction succeeded,= and + updated the RMP entry. + @retval PVALIDATE_RET_NO_RMPUPDATE The PVALIDATE instruction succeeded,= but + did not update the RMP entry. + @return Failure code from the PVALIDATE + instruction. +**/ +UINT32 +EFIAPI +AsmPvalidate ( + IN PVALIDATE_PAGE_SIZE PageSize, + IN BOOLEAN Validate, + IN PHYSICAL_ADDRESS Address + ); +#endif + =20 #if defined (MDE_CPU_IA32) || defined (MDE_CPU_X64) /// diff --git a/MdePkg/Include/X64/Nasm.inc b/MdePkg/Include/X64/Nasm.inc index 527f71e9eb4d..528bb3385609 100644 --- a/MdePkg/Include/X64/Nasm.inc +++ b/MdePkg/Include/X64/Nasm.inc @@ -33,6 +33,14 @@ DB 0xF3, 0x48, 0x0F, 0xAE, 0xE8 %endmacro =20 +; +; Macro for the PVALIDATE instruction, defined in AMD APM volume 3. +; NASM feature request URL: https://bugzilla.nasm.us/show_bug.cgi?id=3D339= 2753 +; +%macro PVALIDATE 0 + DB 0xF2, 0x0F, 0x01, 0xFF +%endmacro + ; NASM provides built-in macros STRUC and ENDSTRUC for structure definitio= n. ; For example, to define a structure called mytype containing a longword, ; a word, a byte and a string of bytes, you might code diff --git a/MdePkg/Library/BaseLib/X64/Pvalidate.nasm b/MdePkg/Library/Bas= eLib/X64/Pvalidate.nasm new file mode 100644 index 000000000000..a7d177913405 --- /dev/null +++ b/MdePkg/Library/BaseLib/X64/Pvalidate.nasm @@ -0,0 +1,42 @@ +;-------------------------------------------------------------------------= ---- +; +; Copyright (c) 2021, AMD. All rights reserved.
+; SPDX-License-Identifier: BSD-2-Clause-Patent +; +;-------------------------------------------------------------------------= ---- + +%include "Nasm.inc" + + SECTION .text + +;-------------------------------------------------------------------------= ---- +; UINT32 +; EFIAPI +; AsmPvalidate ( +; IN UINT32 PageSize +; IN UINT32 Validate, +; IN UINT64 Address +; ) +;-------------------------------------------------------------------------= ---- +global ASM_PFX(AsmPvalidate) +ASM_PFX(AsmPvalidate): + mov rax, r8 + + PVALIDATE + + ; Save the carry flag. + setc dl + + ; The PVALIDATE instruction returns the status in rax register. + cmp rax, 0 + jne PvalidateExit + + ; Check the carry flag to determine if RMP entry was updated. + cmp dl, 0 + je PvalidateExit + + ; Return the PVALIDATE_RET_NO_RMPUPDATE. + mov rax, 255 + +PvalidateExit: + ret --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75086): https://edk2.groups.io/g/devel/message/75086 Mute This Topic: https://groups.io/mt/82787291/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75084+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75084+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863220616404.26489083321394; Wed, 12 May 2021 16:47:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id v6X6YY1788612xLc1k6TQmJa; Wed, 12 May 2021 16:47:00 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.73]) by mx.groups.io with SMTP id smtpd.web10.6186.1620863210873702199 for ; Wed, 12 May 2021 16:46:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=meoBLZpXXRiKfT9RbWjKqTyf4pleXDt/AR5vYDZw6Dc90nyGiNIvJISFNvyfb7yiPEj8qW8kTWzJ34cdeoOZ+Sx4tFOLVFR8IeaXVSkXfkoI+XlRlVKJEs0fFT83aoOpo2TeYyle57QNgwToIqyb37XaasmZNJvlA/6VzUUODQIUk8ASPz4A1Ep5sLVAh8LbDYQz7IwroNY0HwDmnENBEQ/EENgF5ERJSMip81t/KkUfU+V7EWNdHUe99zVTDlmNZelleCZuSCVVNl7Xe86jvLfs7X3xArhIccztaLUZl04UN1NWOdiEM35g7rbDjocMKWaOnDVFKysEV3mXi73EJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7S10dJ2dzzGKcxY+6h336pBDcZz6E8sX+2adwbxgZI=; b=iWpNchwlbN/49qYlizcAkEmKteyJWATAOCIB7bttus0Mn/qqtWEVAH2GbG4cczMcWi0Mh666GG/qtmf5wKk6Yy0ieubkAL2gGvSt2Kz5DpfAO47F4gWfdhMBm1sWbT8CwHTV3HYCX5syBOgPS1AqAjUafrDMePjQJWn0oCMqX5Hc2TqaU15MEEwrah4ZeEpcSoCuDT07vsfS1o7bKGQcB1DELtOFZ8hbiR7Qre/qSK+zaxhj+u81Sya/N+id/xYsnVXfPSn3OGxglSJJmmoiZeDa6sVZryf7NjwL4WCSZvBH5xf3j2BdzK4zMlOc3o6ATk1gXaMRfY+v3+yfjutwDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:46 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:46 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Tom Lendacky , James Bottomley , Min Xu , Jiewen Yao , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu , Brijesh Singh Subject: [edk2-devel] [PATCH v2 08/13] MdePkg/BaseLib: add support for RMPADJUST instruction Date: Wed, 12 May 2021 18:46:10 -0500 Message-ID: <20210512234615.1726-9-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6adcae6-544e-49fe-ba53-08d915a03309 X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 91zFXc5moRJQooBLtlb6xRAh7SzMjTi7ulXxuUAOIfxSpPF1uVWK4A8fePVKd5rzpfeSru55sOGZL0gheG2CDVYaIe1sqguOTFEh1co/GUYNPah6pC6t7QawbZzPxdpmkqRmJETpTR0oI+kg1rKzG+wMFoU192TbnkrfDudjnFovAuNRhL3KKr1pnkQVLNFgfmJDGYYG1oGmZKn4Dwn2XGaZxFoKhMtOvAPFmfvZzvXNtQguQ0KVCDXRqDeWim9u0q0KnHwntsIs0IsvmYspUjGuSrvvwv+JgMOX6KyKmplrgC9wHAB0slIv46i/Q4fHSdjEkD0Q7C+rEDU3FELelqNBvu1p89lwfGA0t2jWHWx3UBiporDZwSmMJifi1Pu4dWEilZ0puThL+PlbANfsB2RA1REypzYq9LrKPwEScNhDvTXnEk7c4TT3KlL2ldXTMUUVKfAO9EUw40omSlXnC3Z59dygxErBoC+PrrkhUcqD7LZU3SoljrWh/ANy2jndmakGK49rUFiupY2zMjOCOxM0MnG76VSZDBi23T2iUpfR9jp0LNNOBpnMYObYGDjijpZ4G2Pj81JDNY3cYOyubWjyh47+VVnNIK6oxNxq20TA4REMljHMf+MOnIE2VedI3O02VwveBdsllO7BCoKnowauTaxh5aTxs/Q2xGky0L8hTU3rzA5c0sibpTgFTvYFjnikkA7l+vBa1LVpkT5X+Vy0Z5Cwe669Cct929blQ+w= X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?ASQKcQMKL8TOgZfaOiJGzAkL1+amNjxY/OFJ1jsl6wb1HwutZ/0pJTlDZmVW?= =?us-ascii?Q?No+CzQMcVsuBVG+XaeQH0ypW34LWfdnV+j97J9cl2ddpw2NIVV8z4whGdQz9?= =?us-ascii?Q?jhdPchSBKBI5lpGznzhJtL6hhEqLMVr4yQwXh38e+FqikayIPAnlQB4k7IXo?= =?us-ascii?Q?Fdd4bgKhSXubvrqYjh/KXNvjEXWyStzU0XruuqtZFltocEpKZED1SrLFOM6d?= =?us-ascii?Q?ICK3UP9kpgguJMJKbO9JnuE5Dx/uU8VG/VcLwqgRgApbYWdhNqsi3AlRtdS9?= =?us-ascii?Q?bVyw1qiGksfg2OUiuag0vcuX+rvYqJ3YFnfJZkZGQCii9hl1EKGgW17eox2I?= =?us-ascii?Q?xBagm5n9UAdHMQKdaxG+2MwvWiLGTKGSDykc0uT/pkRdoHyi16BHy9FL8zMo?= =?us-ascii?Q?Zxi8gaquCxE+AyozIG0MKpZ44gsnKaCuhdnQvn0WUbt6OrKhKETu8/LJUK1L?= =?us-ascii?Q?M3YP6OoiOEmzgC+XxmrVhDN8y67dn4qfmGp021z4uV0xPDAXGh99RR7jXnPq?= =?us-ascii?Q?y0UAbg2ijlbINtUmRz9rPKkvf6uualu3aEzwXxqCTJ+FQwsXdh9JGZJHaq3h?= =?us-ascii?Q?h8e4vLlkGV3yG5M/1Dqa+d3lHXtVgNEzRbKqomM0DtMtUqmnFS2n8RYA4SXH?= =?us-ascii?Q?Fro/xb+SfAdif28ehKaC/gv0AX3jN97vugE9EJQ35XlV/jGTleabP4dOxUPX?= =?us-ascii?Q?ly4SbsEwirWx6PTnS0xahskKz9b5QDlQ2SpbLLQKeREZLiiDHmxJDNMNE/WQ?= =?us-ascii?Q?f4Mfsd5yrMMwH1/2aT3blXm2fFJL6PGuUAgc1SVtLmBfsqovU0pBINWEO9Ni?= =?us-ascii?Q?R4wnSuz4AyfQmcAKcIOehns6BKaVwBqKTgh36WlL1lCMBrOdc+5jZOVEtYtU?= =?us-ascii?Q?tOZ9v1DQVSgjz3LbjENMkHkvjY8bdLwuFZy5MAVijS59h/UWueDibx+I3NrX?= =?us-ascii?Q?xTvFfM0+TaQANrE2mb7hGa1uyEEdyZgTW2lT65lEmi5OoLObiwBWPDVaUHXG?= =?us-ascii?Q?SLjdvlxUDGPVT4flJQcBSzZKzoSDkRl2awDQKTSjjVm/0OJyOumgm+ddNDO/?= =?us-ascii?Q?lOUhxryCbLpF3zifmRKg5toj3pG6A4GX99EOyhONXcZ3Pfn3iyYIIifOVJNS?= =?us-ascii?Q?6UNOOUKQz93qe4LLnw32k5DvgIbNF3n2nZLS+uzC99w47ZYL+dnsn8T0tgyF?= =?us-ascii?Q?N0tauGobj93P9ddflQRm6F+I9DpNKrNx8Jk7eLaikY6s4464LQZa28yN8wb5?= =?us-ascii?Q?yfC4AoZxW/6qG+YbyoJoIO386jifklfpDh+H0WKz3Na4xgX/Itf7iKBJqURB?= =?us-ascii?Q?UY6BvO/RdBu+hdAS4Vlxr8E2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6adcae6-544e-49fe-ba53-08d915a03309 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:44.6311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eTaVA67EqnjiEweB5wfzFECU/ueUPpx7ca78OIvfJpgXULzB3eDW833yNUS7ojgCf6XI4CEB9FeQnluuPRojnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: g5EDnJT2Ckzgt6nsFaUipyDlx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863220; bh=tmrnpZIE7mbbLemY//X6WPz5kdZ8pPVijNEw41eN1cU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=KLDNixzlPum0R9D3K6SJE83lNmGWhPf0PzthGKubGOEYrx9yKp50iIHjkUFr+mxF5oV V09EiMj+3VpjQkCZ9xzg29+J/vfeQnc/F+i5Fzzx2vDbns7X01YTlMwFF/+ftB5XVrGns Qugt1xU+ZhPam26+z0mTwNvk8YJEzLxPRxI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The RMPADJUST instruction will be used by the SEV-SNP guest to modify the RMP permissions for a guest page. See AMD APM volume 3 for further details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Signed-off-by: Tom Lendacky Signed-off-by: Brijesh Singh --- MdePkg/Library/BaseLib/BaseLib.inf | 1 + MdePkg/Include/Library/BaseLib.h | 35 ++++++++++++++++++++ MdePkg/Include/X64/Nasm.inc | 8 +++++ MdePkg/Library/BaseLib/X64/RmpAdjust.nasm | 40 +++++++++++++++++++++++ 4 files changed, 84 insertions(+) create mode 100644 MdePkg/Library/BaseLib/X64/RmpAdjust.nasm diff --git a/MdePkg/Library/BaseLib/BaseLib.inf b/MdePkg/Library/BaseLib/Ba= seLib.inf index 89a52f72c08a..6ccb8997b7e8 100644 --- a/MdePkg/Library/BaseLib/BaseLib.inf +++ b/MdePkg/Library/BaseLib/BaseLib.inf @@ -319,6 +319,7 @@ [Sources.X64] X64/DisablePaging64.nasm X64/Pvalidate.nasm X64/RdRand.nasm + X64/RmpAdjust.nasm X64/XGetBv.nasm X64/XSetBv.nasm X64/VmgExit.nasm diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/Base= Lib.h index a2cd134bea9a..e8eff32716b8 100644 --- a/MdePkg/Include/Library/BaseLib.h +++ b/MdePkg/Include/Library/BaseLib.h @@ -4861,6 +4861,41 @@ AsmPvalidate ( IN BOOLEAN Validate, IN PHYSICAL_ADDRESS Address ); + +// +// RDX settings for RMPADJUST +// +#define RMPADJUST_VMPL_MAX 3 +#define RMPADJUST_VMPL_MASK 0xFF +#define RMPADJUST_VMPL_SHIFT 0 +#define RMPADJUST_PERMISSION_MASK_MASK 0xFF +#define RMPADJUST_PERMISSION_MASK_SHIFT 8 +#define RMPADJUST_VMSA_PAGE_BIT BIT16 + +/** + Adjusts the permissions of an SEV-SNP guest page. + + Executes a RMPADJUST instruction with the register state specified by Ra= x, + Rcx, and Rdx. Returns Rax. This function is only available on X64. + + The instruction is available only when CPUID Fn8000_001F_EAX[SNP]=3D1. + + @param[in] Rax The value to load into RAX before executing the RMPADJ= UST + instruction. + @param[in] Rcx The value to load into RCX before executing the RMPADJ= UST + instruction. + @param[in] Rdx The value to load into RDX before executing the RMPADJ= UST + instruction. + + @return Rax +**/ +UINT32 +EFIAPI +AsmRmpAdjust ( + IN UINT64 Rax, + IN UINT64 Rcx, + IN UINT64 Rdx + ); #endif =20 =20 diff --git a/MdePkg/Include/X64/Nasm.inc b/MdePkg/Include/X64/Nasm.inc index 528bb3385609..cfb14edc9449 100644 --- a/MdePkg/Include/X64/Nasm.inc +++ b/MdePkg/Include/X64/Nasm.inc @@ -41,6 +41,14 @@ DB 0xF2, 0x0F, 0x01, 0xFF %endmacro =20 +; +; Macro for the RMPADJUST instruction, defined in AMD APM volume 3. +; NASM feature request URL: https://bugzilla.nasm.us/show_bug.cgi?id=3D339= 2754 +; +%macro RMPADJUST 0 + DB 0xF3, 0x0F, 0x01, 0xFE +%endmacro + ; NASM provides built-in macros STRUC and ENDSTRUC for structure definitio= n. ; For example, to define a structure called mytype containing a longword, ; a word, a byte and a string of bytes, you might code diff --git a/MdePkg/Library/BaseLib/X64/RmpAdjust.nasm b/MdePkg/Library/Bas= eLib/X64/RmpAdjust.nasm new file mode 100644 index 000000000000..c307f64b518a --- /dev/null +++ b/MdePkg/Library/BaseLib/X64/RmpAdjust.nasm @@ -0,0 +1,40 @@ +;-------------------------------------------------------------------------= ---- +; +; Copyright (c) 2021, Advanced Micro Devices, Inc. All rights reserved.
+; SPDX-License-Identifier: BSD-2-Clause-Patent +; +; Module Name: +; +; RmpAdjust.Asm +; +; Abstract: +; +; AsmRmpAdjust function +; +; Notes: +; +;-------------------------------------------------------------------------= ---- + +%include "Nasm.inc" + + SECTION .text + +;-------------------------------------------------------------------------= ---- +; UINT32 +; EFIAPI +; AsmRmpAdjust ( +; IN UINT64 Rax, +; IN UINT64 Rcx, +; IN UINT64 Rdx +; ) +;-------------------------------------------------------------------------= ---- +global ASM_PFX(AsmRmpAdjust) +ASM_PFX(AsmRmpAdjust): + mov rax, rcx ; Input Rax is in RCX by calling convention + mov rcx, rdx ; Input Rcx is in RDX by calling convention + mov rdx, r8 ; Input Rdx is in R8 by calling convention + + RMPADJUST + + ; RMPADJUST returns the status in the EAX register. + ret --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75084): https://edk2.groups.io/g/devel/message/75084 Mute This Topic: https://groups.io/mt/82787289/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75085+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75085+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863218815509.2899573068918; Wed, 12 May 2021 16:46:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id c5gOYY1788612xHJGk5ilmxp; Wed, 12 May 2021 16:46:53 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web10.6186.1620863210873702199 for ; Wed, 12 May 2021 16:46:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eg52vaFmKbItE+zq4JvNhhUD6x+YqDBTaEmqOAU/lcLM9QRjX7b5ZMdeOXySX9tX0ehceYTzulAxr3U5QPTWZMyEz1FIdl4cocJE1WV8/Ow60tU3m2nPZEOampF1IUd01pHcQRmqpItFlsfycJD/WvRsXbzxS3kMnG84J+/hS0nun903lIZLCthotA4+hHGbtNeRItasjl1FxUQiKri3ony+60AnsPVk5QAcYeaSpVEd3qVsyXtHhGDNeSkRtXCts4WOYMEcA+eyKPMrHy2WTYmevjBhsG/UBfYhcEI+cxSMSAzKVSltGn00bO7P/St+M+bmhv8cZb+jsGpqq4Z5vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEZGcqArN7aJZqgUxpRSdFkwW7N58e/ychUCW5J5HSY=; b=oRcMfXEH6viw9CUDDWokpN+fqoozq7DZxtACiH0LTFxDvA09IvzRbLtdO8cGJJq9KJdcXLynXRBza7DBYFFLCJp1xg6GatV9Iw13/ud3XZGt/zbZOiBP3+1btmQzVEXIt1zGJ+xres294IHAKEmceJIfKGnSkrNmsitzOz9yOpEZRSnUVdwKfGJkc06QEZ+TU57mjP9NktorsoNAt3qbJ2+Akcmgo6wunfH9aCuKifj6POzcmUev8s7ZDOdPSP+ZLjqBgMJP/zulYbzZku6SwFwZh6Yg1QdfXVIhlOdFI2bGg5kqfD+dqXB0k0mZIUIvBrgzcjvHUcPddd2FpXQ2uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:47 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:47 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas Subject: [edk2-devel] [PATCH v2 09/13] OvmfPkg/BaseMemEncryptSevLib: introduce MemEncryptSevClearMmioPageEncMask() Date: Wed, 12 May 2021 18:46:11 -0500 Message-ID: <20210512234615.1726-10-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a3717bc-c87c-469f-ca60-08d915a03359 X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: hogvpL5lFAXTavKYXa9Gdte8texi/J9KUD77bOdWvYEBtliSXso2naMcoZW/AFrAoniqCKDJbD85mu6zA8ruT30vtIjDfi7UKV/CCs3qjS+rXfS9+zH+XJwKMEETFu4Mk0pVVhaeXClTbhznpqZx4WpSlqtqTqi3weTa92mxeeTzsqi5iRpiYi4PwTyRK9vxBrCCd5qQCbpgv420mRWxiKhPXQU24nG3ncnq/c8GcOj1vHpAPGIfc3LmTUj0PCr1qk+N/vmvDUhBsIW/58Wf83QrX2w9S1O++USF3uYWsZzy955aK2NflUTrtDcukzKkbqUcW1oDYAJucxCD15Q92wyLE2Pfn1BNDvOWiNfDHO5ZYW+JloS9G6C5FGOV8JLxnmWlrvvGieuOOzXBtSrhLpcUToRjR2hakYjK/MqPhIUF7zGoDP2mJ8UT2seJvGO5KwLWe5OuSmouG0i0sFgFY/DzqP0ZDOf7oHmNPz6KwcYdf81pM8eLePS6mF2I2Tn86KPCZsdetAPcomwTzU25jTjmLpt+qToD7MpqbqOHD8dOO6m+cI5GNjQlDQViGyWhJrYRn2aP9uxOis4qPvym6y112u9XLWEdc3qmstnTqY44qeJ3NIoPIOjyRLgiEUlMqn/U/VoJWKmyyNdXFcZVBmxtZ8wHZEFu1zfDQUKV2V7GnUu0iWNm8n5AiGZVo4HQ/rPzcRIQ2I7CwFj4cAq1t3Q383W2KT1S8JGzONNPBFUrpVe0iC/U7Fa2D9gWcfThbAYOYxlmjTz3YN9kODIg6Q== X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?KdFuvg6HrhkFD8NeSxEOI8Ecjq7tRpwdbZ/lU5en2av8j+mqGh9CM+eG30+u?= =?us-ascii?Q?ecDEWKe7dx3i1r7E6WY51b/38czoM8ZFelc9xYkXGXmFdCCVGXIStN+xglk8?= =?us-ascii?Q?WiT86pBL7qQOgX9iMDYxplkLIBH/d6Z7qY3DctyZ/WZDIEV75PlIdGy4Neab?= =?us-ascii?Q?4lffMWg1JGL5sKMrJj+zhjjLcFtdeWOTzGXHpYsC9T6Gu+AAm+ot80KvCz2F?= =?us-ascii?Q?sqXfj+enhvsbZgpaj5ptbb+RBE++5jpHATsErO1dR94WY43kquhsL8Uh2X9G?= =?us-ascii?Q?kCdqg6qSpy7tHHdwd/D/Hy161eY+tTJKhQQcTmydANlXslRhcm1W2Ph6m3eU?= =?us-ascii?Q?3W8+tz31q5AIGLQzjnHX3n/jYfy3be6u5FIo/m5qiPomdzbn7ojbAm7CdmSu?= =?us-ascii?Q?auib+oWGekttc42PaEc7dv84kuBP1ivMG4E4AjT5XB95orjDKgdLdq295WZ9?= =?us-ascii?Q?3/xFfQ5dX4Q/U6IxohexSCKftO1w2ynuGU7z68Ts0qvhb17WUnXEnWuNSnzQ?= =?us-ascii?Q?hjAai7T6+h/xu+8E0T8DJsKjpbPWmI4/e3z2oowkkhdobIw5GmW2xmc9FAxP?= =?us-ascii?Q?1taeKOKUmKmz/T6BAKdrasjiAJgMw48oELFUeq2deRj8qbqrBfSneY4+nwmR?= =?us-ascii?Q?nMgM5NmK0rSXFL29w6QmRHZJVQ7a8Q3m/R6DEH1VdZ22agZCYSqOUXEB/Q51?= =?us-ascii?Q?o8u0/LjTu+uI+2Y7xPs+hgsfdn9aAXHLZ8vb4hupucfM9LRqJyBZWroDiQ3M?= =?us-ascii?Q?rbcoGmnjpJCITGNtHMiFUxMl1QaOcK2PicA50/nS2irHe7ma41/7oPyrH5j6?= =?us-ascii?Q?NWr3VyISXm5/PoVs51Y2GER5Wgwq5yRYhzMigbgDfTWecAHZrjuypFRMxw9R?= =?us-ascii?Q?6Kw+wLX1qWX1qyu/s6iD9v6Ay8GDff11bHR5zxMAkxHaPu8mn6ey1c6C0FZV?= =?us-ascii?Q?PjdDYbDJaU9y1QGzFXHXz8MIyjZs6jKtslQQKKVMhiiWN7OxMNWK2CG0v6iH?= =?us-ascii?Q?jw5sRv4V4yYNTqP3KvtvXxdlcKF/IAmS45mlx39C/Jw4WrvXIUxnTTTBFYLQ?= =?us-ascii?Q?OBozFZauQNh1Z4dZgMwmSpaBxcuhL7AqesPtbJ0PstXVlJfXCAtlPeE0WlhO?= =?us-ascii?Q?n1W7rIMoInzETIx5RNMMlTfsSIIxHhuKCSwCk6OAgU6ZU+sMs1BTtjBMRLiP?= =?us-ascii?Q?lJDVbKbi1nWbmCJPzvLJXLSvJAttS92MFIiYbN+W++JLuU41Qn2K8vayr8JL?= =?us-ascii?Q?2WCITBxSJw8fLlwW98l7W+8dHftNGyWs+6MXiswxzlq+J0Tkl1QvvEt466K0?= =?us-ascii?Q?Hh/qmdiCDecc04RcRFwXmmLK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a3717bc-c87c-469f-ca60-08d915a03359 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:45.1878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: umoKb4W+hHcnQ6HG+RYF6bKiYlgyO8MXB7XvWUj3jKdSvBLRihUXRZwtvco8MGfflQqmMOoam4zJcTkwFwZMaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: I7zalLCrfpqf15Q1eAjlDM3fx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863213; bh=ASJd8Mf8hp4DTYW31Ox4d4q9HIj4WqN72THhgo3EqYo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=BRlwcIRERhWvtB7X/2FzPiWaRianb2Be2PSJj/pBswZE+XcNk7z2lpVJHjq9yJtm7WL I5sFQe8SQ0FMAXeqeWF3YjeGi/CcyCzhhHvLi7451QEzyJSo8UU8mq6DNvx0kj73c+6+7 gP3YLg+QvwdAgqFUJfhXgJYA5h9us0gCinM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The MemEncryptSevClearMmioPageEncMask() helper can be used for clearing the memory encryption mask for the Mmio region. The MemEncryptSevClearMmioPageEncMask() is a simplified version of MemEncryptSevClearPageEncMask() -- it does not flush the caches after clearing the page encryption mask. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Reviewed-by: Laszlo Ersek Signed-off-by: Brijesh Singh --- OvmfPkg/Include/Library/MemEncryptSevLib.h | 25 ++++++++++++++ .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 23 +++++++++++++ .../Ia32/MemEncryptSevLib.c | 31 +++++++++++++++++ .../X64/MemEncryptSevLib.c | 33 +++++++++++++++++++ .../X64/PeiDxeVirtualMemory.c | 33 +++++++++++++++++++ .../X64/SecVirtualMemory.c | 30 +++++++++++++++++ 6 files changed, 175 insertions(+) diff --git a/OvmfPkg/Include/Library/MemEncryptSevLib.h b/OvmfPkg/Include/L= ibrary/MemEncryptSevLib.h index 99f15a7d1271..b91490d5d44d 100644 --- a/OvmfPkg/Include/Library/MemEncryptSevLib.h +++ b/OvmfPkg/Include/Library/MemEncryptSevLib.h @@ -203,4 +203,29 @@ MemEncryptSevGetAddressRangeState ( IN UINTN Length ); =20 +/** + This function clears memory encryption bit for the MMIO region specified= by + BaseAddress and NumPages. + + @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use + current CR3) + @param[in] BaseAddress The physical address that is the sta= rt + address of a MMIO region. + @param[in] NumPages The number of pages from start memory + region. + + @retval RETURN_SUCCESS The attributes were cleared for the + memory region. + @retval RETURN_INVALID_PARAMETER Number of pages is zero. + @retval RETURN_UNSUPPORTED Clearing the memory encryption attri= bute + is not supported +**/ +RETURN_STATUS +EFIAPI +MemEncryptSevClearMmioPageEncMask ( + IN PHYSICAL_ADDRESS Cr3BaseAddress, + IN PHYSICAL_ADDRESS BaseAddress, + IN UINTN NumPages + ); + #endif // _MEM_ENCRYPT_SEV_LIB_H_ diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h index fe2a0b2826cd..8dc39e647b90 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h @@ -126,4 +126,27 @@ InternalMemEncryptSevGetAddressRangeState ( IN UINTN Length ); =20 +/** + This function clears memory encryption bit for the MMIO region specified= by + PhysicalAddress and Length. + + @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use + current CR3) + @param[in] PhysicalAddress The physical address that is the sta= rt + address of a MMIO region. + @param[in] Length The length of memory region + + @retval RETURN_SUCCESS The attributes were cleared for the + memory region. + @retval RETURN_INVALID_PARAMETER Length is zero. + @retval RETURN_UNSUPPORTED Clearing the memory encyrption attri= bute + is not supported +**/ +RETURN_STATUS +EFIAPI +InternalMemEncryptSevClearMmioPageEncMask ( + IN PHYSICAL_ADDRESS Cr3BaseAddress, + IN PHYSICAL_ADDRESS PhysicalAddress, + IN UINTN Length + ); #endif diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c b= /OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c index 12a5bf495bd7..169d3118e44f 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c @@ -111,3 +111,34 @@ MemEncryptSevGetAddressRangeState ( // return MemEncryptSevAddressRangeEncrypted; } + +/** + This function clears memory encryption bit for the MMIO region specified= by + BaseAddress and NumPages. + + @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use + current CR3) + @param[in] BaseAddress The physical address that is the sta= rt + address of a MMIO region. + @param[in] NumPages The number of pages from start memory + region. + + @retval RETURN_SUCCESS The attributes were cleared for the + memory region. + @retval RETURN_INVALID_PARAMETER Number of pages is zero. + @retval RETURN_UNSUPPORTED Clearing the memory encryption attri= bute + is not supported +**/ +RETURN_STATUS +EFIAPI +MemEncryptSevClearMmioPageEncMask ( + IN PHYSICAL_ADDRESS Cr3BaseAddress, + IN PHYSICAL_ADDRESS BaseAddress, + IN UINTN NumPages + ) +{ + // + // Memory encryption bit is not accessible in 32-bit mode + // + return RETURN_UNSUPPORTED; +} diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c b/= OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c index 4fea6a6be0ac..a2bf698bcde7 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c @@ -118,3 +118,36 @@ MemEncryptSevGetAddressRangeState ( Length ); } + +/** + This function clears memory encryption bit for the mmio region specified= by + BaseAddress and NumPages. + + @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use + current CR3) + @param[in] BaseAddress The physical address that is the sta= rt + address of a mmio region. + @param[in] NumPages The number of pages from start memory + region. + + @retval RETURN_SUCCESS The attributes were cleared for the + memory region. + @retval RETURN_INVALID_PARAMETER Number of pages is zero. + @retval RETURN_UNSUPPORTED Clearing the memory encryption attri= bute + is not supported +**/ +RETURN_STATUS +EFIAPI +MemEncryptSevClearMmioPageEncMask ( + IN PHYSICAL_ADDRESS Cr3BaseAddress, + IN PHYSICAL_ADDRESS BaseAddress, + IN UINTN NumPages + ) +{ + return InternalMemEncryptSevClearMmioPageEncMask ( + Cr3BaseAddress, + BaseAddress, + EFI_PAGES_TO_SIZE (NumPages) + ); + +} diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c= b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c index d3455e812bd1..a18d336a8789 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c @@ -891,3 +891,36 @@ InternalMemEncryptSevSetMemoryEncrypted ( Flush ); } + +/** + This function clears memory encryption bit for the MMIO region specified= by + PhysicalAddress and Length. + + @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use + current CR3) + @param[in] PhysicalAddress The physical address that is the sta= rt + address of a MMIO region. + @param[in] Length The length of memory region + + @retval RETURN_SUCCESS The attributes were cleared for the + memory region. + @retval RETURN_INVALID_PARAMETER Length is zero. + @retval RETURN_UNSUPPORTED Clearing the memory encyrption attri= bute + is not supported +**/ +RETURN_STATUS +EFIAPI +InternalMemEncryptSevClearMmioPageEncMask ( + IN PHYSICAL_ADDRESS Cr3BaseAddress, + IN PHYSICAL_ADDRESS PhysicalAddress, + IN UINTN Length + ) +{ + return SetMemoryEncDec ( + Cr3BaseAddress, + PhysicalAddress, + Length, + ClearCBit, + FALSE + ); +} diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c b/= OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c index bca5e3febb1b..e0d3a15e8503 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c @@ -98,3 +98,33 @@ InternalMemEncryptSevSetMemoryEncrypted ( // return RETURN_UNSUPPORTED; } + +/** + This function clears memory encryption bit for the MMIO region specified= by + PhysicalAddress and Length. + + @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use + current CR3) + @param[in] PhysicalAddress The physical address that is the sta= rt + address of a MMIO region. + @param[in] Length The length of memory region + + @retval RETURN_SUCCESS The attributes were cleared for the + memory region. + @retval RETURN_INVALID_PARAMETER Length is zero. + @retval RETURN_UNSUPPORTED Clearing the memory encyrption attri= bute + is not supported +**/ +RETURN_STATUS +EFIAPI +InternalMemEncryptSevClearMmioPageEncMask ( + IN PHYSICAL_ADDRESS Cr3BaseAddress, + IN PHYSICAL_ADDRESS PhysicalAddress, + IN UINTN Length + ) +{ + // + // This function is not available during SEC. + // + return RETURN_UNSUPPORTED; +} --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75085): https://edk2.groups.io/g/devel/message/75085 Mute This Topic: https://groups.io/mt/82787290/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75087+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75087+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16208632192521015.871265314766; Wed, 12 May 2021 16:46:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id LCP2YY1788612xMKi66GaIa7; Wed, 12 May 2021 16:46:58 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web10.6186.1620863210873702199 for ; Wed, 12 May 2021 16:46:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WvDjThbfNSXRMd/icsn6p05Znp9N4mpV7BMjLJ4QUfRq1usIFsMHem5ww5rTFBUU9k9/z6SnNG2o+S0SGySK6tOSa3SfKuOMRHsdZpUJ2YkM6DoV2XqutzMMOL7wAPiRxz+gJbtiiSIg/Y7oAma3gJNPgpeIYjeYI8xrTiOAf1yc/Rm+Kjt+nQmDwYxWgMZ0o+d3WP7StcwHdb4lcEY5Gl2L494VRC7i4+O1Ql2XdfzC57wHtP3clBMqayWKwdpmSW4QVD/uhYsk+2cGbH6KRiEslnGQntAkioXmpLnS1FI9AzgjpwkV4vzIGZWeaTSBEBG+RudLsda0ixvBNTD8yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/okNaFz+eyRjDnmLx35Ha7Jiq/QW4TI6ieKg3CSwIAE=; b=E9dGhAOG7lqQhAFv8zIP8j504//+r8g1e0Z+qtENips3S7xcY5DydRVA5f45EzZrM24HUCxUWA5JlOKYlA+WpkYZ2KHfRZkBcvY92q/uMxkjEoYM5W8gFjEbplmAbMblMNn/rdwI5uMBZoO7KhWCaI/8/yWW8tBui9Ius21FCnjUeLYVw8xhqFiLX3Z0olyCsovR/cfdGbDBmwV2egq+CNEJcriF0EYIcQd4rcYwXMfRX4M45EFXRE4lOVpWglUBtG5iN9unOVV2XP4XLe+rjp1JbrAe1cpLwVVeSec09ty4b1FCvp9zfz8OlYtBKxjaoNe0ZTz6cMt+Xy2Hc3FgYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:47 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:47 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas Subject: [edk2-devel] [PATCH v2 10/13] OvmfPkg/AmdSevDxe: use MemEncryptSevClearMmioPageEncMask() to clear EncMask Date: Wed, 12 May 2021 18:46:12 -0500 Message-ID: <20210512234615.1726-11-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0c8c9a1-48f6-4cf0-054a-08d915a033b1 X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: yrASFB1CsxEjC+KwHIYuatgxQ677AfUtpHjRnx6z5YqEYKQd0RgFgcc9lFf7zNBISHaGKedecorH+RfWkMAltN/EllDKFUld5Tfc1GgxXccZPGx93j3yjXnim1kbFYwdC9LKGCAOX8Rdg0Pp52m8XbSJmXevj56tABiu5di78LIDKvNUMXzWQS1qUQOQ4xB9a+e1NYWfrOIlM3obaQnrzZldVTo9Gaei+OnkBH3bF1IsBRSX1WiN74iCf6rSGA/jrJzkHJWvE2RDvO952/PfPstNflzvjVk0irdA2YSK8W255ahrk22Hvy3Dq88wjj21BZo4j7hO2r2LW67qSC0xq89gJMonR1zRORipQJIOw4CFY8T8lDKdXmwb5ePnycbkYA0pEgBz+p3sL45JOyfZGpoeulLfc61CM2LedlW0alu6M6jO653rsnZaSAiLdR5AG203CUYXGN+yzUUfSOrXbI3QBE6d4G58X8b1PWqfuCmYSQ729wSpxjuUfeqnjAV8MOhw8ghlolEeVB/7ftqGf6c4kuP2Eoqf0AGsSIPA/k2rtZcZxmqQxhXe4+CETA8WBeNhNJfT3vfCk3TBsz3bfwYg48+BBzrLjR7P+yjZGyLZ7QmPmUsPURvNcF+7d25njPUsUXTkuekoZCoYdu+utMuss3+mOGbKJrj0/eAioNpUDv0ZeaNoLK909LQ5KQ2oqWN2bxfz2aRzL/5hDCNPOZ/6q8cdQNmzNOt2SXQUhxb20T61TC5NHuCrJ5zOLtSK2dM389pFLZWxjqNRyIBpsw== X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?gt80ZcgOINg2Vimb29hmxYhKs9iYrWyn/Opa63oaNQWEXa6taF8SXaznXnX6?= =?us-ascii?Q?GDGYpvzU8EI0QbY0Li2F1Tb2Wui24eij+hDpcgZLSGdTmDX5x9RiowPVcBQM?= =?us-ascii?Q?ckSkc6TtFO6g1vAgFRTsM6dxww2rxEeU/zlmrGSO7vWxoCvfCk6b5kTIFiS0?= =?us-ascii?Q?EPGv2qQnH7MO1lGOllX9+B8AVTTr/qb6zEFyulfNLzDPb0mjijjSQm8JDBZT?= =?us-ascii?Q?5WdCqVtTXx7iAfvjAr7OF4TH0GPfMKyMqaaOMd+wz9+WENYnvqd5VnCGtU0C?= =?us-ascii?Q?C2Dvmg48gdGe6Y4ufz6Vply+VLVSWXuwTA/UdalntfYgR12/DEDrI34w0kcB?= =?us-ascii?Q?LG/ovH49k46QX8mISPzoszG43cKRr0iWi73JmgSB0gMJQ6padUBX9M9XjkxW?= =?us-ascii?Q?dOsq9hpCs6hZBhP9V6FRlMCbjXNKUgkb0vmZZ77V2iBFWSKuKpwQ4Z3Q4Kk+?= =?us-ascii?Q?HUdknqNTyeFEcs1in8lnXqc6h+jPTwemMvDTX4fJadB33p0RMfVe46eFR2uY?= =?us-ascii?Q?Ed9DeMrI8lUOxVjUOdaKOrI1ZPTWnEKEvhPCvUs5sFDseh2S0F0Wv+Xcax1Q?= =?us-ascii?Q?xbPfZqfuz8biv4n6KZaISdkf46B9hg5Cb+9GW8zgtDQyZtsaPcUsyKSRd/Yw?= =?us-ascii?Q?MsWKPiHnM4rnvpmjp1cgshWg3OKmKlv1ztxvSdwP2IGWJVq0RblJaliVT5fy?= =?us-ascii?Q?lsKkaJGZg3N5bIr+cMmgOx2FTufaS9UZ/4yuR2qpXnF/5w+dIB5V9pDNBuwI?= =?us-ascii?Q?vS5QwZLu1m++9SqDo2/40RAZcK54vyIzbAmFXn+WWxFfGnrnudjXygRZZnMH?= =?us-ascii?Q?pTRCf/Q30pzxN6QZYhkTHcUgC+yYG5Xa0aB2H0ZWzMSFFuvx9S4GTy2gK3rn?= =?us-ascii?Q?/fu1PyBCyERVFJzPkOITduMdCFmRw06xZYPxun2tONnfaEo07LfV9nnP9JzX?= =?us-ascii?Q?jpzX89z9GiqYOgMJ8pNTbgpA0K8Z793V9NLgWWBRNA+xqtHmzz/PnksB63La?= =?us-ascii?Q?wEHb8eFZ3r/u+pDhoVw7SoSQu8rpJbsbMqFJ6PHVTPkUdgP4hg1JXu/UM1b5?= =?us-ascii?Q?hbmmdoqRJERyhjePh5hczc6UfyRlhrR74zmB/uiW7uhMI8bEZAsvJ3zLDzZt?= =?us-ascii?Q?Q1f+ACgLpelvqSFDjShKb2sCHPABH32BZYSFpLL9tMm/LVd1H4BUIycLVziB?= =?us-ascii?Q?eywbVI4qa9nRJgexrwLfnYZzXJCO/ilpsO7acZFiyRh0bl1OIfy9Gqq834Mj?= =?us-ascii?Q?Ykq1vN/1ufWnhqp5EtFfKCDAUAjxtz9FcJyg1l7vj0hLZiIvvFo57xK98t7u?= =?us-ascii?Q?8I7OnGkgnzSN9DTutUdzPbpO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0c8c9a1-48f6-4cf0-054a-08d915a033b1 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:45.7764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 334v/19aveZZasF46S8GznHLN7AhMeWH2+0z2M/BKgI38TbFaE2oqau7NTThvLyU5wDv+CvF3uey/eVIyMX6Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: lGxFe23zTNzPFrIhSTHWGzPzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863218; bh=DZObjqGKKqH9badL4tr6uHDXPjAQa5JDokpihPQTz8c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=MowpaV5Oz/RpRS4oxHtnsH+JIOegJYGtjZn1WNEae6pUOYggiGpKrA0qqgc4d/ZlFcA qWWS3I9pokKTfu2dAyiksVyZQXpgrlwpHAbrZkMB3ntHncTbMWskyaaJersBNN/Ef/isc Kd8OwSnbzEPSqSFVmS9BousNKBQjEM+F01E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio and NonExistent address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Reviewed-by: Laszlo Ersek Signed-off-by: Brijesh Singh --- OvmfPkg/AmdSevDxe/AmdSevDxe.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c index 689bfb376d03..80831b81facf 100644 --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c @@ -53,11 +53,10 @@ AmdSevDxeEntryPoint ( Desc =3D &AllDescMap[Index]; if (Desc->GcdMemoryType =3D=3D EfiGcdMemoryTypeMemoryMappedIo || Desc->GcdMemoryType =3D=3D EfiGcdMemoryTypeNonExistent) { - Status =3D MemEncryptSevClearPageEncMask ( + Status =3D MemEncryptSevClearMmioPageEncMask ( 0, Desc->BaseAddress, - EFI_SIZE_TO_PAGES (Desc->Length), - FALSE + EFI_SIZE_TO_PAGES (Desc->Length) ); ASSERT_EFI_ERROR (Status); } @@ -73,11 +72,10 @@ AmdSevDxeEntryPoint ( // the range. // if (PcdGet16 (PcdOvmfHostBridgePciDevId) =3D=3D INTEL_Q35_MCH_DEVICE_ID)= { - Status =3D MemEncryptSevClearPageEncMask ( + Status =3D MemEncryptSevClearMmioPageEncMask ( 0, FixedPcdGet64 (PcdPciExpressBaseAddress), - EFI_SIZE_TO_PAGES (SIZE_256MB), - FALSE + EFI_SIZE_TO_PAGES (SIZE_256MB) ); =20 ASSERT_EFI_ERROR (Status); --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75087): https://edk2.groups.io/g/devel/message/75087 Mute This Topic: https://groups.io/mt/82787292/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75088+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75088+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863220137349.575975159226; Wed, 12 May 2021 16:47:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4uThYY1788612x8fgUM0xBET; Wed, 12 May 2021 16:46:59 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web10.6186.1620863210873702199 for ; Wed, 12 May 2021 16:46:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nu1LnfPLj6YcAM3c+5ph89wS5uOnBWHat3MQEIbwQJHMtpsYNsr2z56H77u3ucP7x6n9wlFZBP/TFfJMhgqIvbDFf/9egr6ClXDsMzsjpLLnJietoUzh0CtNXlHphPsvmakSWeD0oM+edDX3e4WPJxhcwsnDtcB4hFRxbwL1CRBMeBKjF6po66f0yq6A67Yz5ysr+MZt4V6Ic52MQ0LpKBLgdkbJQx/LuCqf6EjG2KWdQwN24ifSvC5ugXDY3I5Moax+UOPP4keY7uY+BgOHjgvG/EguPvgfVNSTpt6DxchJG8A+EPmzgvI+hRGd+wJNBBMFphDZAjRmobty8Dy6fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzufsZrWgS+UNzs4KbfjAj1i6bjJ2PYGsIILu54EiEI=; b=c18ybwRNM8tgd1e4eM7h3JwtHAIaa2akaDV8J90AVeofNjZ95bZNiw8aIXebx4EArpxU9ivYlJ8Q7JdHuNadnLeRcFTNVJg0h/H1PJ0OvfI7hiHcU859R2p/qicO1hAfgA2QgVP5yuSmKPEmNSOS29x7zNoHDZAeevCrBG3NxDDf5r5/voSPpWAswsmT6Y4WnRhmsmsdXRpuyC20u2jA03eZ9NJ1NcZHwL66wnA+plT1aGYsbu/Nh+oDA9VJ9RlBeWdkLh7YZHG7NuKGcqY4M+kee+zrH7mM3DCZtKNZtfRG7UqAj+vm1P8LlbpYttYDbN3dBIEFbg/fj+5ZF+tDLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:48 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:48 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas Subject: [edk2-devel] [PATCH v2 11/13] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: use Mmio helper to clear enc mask Date: Wed, 12 May 2021 18:46:13 -0500 Message-ID: <20210512234615.1726-12-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc4730b9-d08d-4b8e-ce4e-08d915a03417 X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 9H1ulQoJh8S0hEp6V41UeLqsgLhfqvfLvA+pBmFKhEkZa4vwIM+kzlbwkQgYjf+JxYM4ThH2TmKQfpfX4lvfgcpqG7YR79ygAKFORF/B72bolqS8wEUrTVISgRGbhbyOLQMGvHwz9fERMkFt1t4suyLnf035w3EemPQJ38lsKPZswP7xrL1QjHnlY82LkhC52sEf3+81kbJdAIYCISOkGsTM6UyRa5p2qoKm8oKhnoOpJUZZ4j2b+1RlE6CyXiZxpKdxk9tdgLu5lDNl3YeMblW+928p8nmEWM8R4cfZKQCODUNu9uXypBeyn40LJurUkjSg9besT9N2DtLm3izsSoLdk/NFYUwNv7ZVPCn3a5l2WK8S8C+GTU94jBi7et1f3VXEq1R8yF/Jujn4ZNdlOJ/zhCUqzhTiBXvYImIbmT/JPrHFnFack1I8+PJUpMZoHFnhdG2MSaJL+r0acsWrKsMLoIs5JK1PfXjdL2v65NbiQpry/YWrud40q/LfDkkGd91k3OUP3XIwYLmU3SkgtfhifTFarLY1q/SAur7Y/vPsQt9i9PopGxYBKtJmJLTh3BS3gFoOq7IxQbtJkXXZ5HvRoAggj3kvJ5yBk4KKdGw3l4vh7ycYI3TOGyWSMxPoiAQ233DunWNQI8VczMJmBeMtMIcCCyhOJlfvVzzgg4/U8XIrvUil70YL4FRjEJjqtQJp3IDcndVSmkM9HN4zUCu3XndHthAyyPxOvCChWMKNp1NRalrha1VqJ/DT6kgeu+0ioFhj1D0kQ1IBRLRzbw== X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Ov3RNJS4YIIUmXPLPa4OW13lc+iV5eK+SoHknRMq/qcgihIF14bc+vwF0m5H?= =?us-ascii?Q?fkpxwdd9SU9cPDECYZqFOMt6ogo0dowz7x+1LgD/QkMg8n2aDjzXfIdYGonP?= =?us-ascii?Q?CmW8aybAgqwDiVLQwtc6yBNLPsm3+zseP720FOo787NnuLEYnQOt5t3I8ASw?= =?us-ascii?Q?9Rge9jHdKtt3A//ZEetQdsq+sR/QIWmyoztsw+sDg3FkjmPIXsL0oUbrVSHo?= =?us-ascii?Q?JjSWlyWZ9ypNThnSRjmcrlbyITW+77vnUZk5EOcidFGQ0xHA4IEaIuSaF+Ff?= =?us-ascii?Q?zYEXkyrT913iHJbGF/w03/SuFWOLIoT53L9yI2zo3eStzrZcx6aNqtGgqp9T?= =?us-ascii?Q?RyRVOd9eIpWO9ZZ+/INeh2vwBOjZW2lmmOp/Tf8tl6iJt5Efbm7yfuhOlAMa?= =?us-ascii?Q?ogZljr1ngi1Nos7prFmpEp6uImRb6nD38CQeJuI8MCDXiSx2xpsT8apbuf9x?= =?us-ascii?Q?B+j++S3Sp/Qkpw9eX3kLaPJ6Pvc0/e6HDBBmm+g9ULGpGlIX8rVyTxzY2QhH?= =?us-ascii?Q?9fqD/ZdXS3fgud16XDkrn0ta2kyw07tpG937PK6aBbL/rbqow1uK5E/MS+tc?= =?us-ascii?Q?DGGaYN3l1ORyW8gGK2ohYqz68mNYsJ0i2elo7qvripn1jeLY1xq5WGHRiBs2?= =?us-ascii?Q?/VOvlI+WtavUvii3GLByN4yxpgQtKkJS2YqBvJpU3w9WiQgFwS26nIVfiecm?= =?us-ascii?Q?mYK6TSYHWq/jd8/YC+jboKtoG+gNfNf7ux0LAJ1iBtp6ZbktDDrz7ncc1kDU?= =?us-ascii?Q?tKCijhPkp5lmtt607gq7UGvOdYZ3cf1ynYHqL4JeLuwvabxiSfk2oReSjX4H?= =?us-ascii?Q?CPgPzD9lNAm04ufXT9SrvAzw+nN8eSrpEEtiKgWK0EvGJzKLjLdph35ptvzL?= =?us-ascii?Q?dUVi5DtmIRaTVX8LJi+5S3EvoLBmB0D1+dMdHC2z8KCnAwO8OSQ26JfWPgxI?= =?us-ascii?Q?NaKmIXO5Owmm4E6vnTfFNDCStf9l6t89NCeAVmXr7umdEZjMdBei4vBB3NIA?= =?us-ascii?Q?zH8iN+w3vZFc0tePzpqLFEPD8JEdyKat0gqUO/XoqQ8x0W0+m8U91iPe16Ea?= =?us-ascii?Q?jxRfGKqGrWOGCiCxxM22AlPwOgCWJB05nvrKa/R8u5kPZUWz1RfSdJt8t08X?= =?us-ascii?Q?v13bm6n/5Rbl4TCrUXYDa6UHCUad2t248MsFQDDVr4++rlGHKCwAFUaTv4yW?= =?us-ascii?Q?8LgOZKogpjLHZOa72e3lTWWmPl7GCQwIJRiFESkF33RP6n5xlJmrfMeUoMoR?= =?us-ascii?Q?owChnyiKfHweLtlVl5FyKujwCXEjBej0kOpjvcHAifRC1BryOeHvR8wVg0Fy?= =?us-ascii?Q?k2t1xm2cotRnVXM3vd61gnue?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc4730b9-d08d-4b8e-ce4e-08d915a03417 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:46.5090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uRObYgIPMv7SmjubdZuHyY5K2ruk7Sh7lGcn6epYbGKAXhUDxJjqi6w+v6J9nCwrg8pyGNYMwfuOK7Z0t9EUeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: HI4UV7ljfLSJq9F8gNncVbYKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863219; bh=CfBp+kRv6pyXDDnFqwny+m7kZvrJqrP+uDm7qpizYEo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=nXgPx7gtDq6fuLAniQUUteRcYrekNdavb745uk05vmU997DO4hniT0D5Vo/kV24bf/c k2/3CDwJNoc7SJL2sEwMj+drG0tissnxx9w7/vBEhb0CVEjScBhMgHjzQ7kRQ9AYUbCiA DZEZ35nHwsn8GWTcPEUGxKqweRInCow0Asw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Reviewed-by: Laszlo Ersek Signed-off-by: Brijesh Singh --- OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 5 ++--- OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashSmm.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c b/O= vmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c index 1f285e008372..ab40087a8408 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c @@ -205,11 +205,10 @@ MarkIoMemoryRangeForRuntimeAccess ( // memory range. // if (MemEncryptSevIsEnabled ()) { - Status =3D MemEncryptSevClearPageEncMask ( + Status =3D MemEncryptSevClearMmioPageEncMask ( 0, BaseAddress, - EFI_SIZE_TO_PAGES (Length), - FALSE + EFI_SIZE_TO_PAGES (Length) ); ASSERT_EFI_ERROR (Status); } diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashSmm.c b/OvmfPk= g/QemuFlashFvbServicesRuntimeDxe/QemuFlashSmm.c index 7eb80bfeffae..ea75b489c7fd 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashSmm.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashSmm.c @@ -38,11 +38,10 @@ QemuFlashBeforeProbe ( // C-bit on flash ranges from SMM page table. // =20 - Status =3D MemEncryptSevClearPageEncMask ( + Status =3D MemEncryptSevClearMmioPageEncMask ( 0, BaseAddress, - EFI_SIZE_TO_PAGES (FdBlockSize * FdBlockCount), - FALSE + EFI_SIZE_TO_PAGES (FdBlockSize * FdBlockCount) ); ASSERT_EFI_ERROR (Status); } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75088): https://edk2.groups.io/g/devel/message/75088 Mute This Topic: https://groups.io/mt/82787293/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75089+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75089+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863219662605.0633007633307; Wed, 12 May 2021 16:46:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id NnISYY1788612xR89oh3oVE2; Wed, 12 May 2021 16:46:59 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web10.6186.1620863210873702199 for ; Wed, 12 May 2021 16:46:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1ofjcDf3hk0UOS+9mBxxlq0eH47aT6le2ufAgm+5XA1KDvfV1UNTeRjcJ1dKUuXGWMco0QKsUVDCz5hropOic652tMLvAuNQ6Deh/U7JIt66j0knlMbraC/WYVQuVDTc/VyilAia3MGgr4P4KJcaB9aZe1RWpyYJv9wGriuZDvng72rhdS4EuZbAIManYbOM9cLIayEo2Jb7ysFMINVetyGLOh4K2CGAAO+XFy9LDSt2ubzXGP7NqDbSw1bn0NmSwl0hNnfyUTqkKwmnEmWgQ0duFX3X2m8+ErVpbkhV1gyuElMomXwzmme6JDUC9KBVS/Jmcu9FZDdSTikl79NSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8Rm49ET0mDGF9wp7X4cXNbdvH36yAyJzBfsZludOwo=; b=Q1pzbmSFx7zMHwcsStLDUvQ33ZJCa1OaGsFVeXYqfiUFK1/yi4EKFpC/BJlLp8zUgK08Ynbhj7O4rp7LsgtQ69o+s3u/5YbS9AHYmuTu4xmauoXwtRSJFa/evcK2jCwbBr5DYbJqu5bpoNVQmqzavP+AMbPZB3O6UsHqx7N7jW1igmCa40HFcaar1PErJXHUqnkMrn/qav60a4x/pJNqEI0+7V6xr+e0NidLaZJPZt+Lk12tZ4RaUiVqjKBKjnszJ9qto+mW1LHsTSQE3nKxix7ayuIoWD706+7fsLoeEU1trWueyLcF2t7/MiCWXoPhPlmq7itaobm7ra9ePLJaNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2781.namprd12.prod.outlook.com (2603:10b6:805:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:48 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:48 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas Subject: [edk2-devel] [PATCH v2 12/13] OvmfPkg/TpmMmioSevDecryptPei: use MemEncryptSevClearMmioPageEncMask() Date: Wed, 12 May 2021 18:46:14 -0500 Message-ID: <20210512234615.1726-13-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d2a3dfe-9dd1-4f20-4c78-08d915a0348e X-MS-TrafficTypeDiagnostic: SN6PR12MB2781: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: of1TXkXfgqLdfTs9XEbNxRddZYduuq1FU12j5vrR1TegH6HzeHF5JLhzUWAG/x6FGNIKDpsHFSk0P5yonYpIwnrVMA1rqn5nGywIfdynRkHivmAHj2hv1fDh/dAenFMuWh/tL7ceLMVKRzRfdhwS/X1dQsXgUyfYK7hCeqc83UpGnPuu/4K3EMRXmO/CJ47ETxj+niE3fAldl8C0dpkOMVsxpn74BzPPC9/FGd6D9YDU0QEZ3ndxhHkgX6/0cgBUZgSHOgolMv5qUqO5U7nj7uu3OHItGjNFfqCbItbgup8Mi6rlLEfp//mRGAj8JA0MuQ0pzfyUcQ9cZuzUwy32r8F5Zokl64nEELDYSodUtIKu2bRDAF8xd6o0oGleRO/2DtjnAziRQ2PKex798NEIIldYuXgm09Vm/RC+vOY5S8tOC+ROBZIx/wJJaTIbhpEodYlASX1paaFeEWABW2lyjz5PGC/iHabKTpPYvkP0QWNqJA9VjsY80uBuRPtnfLX46RRXUo8zOZpUV6LGgLX1UVRQL/2BqgmtBcDbrJLjtdnyx04zNSWw3Fo50ge3XzyvihxFwUE4nuVFKiCyOrzNlI4q7pGlTbo1puS9mx9rLMDxt2KdKq3gVJ+qzFUwjwuwaY4qvPu4nO8aR/w0o5kmCrBHxy8tMoPPr989jzZm4fcxgDp8ty37Z8l9rM5/qxi5iCCwu3FsWruEx2mrxUfzMmgizZLqpr7F/qKi83zkX7XUFMZarL3IOJRjxWe7ThB7RUpYT1s+mQuJ9h5s2NNjew== X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?wY8Nr6XRiNHl5iol5GjKZD5PGEvmp9tDQ6/r/WNg6rAlecsD/sPO12BSSw8P?= =?us-ascii?Q?0J0o80betUzn6O2E35c9LoCR2ih0tm7ZlvsCTbsxRpZVNSNsXWVoHfMkAy/Z?= =?us-ascii?Q?wTY2myD5ZatqV3OnSJSDK4bx5p8tLLesJE4YRDG495SjNQ11+7Hv9F0jkUY+?= =?us-ascii?Q?1GsHJ32Qe77v+a4jUhf87OFLdTJUUs3EDc6tMKCApJYh9TrJ9uOLgyfyng0a?= =?us-ascii?Q?QvuEfODV7HCR7xqguvubFcAN+dwPylUa9OZwT/mZ4YiJjUsFVzCAEe7l9hCO?= =?us-ascii?Q?10Zj9ColEdoU3Bfgjo0LxeN+dm70zY9MIr2mU6cY6DePms09EzH3ELnASONe?= =?us-ascii?Q?U8FlB5FZHml71OIAkeSsm0I208Jfs1RKZ+q0O7Wsi5PfyFWgp7IeMjog5anZ?= =?us-ascii?Q?QTW/rsed2ticaBEvDMPfS0dqExOpGIkkBKYngUo8mP4j4+InbBvNKXopUaEQ?= =?us-ascii?Q?dAcWGF0A3XLYwRRp1bFIX0xcsuXxevHCyeaZQRDkng/VUKMp5Aap/DNzYlGH?= =?us-ascii?Q?yM2PGN8Q1Bt+LBuQAdgrerQha1NRbBdZJ67Kz9doS+LJ1KBbVea12GqNsRd9?= =?us-ascii?Q?h8pv2U8uNcUKvZestSgSxk3HITtLRCs0aAPA8nueZPk07WTlIwYRvFJEgA2U?= =?us-ascii?Q?GJWOgVOHdBrmVp4arFfDnlsTszrVQ6+X2ap4zH8LdTXotE3p2R+brWvZnj21?= =?us-ascii?Q?XI37yV/wtOUvocvT1D9E8vb0dTq2MbBm/kHAf5ZWHnskvrYoShZ8DVk1OahW?= =?us-ascii?Q?7ua7VrhZebvc+f4EGsgDfJhAKdHt1hRgbzO80Xjp1MHqBx76UbraaHVPNiMY?= =?us-ascii?Q?PYiAyJ1wM0cM965bmsTCWVhw4NKfXTRRPaUipWz4ar0e0lXo+oNt1C43re6n?= =?us-ascii?Q?VQlF8CEVj3OP0f8lnMeixBcWIJCNsriaskEM2+tC8tBY6LrPNL4QJDNkKaE6?= =?us-ascii?Q?nUSQa+PosZU7lR4uHex93EUiiFGIGwWCTdhtvrecajWfYRCtqHDUqp5sDydk?= =?us-ascii?Q?6c7m1KtCteQ9A/KMyZdhI5iJjTCGJvKhYH+Obhcel9ZXlkdvBlBYrvev6n25?= =?us-ascii?Q?Ow27mKGDq4uzuEF7L8aYfxHl74+qOp/XStlntmwG/hPa6uEUvpt9z7DDrav0?= =?us-ascii?Q?i8rFHHm+P3SyPXWE4k/XxYmEKLHvyk1/4DOy68mOQsz1VxAkFOfR7o8LKj95?= =?us-ascii?Q?woW+UyLmq7oM/e7p6vj6appotDcQZk6ZgItk5G+7/XRuzlFZVDsxcscJPXbL?= =?us-ascii?Q?kF6OsyFJREVwEm8kjezwVdEMiON6w8Z3Sj2YT+CtCFxgD1HU+rztWYO19H2d?= =?us-ascii?Q?PTijVuaTns0sLjeu5WXYFiL5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d2a3dfe-9dd1-4f20-4c78-08d915a0348e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:47.2656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 36E+AuI7a5KtJe941dnCSDSYn7HrnayVcF1bY4pCiTwmbDfJDWhR8aRH3p+3lQuBPnKBVRb/qVfZHGvGlcPFAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2781 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: aUwlDTwI9S1hN86UdMmUhv91x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863219; bh=ELccsk1MdeN/fAmG6Rf1FLV2owhGGkq348AkDj5Zd54=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FeiXRSl2rdUR2NdY442YDJaAi1YCa7b3LCczNq/sFHXVru/UJTZrFrdcNFWgvuasSIR Kv8fTEf6t9vfD8GijJF3+djg7uqKSG4nAwmcDX4J9pP5oUS7uNAObfT9GUvMDAfSbrzda hOfEFIfwlhPqaRHmv+iwjhd0wFzMX96E5aA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Reviewed-by: Laszlo Ersek Signed-off-by: Brijesh Singh --- OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c b/Ovm= fPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c index df2ad623308d..570c8467a673 100644 --- a/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c +++ b/OvmfPkg/Tcg/TpmMmioSevDecryptPei/TpmMmioSevDecryptPeim.c @@ -62,11 +62,10 @@ TpmMmioSevDecryptPeimEntryPoint ( "%a: mapping TPM MMIO address range unencrypted\n", __FUNCTION__)); =20 - DecryptStatus =3D MemEncryptSevClearPageEncMask ( + DecryptStatus =3D MemEncryptSevClearMmioPageEncMask ( 0, FixedPcdGet64 (PcdTpmBaseAddress), - EFI_SIZE_TO_PAGES ((UINTN) 0x5000), - FALSE + EFI_SIZE_TO_PAGES ((UINTN) 0x5000) ); =20 if (RETURN_ERROR (DecryptStatus)) { --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75089): https://edk2.groups.io/g/devel/message/75089 Mute This Topic: https://groups.io/mt/82787294/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 06:50:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75090+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75090+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620863221435643.1890665125762; Wed, 12 May 2021 16:47:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id jQd6YY1788612xYnDRS7i7rs; Wed, 12 May 2021 16:47:01 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.73]) by mx.groups.io with SMTP id smtpd.web08.6094.1620863212737952951 for ; Wed, 12 May 2021 16:46:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAJTwAxj5eAqFoHGeW+Ityf9FTwqdWd8xRmv0t6GXjULREjzk2Fti6jynMxNBIiKkBJUo7iIAwCDF5z5HQrGnnxxeIatwmw36BvLOMTee49gsrlNjS/pc6fVexz6YZDtOYsaRZ2FaSD50dJbu9q/fM8Ku7n9nHHbsVqp8qWNO/CHzDW6pEXLCh9r3Tm+qcg20k2tnTsVTlvU4xBDNzb4Y4/gefk2V/z2bRN0bTYYaez0GVgA4fOcfpf0Al/mmV/4QSS3+Ji46LVe1jBG6qrNNpe/YABkd9jFSwPQUdU7hRFalXyRk2jbBdCyzEI26bHHt/rqS6Ced7ciAon2nn9Tbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g6z800AL5Ddb/AbQzRPgsUmL+3pQQg9GQIseQAj5YDk=; b=Q3Hb7u9G31ynu/0qolD8dKphMVZUuB2i/ZnvKcXw/yhRwfvqfL7IVqFD8V5EbyzO7HFtalJQo3lVUiCrTnMJiSQq3/DgNdB2kzsFJ/Slu127rcIrAujQD/Fw5eS5tqe07JK4d9tx2X4yV8THnom2JmlSiJymmjeBkdNUetNbd1C2oNJRqpaDVAPmeqhg9E5Im1OlMzhVMa5EoMYbb7HuRrr2Gk9EFpkP+g82QwzXkGvE0lMRGQmyEaZiGF83DtO6V+sCAXZwZrZgCBsF8vrgUO1cuvToNdY2BgXVeYeNjQSM965XQ/pz116SRCaIn1OYzORC2KpV92Q+1en6O2Tu/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2445.namprd12.prod.outlook.com (2603:10b6:802:31::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 23:46:49 +0000 X-Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4129.025; Wed, 12 May 2021 23:46:49 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: Brijesh Singh , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas Subject: [edk2-devel] [PATCH v2 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter Date: Wed, 12 May 2021 18:46:15 -0500 Message-ID: <20210512234615.1726-14-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-1-brijesh.singh@amd.com> References: <20210512234615.1726-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:806:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Wed, 12 May 2021 23:46:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73b6d3de-1381-47ae-0439-08d915a034f4 X-MS-TrafficTypeDiagnostic: SN1PR12MB2445: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: nfnwO+vgu9OIvxZU4euPGA9lT6qOgZJ+IQwXVMuJkCSr6Qsljwt+3jnIbFcARXdyXZBb8OhK4ZI/P0dE/+UEsQjSD3TXpFJVZwdMbGLwV0X0Qrb0epynoSftQOpG6s+FgL8CLultpvtJ6TXDxvbe68jrMuN/yJBDpxT6OvlG1Q7KNwuBO2qURCRwQcTrPN7DltVhCPbhTiyeyc3kyPrCWCDR8+ukMIIDtag48cV0Q+r/NYbFawX7DzYB1yw1fnguP/49YVSQUCa92hWnjDlZDaketFtEzBO4KGN3Fi5emALkP+IGYLX4v07OY7Cd0PJ3fb/g3bXN5Caun3C4fr4EncH0McGfwkxyKsRx5jvw6bX69ekLIvBuWM7HAltbWALkqDHgNpHLZt3aFtZRDAXCiDR3j+XuIOEcitAPoeGjCWNDJ9xQoPU32K3Rw/90RXc4NgQaiG//zXDMcfW4lh/cLyNAHe5oPeXqxK6Ftq+uEiyhOfbmFdUH7okwLtTxbPC69g70fdoHYyTLJVNvpc/J3yD4We81xzuig2Wbkun16FF0+iZi9VJM7cn4qTafUsMn+CNjuqCoJs9MjriLDv5wTa8RRvU0fGwG0CY1Gg3FQwHb54l7yDE11wXzToZefm8Gd8+rMpygQLpFCa3u8uRtbODjt13giYI45CZZ9t/k34rjbdMwjERigGYS4NbTKfJpKqznufLVyPLg5glGhfdAEBfxMAo/1bWe5E5BpBAWDfYGsgGQhoCnpUE/ZM3as8yrWkBv+ICZCCPtIsVEa1n1Tw== X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?P7d6TlqIy+UblwVlJ62KUgEwCZPSkLZsyYKUwds7lzEYbdHlW20pHk9wl2W9?= =?us-ascii?Q?xcAKXS/BjWgG1Z8zM31xSheo/NpeX/MsV8GakdB/nVnTbP4BKWV3aJ5hsuQn?= =?us-ascii?Q?KtacbTjxLFwnxKEi8akD5PKMzjZ2zXKpO+6s3x3CFbpRjt0d6c85mmxv5JdH?= =?us-ascii?Q?CRyCYVJaWUNVPeLyONjZmd8waMhC/RPVA9+gtVodUGNnmmrpUUccZHLOiGXs?= =?us-ascii?Q?iDDLdJwebbsiI6NQ7uDkN6P8ktCUDVTzYYBt7nUNuZY3FKpKh5b4+cwcPqia?= =?us-ascii?Q?zdIPxFjldJY53lh0tCL+5ltp/P26c89vh2HP3aC3gb3muh40C6cHF2Y8oQWb?= =?us-ascii?Q?t0S6gz5BDJ2ZmZzGqFE9B8/LaeZTzqNxVUoa8a37zXBnxeDnAoilHFghfy8I?= =?us-ascii?Q?jesd6POMJLwRmQ743BoJb8r3C/F8piuUbKFstXwN5ewogiAhMJNAQTjqGdzM?= =?us-ascii?Q?7a12MBx7Trmwcx/BBmmeh9E5nOefF3804sB0Yn2KXnmKAxfzlqa9HdnoOfxF?= =?us-ascii?Q?MJ3G/M8ou0L3i2Y/nR1CohjpvXHgA7WJAi3T5wXDBh1Fk1fOw/ztOwxWNHmQ?= =?us-ascii?Q?Y4YFMRwApwsnnoSratxqwmSu8PCxCSD2xSQoVW8ySV8ZPFiWsb2zpLiCYO0P?= =?us-ascii?Q?GhrhQ7iCfw5Shg+Z8yoDSO75f14g3LkTwDop+TT/1DExaA5owmqfP7809Ffr?= =?us-ascii?Q?LEuw2GTvxlRgqXL/L3ZkCRuH3GNUcRSKeXNCc+wmfr7QFs1pb0+Moz5PT1KQ?= =?us-ascii?Q?KztGg2JEjI1u/nXAdK1Ose9gzuxsxSgFiXFeSSOUMlck0woczkI45fcoFRVL?= =?us-ascii?Q?7QwrM4UpeDbmBHnDyAJRPAHk4/qklpIv1wXLCIpyTEtLru8Xsx2SLtClWyC/?= =?us-ascii?Q?v2m2RNI7DafS0DNO7kR3uaDmTgD68h9yrfneacJdNSJrcKzE4aS+Aha9ftjh?= =?us-ascii?Q?0w7mvD7HiOO0e3PsDeTKY9dx1XLBhN1huQLAqbtT2Cjm8xLrxpmzVkEhHE1N?= =?us-ascii?Q?EG1dLYlK3xrURjeN38alZ6TKFzEVYPMd2bFQRwqNrCvfVlUUaJfwPChJWPkP?= =?us-ascii?Q?6lIJuKj7b8ABnQgHL/3SimlFI2Y45VwiuyikIv+O0mpkzQGpimfKlllWR5eF?= =?us-ascii?Q?E9nSVNGJ4s4FmjDmLXKUgVU/3FWkHm9x2TXsqi4fjvCtmEcCTDRzhxCY0QTJ?= =?us-ascii?Q?Fh+A52L1uPH2vf8TDRd0nwocAHmuoj8ijWdWPbLm+rHaZnn8H3m3+hMrsrad?= =?us-ascii?Q?q3It4KiIRgEXXBdJz7HHx88A76xeY5ET2wWbRw2SNpHgNVoxDtAwv6Bpq6Zu?= =?us-ascii?Q?Kwu6drn7NTTXZLarwT4py4gh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73b6d3de-1381-47ae-0439-08d915a034f4 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 23:46:47.9262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 05hmuQ13fSWvYWz3al1MZ9pLSPdQn8ro9W8QwRiKBA7aYlpIloJIQyaSE1+8ckekfwkbaF3zREdo0dZcwSAcRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2445 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,brijesh.singh@amd.com X-Gm-Message-State: LypDfS9w0yVO9iYtDarKh1Jwx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620863221; bh=8F8P8d8GnuOz1KvoRVsRFss5T/Jy62nVUQWt6uIZ03s=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Ah+jzxwYj9u79poaxdX5q8piVMoZT1gZbo6AzU7MRpiFC3SnceR0DvcEpYFGzyKwaLO XLrg7H2EV+/KU0Y/tRtgzvf5ACrQoqO0suCxJ//3q0I3ohYUGntWYh7I8LlGyW9bgqz0F aHUMFXVDailLz60CVGGi6npHTt73BMJqQmI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The Flush parameter is used to provide a hint whether the specified range is Mmio address. Now that we have a dedicated helper to clear the memory encryption mask for the Mmio address range, its safe to remove the Flush parameter from MemEncryptSev{Set,Clear}PageEncMask(). Since the address specified in the MemEncryptSev{Set,Clear}PageEncMask() points to a system RAM, thus a cache flush is required during the encryption mask update. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Signed-off-by: Brijesh Singh Reviewed-by: Laszlo Ersek --- OvmfPkg/Include/Library/MemEncryptSevLib.h | 10 ++-------- .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 10 ++-------- OvmfPkg/AmdSevDxe/AmdSevDxe.c | 3 +-- OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 6 ++---- .../BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c | 10 ++-------- .../BaseMemEncryptSevLib/X64/MemEncryptSevLib.c | 16 ++++------------ .../X64/PeiDxeVirtualMemory.c | 14 ++++---------- .../BaseMemEncryptSevLib/X64/SecVirtualMemory.c | 8 ++------ .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 +-- OvmfPkg/PlatformPei/AmdSev.c | 3 +-- 10 files changed, 21 insertions(+), 62 deletions(-) diff --git a/OvmfPkg/Include/Library/MemEncryptSevLib.h b/OvmfPkg/Include/L= ibrary/MemEncryptSevLib.h index b91490d5d44d..76d06c206c8b 100644 --- a/OvmfPkg/Include/Library/MemEncryptSevLib.h +++ b/OvmfPkg/Include/Library/MemEncryptSevLib.h @@ -100,8 +100,6 @@ MemEncryptSevIsEnabled ( address of a memory region. @param[in] NumPages The number of pages from start memory region. - @param[in] Flush Flush the caches before clearing the= bit - (mostly TRUE except MMIO addresses) =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -114,8 +112,7 @@ EFIAPI MemEncryptSevClearPageEncMask ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS BaseAddress, - IN UINTN NumPages, - IN BOOLEAN Flush + IN UINTN NumPages ); =20 /** @@ -128,8 +125,6 @@ MemEncryptSevClearPageEncMask ( address of a memory region. @param[in] NumPages The number of pages from start memory region. - @param[in] Flush Flush the caches before setting the = bit - (mostly TRUE except MMIO addresses) =20 @retval RETURN_SUCCESS The attributes were set for the memo= ry region. @@ -142,8 +137,7 @@ EFIAPI MemEncryptSevSetPageEncMask ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS BaseAddress, - IN UINTN NumPages, - IN BOOLEAN Flush + IN UINTN NumPages ); =20 =20 diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h index 8dc39e647b90..21bbbd1c4f9c 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h @@ -58,8 +58,6 @@ InternalGetMemEncryptionAddressMask ( @param[in] PhysicalAddress The physical address that is the sta= rt address of a memory region. @param[in] Length The length of memory region - @param[in] Flush Flush the caches before applying the - encryption mask =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -72,8 +70,7 @@ EFIAPI InternalMemEncryptSevSetMemoryDecrypted ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS PhysicalAddress, - IN UINTN Length, - IN BOOLEAN Flush + IN UINTN Length ); =20 /** @@ -85,8 +82,6 @@ InternalMemEncryptSevSetMemoryDecrypted ( @param[in] PhysicalAddress The physical address that is the sta= rt address of a memory region. @param[in] Length The length of memory region - @param[in] Flush Flush the caches before applying the - encryption mask =20 @retval RETURN_SUCCESS The attributes were set for the memo= ry region. @@ -99,8 +94,7 @@ EFIAPI InternalMemEncryptSevSetMemoryEncrypted ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS PhysicalAddress, - IN UINTN Length, - IN BOOLEAN Flush + IN UINTN Length ); =20 /** diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c index 80831b81facf..c66c4e9b9272 100644 --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c @@ -120,8 +120,7 @@ AmdSevDxeEntryPoint ( Status =3D MemEncryptSevClearPageEncMask ( 0, // Cr3BaseAddress -- use current CR3 MapPagesBase, // BaseAddress - MapPagesCount, // NumPages - TRUE // Flush + MapPagesCount // NumPages ); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: MemEncryptSevClearPageEncMask(): %r\n", diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c index 49ffa2448811..b30628078f73 100644 --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c @@ -252,8 +252,7 @@ IoMmuMap ( Status =3D MemEncryptSevClearPageEncMask ( 0, MapInfo->PlainTextAddress, - MapInfo->NumberOfPages, - TRUE + MapInfo->NumberOfPages ); ASSERT_EFI_ERROR (Status); if (EFI_ERROR (Status)) { @@ -407,8 +406,7 @@ IoMmuUnmapWorker ( Status =3D MemEncryptSevSetPageEncMask ( 0, MapInfo->PlainTextAddress, - MapInfo->NumberOfPages, - TRUE + MapInfo->NumberOfPages ); ASSERT_EFI_ERROR (Status); if (EFI_ERROR (Status)) { diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c b= /OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c index 169d3118e44f..be260e0d1014 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c @@ -25,8 +25,6 @@ address of a memory region. @param[in] NumPages The number of pages from start memory region. - @param[in] Flush Flush the caches before clearing the= bit - (mostly TRUE except MMIO addresses) =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -39,8 +37,7 @@ EFIAPI MemEncryptSevClearPageEncMask ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS BaseAddress, - IN UINTN NumPages, - IN BOOLEAN Flush + IN UINTN NumPages ) { // @@ -59,8 +56,6 @@ MemEncryptSevClearPageEncMask ( address of a memory region. @param[in] NumPages The number of pages from start memory region. - @param[in] Flush Flush the caches before setting the = bit - (mostly TRUE except MMIO addresses) =20 @retval RETURN_SUCCESS The attributes were set for the memo= ry region. @@ -73,8 +68,7 @@ EFIAPI MemEncryptSevSetPageEncMask ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS BaseAddress, - IN UINTN NumPages, - IN BOOLEAN Flush + IN UINTN NumPages ) { // diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c b/= OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c index a2bf698bcde7..a57e8fd37fa7 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c @@ -27,8 +27,6 @@ address of a memory region. @param[in] NumPages The number of pages from start memory region. - @param[in] Flush Flush the caches before clearing the= bit - (mostly TRUE except MMIO addresses) =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -41,15 +39,13 @@ EFIAPI MemEncryptSevClearPageEncMask ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS BaseAddress, - IN UINTN NumPages, - IN BOOLEAN Flush + IN UINTN NumPages ) { return InternalMemEncryptSevSetMemoryDecrypted ( Cr3BaseAddress, BaseAddress, - EFI_PAGES_TO_SIZE (NumPages), - Flush + EFI_PAGES_TO_SIZE (NumPages) ); } =20 @@ -63,8 +59,6 @@ MemEncryptSevClearPageEncMask ( address of a memory region. @param[in] NumPages The number of pages from start memory region. - @param[in] Flush Flush the caches before setting the = bit - (mostly TRUE except MMIO addresses) =20 @retval RETURN_SUCCESS The attributes were set for the memo= ry region. @@ -77,15 +71,13 @@ EFIAPI MemEncryptSevSetPageEncMask ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS BaseAddress, - IN UINTN NumPages, - IN BOOLEAN Flush + IN UINTN NumPages ) { return InternalMemEncryptSevSetMemoryEncrypted ( Cr3BaseAddress, BaseAddress, - EFI_PAGES_TO_SIZE (NumPages), - Flush + EFI_PAGES_TO_SIZE (NumPages) ); } =20 diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c= b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c index a18d336a8789..c696745f9d26 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c @@ -828,8 +828,6 @@ SetMemoryEncDec ( @param[in] PhysicalAddress The physical address that is the sta= rt address of a memory region. @param[in] Length The length of memory region - @param[in] Flush Flush the caches before applying the - encryption mask =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -842,8 +840,7 @@ EFIAPI InternalMemEncryptSevSetMemoryDecrypted ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS PhysicalAddress, - IN UINTN Length, - IN BOOLEAN Flush + IN UINTN Length ) { =20 @@ -852,7 +849,7 @@ InternalMemEncryptSevSetMemoryDecrypted ( PhysicalAddress, Length, ClearCBit, - Flush + TRUE ); } =20 @@ -865,8 +862,6 @@ InternalMemEncryptSevSetMemoryDecrypted ( @param[in] PhysicalAddress The physical address that is the sta= rt address of a memory region. @param[in] Length The length of memory region - @param[in] Flush Flush the caches before applying the - encryption mask =20 @retval RETURN_SUCCESS The attributes were set for the memo= ry region. @@ -879,8 +874,7 @@ EFIAPI InternalMemEncryptSevSetMemoryEncrypted ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS PhysicalAddress, - IN UINTN Length, - IN BOOLEAN Flush + IN UINTN Length ) { return SetMemoryEncDec ( @@ -888,7 +882,7 @@ InternalMemEncryptSevSetMemoryEncrypted ( PhysicalAddress, Length, SetCBit, - Flush + TRUE ); } =20 diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c b/= OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c index e0d3a15e8503..a155c8729bfb 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecVirtualMemory.c @@ -42,8 +42,6 @@ InternalGetMemEncryptionAddressMask ( @param[in] PhysicalAddress The physical address that is the sta= rt address of a memory region. @param[in] Length The length of memory region - @param[in] Flush Flush the caches before applying the - encryption mask =20 @retval RETURN_SUCCESS The attributes were cleared for the memory region. @@ -56,8 +54,7 @@ EFIAPI InternalMemEncryptSevSetMemoryDecrypted ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS PhysicalAddress, - IN UINTN Length, - IN BOOLEAN Flush + IN UINTN Length ) { // @@ -89,8 +86,7 @@ EFIAPI InternalMemEncryptSevSetMemoryEncrypted ( IN PHYSICAL_ADDRESS Cr3BaseAddress, IN PHYSICAL_ADDRESS PhysicalAddress, - IN UINTN Length, - IN BOOLEAN Flush + IN UINTN Length ) { // diff --git a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/OvmfPk= g/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c index fdf2380974fa..c7cc5b0389c8 100644 --- a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c +++ b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c @@ -283,8 +283,7 @@ SmmCpuFeaturesSmmRelocationComplete ( Status =3D MemEncryptSevSetPageEncMask ( 0, // Cr3BaseAddress -- use current CR3 MapPagesBase, // BaseAddress - MapPagesCount, // NumPages - TRUE // Flush + MapPagesCount // NumPages ); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: MemEncryptSevSetPageEncMask(): %r\n", diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index dddffdebda4b..a8bf610022ba 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -72,8 +72,7 @@ AmdSevEsInitialize ( DecryptStatus =3D MemEncryptSevClearPageEncMask ( 0, GhcbBasePa + EFI_PAGES_TO_SIZE (PageCount), - 1, - TRUE + 1 ); ASSERT_RETURN_ERROR (DecryptStatus); } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75090): https://edk2.groups.io/g/devel/message/75090 Mute This Topic: https://groups.io/mt/82787295/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-