From nobody Fri Mar 29 12:40:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74681+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74681+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1619816879; cv=none; d=zohomail.com; s=zohoarc; b=SyJYbnrdHiYCJJkufjhwLznUKAEc/HirN9Nygc5MpV4GST38lVf6R8q6i9fAQVYG36zDclDD5j8BvTaqFVK7Nf2PG/FOqpEVi5k7N7CNEjJlGWlSSYPDPtXiK6B2TEAu7uncPKolCoKMyYfOwcPRdSIVjUQ3+YLKRkz5waXLn9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619816879; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=DuZBd8KyimjzPb33zuWeWk1xqRXqoatnrp3fwTB/9Ws=; b=Xv6twgKsMZlZED6K+Bqlwcaazxq0ab5s9niMYXGHfRD90RNT7TyDxZTCuh8J6f3J9kYtWR4LR/r9eCUqkamu/GAgbI++ay/PcUR/UlcxsQx1fEjOq+pl9DEjOgZ8fSFdPN3EE9s4TYsUwEwdEEnPfMPVVR6OO2ypnDhH10B+scw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74681+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1619816879451933.4234498991699; Fri, 30 Apr 2021 14:07:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KCbhYY1788612xmQKO6uSLkY; Fri, 30 Apr 2021 14:07:59 -0700 X-Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mx.groups.io with SMTP id smtpd.web10.4305.1619816878466210976 for ; Fri, 30 Apr 2021 14:07:58 -0700 X-Received: by mail-qk1-f180.google.com with SMTP id a2so2370581qkh.11 for ; Fri, 30 Apr 2021 14:07:58 -0700 (PDT) X-Gm-Message-State: CRs4TXU0Z8jxbzYwftEebvezx1787277AA= X-Google-Smtp-Source: ABdhPJwPKMLWEDtrPyICX+oYnaNTUOvv3+MrwBNYnGw1aZkVGJH4FPdpU+Oa/pLlt+FfPNYtrolIeg== X-Received: by 2002:a37:b5c5:: with SMTP id e188mr7527133qkf.144.1619816877425; Fri, 30 Apr 2021 14:07:57 -0700 (PDT) X-Received: from localhost.localdomain (ip72-205-56-117.dc.dc.cox.net. [72.205.56.117]) by smtp.gmail.com with ESMTPSA id w4sm3135233qti.6.2021.04.30.14.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 14:07:57 -0700 (PDT) From: "Getnat Ejigu" To: devel@edk2.groups.io Cc: Michael D Kinney , Sean Brogan , Bret Barkelew Subject: [edk2-devel] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Date: Fri, 30 Apr 2021 17:07:49 -0400 Message-Id: <20210430210749.1112414-2-getnatejigu@gmail.com> In-Reply-To: <20210430210749.1112414-1-getnatejigu@gmail.com> References: <20210430210749.1112414-1-getnatejigu@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,getnatejigu@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1619816879; bh=8J3xYWfghjjXqmOY2epGawlcmNP7xaerl8HU6AvXO9U=; h=Cc:Date:From:Reply-To:Subject:To; b=INx1QNNWp9OZ2WiTVwYlrfW4A6V+xxcvaV50jwlMH4q+L/u8KHT65GYgC+v4Om73NJC B8n2bpRAAlDP2wnReNrtjglpCr5k0cNNR5H+IzclIrHhoFRBRAK/lFBVSu0ul//B2sUBA zj0H9eFkfaPpJCg/JYKa89feH18Ajj0VS1E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Reviewed-by: Bret Barkelew > Reviewed-by: Bret Barkelew Reviewed-by: Bret Barkelew Reviewed-by: Michael D Kinney mailto:michael.d.kinney@intel.com Reviewed-by: Michael D Kinney michael.d.kinney@intel.com --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ib.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ibConOut.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportL= ibDebugLib.c | 1 + 3 files changed, 3 insertions(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/Uni= tTestResultReportLib.c index 66c9db457d80..7f7443a23391 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLib.c @@ -11,6 +11,7 @@ #include =20 VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportL= ib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c @@ -12,6 +12,7 @@ #include =20 VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultRepor= tLib/UnitTestResultReportLibDebugLib.c index 1402d0ef83e2..1d62c6a37117 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibDebugLib.c @@ -11,6 +11,7 @@ #include =20 VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74681): https://edk2.groups.io/g/devel/message/74681 Mute This Topic: https://groups.io/mt/82491973/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-