From nobody Tue Feb 10 11:23:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74516+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74516+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1619605488; cv=none; d=zohomail.com; s=zohoarc; b=NtnQLs/Xc8dWVIxvXI7p8QsEaHsfcq1tC3GZls5t4pfxOCQ+vC+1+CIhdVv7M7CADXXx14KeojaReNb2vITJCRThjcH0sc8mU9wl12FNBMCp/A9ps8U8KgG14q7vV6dDT8dl8btk5DpbsH7C2ANAzDnPo+jnoWD/8LgUHD4LBJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619605488; h=Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=/nREel3ukPd54albs6De7Es9tUm3xoxtDuNtbmucSy4=; b=IoemMud04HitflVYNUklNh7zT3pdCqHLqm5THHXqhcs5ajbjbE3UQ4alFRTaCVAhw4rVJBgRDJhi0PrFPUmfiUm4IMfo+o8WuqzxvqAXVyNVAjKifgkemi2IYLfI8If1k3hZrbjDLrE5bRRxKZZwpqDUrDc+jG0xAMsPyUHoFYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74516+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1619605488058341.4064366904722; Wed, 28 Apr 2021 03:24:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id eKxvYY1788612xqrVFtqOH02; Wed, 28 Apr 2021 03:24:45 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.9892.1619605254637373521 for ; Wed, 28 Apr 2021 03:20:54 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A01A1042; Wed, 28 Apr 2021 03:20:54 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.1.97]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B33B23F70D; Wed, 28 Apr 2021 03:20:52 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, sami.mujawar@arm.com, leif@nuviainc.com, ardb+tianocore@kernel.org, sean.brogan@microsoft.com, Bret.Barkelew@microsoft.com Subject: [edk2-devel] [PATCH v3 02/15] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib Date: Wed, 28 Apr 2021 11:20:07 +0100 Message-Id: <20210428102020.2311-3-Pierre.Gondois@arm.com> In-Reply-To: <20210428102020.2311-1-Pierre.Gondois@arm.com> References: <20210428102020.2311-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: bdnCYzYktdg62B6OmOKbYhnWx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1619605485; bh=VVEd782TDiBXHw6g2VNgr7UcP6MS9WfntXXeK3DFeJo=; h=Date:From:Reply-To:Subject:To; b=MsUGBlNuM/TcDg7sHuJgonwHy64KJ6fVZhq3ZRSv5T2nf3//KE/aA7PK8itqIAff0x/ FsUfX73f4Mp3t1kBWcCudoCFT1DSLT/SIy2MleHfKpD+4vBzWbYQn0U2M+bIpxIHtNILD qF1atHMyCDf/lM5+lS5wb9+1VYL/oOJSYkU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLi= b.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c index 5f453d18e415..31672ae5cf4d 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c @@ -101,7 +101,7 @@ SendMemoryPermissionRequest ( } =20 // Check error response from Callee. - if (*RetVal & BIT31) { + if ((*RetVal & BIT31) !=3D 0) { // Bit 31 set means there is an error retured // See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and // Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74516): https://edk2.groups.io/g/devel/message/74516 Mute This Topic: https://groups.io/mt/82426076/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-