From nobody Tue Feb 10 04:53:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74474+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74474+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1619537590; cv=none; d=zohomail.com; s=zohoarc; b=TFLRyEIMsNYfoH7DeHeGx54bKIAranmP7qG8j3lX5h8wBNKKpf+G9dhCi8va1raOf+V5bCQYFFolmx5areDQiOhswE7DnJlIkirM6VyAVzs5pgf8TLZITl3HbuqoZds5/pw8MuSquwVHIn+sBS4P+8igo9Fgra8M/aptLy9u3Hw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619537590; h=Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=hNVnh+5a1QYnyXyJSqckV62zG/TOz4Hvau7QZRvC5UQ=; b=B4GpJu5BTWClJqa2+jF5FVGqgYuxNKDK32g859sfnaLt3+xyGLc9K4YlPS7Ukm0vQS2/mFWGsN2jCxqdfDpTuKsgMyWPvBWK2mq7FVRg5ybeLRAKVxlE1ApEMIz80elm6no6ju9+3ZgTcqB3LVN1ie0y7GDYzdHTHM4oTPpLHNc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74474+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1619537590360464.1125383640409; Tue, 27 Apr 2021 08:33:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id GhN2YY1788612xGiJBQ44p6g; Tue, 27 Apr 2021 08:33:09 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.9864.1619537580819044754 for ; Tue, 27 Apr 2021 08:33:00 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76AA031B; Tue, 27 Apr 2021 08:33:00 -0700 (PDT) X-Received: from e120189.arm.com (unknown [10.57.3.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 06BD03F73B; Tue, 27 Apr 2021 08:32:58 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, sami.mujawar@arm.com, leif@nuviainc.com, ardb+tianocore@kernel.org, sean.brogan@microsoft.com, Bret.Barkelew@microsoft.com Subject: [edk2-devel] [PATCH v2 02/15] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib Date: Tue, 27 Apr 2021 16:32:38 +0100 Message-Id: <20210427153251.11576-3-Pierre.Gondois@arm.com> In-Reply-To: <20210427153251.11576-1-Pierre.Gondois@arm.com> References: <20210427153251.11576-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: HoWG3lytBpneBpN61DEUzmAXx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1619537589; bh=WpS5TAqOm+pi9dn0mWN3caOSESOTRnX89jzFGfznMrM=; h=Date:From:Reply-To:Subject:To; b=Q10tmPFjZNpmTnJlUdf8yxUQPm/SUaLkLv2jsGK8T/Ll7ui4B1CcmvXrxA6ridaeuhl c0uUmS2XCWWuiWSdeuIhAIdZI+GMSQY7TbdT3ZzzdV/uv1Ep6CQhyTZ+zr23SB0l3NriE A2YRVrIF6ULnNvbiHqn1cxGeyE+aqy1SUNc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLi= b.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c index 5f453d18e415..31672ae5cf4d 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c @@ -101,7 +101,7 @@ SendMemoryPermissionRequest ( } =20 // Check error response from Callee. - if (*RetVal & BIT31) { + if ((*RetVal & BIT31) !=3D 0) { // Bit 31 set means there is an error retured // See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and // Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74474): https://edk2.groups.io/g/devel/message/74474 Mute This Topic: https://groups.io/mt/82406639/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-