From nobody Tue Apr 16 23:32:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74405+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74405+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1619361709; cv=none; d=zohomail.com; s=zohoarc; b=e9AnCShGarov9CdJgAEPQtv5L5Y0QwW3Jgutim96QH8aFCgjkFwIW70XUiGMsfeFqSuFqiAZT/4DBHnFFpzxMIbwo3W59AqNtMuBvH4KmkkV/m1KBcPjnrU6HdbUGglV3m2CD9l3nvoMW5yXI7AuhBTg1dvy21BGHyQvtAJhBJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619361709; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=vAlmmj6FDMGpEWLnsbJ4ATMjxv8V+pEprMUIWuOsB2U=; b=l36xMLGnBsnAURVATdr9RHvJm3G8WECXfnD+8Cur09O/OSrcKV8SwBW1FQtqkL43qOmAUFzhwDO2hAjTfjuJFbpK54+DTYv7g2BwnDeXdragsb3NdTladJUPWxkh1EZv0ovdqird6rGsJQ231Thjj8C+to8Zhnev1+ttem9OW+0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74405+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1619361709571699.2189336519474; Sun, 25 Apr 2021 07:41:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id N9iKYY1788612xxsX7aA4sCS; Sun, 25 Apr 2021 07:41:49 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.2136.1619361705450113277 for ; Sun, 25 Apr 2021 07:41:47 -0700 IronPort-SDR: 7oMgobiY8ksMK7OGwgoLaRRInLu5mo7vrECV1zVO8PwiLX9sKHhwnjh8UxGZNTo9mW78NbJ0YS pGulslSkYZiA== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="216931737" X-IronPort-AV: E=Sophos;i="5.82,250,1613462400"; d="scan'208";a="216931737" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2021 07:41:43 -0700 IronPort-SDR: dOM9v/cfifG/CgEkW7zV2qWaN4SKF609GgWhK5D51hNovgL5Ih0hCO0exA4XJFfCP97Sj1jRiS PU8T4h7LzPNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,250,1613462400"; d="scan'208";a="429053643" X-Received: from shwdeopenlab102.ccr.corp.intel.com ([10.239.183.74]) by orsmga008.jf.intel.com with ESMTP; 25 Apr 2021 07:41:41 -0700 From: "Jason Lou" To: devel@edk2.groups.io Cc: Jason Lou , Chasel Chiu , Nate DeSimone , Star Zeng , Ray Ni Subject: [edk2-devel] [PATCH v1] Intel/CometlakeOpenBoardPkg: Simplify microcode related PCD usage Date: Sun, 25 Apr 2021 22:41:34 +0800 Message-Id: <20210425144137.16411-1-yun.lou@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yun.lou@intel.com X-Gm-Message-State: tVH4hCujVnlatisryzAsMsikx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1619361709; bh=e0QwoDuo6YYV0eMaTjOEqNjmCvbDHc+3jBPk/U0GHiA=; h=Cc:Date:From:Reply-To:Subject:To; b=lXnO5rAqukW4hMmfTBxsYs1u3835/axLVl/OhtvQRMX/BgBQyDC5uykh5bhcguo4tjy H524X1pdRuZuxwmEDcgakO4lRhChoSV1XXL9sTyZWNrCG1OqXnhGrHfrQvcKPvkT90HE1 kL1LUvA9mxxbJI2INTDUnJtv4fM7BBOxUcE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Jason Lou REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3334 There are following PCDs in IntelFsp2WrapperPkg for microcode location: * IntelFsp2WrapperPkg: PcdCpuMicrocodePatchAddress PcdCpuMicrocodePatchRegionSize PcdFlashMicrocodeOffset The change simplify the platform code to use following PCDs instead: * MinPlatformPkg PcdFlashFvMicrocodeOffset PcdFlashFvMicrocodeBase =3D $(BIOS_BASE) + PcdFlashFvMicrocodeOffset PcdFlashFvMicrocodeSize PcdMicrocodeOffsetInFv Signed-off-by: Jason Lou Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ray Ni Reviewed-by: Chasel Chiu --- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | 6 ++= ---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.fdf b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf index 31f4d22311..795cc0da75 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf @@ -2,7 +2,7 @@ # FDF file of Platform. # # -# Copyright (c) 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -47,9 +47,7 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase =3D $(gS= iPkgTokenSpaceGuid.PcdBio SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize =3D $(gSiPkgTokenSpaceGui= d.PcdFlashMicrocodeFvSize) SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D $(gSiPkgToke= nSpaceGuid.PcdFlashMicrocodeFvBase) + 0x60 SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D $(gSiPkgT= okenSpaceGuid.PcdFlashMicrocodeFvSize) - 0x60 -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D $(gSiP= kgTokenSpaceGuid.PcdBiosAreaBaseAddress) + $(gSiPkgTokenSpaceGuid.PcdFlashM= icrocodeFvOffset) -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D $(g= SiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) -SET gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset =3D 0x60 +SET gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv =3D 0x60 SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase =3D gSiPkgTok= enSpaceGuid.PcdFlashMicrocodeFvBase SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize =3D gSiPkgTok= enSpaceGuid.PcdFlashMicrocodeFvSize SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset =3D gSiPkgTok= enSpaceGuid.PcdFlashMicrocodeFvOffset --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74405): https://edk2.groups.io/g/devel/message/74405 Mute This Topic: https://groups.io/mt/82355105/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-