From nobody Thu Apr 25 15:59:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74189+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74189+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1618541257; cv=none; d=zohomail.com; s=zohoarc; b=LhFHywYYmYzBwR1tE0zgfirBnbLJdG0qmrBqiRfck5GXoSh3Wn1R6UEz7zvrFiGHccTOdgl4KzQRnGa1i6MK4w3bmEVlCGft3LZ/2SkHY/A3bfOn22AFi4Go+JZ1MCOPsg99TvSJKOG/dNOayQl57J97ho7NyjGRvlOOqbZQPEU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618541257; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=iqiZjCClDVOLn7N/NXXZLkmOG1zuMWogJZhxHWfaX30=; b=Uf1GFTHhUd5QlQ/98wDo9STxlxJW4UxWA8gEiRBvNn+eOt7vKXtIESwObrVlxTtDFQwov0NGowqTzOw5tYQrgNuOeHXbKwpOTLiqLXQS16DnYPwkF3PmuJ+4cI9NHR0uqQUJRdm0kEFYysqR6Xl1iY2aCmV6BOAPzhUh3HMCmR0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74189+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618541257774943.822219498579; Thu, 15 Apr 2021 19:47:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0k6PYY1788612xFK5Evp3Pvc; Thu, 15 Apr 2021 19:47:37 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.3950.1618541255333811076 for ; Thu, 15 Apr 2021 19:47:36 -0700 IronPort-SDR: YbrUgcUWgIsvOF+aoM6+L3jB/j0FhBPh18JkGUaeZqa0wdzJ8kigwv+rS5Uj+UmecjnvI3d554 8bRo01az1qAQ== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="175087281" X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="175087281" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 19:47:33 -0700 IronPort-SDR: PC8xK7Tm+m/sXoCvuOzsLNI0aSkyFg9O+hRXBO9j6y8t5pYeAJYg1iZt3PMYMY7CP+UIg4fvGe aBzmgdj7fXVA== X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="522579580" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.209.106.94]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 19:47:33 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Liming Gao , Eric Dong , Michael Kubacki , Isaac Oram Subject: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib Date: Thu, 15 Apr 2021 19:47:17 -0700 Message-Id: <20210416024717.717-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: oPd2tbQjyXVIrVwdAQZ5IRv1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618541257; bh=N22i3vZ+O/ZJ0iMp1iHX01oNMeK5iAiaaoqsUSpSyTs=; h=Cc:Date:From:Reply-To:Subject:To; b=DmzywnSZcY4vg/XZ+ne0hmDwitmCtMvQTAfKB0N2P9+5lSFaOafAT6Igwiq+IzirbEt LWST5rV9wa/mrJzq4n9GmG3UWqusK+uTsPS2i0fSp7eyExOneF6UM4dCDNDsmzyUocs8i Y8RR/rgk6rHcVHENtWBwWpUpCpx5m60PB5E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" With all the refactoring done during code review, I misplaced the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back. Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki Cc: Isaac Oram Signed-off-by: Nate DeSimone Reviewed-by: Michael Kubacki --- .../Library/BaseLargeVariableLib/LargeVariableCommon.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/Lar= geVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariabl= eLib/LargeVariableCommon.h index b6554764b7..d6db9f6c66 100644 --- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVaria= bleCommon.h +++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVaria= bleCommon.h @@ -44,4 +44,11 @@ // #define MAX_VARIABLE_SPLIT_DIGITS 6 =20 +// +// On some architectures (Ex. Itanium) there a requirement to +// maintain DWORD alignment of the variable data. Hence the +// maximum possible padding size is 3. +// +#define MAX_VARIABLE_NAME_PAD_SIZE 3 + #endif // _LARGE_VARIABLE_COMMON_H_ --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74189): https://edk2.groups.io/g/devel/message/74189 Mute This Topic: https://groups.io/mt/82134143/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-