[edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib

Nate DeSimone posted 1 patch 1 month ago
Failed in applying to current master (apply log)
.../Library/BaseLargeVariableLib/LargeVariableCommon.h     | 7 +++++++
1 file changed, 7 insertions(+)

[edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib

Posted by Nate DeSimone 1 month ago
With all the refactoring done during code review, I misplaced
the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../Library/BaseLargeVariableLib/LargeVariableCommon.h     | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
index b6554764b7..d6db9f6c66 100644
--- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
+++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
@@ -44,4 +44,11 @@
 //
 #define MAX_VARIABLE_SPLIT_DIGITS   6
 
+//
+// On some architectures (Ex. Itanium) there a requirement to
+// maintain DWORD alignment of the variable data. Hence the
+// maximum possible padding size is 3.
+//
+#define MAX_VARIABLE_NAME_PAD_SIZE  3
+
 #endif  // _LARGE_VARIABLE_COMMON_H_
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74189): https://edk2.groups.io/g/devel/message/74189
Mute This Topic: https://groups.io/mt/82134143/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib

Posted by Michael Kubacki 1 month ago
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/15/2021 7:47 PM, Nate DeSimone wrote:
> With all the refactoring done during code review, I misplaced
> the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>   .../Library/BaseLargeVariableLib/LargeVariableCommon.h     | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> index b6554764b7..d6db9f6c66 100644
> --- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> +++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> @@ -44,4 +44,11 @@
>   //
>   #define MAX_VARIABLE_SPLIT_DIGITS   6
>   
> +//
> +// On some architectures (Ex. Itanium) there a requirement to
> +// maintain DWORD alignment of the variable data. Hence the
> +// maximum possible padding size is 3.
> +//
> +#define MAX_VARIABLE_NAME_PAD_SIZE  3
> +
>   #endif  // _LARGE_VARIABLE_COMMON_H_
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74190): https://edk2.groups.io/g/devel/message/74190
Mute This Topic: https://groups.io/mt/82134143/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-