From nobody Sat Apr 20 13:42:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74130+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618489164444523.2686024285887; Thu, 15 Apr 2021 05:19:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZikBYY1788612xxACMm6RSu5; Thu, 15 Apr 2021 05:19:24 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.83]) by mx.groups.io with SMTP id smtpd.web09.6032.1618489163083325453 for ; Thu, 15 Apr 2021 05:19:23 -0700 X-Received: from DB6PR0202CA0044.eurprd02.prod.outlook.com (2603:10a6:4:a5::30) by AS8PR08MB7128.eurprd08.prod.outlook.com (2603:10a6:20b:403::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 12:19:20 +0000 X-Received: from DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::a1) by DB6PR0202CA0044.outlook.office365.com (2603:10a6:4:a5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74130+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT044.mail.protection.outlook.com (10.152.21.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:20 +0000 X-Received: ("Tessian outbound 700fd1fc53d5:v90"); Thu, 15 Apr 2021 12:19:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c299fc0c0d0acf55 X-CR-MTA-TID: 64aa7808 X-Received: from f06e0407e91c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 98ED649F-9BB0-4903-AF03-270B3CD9FD76.1; Thu, 15 Apr 2021 12:19:14 +0000 X-Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f06e0407e91c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Apr 2021 12:19:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ftmNHNxq8rn7AxI9Ob3bkBPjkaW4sR4LNJOYNbqsUWgx5e4TDGRPzLAoz5KVbTg2Tvu5B78zb57LSMjgNjJ0znWpHXj5bppGXUy6TSM2FW9VUrwv+4A7s084o3ND3S65OdCrdWePau/XC4VogDD3Vuol3iDcxq5O34LIJ7ECrQRZP+IFuKJnZlHdV+vqqSrJSiVy5nNgjZg+XJWmywHceWoMLu4OnWh7TCrbE0B1qQDIDFZnQe7wWH7+B2Ufnz9Kyz3ldtWYuyZRbM9nPurupSQeFz6x2HX8kVU9tqW1qKyxKIs3tSrD2M2FnxJgURG/DEZcMc0KBmDWuLknR2KXXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NMfGTURac5I1R/LV5tg3kfEoh07Jp8WkmBDHOY4PsfM=; b=oJNg+BP8D4aL6FmzVfZZr7I2VY//2t/xiGafHEdvOo+puGnI9joucasy07AikX97FJZGvJ3Yx8SBr0VYUrK3YpdG8tjmYQZ6AHAOXG0qjENvmRUrMOvmXTiRPENoSIRKh8Kl5c2btOGFvnYdBd9WLBip4b9GtuitSE3iX3i/WKCaoDMZbV1bkUGuRJ1fADpMZMyT7sgd6dXM6CMTwUUwM8SpU1CIZ+GSWJdV//GHd8xLecnAevr8DNuwzRHY4//7/KNu6TlpeFN75dUSD1Zt3Z4NiVlju3Tt78ojKZhTWyBjj+aSp6e+mPD6aft1+Gy43XHY/8ehibRRAA3ys0aQPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM5PR0601CA0045.eurprd06.prod.outlook.com (2603:10a6:203:68::31) by PAXPR08MB6622.eurprd08.prod.outlook.com (2603:10a6:102:153::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 12:19:07 +0000 X-Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::6a) by AM5PR0601CA0045.outlook.office365.com (2603:10a6:203:68::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18 via Frontend Transport; Thu, 15 Apr 2021 12:19:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:06 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 15 Apr 2021 12:18:51 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 15 Apr 2021 12:17:20 +0000 X-Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 15 Apr 2021 12:17:20 +0000 From: "Joey Gouly" To: CC: , , , Subject: [edk2-devel] [PATCH v1 1/4] ShellPkg: Rename Address Size to Access size Date: Thu, 15 Apr 2021 13:17:17 +0100 Message-ID: <20210415121720.11553-2-joey.gouly@arm.com> In-Reply-To: <20210415121720.11553-1-joey.gouly@arm.com> References: <20210415121720.11553-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1fbf709-94b6-4a98-2681-08d90008b27c X-MS-TrafficTypeDiagnostic: PAXPR08MB6622:|AS8PR08MB7128: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:626;OLM:626; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: s/SYt3o2Eik/dE+t3HoTkOokhkvWIneNxmX+JSZGAlMInaBmXEnZaYUu82yC4FcuVpHTioQcO7PV2eEzKGb7GKH2F4eoL356/t3OBIbhUCZvAxhayFsJ463IB0we50gh74NM6dCaYAKOVdHi2YqVds3bhanGO2crjhzDd5TGKvzHQ/YpdeHswVH7gChdYMNniNauoIq4WUVX2xSEIE2SKGJN0LlEfMFiCrb4nHrpzXsFknfIhgxMrV4dGV0OkW/JvLPPmoLoWCcYUMSsGr4avNIHyXCwe28u9qerUC79s1ZHUs0MgNYaxR/vVPbgwyBtVI1niSZQiOwqZSvi3x7h3YMqPeXUlsn8DVTvZjqiKk0kYDy1+Zmwz5dIQAd+uMuv1JM9BmnEnZ8E6eSPwejOJ+4IKKWADuJA7WVoeveLWkKTTu9cOMzQEDnYsB2/UowA6Vgkky0KIKYNiCOCn1KfQbSvZaDs/I8JhRbZbrPliXNku0HDQuBWXPdb98+wONhbgNcB+dWK052WxzFMAeySHcTdcazOkDQ2maq+MAeazDlukac3hHQ5LxSRp0T2+iFWuFgdIO1kJj5kLdioulyZ0IPJCuxbKqYkyA9AfF8e+MN+RqQIrHyo2vgVq2AR02MjA6u6XnH6riK8QrbHuBz/6MxAbEWPJrAC0PRNTwaz0k+RC8BaDFjMi11mtR/0kPEI X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(39860400002)(376002)(36840700001)(46966006)(356005)(186003)(83380400001)(6916009)(1076003)(54906003)(82740400003)(81166007)(316002)(426003)(5660300002)(478600001)(70586007)(2906002)(26005)(47076005)(336012)(2616005)(36860700001)(70206006)(36756003)(8676002)(82310400003)(86362001)(8936002)(44832011)(4326008)(6666004)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6622 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 07e36171-8b94-482d-b641-08d90008aa83 X-Microsoft-Antispam-Message-Info: DyQtuB7MPKgz0bbDRPhSS63EX7nt1LSI2tDhxy5lNF/vYLL5S9leLJXniQKmY3oHtgXZ++taTSlkBRal0aopFwf7WLKotBc/E4Pxd3dinbrRKWm2Qz95OJb3FACk70pvqCoEfTYpSKdjuIDQ0I8T6OtxnBp2GNRVKo8aCgPFCYBf6uAy2goDRAkoZdj1Z22o5hBw0FYWIG19CLw/t5T1iaPd9iU5Wq6VP4YBAULjNlNg2VNcmdwN1wr1JVVm/ysU8656NK1AgxeI/98p7MlQEgQPGAo+RqprNGaUvT2HPg0LxjTku/pZYY7YGOYZiahVgGETFUig7zWu2FIyva2sz2l4nlcfddZ4Fk4gy9yiy18NSou3VgJ+lJdhdTYOF0TxUeEeWTomU4/yjTCk5t18n6u0F78oQP1GqAup5+mlNNlxw1l1oWh5iSwGyfK/2iT2pJA+GPjNB7GJ3i/3l4LVw7JBkG6qH8cSD7Yb20wDNgOOnCJDu3qMbQQ4S5aIRBWwC1YDs8CVcc07APKeDd1guvJuspuVQFVpFJtwlrTuXdzWoZBS6Oa6s7NdP6eVEbNuNmlNJbKP8d1gFhJ3+yWFOEAeD2GCSUvj1UjU+WN5XLQhZhQpvRYBhAmKEtOCFXv7Mm6+OxP1PvFcjH2vNLSL+Q== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 12:19:20.3735 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1fbf709-94b6-4a98-2681-08d90008b27c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7128 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joey.gouly@arm.com X-Gm-Message-State: z3mFQVaJP6ATXcTMzsyf3Fpbx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618489164; bh=zhORNBXZ+qODyor/pSXUbSWkB7sdOaEyqzchAB/wdu4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=uYk7evSwLpCPNJqpdDdGAUSjI8Y8hqmW4Pg2Pj/j/eb87KbPN4iOuri/9pco+gWyb94 CMWh9llUfsYDU5REYVySPblZHMZwbW8rxLRCprpQ0pRVDyCVdfYCFpGJbBRXLE+Wsvg4w pxNkFW2ZTTyxRlUnfgi+MCh8mB0pcrlQBzA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This matches the ACPI spec 6.3, table 5.1: Generic Address Structure. Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 01ac9a9bafeb2ca12c1ba19f406d626b108f5fe2..74056e72c359c732758563a9fe1= 4ff2582f39f21 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -1,7 +1,7 @@ /** @file ACPI parser =20 - Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -628,7 +628,7 @@ STATIC CONST ACPI_PARSER GasParser[] =3D { {L"Address Space ID", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, {L"Register Bit Width", 1, 1, L"0x%x", NULL, NULL, NULL, NULL}, {L"Register Bit Offset", 1, 2, L"0x%x", NULL, NULL, NULL, NULL}, - {L"Address Size", 1, 3, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Access Size", 1, 3, L"0x%x", NULL, NULL, NULL, NULL}, {L"Address", 8, 4, L"0x%lx", NULL, NULL, NULL, NULL} }; =20 --=20 Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74130): https://edk2.groups.io/g/devel/message/74130 Mute This Topic: https://groups.io/mt/82115122/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Apr 20 13:42:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74127+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618489159939171.51583286111327; Thu, 15 Apr 2021 05:19:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id NdbMYY1788612xQDsnMfAfTW; Thu, 15 Apr 2021 05:19:19 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.42]) by mx.groups.io with SMTP id smtpd.web11.6046.1618489158649815468 for ; Thu, 15 Apr 2021 05:19:19 -0700 X-Received: from AM5PR0701CA0067.eurprd07.prod.outlook.com (2603:10a6:203:2::29) by PR3PR08MB5801.eurprd08.prod.outlook.com (2603:10a6:102:81::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 12:19:15 +0000 X-Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::c0) by AM5PR0701CA0067.outlook.office365.com (2603:10a6:203:2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.6 via Frontend Transport; Thu, 15 Apr 2021 12:19:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74127+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:15 +0000 X-Received: ("Tessian outbound 81a4524e9a48:v90"); Thu, 15 Apr 2021 12:19:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0f94f8ccb76b1f2e X-CR-MTA-TID: 64aa7808 X-Received: from 98d844cbb443.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AEB6A7AD-71CB-4682-A7D8-EEB604F8730F.1; Thu, 15 Apr 2021 12:19:08 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 98d844cbb443.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Apr 2021 12:19:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=idkHcjgQTHac/Vdt4c1i4MCwEAISwx26Q9SOLVHGq79xvJxXBrZD3pVZp+4JK7MsdyxVFNg+TRMZJcTj2Yy/RtDh40XEAa4Wn9YSzLSHiDCLTrvS2ZrpWJHonZGkY+mVD/7K0M6f16lvUPZ88OFTmOKi/FM8yWvGzxf7PCTC43oK8MGfJmVBFRwSoUXfE6flb6ssDVKllZoPxMYERHREtAeyWPk99N97UcKgaq/o1tEa8hcjL7JwMVOeAqPh1msZoxxXpW925N7qGOVszLHFyk77wHdZRSw5FJaAVsbspDeORpO7uYmnqo8K0lypNTUSPk2d5tIfpj6KCVObkq9bkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AVYXWbhRpgk1sXgPv4LtXuImcn7trRrlTNJJPS8b+NM=; b=MdwNB7bne2yWtKeSTTalSjN43xJkbChCuXOXs7kp9CvvFlugm7FUTLmjc8KcnMUCo3hCWLDg+8VMX99bnMZq5w6jKH4wc6fkfuVfEJiO993XzYLIC0PC3zLNZt5tYe8AepyJl6eIabsbJuY7XCGEm2ZiaMxvCmqfag79jWT+e0joMK8hgnV9KtpASWCOrIoUxL2aaOhYlU/79sdmwBvgCsZpUhoHyeaBr2IgNaQaz0Xo3E3Eq+HpwmVvLyE7O7X0zFYgh7S1vYmbyQaWR9bOxaz4xzSu1VzgoQgDszA8/Fp7/TvcAObKbxY1+KJolqTn7kEwmL/aGhKxP2jNxgOJQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from MR2P264CA0181.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::20) by AS8PR08MB6022.eurprd08.prod.outlook.com (2603:10a6:20b:295::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 12:19:08 +0000 X-Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:0:cafe::ac) by MR2P264CA0181.outlook.office365.com (2603:10a6:501::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:07 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 15 Apr 2021 12:18:52 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 15 Apr 2021 12:17:20 +0000 X-Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 15 Apr 2021 12:17:20 +0000 From: "Joey Gouly" To: CC: , , , Subject: [edk2-devel] [PATCH v1 2/4] DynamicTablesPkg: Add access size to CM_ARM_SERIAL_PORT_INFO Date: Thu, 15 Apr 2021 13:17:18 +0100 Message-ID: <20210415121720.11553-3-joey.gouly@arm.com> In-Reply-To: <20210415121720.11553-1-joey.gouly@arm.com> References: <20210415121720.11553-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7547c33e-960c-4c5e-f7fa-08d90008af7b X-MS-TrafficTypeDiagnostic: AS8PR08MB6022:|PR3PR08MB5801: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: REqDy7u+6Y4BNkH5B+mo+09n7czADZb8B3w0gOpGeMcwJ1wOQ5VXPLyuCNXRANnsWeekAKBFAcnlJaNa5rXAPpmlAe9Za1Uk3Y9SVQZaKb5Z4OiF6Kush9/gavEYWA66cOFtKYZwG3SqVnP1F7dIklz/P/IWctpibyo1yqgQQV20xV6URkOZOmNlJ+qvoMth0djohwWPk4kz3/W9Um8P/CyJUQHN8vc+9fJXx43tLHsGn6tiPIEHiTK7FayBMMdGx0OQHJjxALbkSg/01S/fd8uwtpKt6h0/Ub8Yd7ufxUrHbbtahrHpLfzbeJWWlsA6aqiVurVIcWNn5ucy6Z1gqmfOqwuA6Ayeseg/ezivHUOj0ZLWy2AzPadyAT+6hxsWfaxwGXWWV6mydZFaveRk42fzyIqE+fFdvRuKn+GJHGxO2zCmN297sQfLXBgmVNPd3kLKr5/xCztOeLWSsbMQEJY45amWFN8hkp10HAF8fso5lwHSj/RZ/FvdeLQP368vmFi0/55xoxvLzfj67b8Bnb7dnCQYXIFLbutACHMbV/3SOFiVVR2MvDhJwGFfDQ6rzvCSWuXtKdJr7SHvW9oYtfTQ0W/vu3RAq4/vrZsGYOHL7N8zokr6DKwEFqdxAlJKPei6D7OYBp5xq+Us4f7JzfcSeLS1Qw+F2myidHU6dGb82+peJXTPYAmzQ+FRkvRG X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966006)(36840700001)(5660300002)(44832011)(478600001)(2616005)(186003)(316002)(82310400003)(26005)(36860700001)(336012)(82740400003)(8676002)(2906002)(426003)(8936002)(81166007)(83380400001)(86362001)(36756003)(54906003)(1076003)(7696005)(6916009)(47076005)(4326008)(356005)(70206006)(70586007)(4744005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6022 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: def17739-5966-4d5a-0605-08d90008aafb X-Microsoft-Antispam-Message-Info: DWpxWH6EstWWIJAUD8aHEx4tumQGTM0wo5LpWndniXgp0kh0vNEbY1RLYNEZ4mk+xvubmVZSwGNpgvBCXYjaTdjG16IFqNGTs8LCHGeu61lMJjxXYtySce2yC6vOr4y3PpZPoKE6xXXtfOxxrOEqYdmBGkKnzTAKQ8quv6KNzWXavqoTKGMP51YcTcMPuHyGuPKww16fSx3zFGtvnQgcafjNSBJHOu6mimBqPZI6m6iQ8s3wigtsTchmoJAVJipIS1eMnAtjVT7uM6NQaJpavZn7j5ou+1U+050NTLCGZktYYa4QnOpHwaW5D5ZXzIi7Fofxv7FQOiSxyxoR7RnX15mW3O5J4qL5XuPK8vo7u201kO7JQrs/rRoez+LD6br0OE/Y/ZMJ/rp+rY7JPcZDp9kFSFpYmxwfJbewv3tc3T1B/F4M5YPft0WErZtRYlHAuMUqovA079upqK9tjoPHfNDGaR1GI9U9zCIBQvJaaRt/xm8+1GB50lQk8EF6eEoXb6GKXfB1MRzsfUhXjxl/HwPIBOtGuhQGltyunLRJLLTkqzf0ujHOfutZkACQUYkF6aQFYYi1c6hO2vb+EpZFto0MU58LxZQ+Uw8SucrhDWvvZ8idqkESJZX4aOEpwPpSDm5AjGcnHSb/JaBwTyUtGg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 12:19:15.2242 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7547c33e-960c-4c5e-f7fa-08d90008af7b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5801 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joey.gouly@arm.com X-Gm-Message-State: 8gybzHZiCJNcNApkqOomZnyGx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618489159; bh=xokzOEx58HTegGyU4Bf+WY0pvIjNxmLaR3XmR6zbXdo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=GNpXpHcqKW5LRHBQBy/5+db9paGIq8Enlvgn+5ylnWBYv6VPuOxWvQYwsnumexVlQrT YgB4b+tC9GfrkH5HknLyiuNX2RicDpMEz0JrBrpRL+5Q01Hz0tm1lRu9aObsg6ZPx+G3X K/OuNnUmF5vI9VaTt0bFzYt0dW1TGWskRZo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add access size to CM_ARM_SERIAL_PORT_INFO so that this can be passed down to the Generic Address Structure. Signed-off-by: Joey Gouly Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTables= Pkg/Include/ArmNameSpaceObjects.h index afcfe3704cb908afb1e6b17e6771b2ebe3f67f76..19dcae13b2191e5f0b03ea85ede= c1191d2a406bf 100644 --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h @@ -293,6 +293,9 @@ typedef struct CmArmSerialPortInfo { =20 /// The Base address length UINT64 BaseAddressLength; + + /// The access size + UINT8 AccessSize; } CM_ARM_SERIAL_PORT_INFO; =20 /** A structure that describes the --=20 Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74127): https://edk2.groups.io/g/devel/message/74127 Mute This Topic: https://groups.io/mt/82115118/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Apr 20 13:42:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74128+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618489163155755.7288668681252; Thu, 15 Apr 2021 05:19:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id TQVTYY1788612xkINUDAtuH5; Thu, 15 Apr 2021 05:19:22 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.82]) by mx.groups.io with SMTP id smtpd.web09.6031.1618489161751142750 for ; Thu, 15 Apr 2021 05:19:22 -0700 X-Received: from MR2P264CA0159.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::22) by HE1PR0801MB1930.eurprd08.prod.outlook.com (2603:10a6:3:57::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 12:19:18 +0000 X-Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:1::4) by MR2P264CA0159.outlook.office365.com (2603:10a6:501:1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74128+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:17 +0000 X-Received: ("Tessian outbound b610e7b4d771:v90"); Thu, 15 Apr 2021 12:19:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 018c2899ab17678a X-CR-MTA-TID: 64aa7808 X-Received: from ceab533ea348.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 277971DC-2D07-4830-B275-B100933B5883.1; Thu, 15 Apr 2021 12:19:10 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ceab533ea348.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Apr 2021 12:19:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAFfMsOweyHdcsabGyNAhGvm+t4bCGzfP50svZIk/RUw/taSDfPsUp+Kxe65MBqlnY4K3Um+Kr+PXzIf1nPLMaAfvnYrtFCBjP1RzVIItvuzuR6L7VqZ37zaZM5pZarYf7nllwXCAswB3DrPg6z2UrxUxg1cazD0kAbS2nY2F4l08zHHfJOXB4ifSA33SHVkNlR2ES0dOkkp6ZDO6wyMdZoL4N+YevMnybQPprPKxTQi6BCIsQRKP0LWPobIiJoN8S2OUurx/KQECIDPvPe+A0xfwaujo/HFn/FO8Zyd4YlBs7SEQeYAG7gbjjw6NN/L7svx49kLgUQXG/0upJSezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KdcaVEiAmSd2E9i9pQbrLUzwaRWFCGos7IFpZxuUMms=; b=Smm0hzeKwWPsj9NhLoFyABp1jB5vAtKBttK8k2tKv5ceMT2U4NKc8WXyXOW1yAndclR2KkgABtkAGc8ic4hZfZUjgsimtxz5m7MhUBe58SzBVuEjVAV+S5PSJAVCIGx7zfzWRkbp0nK4YtiX9Wlj/MoQltqrilWnX/Qode8Ckw4G8alJLQuIyvz9j1lUYVmgyo2/LthS/2VlxI2vr5dTeJtzJ5DHtu6OSAChV6SQc+eRD63iVu54SXB22wE/uu/cL4vCVCapZnTY0nx8ikraklCFtBq0xuI9H5fNvQI2ZEg7xt3TgNn84rceqQaQQoYude5OmPK0x6oRWZ3tZUI4eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from MR2P264CA0175.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::14) by PA4PR08MB6301.eurprd08.prod.outlook.com (2603:10a6:102:e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 12:19:07 +0000 X-Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:0:cafe::63) by MR2P264CA0175.outlook.office365.com (2603:10a6:501::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:19:06 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 15 Apr 2021 12:18:51 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 15 Apr 2021 12:17:21 +0000 X-Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 15 Apr 2021 12:17:21 +0000 From: "Joey Gouly" To: CC: , , , Subject: [edk2-devel] [PATCH v1 3/4] DynamicTablesPkg: Set the Access size for the SPCR table Date: Thu, 15 Apr 2021 13:17:19 +0100 Message-ID: <20210415121720.11553-4-joey.gouly@arm.com> In-Reply-To: <20210415121720.11553-1-joey.gouly@arm.com> References: <20210415121720.11553-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf00a7bc-b116-4894-e854-08d90008b0fd X-MS-TrafficTypeDiagnostic: PA4PR08MB6301:|HE1PR0801MB1930: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1QIqeCrzckfQnr61Xz0nTXtbYupe8uFfGFWLa6n7/w7c29GQ4mNQGNQOEz/d/MS+03GwEu3xdn9fYCC4tRi8cmzSYynQEvKVcPxO9idmM35Xu91MQL3pkRocgOtvX8ofTbr/urpXSBInTZtoCdYZJKfQSygxFTRcJcoiGkjgcFF5c3IevHXsR1n/HuSi/EfjC0kwOPrf4fbqJTIPxEWMyw+ENodK9/Ixr9GdYYKnZgbjzfqR/2VZXJBV31aiEI7aZFlED/W0B/OOUHEwSqf8jZbMpsYwcvqpscUHnonzAtiRUsHNHTqZdyCecBLSAHr0twIp62NTkxegkmjQA4ZMi0usmv6avkGzCsomD8JQtg3gW/5N8hugQetHA0n4ZrIJ6NQKBkvxhvA6v28jS4KKEXq2Q55qrp4x+E7rI90jIY9IFxVkHfU1H1nvLNzqPM8NkhG8sW2yxi+JlNIQVImdJtNZebB6l7pt2Q8gyiGqkAnxvd52mPHXKP4izGwRBe6+ztjPIUdvTuBZn2PjIIbrNFBDHdPKab8U5hlm9WaMj/lWCn1Dw8B58Oq+VU13rAlO/V/D4u8MN9LRvstrNg3uT56kNI3Sll6E27/qoJDrRuYwTknQ9GtIeo6LcxjI1V7rFjBwo/00TZzMHL1khEkoo6vd15Drng9sJDTn8mjtJBssF5YDoEdi5IZ5Mrv5zAeP X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(46966006)(36840700001)(70586007)(36860700001)(70206006)(54906003)(5660300002)(47076005)(478600001)(36756003)(356005)(7696005)(8676002)(316002)(2906002)(44832011)(8936002)(2616005)(426003)(336012)(186003)(82310400003)(82740400003)(83380400001)(6916009)(86362001)(1076003)(4326008)(26005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6301 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8dbc0076-0bd9-49f8-f297-08d90008aa6d X-Microsoft-Antispam-Message-Info: vb709CQlcmJTwmJRPTPlnApWeKl6BHeSCfcLfj8qUXAQQCFiTDIk9WgZDqu6l5I87xVxnWE7+ofe2xiUmsdXZRHkcVQcScp2yOWmGvxGCcl51Zb01DA3WdrkPR/3GeqMvAMdWT9XXQxqPKy8lxaV98BV0pdWgMnr3bFW0VaE0FH2JJ2YLxWa3MhgEu6zdmaInAeqw5AOHbbblJg+vKPZozfI2zCGagTnrlpyENjq1wE1+CxbWBCaK7OjZPrFlVHqjYuUyYUR12UYMfvo1BjUIhCwnIPJhUrbpNPXTWEm4A2JtVfQbLInE7hKDX/nfv0hOiPARfw8dpXCU+T5xtLBmhbnXI272BN92GiJ3pvjQ6uPJphQgvC6803IxOuYLVsRDgcEuqlZ59A7JJTrQrjSI0PfHQLq6TuFaoI6SIoU3rXOBy9xOLSxpGHTCJQtf7174vcmveDcIyNbePVRjzS9UM0bt0frABW3UIy5vGd2X4WzbBCB5+vn8JjbQS30zUy9pG6mYfVCOnJjae/fMK5YwdgNqdjx1yNzvBRiPyicXwVffeycHD/V/FTzv6dpFkEakLHStf5s0TNd6gUkxjzniRgWuCA+1aN5FF7Tin7IMeJNNvzOo4jpVLCAAreNXF3tQWNdrVeHOsTePrbYrviiN3pJ1jzlQ0AL+C33UHSW8uI= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 12:19:17.7515 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf00a7bc-b116-4894-e854-08d90008b0fd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1930 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joey.gouly@arm.com X-Gm-Message-State: F34wOrIdAJ8TfEOxuew351MQx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618489162; bh=ZAVjNXn4Ke3Kq3PP+y0GggtWnm6lwIsOAXNe3pMyvwA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=wjOU/DmJxH0WpKHqARX8ESsCctgTn5bEnb5eGz5Lw/1l+4PkD7TatlbYCVRbILBbRdr iJTviXvQzB5XCP3rqPZpmMJ/koFVIHe+VUUwra+i17mXQbTn6Cdr/FZg9+YdEuhgP0H5B W8ATt8DRO8XKzejVCSXN8guTUynlH9tCWHQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SPCR table generator set the access size for the UART to DWORD (4 bytes) by default. However, according to Section B Generic UART, Arm Base System Architecture 1.0, Platform Design Document, a Generic UART can have BYTE, WORD or DWORD access sizes. To address this an AccessSize field has been introduced in CM_ARM_SERIAL_PORT_INFO object. This patch updates the SPCR generator to setup the AccessSize field in the Generic Address Structure (GAS) for the UART in the SPCR table with information provided by the platform. Signed-off-by: Joey Gouly Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 22 ++++= +++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c index 24bb5c014607b0746c4a8bb8bd260510fbdff08b..fecfd6bbabd63698f5f45f6bfbd= 494f25cf0faeb 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c @@ -1,7 +1,7 @@ /** @file SPCR Table Generator =20 - Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.
+ Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -313,6 +313,26 @@ BuildSpcrTableEx ( // Update the base address AcpiSpcr.BaseAddress.Address =3D SerialPortInfo->BaseAddress; =20 + // Set the access size + if (SerialPortInfo->AccessSize >=3D EFI_ACPI_6_3_QWORD) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: SPCR: Access size must be <=3D 3 (DWORD). Status =3D %r\n", + Status + )); + goto error_handler; + } else if (SerialPortInfo->AccessSize =3D=3D EFI_ACPI_6_3_UNDEFINED) { + // 0 Undefined (legacy reasons) + // Default to DWORD access size as the access + // size field was introduced at a later date + // and some ConfigurationManager implementations + // may not be providing this field data + AcpiSpcr.BaseAddress.AccessSize =3D EFI_ACPI_6_3_DWORD; + } else { + AcpiSpcr.BaseAddress.AccessSize =3D SerialPortInfo->AccessSize; + } + // Update the UART interrupt AcpiSpcr.GlobalSystemInterrupt =3D SerialPortInfo->Interrupt; =20 --=20 Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74128): https://edk2.groups.io/g/devel/message/74128 Mute This Topic: https://groups.io/mt/82115120/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Apr 20 13:42:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74126+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618489100598653.6621630582808; Thu, 15 Apr 2021 05:18:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id i0rMYY1788612xl3v42ve6BF; Thu, 15 Apr 2021 05:18:20 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.56]) by mx.groups.io with SMTP id smtpd.web09.6010.1618489076324412530 for ; Thu, 15 Apr 2021 05:17:57 -0700 X-Received: from AM6P195CA0097.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::38) by VE1PR08MB5101.eurprd08.prod.outlook.com (2603:10a6:803:106::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Thu, 15 Apr 2021 12:17:50 +0000 X-Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::28) by AM6P195CA0097.outlook.office365.com (2603:10a6:209:86::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:17:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74126+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:17:50 +0000 X-Received: ("Tessian outbound 82c2d58b350b:v90"); Thu, 15 Apr 2021 12:17:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 10068dfe2ce447ab X-CR-MTA-TID: 64aa7808 X-Received: from 478039097243.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D856270C-329A-42A7-A977-E9AB10A7F2A8.1; Thu, 15 Apr 2021 12:17:41 +0000 X-Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 478039097243.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Apr 2021 12:17:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cUyHn8QCa+45UGnwX24I9M52Rq4UcP5U+AsP4NgOsSGS4yo6319CHXfKBwBlz7/zsluGL/x2h4j/7q9xm7rmbloa6aHNebRmdlDc6XdakeOJ/BBXWMjhzXY6rHKBNsuoJKjXVT+P4CwCEToEQNcj8SRE7HWjky0l6Cf6UPHMoGw4VWcoXeQyI0DJIkRgf9de1enF1WWjzhj9aETYCtR1RGyf2dzQ3fZXTDh4dq079PUeA2+QaSU0MCIJLTBKbdH9h7BVnfb1eA6I0kqVOmkd2uMBe0nKtFXECL3SZfT01mreP2wr/cuNiyv78RPk0HowdxduNrLp+Du6RIZIS7StKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/1QEKQHB6Fm4oGsittkbgldOZ9eLtLNHlzc3yX9pgs=; b=lDL3BOgXJMUg1do6SAJzWL8IfQu+REW/N3v7RMw1BBNHtw+ptZrGAo2fcNuycbNCq/lIhqOz1eBdd57xyZEsHvJdyVTaCDdKfd3UxugSyC5zeDlq4jSoJntGrh0ZNvW0BvhdNR3HDuyN55W/1nngNQdK+BvPH6oGxznYIJBdmJzPhQRK7ymld8m8gS4wyA5RatUjKqUEkOBzoz5o6LsBxk0GSYQjYNSenQr5MbOmI/SD/h+1lX71VnM1RvwAzdtXbaqjYHrTwHAUIXfLl7g5NOyxCJXBmKzTTM6maXzyKQSej0wzpqMEKTNNbs3JrYDgYwk8DsnocM16UOxuTKYdtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR0202CA0046.eurprd02.prod.outlook.com (2603:10a6:20b:3a::23) by DB7PR08MB3897.eurprd08.prod.outlook.com (2603:10a6:10:7e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Thu, 15 Apr 2021 12:17:38 +0000 X-Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::5e) by AM6PR0202CA0046.outlook.office365.com (2603:10a6:20b:3a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:17:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 12:17:38 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 15 Apr 2021 12:17:21 +0000 X-Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 15 Apr 2021 12:17:21 +0000 From: "Joey Gouly" To: CC: , , , Subject: [edk2-devel] [PATCH v1 4/4] DynamicTablesPkg: Set the Access size for the DBG2 table Date: Thu, 15 Apr 2021 13:17:20 +0100 Message-ID: <20210415121720.11553-5-joey.gouly@arm.com> In-Reply-To: <20210415121720.11553-1-joey.gouly@arm.com> References: <20210415121720.11553-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce773d7c-6a12-4e33-5da9-08d900087cca X-MS-TrafficTypeDiagnostic: DB7PR08MB3897:|VE1PR08MB5101: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nGobmkpKCAkNP0M8foi1f9si/mpVBy81azbgvY/bLKZ4SbBIGYFO2/jrDD8lDhh+T+RprnQGw8aclyOSNP/72otKGnFwoF+e0rx+QC1pSY1I2S6aJfAC9TizqRwz4TvVp1WFC7Bfr6Ipk50bs670AghkVWozM9PjOYkq6NEzJegoWavwokopE0ETznjM/Gu7+BzsrgZFYQAtPb5Ei1GHpB+s1C3JMccHQY1Ue3Kjz5FK6CtGx70vZzkU6lR7tGWyDH5L52IybHtjmU4LviMSqdOjdXyJne2RPtidm9KcaglC9jsY3nEsvTxlzfbpKllpCCW7gdEPJovngT/JU1fp3Y/u+PP2GqB0fYfx0Qc/+tV0YJriftFSz6yI6QQVh9u57DnGB5rjChZ9pKIK5qOPgVdolxJJ/J+hlAbV7Z0lHCLKUNAs1RpHjck6PNqUoTQJdGLn4/xQAh3dG0W/BVw92kn3E6rgpehizy+cZlYUyQMu+52BSQYLB2KU1ZqpVWHMh2pmk02GcfpTtClKWUJNZ8LhjWA8bCu2lG9waXiqZd4okJ4mE39eRO5XCOahduywxxxNPz/R3zcXBRYgM/IohfRQike5JEw0tFhoqDHxFtos6FYv1S9jFS1ATiJRA7g2N3hgvmsK+z+D2XEpFWl5483EBC4Dc9F8LzJ+LdoKXJFoVVyk4SuGUOR1yY8vf/Gw X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(36840700001)(46966006)(8936002)(86362001)(426003)(81166007)(8676002)(2906002)(36860700001)(316002)(47076005)(82310400003)(356005)(4326008)(186003)(6916009)(336012)(5660300002)(478600001)(1076003)(26005)(44832011)(70206006)(2616005)(83380400001)(82740400003)(36756003)(7696005)(54906003)(70586007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3897 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: afc47c39-1885-46a0-9fe0-08d90008758e X-Microsoft-Antispam-Message-Info: Q3R6ynzXe/PcHwwtjJ2yM4uBOqXdyDbRqNynh2qWCoKa0g4Y5Y6649wSIMSjynlxHUwr8Q+xQPiMW+v6ZJtIVirsxcDza6EvFUmfP58ww/rUYYXzxBFMaPkcbtXyuV3M/gjrchj1NtKvvsOVPF0jVJeRZz8tVx5JOJL4WrCYE90d91BJn8+HKTTPph9b5w4Vfzg8Q1rg05fANzg0DD0OX+NCwJ8iA+fo3TUHfKl7D/qRCmwSIJI7ipsOPume1WcVA4sN/CtRDd9AycwPag3s6cESvtczoYfS3XIh22dOFC3Qt2gtbFjJGzEG4mOPSNXO4wx5XewD/9odV0XGhYQIzNqFJVZgEeb6Tz3SnmVgRz0RlErTSCRo8gz/o+noeTqM1KLwddDhI8AxhDkHhDcScOVuF3Pwpl1sqrW740TRJrR2M78xVVgKRSPZeJImqlq0wDN/9Kl2lAb+xmwwkT2wk8DdNvDWR1qZjOum5Bd+zyRrCYputR2bMXyQrbBLwK49N5i75pApLvNLMAaWAfCqWc/paf0bXSuZ4udd6f9RbuddMKN9SJUwm+TOpcLLJ6xv2E3Ld/PFn8pNUvegGUtqgiNy5iic5bsrAQjhUml6EGxXnze70nT77iYOsjTqTRXeZ0wg+SzgwuHnVzNdBTTgiN0RhDHvVKOR+jjMlou+qsI= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 12:17:50.1681 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce773d7c-6a12-4e33-5da9-08d900087cca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5101 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joey.gouly@arm.com X-Gm-Message-State: 2waqszIVgcGPoUVCdH41xSqfx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618489100; bh=oxGcgzrizYkYSLjywbNECjDNNfjgCUcVnMcm4+OMmWM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ZoNZtAwfqpnYrqAhMVIxB4f08D75emx8F/mEfM+LIE7k2wc+tfGXr9Xbm4YnC9F6+Pu PMSCToGs4kg9zOZmtdazA7g3Er578cGzcw+b1docJfbAKHpksKEVJSMtvA7FIKP+N2gNn bEskOVpZjTuw/pXJ+CX7HoAG5VGkncKX4V8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The DBG2 table generator set the access size for the UART to DWORD (4 bytes) by default. However, according to Section B Generic UART, Arm Base System Architecture 1.0, Platform Design Document, a Generic UART can have BYTE, WORD or DWORD access sizes. To address this an AccessSize field has been introduced in CM_ARM_SERIAL_PORT_INFO object. This patch updates the DBG2 generator to setup the AccessSize field in the Generic Address Structure (GAS) for the UART in the DBG2 table with information provided by the platform. Signed-off-by: Joey Gouly Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 24 ++++= +++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index d902bbc8463921624f1a6333e8d6bd84c6cb38f2..a7508d4a8834fd2038946a62de3= 9e9cd0894bf79 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -1,7 +1,7 @@ /** @file DBG2 Table Generator =20 - Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.
+ Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -420,6 +420,28 @@ BuildDbg2TableEx ( AcpiDbg2.Dbg2DeviceInfo[INDEX_DBG_PORT0].BaseAddressRegister.Address =3D SerialPortInfo->BaseAddress; =20 + // Set the access size + if (SerialPortInfo->AccessSize >=3D EFI_ACPI_6_3_QWORD) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: DBG2: Access size must be <=3D 3 (DWORD). Status =3D %r\n", + Status + )); + goto error_handler; + } else if (SerialPortInfo->AccessSize =3D=3D EFI_ACPI_6_3_UNDEFINED) { + // 0 Undefined (legacy reasons) + // Default to DWORD access size as the access + // size field was introduced at a later date + // and some ConfigurationManager implementations + // may not be providing this field data + AcpiDbg2.Dbg2DeviceInfo[INDEX_DBG_PORT0].BaseAddressRegister.AccessSiz= e =3D + EFI_ACPI_6_3_DWORD; + } else { + AcpiDbg2.Dbg2DeviceInfo[INDEX_DBG_PORT0].BaseAddressRegister.AccessSiz= e =3D + SerialPortInfo->AccessSize; + } + // Update the serial port subtype AcpiDbg2.Dbg2DeviceInfo[INDEX_DBG_PORT0].Dbg2Device.PortSubtype =3D SerialPortInfo->PortSubtype; --=20 Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74126): https://edk2.groups.io/g/devel/message/74126 Mute This Topic: https://groups.io/mt/82115095/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-