From nobody Thu May 2 12:04:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+73938+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73938+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1618217140; cv=none; d=zohomail.com; s=zohoarc; b=TQ4qTqU0Hflwa3haRsoaoa5t0Hg1je+6lxTn17JKMJp+NIEqcuvWdJyvWHLszosqRLYX8oSC82dMHfuWgVlfzV2HtdyJZ3uwQSxuICmDWEiuQcUSLZXKBi0H486GpfowPWxo+3gadgWZwJ4LwSzR6n0EguzK7MrEK78jfr1+pcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618217140; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=fbUIK5ilm6zXO7BUZI8xquBIPW95w4IGehGl7RdqEw0=; b=kT0VvvirTXhdZ/xLqPjNOwLPHzazQifW1SKOKsfGNHv5Dlfe/7JIy7xNBaQmeNUdVvvHlwlQX9RODW5ITvaaH8sX49zmW8tJPCfCB/7Dtki3h2Pv7W3FJl+5V+lIgVRZCx04I80Vn6ZRcx3nVueAJY7u65OsjrVudlHIcBzrFt4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73938+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1618217140825601.7471661781005; Mon, 12 Apr 2021 01:45:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id cdXqYY1788612xv0b2C2gzZs; Mon, 12 Apr 2021 01:45:40 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.29388.1618217139925576318 for ; Mon, 12 Apr 2021 01:45:40 -0700 IronPort-SDR: gFSoPnH7siKNlOg10eI7cqSBiHhZoKpLgz3ozIT0ohhM1DsfU/ADXTzw/0llFWtrY5x90mAuTk BFqdEm4p+GMw== X-IronPort-AV: E=McAfee;i="6000,8403,9951"; a="258117873" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="258117873" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 01:45:37 -0700 IronPort-SDR: /x3b92kS1I+gXh0wL7w8ZeYVae+iBma2LPaKMJizf4LjYHV2tHagiSFADwPhDzS8e9ff2dgeQ6 O1I9/0u82n0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="417293230" X-Received: from ray-dev.ccr.corp.intel.com ([10.239.158.87]) by fmsmga008.fm.intel.com with ESMTP; 12 Apr 2021 01:45:35 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Rangasai V Chaganty Subject: [edk2-devel] [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure Date: Mon, 12 Apr 2021 16:45:25 +0800 Message-Id: <20210412084525.1655-1-ray.ni@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com X-Gm-Message-State: M9HLQZlBMebCtuSVnszjfzLOx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1618217140; bh=DWf7HNU4Z7tWOXDt769rF7+2oJEgBBm1v/Ar6Xz6rDU=; h=Cc:Date:From:Reply-To:Subject:To; b=WBx1pFU1oF93RSJsl1eD38/ud3PhNcJjNptVP8AmOwXuKw2H8RVJ6zfKKZPXo/uv6+h DS6pcfA/8SQ6YRIcr7ExYN24x4H3Gfd/ISdukH58GK+g05TfuhV+AKgStxnytSmZNpWYn ucmsKz+q7aaN3h6TMGH1mHvEFovj2HC5LBs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The commit 7e4c6f982a0accd5aa86337b46d20199db989aeb updated ShadowMicrocode module to consume MicrocodeLib. But the change caused the build failure. The patch fixed the build failure and also verified the change in real platform. Signed-off-by: Ray Ni Cc: Rangasai V Chaganty Reviewed-by: Sai Chaganty =20 --- .../Feature/ShadowMicrocode/ShadowMicrocodePei.c | 3 +-- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMi= crocodePei.c b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/Shadow= MicrocodePei.c index 4e4b69a0ca..7f4a3f8fbd 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocode= Pei.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocode= Pei.c @@ -291,7 +291,6 @@ ShadowMicrocode ( UINTN MaxPatchNumber; CPU_MICROCODE_HEADER *MicrocodeEntryPoint; UINTN PatchCount; - UINTN DataSize; UINTN TotalSize; UINTN TotalLoadSize; =20 @@ -342,7 +341,7 @@ ShadowMicrocode ( if (FitEntry[Index].Type =3D=3D FIT_TYPE_01_MICROCODE) { MicrocodeEntryPoint =3D (CPU_MICROCODE_HEADER *) (UINTN) FitEntry[In= dex].Address; TotalSize =3D GetMicrocodeLength (MicrocodeEntryPoint); - if (IsValidMicrocode (MicrocodeEntryPoint, TotalSize, MicrocodeCpuId= , CpuIdCount, FALSE)) { + if (IsValidMicrocode (MicrocodeEntryPoint, TotalSize, 0, MicrocodeCp= uId, CpuIdCount, FALSE)) { PatchInfoBuffer[PatchCount].Address =3D (UINTN) MicrocodeEntryPoin= t; PatchInfoBuffer[PatchCount].Size =3D TotalSize; TotalLoadSize +=3D TotalSize; diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dsc index edc79c9b9c..5e0de7e19a 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc @@ -39,6 +39,7 @@ MicrocodeFlashAccessLib|IntelSiliconPkg/Feature/Capsule/Library/Microcod= eFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf PeiGetVtdPmrAlignmentLib|IntelSiliconPkg/Library/PeiGetVtdPmrAlignmentLi= b/PeiGetVtdPmrAlignmentLib.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurem= entLibNull.inf + MicrocodeLib|UefiCpuPkg/Library/MicrocodeLib/MicrocodeLib.inf =20 [LibraryClasses.common.PEIM] PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73938): https://edk2.groups.io/g/devel/message/73938 Mute This Topic: https://groups.io/mt/82033444/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-