From nobody Fri Apr 26 05:46:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+73813+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73813+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1617861538; cv=none; d=zohomail.com; s=zohoarc; b=etiM1z+9PYNDtbWSR0eXgn/Qg2+dDuYM4PuHfO4q/akUQ2QGyhUXmNdoayGnilBBkb8+9RJ5tZPHdSLYrUAwMoH+1ElAOz0doF5mRt3AWYV9j0dOKeTXI0OwQ0abb4FdLr7wbnZ6Ds3ELTtxJ/fy3D6F0aA1eAO7LKZTgw5jGDI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617861538; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=coo1N8bQ5dYncgjIbRVVJbW4h2lr8CAC+8DFQvY6F9c=; b=K4oKVmtNKUfEBJmxSc4kNtlV0BwEfSyPSO84dbyW7zwNAsCVvkZEn2Icr0DVzLkGHjub5d3WZD5blnxA3xVmDq7TX9fvF8jtmAxZ2fRjbf6d6EY4MU2IY3d1VENWDXVB6vW6GkQTXc87L301nyqZjaEA25ito/g+NVVHeo9T+A0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73813+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1617861538742250.88628243698747; Wed, 7 Apr 2021 22:58:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id W7uXYY1788612x6u09G6s3Pk; Wed, 07 Apr 2021 22:58:58 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4287.1617861537897235910 for ; Wed, 07 Apr 2021 22:58:58 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 823E51424; Wed, 7 Apr 2021 22:58:57 -0700 (PDT) X-Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6F6363F73D; Wed, 7 Apr 2021 22:58:57 -0700 (PDT) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com, Jeremy Linton Subject: [edk2-devel] [PATCH 1/3] Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode Date: Thu, 8 Apr 2021 00:58:41 -0500 Message-Id: <20210408055843.2883563-2-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-1-jeremy.linton@arm.com> References: <20210408055843.2883563-1-jeremy.linton@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com X-Gm-Message-State: bK3EgvTI3wix6XjoGvmBQkvrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1617861538; bh=oNOXlYsYM3Y92kLfIuIlauT/YBCUd0Rtn4THEYPcVM8=; h=Cc:Date:From:Reply-To:Subject:To; b=a7TEhjK0oQ1JyyES8WDwsgl7zcYO2qoC4UxzoA0QR/yCZbQ0d+n/kMwtrcw5ZULseTK 8Shz2itE+g5BwFBJGviQs3yzS8ZxVSie+jAOy/9nj0T9vJ102dOuOmfVZqHqIcz/fv11b Cc2d339IHZV/6Hfysz1ROaMMixh73OvmqSw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The arasan caps registers are no longer being overridden by the brcm iproc driver, so we should be assuring that the "High Speed Support" bit 21 is set in the capability register. This significantly improves the wifi perf using linux. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin > Reviewed-by: Andrei Warkentin Reviewed-by: Pete Batard > Reviewed-by: Pete Batard --- Platform/RaspberryPi/AcpiTables/Sdhc.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/AcpiTables/Sdhc.asl b/Platform/RaspberryP= i/AcpiTables/Sdhc.asl index 0430ab7d2d..42776e33bb 100644 --- a/Platform/RaspberryPi/AcpiTables/Sdhc.asl +++ b/Platform/RaspberryPi/AcpiTables/Sdhc.asl @@ -52,7 +52,7 @@ Device (SDC1) Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { - Package () { "sdhci-caps", 0x0100fa81 }, + Package () { "sdhci-caps", 0x0120fa81 }, } }) =20 --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73813): https://edk2.groups.io/g/devel/message/73813 Mute This Topic: https://groups.io/mt/81935643/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 26 05:46:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+73814+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73814+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1617861539; cv=none; d=zohomail.com; s=zohoarc; b=ZmC9fVCKC36WtDs1AR69r7GKOVuqL3dDtHuzk6Vs1fOxiam/yGW1eURCYRDKsWxtHsvHL+OgHfMJ2KgSEST473Krzi7x8m8YuhqMp6rmnOvBXAfsvYHxpkLSbEyEAi2KSg4jLjbRf5tzqVPIfJCq1OSF9f5LCV3W9n+s+lGx3lo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617861539; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=PFWudCMGcucIRQjzlZD1hQf4dnPbWp2pCyvipaTO4iI=; b=TP0EP019tozluUz7COMg5WTpnoEUdhvMZV90tDchFhcDxyY3fP6SPy1QUOf9dY1sAfbGbincfgjHGy47weqj2ZIjDdds1hHT5XITEllkoS+g/1D/qzDHgF6rVwWFwFfVzMa6UEMx+ClvmqtuutNEsBMRBUzONJAoRdIEgz3tuWg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73814+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161786153910112.412071764384905; Wed, 7 Apr 2021 22:58:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KogoYY1788612x5v9CHNXdoa; Wed, 07 Apr 2021 22:58:58 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4288.1617861537939352816 for ; Wed, 07 Apr 2021 22:58:58 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 874A01435; Wed, 7 Apr 2021 22:58:57 -0700 (PDT) X-Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7D27F3F93E; Wed, 7 Apr 2021 22:58:57 -0700 (PDT) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com, Jeremy Linton Subject: [edk2-devel] [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Date: Thu, 8 Apr 2021 00:58:42 -0500 Message-Id: <20210408055843.2883563-3-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-1-jeremy.linton@arm.com> References: <20210408055843.2883563-1-jeremy.linton@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com X-Gm-Message-State: AJvxyKXO39HgGx6Q408cevyfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1617861538; bh=zuYrojpfv31Rr6C+GYPkQX16/TYJnQ1UfKLYlDEI9yA=; h=Cc:Date:From:Reply-To:Subject:To; b=gduL0HbDnBDXRha/6Q6cO97X/hxTTGHyxP6JFkjVAIAVF5nHgldlqex/VfWTtPKunun HJike7KQtVlexvS6fOkvfVWQiM6NLy39+RjDnc6tkHUX5HCfe0oN+RinHRO9oKz7+Ryc6 NJfQqLGN3st9khoR386z3xjP4qlC5n68EEA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Add some additional IORT nodes for the USB & EMMC devices, realistically we probably only need to have a single node with the lowest AddressSizeLimit but this is conceptually "cleaner" should anyone actually try and use these values rather than the _DMA provided ones. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin > Reviewed-by: Andrei Warkentin Reviewed-by: Pete Batard --- Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 +++++++++++++++++++++++++++= +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/Raspberry= Pi/AcpiTables/Iort.aslc index 00720194bb..810307ae37 100644 --- a/Platform/RaspberryPi/AcpiTables/Iort.aslc +++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc @@ -20,6 +20,8 @@ typedef struct { typedef struct { EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort; RPI4_NC_NODE NamedCompNode; + RPI4_NC_NODE NamedCompNode2; + RPI4_NC_NODE NamedCompNode3; } RPI4_IO_REMAPPING_STRUCTURE; =20 STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { @@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE, RPI4_IO_REMAPPING_STRUCTURE, EFI_ACPI_IO_REMAPPING_TABLE_REVISION), - 1, // NumNodes + 3, // NumNodes sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset 0 // Reserved }, { @@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { }, { "\\_SB_.SCB0.XHC0" // ObjectName } + }, { + // gpu/dwc usb named component node + { + { + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type + sizeof (RPI4_NC_NODE), // Length + 0x0, // Revision + 0x0, // Reserved + 0x0, // NumIdMappings + 0x0, // IdReference + }, + 0x0, // Flags + 0x0, // CacheCoherent + 0x0, // AllocationHints + 0x0, // Reserved + 0x0, // MemoryAccessFlags + 30, // AddressSizeLimit + }, { + "\\_SB_.GDV0.USB0" // ObjectName + } + }, { + // emmc2 named component node + { + { + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type + sizeof (RPI4_NC_NODE), // Length + 0x0, // Revision + 0x0, // Reserved + 0x0, // NumIdMappings + 0x0, // IdReference + }, + 0x0, // Flags + 0x0, // CacheCoherent + 0x0, // AllocationHints + 0x0, // Reserved + 0x0, // MemoryAccessFlags + 30, // AddressSizeLimit + }, { + "\\_SB_.GDV1.SDC3" // ObjectName + } } }; =20 --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73814): https://edk2.groups.io/g/devel/message/73814 Mute This Topic: https://groups.io/mt/81935644/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 26 05:46:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+73815+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73815+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1617861545; cv=none; d=zohomail.com; s=zohoarc; b=HI4yDQPLtDrxPXW/Si28bAkFu4sfu+0TJdXTQsM85Uf/1dyqN9rQOj+9eNj3PZ9DEJHnTJ+Fq0YHeYuLSrkylzQzXbz+AM+uYd/I0O6yx1Sig+XQpCipO6Hmn6Ye96T6DUSdq2W5QxEXJFCk5NxdHoONg940bStoDZpFjyIJJ+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617861545; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=TB7y1vIKvnDPGwKTBzX84EWPulcQSPkDKMZ/DhFWg5I=; b=QkSu7GvHu8LaaHCNkMMExm3xdnrLHsJax9LB6/0jmHZhtVu+HaQeBFrU+A5/5Il1xUxrYFi2MOXaYWkpNbxYnlX1aCayqPi5mAb5YXpxe4LH1LjlHCmQ9btJg4PLdYjQxzB+WvNGwrtjtEPz+OvtVCoGkL532Z3jR5PSVq9/G34= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73815+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1617861545809917.2479705522002; Wed, 7 Apr 2021 22:59:05 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KvMJYY1788612xQNz6HNKHP9; Wed, 07 Apr 2021 22:59:05 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4163.1617861539945798059 for ; Wed, 07 Apr 2021 22:59:00 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74FD01424; Wed, 7 Apr 2021 22:58:59 -0700 (PDT) X-Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6BD4B3F73D; Wed, 7 Apr 2021 22:58:59 -0700 (PDT) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com, Jeremy Linton Subject: [edk2-devel] [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Date: Thu, 8 Apr 2021 00:58:43 -0500 Message-Id: <20210408055843.2883563-4-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-1-jeremy.linton@arm.com> References: <20210408055843.2883563-1-jeremy.linton@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com X-Gm-Message-State: BIGK8hY3eTP2RJ8ZWZTRMyNWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1617861545; bh=HUe/yWbcU/FK11AJmEg/fTh8EqJZHTRTqBNyFuNfueY=; h=Cc:Date:From:Reply-To:Subject:To; b=eJpgfeSRoJHRNTxYgatpdfsflqSUg+Sr0qyQIr4YXGtm6fdL7t0mSGajhqitWm4gamQ QyaqfQs56iewubok/GYR24oftbRoiceteP28GrrVn1b9IH2KpyI/Pey4UjEez6H7gj79o eObyxdLyGPoFgBkxYE7PGMh3U8nZgSUFRnQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Bridge devices should be marked as producers so that their children can consume the resources. In linux if this isn't true then the translation gets ignored and the DMA values are incorrect. This fixes DMA on all the devices that need a translation. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin > Reviewed-by: Andrei Warkentin Reviewed-by: Pete Batard --- Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryP= i/AcpiTables/Dsdt.asl index d116f965e1..32cd5fc9f9 100644 --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl @@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI"= , 2) // Only the first GB is available. // Bus 0xC0000000 -> CPU 0x00000000. // - QWordMemory (ResourceConsumer, + QWordMemory (ResourceProducer, , MinFixed, MaxFixed, diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryP= i/AcpiTables/Emmc.asl index 179dd3ecdb..0fbc2a79ea 100644 --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl @@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC= ", 2) } =20 Name (_DMA, ResourceTemplate() { - QWordMemory (ResourceConsumer, + QWordMemory (ResourceProducer, , MinFixed, MaxFixed, --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73815): https://edk2.groups.io/g/devel/message/73815 Mute This Topic: https://groups.io/mt/81935645/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-