From nobody Fri May 3 07:44:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+73002+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73002+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1616043069; cv=none; d=zohomail.com; s=zohoarc; b=HUydFwfPdzE0YMG+FXl+5s0vLkInv55TmP+12x90SN7FbQULlQllZ0BVX6TM/Uu8xzkKjRPYjDXHcjVOL+7f99L03i1AV/zQVJ3lDnftbt+p/7UpND8iQlZ+0blRaGcdnZIMEFhkeTL6wWTYLeSrNUX8imPxICrWsnb/MkwChNM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616043069; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=bYjXhrIlW0OjmGADm7ziLxKcyrqfnDe1HcT8gAr4hg0=; b=nZGWjZnafwu2rU8IRn8/MVYPVxplbKXPP4e13qiNwiDkDQIyQDAK45O+bQ5DZb743PrtUnPAtgyD0pogJW27eE/0Mjt7qWgrTPSzUfgxH0puqPZrhaBq+OK4ievcXb11M1QBTWs8FTmpb68s9ZWbsabKHpCDC462ho4qfyeZSjI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73002+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1616043069185161.39341462567836; Wed, 17 Mar 2021 21:51:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sYagYY1788612xZ63xOl4oxs; Wed, 17 Mar 2021 21:51:08 -0700 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.4987.1616043066481712253 for ; Wed, 17 Mar 2021 21:51:08 -0700 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 18 Mar 2021 12:51:01 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu Subject: [edk2-devel] [Patch v2] MdeModulePkg: Initialize local variable value before they are used Date: Thu, 18 Mar 2021 12:50:46 +0800 Message-Id: <20210318045046.1909-1-gaoliming@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: IYibwP8Pn5CMT11oD5FClJe0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1616043068; bh=zbFhwyu1WdnV+/UiyXXMmqEnwd1qZskmbwbDg65MOrA=; h=Cc:Date:From:Reply-To:Subject:To; b=Q5a4jdBwYEgbuot7jxhJIUSXPojnirq9YMG+OR/XHbUtmcirXsz6qAoXxqCWMRJx0MH G/GbiDedoiuJfYt8VisfbgJqUpYzSh4p8FYZT6AgjmCxWFCbLhK5/JokfnpVIT1KAFlf9 Yy8gu3lI1DORDEPXzHPAYmjzhNEeuQQkYNY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3228 This change is to fix the false compiler error on GCC49 release build. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Liming Gao Reviewed-by: Hao A Wu Reviewed-by: Laszlo Ersek --- In V2, add the comments for the false compiler warning MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 5 +++++ .../VariablePolicyHelperLib/VariablePolicyHelperLib.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.c index e99a812a44..1053695b3b 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c @@ -1127,6 +1127,11 @@ AhciDmaTransfer ( return EFI_INVALID_PARAMETER; } =20 + // + // Set Status to suppress incorrect compiler/analyzer warnings + // + Status =3D EFI_SUCCESS; + // // DMA buffer allocation. Needs to be done only once for both sync and a= sync // DMA transfers irrespective of number of retries. diff --git a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHel= perLib.c b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelpe= rLib.c index 0c9299c8b0..6bcb95247f 100644 --- a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c +++ b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c @@ -115,6 +115,11 @@ CreateBasicVariablePolicy ( return EFI_INVALID_PARAMETER; } =20 + // + // Set NameSize to suppress incorrect compiler/analyzer warnings + // + NameSize =3D 0; + // Now we've gotta determine the total size of the buffer required for // the VariablePolicy structure. TotalSize =3D sizeof( VARIABLE_POLICY_ENTRY ); --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73002): https://edk2.groups.io/g/devel/message/73002 Mute This Topic: https://groups.io/mt/81422804/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-