From nobody Tue May 7 19:30:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72683+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72683+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1615493960; cv=none; d=zohomail.com; s=zohoarc; b=TcjUJ5++159gAxf/X0hfTJQe0YvwL18N7oO10IIvC5BXiteN0RA10N7ubFo9cr4y988vi+pHXq3qML7FXvGFHyP9hbDrs+WtASoTCUkbAKgyk1BELlRe9EihcprlVUPdCrv4L6Qrdx6rsSUX8rrGiBK/HM7tXIm9z9fOQToYLXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615493960; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=U2Nf/UMItVFyIld+30A/8Q9C55cSheKlDk6ZlWB6RCk=; b=Rqe8fG3hR6OLxE3p8wfWHX1mXYhnM+HfVX91vv/fgXbj5opke3P8VNkJ9+HA6q2XMRs+4KQxXH0AaCv3RLHgmJGRAnH99auyin9lcag0TrPskhPNnXcm8oUuuW77ru8RwK8DpB0lZMJod4c+8F/cc+8oKl3Krhzt0W0CeLmLRnQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72683+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1615493960854697.2194357149814; Thu, 11 Mar 2021 12:19:20 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9EoGYY1788612xGG7bnmMaDz; Thu, 11 Mar 2021 12:19:20 -0800 X-Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mx.groups.io with SMTP id smtpd.web12.1446.1615493959898040695 for ; Thu, 11 Mar 2021 12:19:20 -0800 X-Received: by mail-qk1-f179.google.com with SMTP id n79so22037518qke.3 for ; Thu, 11 Mar 2021 12:19:19 -0800 (PST) X-Gm-Message-State: 0KHTnAlmJeGIUU4Rs2EcIGN1x1787277AA= X-Google-Smtp-Source: ABdhPJzYdA7+5FGKoVy7q/jZ6+IBvanVxuuBDHiGyPwr7v8I8L8ZSJR6MUqDMp9lTG4jLPvZco0V4A== X-Received: by 2002:a37:86c6:: with SMTP id i189mr9692069qkd.455.1615493959035; Thu, 11 Mar 2021 12:19:19 -0800 (PST) X-Received: from localhost.localdomain (bras-base-stsvon1503w-grc-23-174-92-28-187.dsl.bell.ca. [174.92.28.187]) by smtp.googlemail.com with ESMTPSA id 85sm2915865qkf.58.2021.03.11.12.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 12:19:18 -0800 (PST) From: "Shashi Mallela" To: leif@nuviainc.com, ardb+tianocore@kernel.org, graeme@nuviainc.com Cc: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v1 1/2] Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define GICv3 ITS base address Date: Thu, 11 Mar 2021 15:19:16 -0500 Message-Id: <20210311201917.28939-2-shashi.mallela@linaro.org> In-Reply-To: <20210311201917.28939-1-shashi.mallela@linaro.org> References: <20210311201917.28939-1-shashi.mallela@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shashi.mallela@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1615493960; bh=O1xZjlNePKlcx2v3R3xRrIKQFvztp/yzKcVqXs1JPkI=; h=Cc:Date:From:Reply-To:Subject:To; b=vZ6v4bT3uQVbtyyh+P3L2m+I72xF92oeSQT3Lk/ArH9YnvQ/vyFc+pn4fa7MwxMmayi VmKA4qSaMbQq/z4ZuaGJ6dV2/pkd2542iePqzc4P6Ha99KP/xlE7eXD0zIV99PQUk8FP1 xYaXChDIXAqAk/HmLrAhq+LFbcet9fAU14Y= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Update the new pcd setting (defined in edk2 ArmPkg) with the base address of GICv3 Interrupt Translation Service.For Qemu sbsa-ref platforms,this enables the detection of GIC ITS capability within the GIC ITS structure of ACPI MADT. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Graeme Gregory Signed-off-by: Shashi Mallela --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/S= bsaQemu.dsc index c1f8a4696560..58da89232800 100644 --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc @@ -404,6 +404,7 @@ [PcdsFixedAtBuild.common] # gArmTokenSpaceGuid.PcdGicDistributorBase|0x40060000 gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x40080000 + gArmTokenSpaceGuid.PcdGicItsBase|0x44090000 =20 ## Default Terminal Type ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM --=20 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72683): https://edk2.groups.io/g/devel/message/72683 Mute This Topic: https://groups.io/mt/81262678/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 7 19:30:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72684+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72684+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1615493961; cv=none; d=zohomail.com; s=zohoarc; b=P42odcciDjgTNM0Z8bjPKKB5ccYOnq3W9O85d/fGVXGp++JX7WNr9B42tOb8v/TUs3GELRyamVCHES+YA29bLAtlpFj9JPYUvykygyoa59PweVM9QNceG5XOwhifblh+MAOIwSXdJzqS+hB9G+g28vahw1AiwoYfYUAU5xvWHwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615493961; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=c3773dGGN2kiFpZRnJSCWD9DnwhS9SRGvDF5zb9Kzig=; b=d1YYPsYzAHZQB5l/IxIe8NBY8nfA8mA1bZ/pCVkHtiHdlr9GxBDBVBWbzxTe7nsXEcgYe8/tEU/ogWZHjHVmM+TooFUxG+n0LSQSvHoQc8F9FZkiL2XmekSB08MC8Ccg+y7OjmCVYGglEia9JBLXVRHjSOA1XIqplDWcJl35FUs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72684+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161549396164658.58761445055575; Thu, 11 Mar 2021 12:19:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id kSdsYY1788612x7PiwjhhoCT; Thu, 11 Mar 2021 12:19:21 -0800 X-Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by mx.groups.io with SMTP id smtpd.web12.1447.1615493960544319686 for ; Thu, 11 Mar 2021 12:19:20 -0800 X-Received: by mail-qv1-f46.google.com with SMTP id x27so3176281qvd.2 for ; Thu, 11 Mar 2021 12:19:20 -0800 (PST) X-Gm-Message-State: VBW2He57nukVNInP5XTbDjOex1787277AA= X-Google-Smtp-Source: ABdhPJxXHIpmJZ+mVl5QvD3/MoLJCjfEjYZ/oZgcCkdwh4anW7tcClo3K73DBGDQO4HSXAKuk2g76w== X-Received: by 2002:a05:6214:1d05:: with SMTP id e5mr9146873qvd.36.1615493959651; Thu, 11 Mar 2021 12:19:19 -0800 (PST) X-Received: from localhost.localdomain (bras-base-stsvon1503w-grc-23-174-92-28-187.dsl.bell.ca. [174.92.28.187]) by smtp.googlemail.com with ESMTPSA id 85sm2915865qkf.58.2021.03.11.12.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 12:19:19 -0800 (PST) From: "Shashi Mallela" To: leif@nuviainc.com, ardb+tianocore@kernel.org, graeme@nuviainc.com Cc: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v1 2/2] Silicon/Qemu: Update MADT with GICv3 ITS info Date: Thu, 11 Mar 2021 15:19:17 -0500 Message-Id: <20210311201917.28939-3-shashi.mallela@linaro.org> In-Reply-To: <20210311201917.28939-1-shashi.mallela@linaro.org> References: <20210311201917.28939-1-shashi.mallela@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shashi.mallela@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1615493961; bh=3i5cCKb/06Qf9pcrDYVUFKlUFX+lRUWBlc9EAY5Fatg=; h=Cc:Date:From:Reply-To:Subject:To; b=mmE2SK5IEqrFnlDOpT8nTXsvDRTNiQlTTt9Up5iTvSXDgVcIC2ddRDQrcyEeKWCBn3K pD6ZRjqI0VdhqIanAWrRWpevoh0RWKY/fhI4PhFiyzR12q9JLPbv6zqISqhSud+T4Nxgi b4Lexmd1LT/66BChqp3outEYd4Q0rKZB63U= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" For Qemu sbsa-ref platforms,to enable detection of GICv3 Interrupt Translation Service capability in the ACPI MADT,the GIC ITS structure is created with the relevant values for each of its fields.The existing MADT functionality is extended to include GIC ITS structure presence as well. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Graeme Gregory Signed-off-by: Shashi Mallela --- Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 + Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 10 +++= +++++++ Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 10 +++= ++++++- 4 files changed, 21 insertions(+), 1 deletion(-) diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf b/Silicon/Qemu= /SbsaQemu/AcpiTables/AcpiTables.inf index 9be34488eb7a..de58987b0044 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf @@ -34,6 +34,7 @@ [Packages] [FixedPcd] gArmTokenSpaceGuid.PcdGicDistributorBase gArmTokenSpaceGuid.PcdGicRedistributorsBase + gArmTokenSpaceGuid.PcdGicItsBase =20 gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum gArmTokenSpaceGuid.PcdArmArchTimerIntrNum diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.= inf b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf index c6de685bd2c4..adf682fac564 100644 --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf @@ -59,6 +59,7 @@ [FixedPcd] gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision gArmTokenSpaceGuid.PcdGicDistributorBase gArmTokenSpaceGuid.PcdGicRedistributorsBase + gArmTokenSpaceGuid.PcdGicItsBase =20 gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h = b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h index 4d5b05ba17c6..5f9e9477bf6a 100644 --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h @@ -37,6 +37,16 @@ SBSAQEMU_MADT_GICR_SIZE /* DiscoveryRangeLength */ = \ } =20 +// Macro for MADT GIC ITS Structure +#define SBSAQEMU_MADT_GIC_ITS_INIT() { = \ + EFI_ACPI_6_0_GIC_ITS, /* Type */ = \ + sizeof (EFI_ACPI_6_0_GIC_ITS_STRUCTURE), /* Length */ = \ + EFI_ACPI_RESERVED_WORD, /* Reserved */ = \ + 0, /* GicItsId */ = \ + FixedPcdGet64 (PcdGicItsBase), /* PhysicalBaseAddress */ = \ + EFI_ACPI_RESERVED_DWORD /* Reserved */ = \ + } + #define SBSAQEMU_ACPI_SCOPE_OP_MAX_LENGTH 5 =20 #define SBSAQEMU_ACPI_SCOPE_NAME { '_', 'S', 'B', '_' } diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.= c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c index b8901030ecd0..4e0d24ed6608 100644 --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c @@ -91,6 +91,9 @@ AddMadtTable ( // Initialize GIC Redistributor Structure EFI_ACPI_6_0_GICR_STRUCTURE Gicr =3D SBSAQEMU_MADT_GICR_INIT(); =20 + // Initialize GIC ITS Structure + EFI_ACPI_6_0_GIC_ITS_STRUCTURE Gic_Its =3D SBSAQEMU_MADT_GIC_ITS_INIT(); + // Get CoreCount which was determined eariler after parsing device tree NumCores =3D PcdGet32 (PcdCoreCount); =20 @@ -98,7 +101,8 @@ AddMadtTable ( TableSize =3D sizeof (EFI_ACPI_6_0_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADE= R) + (sizeof (EFI_ACPI_6_0_GIC_STRUCTURE) * NumCores) + sizeof (EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE) + - sizeof (EFI_ACPI_6_0_GICR_STRUCTURE); + sizeof (EFI_ACPI_6_0_GICR_STRUCTURE) + + sizeof (EFI_ACPI_6_0_GIC_ITS_STRUCTURE); =20 Status =3D gBS->AllocatePages ( AllocateAnyPages, @@ -138,6 +142,10 @@ AddMadtTable ( CopyMem (New, &Gicr, sizeof (EFI_ACPI_6_0_GICR_STRUCTURE)); New +=3D sizeof (EFI_ACPI_6_0_GICR_STRUCTURE); =20 + // GIC ITS Structure + CopyMem (New, &Gic_Its, sizeof (EFI_ACPI_6_0_GIC_ITS_STRUCTURE)); + New +=3D sizeof (EFI_ACPI_6_0_GIC_ITS_STRUCTURE); + AcpiPlatformChecksum ((UINT8*) PageAddress, TableSize); =20 Status =3D AcpiTable->InstallAcpiTable ( --=20 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72684): https://edk2.groups.io/g/devel/message/72684 Mute This Topic: https://groups.io/mt/81262679/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-