From nobody Wed May 15 07:56:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72264+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72264+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1614584674; cv=none; d=zohomail.com; s=zohoarc; b=hOI0dkEbtMQqR2x0r4VzfDTfZ1eCQn47jMM1rzqgJ7rb65P3g5KYWYXxy/4I6kk9FZVC+PxAefYbCIB6PtvVxa1R6pmAVbdziQhlXne1nqzB6TDsEQYhxBkzbKjBb0pIMt/eSNdDRsK4gxhQqz+hFxt6JbFHq5ggWMkvvJRbjBY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614584674; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=5OjuX92+v9wvau50DsMjc2FU2fnneCfEbF+nvF7Qcgc=; b=O0blzKhhZ4tjpul7+4mrf2XaJS1x99nHTtGNh8aKi7XmK+PdML4nQ7WUCkBoBvpiNW2uC+x7fdznLWQfGW4QpH94kQ2GBVbbD3YjRHFjyJlEiAF3Q9lJqE1krZESSLmC8+JUrQNphWE4b+EsNygHysljZp2PTbZFgvKxr949tpA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72264+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16145846739461023.4525006568246; Sun, 28 Feb 2021 23:44:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 54ssYY1788612xJ3KlVluK0r; Sun, 28 Feb 2021 23:44:33 -0800 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.9465.1614584667487568630 for ; Sun, 28 Feb 2021 23:44:28 -0800 IronPort-SDR: udv4Zw4Ak/P40ogE1ygYURD6r/TJjOsCXv/bAuLjj8Mk+Apa+rhCJGTOCRZ4nZRnOTdC2gQiT+ T9NYgKXtEdDg== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="165618147" X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="165618147" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2021 23:44:26 -0800 IronPort-SDR: 0ZfFfsHbz8alz/oSfUSMGYNb9S2J6H26qMb5AkoRPmMMNXW0GQErdt+JjcZ0i7s4kJA/fRse1i llP4p3wW7RhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="406106834" X-Received: from sh1gapp1009.ccr.corp.intel.com ([10.239.189.79]) by orsmga008.jf.intel.com with ESMTP; 28 Feb 2021 23:44:24 -0800 From: "Wu, Jiaxin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Siyuan Fu Subject: [edk2-devel] [PATCH v1] MdePkg: Support standalone MM Driver Unload capability Date: Mon, 1 Mar 2021 15:44:21 +0800 Message-Id: <20210301074421.13232-1-Jiaxin.wu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com X-Gm-Message-State: Bwc6AqCGvWuEjprxuSUNPRPQx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614584673; bh=xci8k8TbK57PP89SQwZZEiTa6U7sOsmTsQwpgzrzTMA=; h=Cc:Date:From:Reply-To:Subject:To; b=GyTOh3F9qCFUQIj4ACONNakSbjBXGwmZg/7IVnrWe4iUO1k+ppGGLcWv9Zk6eGLVGUE Yq2VQZTy403ItsqWnxOeNGHQKfokB4GVSReY+e9wYjQaRhk1dRqWlT0NnOA8JIASAH1To Pp9JR2+uHCRmrZCBjiMKmmcxdd8uptLUBqg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D3240 This patch is to support standalone MM Driver Unload capability by providing _DriverUnloadHandler() function. Change-Id: I26cdbfccb7052685c464d6394e472c7579b7b67e Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Siyuan Fu Signed-off-by: Jiaxin Wu --- .../Include/Library/StandaloneMmDriverEntryPoint.h | 25 ++++++++++ .../StandaloneMmDriverEntryPoint.c | 56 ++++++++++++++++++= +++- .../StandaloneMmDriverEntryPoint.inf | 5 +- 3 files changed, 84 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h b/MdePkg= /Include/Library/StandaloneMmDriverEntryPoint.h index 25b2d8d68d..12f7886640 100644 --- a/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h +++ b/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h @@ -16,10 +16,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent /// Declare the PI Specification Revision that this driver requires to exe= cute /// correctly. /// extern CONST UINT32 _gMmRevision; =20 +/// +/// Declare the number of unload handler in the image. +/// +extern CONST UINT8 _gDriverUnloadImageCount; + /** The entry point of PE/COFF Image for a Standalone MM Driver. =20 This function is the entry point for a Standalone MM Driver. This function must call ProcessLibraryConstructorList() and @@ -120,6 +125,26 @@ EFIAPI ProcessModuleEntryPointList ( IN EFI_HANDLE ImageHandle, IN EFI_MM_SYSTEM_TABLE *MmSystemTable ); =20 +/** + Autogenerated function that calls a set of module unload handlers. + + This function must be called from the unload handler registered by _Modu= leEntryPoint(). + This function calls the set of module unload handlers. + This function is autogenerated by build tools and those build tools are = responsible + for collecting the module unload handlers and calling them in a specifie= d order. + + @param ImageHandle The image handle of the DXE Driver, DXE Runtime Dri= ver, DXE SMM Driver, or UEFI Driver. + + @retval EFI_SUCCESS The unload handlers executed normally. + @retval !EFI_SUCCESS The unload handlers failed to execute normally. + +**/ +EFI_STATUS +EFIAPI +ProcessModuleUnloadList ( + IN EFI_HANDLE ImageHandle + ); + #endif diff --git a/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriver= EntryPoint.c b/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriv= erEntryPoint.c index 2c41e23a03..d74c9bdfed 100644 --- a/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPo= int.c +++ b/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPo= int.c @@ -1,23 +1,63 @@ /** @file Entry point to a Standalone MM driver. =20 -Copyright (c) 2015, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
Copyright (c) 2016 - 2018, ARM Ltd. All rights reserved.
Copyright (c) 2018, Linaro, Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ =20 #include =20 +#include #include #include #include #include =20 +/** + Unloads an image from memory. + + This function is a callback that a driver registers to do cleanup + when the UnloadImage boot service function is called. + + @param ImageHandle The handle to the image to unload. + + @return Status returned by all unload(). + +**/ +EFI_STATUS +EFIAPI +_DriverUnloadHandler ( + EFI_HANDLE ImageHandle + ) +{ + EFI_STATUS Status; + + // + // If an UnloadImage() handler is specified, then call it + // + Status =3D ProcessModuleUnloadList (ImageHandle); + + // + // If the driver specific unload handler does not return an error, then = call all of the + // library destructors. If the unload handler returned an error, then t= he driver can not be + // unloaded, and the library destructors should not be called + // + if (!EFI_ERROR (Status)) { + ProcessLibraryDestructorList (ImageHandle, gMmst); + } + + // + // Return the status from the driver specific unload handler + // + return Status; +} + /** The entry point of PE/COFF Image for a Standalone MM Driver. =20 This function is the entry point for a Standalone MM Driver. This function must call ProcessLibraryConstructorList() and @@ -44,10 +84,11 @@ _ModuleEntryPoint ( IN EFI_HANDLE ImageHandle, IN IN EFI_MM_SYSTEM_TABLE *MmSystemTable ) { EFI_STATUS Status; + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage; =20 if (_gMmRevision !=3D 0) { // // Make sure that the MM spec revision of the platform // is >=3D MM spec revision of the driver @@ -60,10 +101,23 @@ _ModuleEntryPoint ( // // Call constructor for all libraries // ProcessLibraryConstructorList (ImageHandle, MmSystemTable); =20 + // + // Install unload handler... + // + if (_gDriverUnloadImageCount !=3D 0) { + Status =3D gMmst->MmHandleProtocol ( + ImageHandle, + &gEfiLoadedImageProtocolGuid, + (VOID **)&LoadedImage + ); + ASSERT_EFI_ERROR (Status); + LoadedImage->Unload =3D _DriverUnloadHandler; + } + // // Call the driver entry point // Status =3D ProcessModuleEntryPointList (ImageHandle, MmSystemTable); =20 diff --git a/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriver= EntryPoint.inf b/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDr= iverEntryPoint.inf index 2f33a6d4ad..9303566309 100644 --- a/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPo= int.inf +++ b/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPo= int.inf @@ -1,9 +1,9 @@ ## @file # Module entry point library for Standalone MM driver. # -# Copyright (c) 2015, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
# Copyright (c) 2016-2018, ARM Ltd. All rights reserved.
# Copyright (c) 2018, Linaro, Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -34,5 +34,8 @@ =20 [LibraryClasses] BaseLib DebugLib MmServicesTableLib + +[Protocols] + gEfiLoadedImageProtocolGuid ## SOMETIMES_CONSUMES --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72264): https://edk2.groups.io/g/devel/message/72264 Mute This Topic: https://groups.io/mt/80992105/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-