From nobody Sat May 4 16:28:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72177+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72177+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1614223953; cv=none; d=zohomail.com; s=zohoarc; b=cjuajrhKhJWXlfIwtfUtzmiZxrhGtjYlf7hteDHsJZewjJeuiiRco4KrkzagxJb2xSc/tS8160bxwGB5Xf3dVAi9lZu2vqBcDfDgFsnLvA3wasymKMahfSaoiCFC5DqKfSfu4IssPQTRlzDM3VWYzRSL+drIHu/OSEHCMDZoC6o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614223953; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Y14Z3p0YyANZXGcMuQgy82kVPP+1uXeZ3L5CBKWZhKs=; b=i0Cth2F75bquh93EQUiae1wKvQnjMDW90oYxSgPnGsfV243zZuiHmX6O9UCm6YvJEyf+XO/ucA/siRA2vFe5yY7Xtjz0HL9oTgQ5lx3gyYZ7CFHmB1LMjvGpUrxjdi8Nm8Qde3GP6meXJ3cWVH1FlKQJoLEpNW0critBa/XItxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72177+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614223953234551.4637774366386; Wed, 24 Feb 2021 19:32:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5qIuYY1788612xbhEPKpqdlK; Wed, 24 Feb 2021 19:32:32 -0800 X-Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by mx.groups.io with SMTP id smtpd.web11.6660.1614223951977797307 for ; Wed, 24 Feb 2021 19:32:32 -0800 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R611e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=huangming@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UPVMN6Z_1614223933; X-Received: from 842effaa37a8.tbsite.net(mailfrom:huangming@linux.alibaba.com fp:SMTPD_---0UPVMN6Z_1614223933) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 11:32:25 +0800 From: "Ming Huang" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: guoheyi@linux.alibaba.com, Ming Huang Subject: [edk2-devel] [PATCH edk2 v2 1/2] ArmPkg/ArmGicLib: Fix two macros issue for offset parameter Date: Thu, 25 Feb 2021 11:32:11 +0800 Message-Id: <20210225033212.2180-2-huangming@linux.alibaba.com> In-Reply-To: <20210225033212.2180-1-huangming@linux.alibaba.com> References: <20210225033212.2180-1-huangming@linux.alibaba.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,huangming@linux.alibaba.com X-Gm-Message-State: vyPiHvXGYxHBWCewHuHcAgCxx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614223952; bh=SIzvnr1RtCPXkNX9975I3001Wx1J54ThOkSZvnnRENA=; h=Cc:Date:From:Reply-To:Subject:To; b=w/tudXCNUiTTEXondFDpN7XpyghuobPEGtAe7Ke0j/jQHXeoGvvh7PM30HOQHpEL8n3 fUS6TNj04y2ll8IuqlcH82RewOhdwXbWSwWGkTytmrFYB34xBAlY86Ce31KmCQaZ3ZQil uau340vtE5p0+ayLFYhHBuTZ6R8x1F3m6s0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Modify two macros to put "offset" in parentheses and remove parentheses from "4 * offset". Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 8ef32b33a1..5d04ed3dac 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -25,10 +25,10 @@ + ARM_GICR_SGI_RESERVED_FRAME_S= IZE) =20 #define ISENABLER_ADDRESS(base,offset) ((base) + \ - ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ISENABLER + (4 * offset)) + ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ISENABLER + 4 * (offset)) =20 #define ICENABLER_ADDRESS(base,offset) ((base) + \ - ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + (4 * offset)) + ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + 4 * (offset)) =20 /** * --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72177): https://edk2.groups.io/g/devel/message/72177 Mute This Topic: https://groups.io/mt/80895011/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 16:28:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72176+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72176+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1614223951; cv=none; d=zohomail.com; s=zohoarc; b=Cml1sJ5pWyhp7ROZYWYrnkC+Xy2tKwfR+FK3qtfHfKvy23REywK4Wa82QVhzQ4OsGa8Zmam/qPUpkwCvKmlkFEIFBaDpT99On64mbAl49mASsVqHuJh6xnzmNLyCjE3qhGjh0SN0f/8LPxHsN6JkxuNYWzDlMgAGoetLTRcan3k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614223951; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=2x59X+zxkVkvbVhHL4JGk9RCmzxvhslswUHoSQfzonY=; b=XsqCP/fpv4RctzYiqoxzcQ8KM8UDWe3A3E4ZcjjhmqzOyPtMIiGsI/zoDHKZLFQi4WD8BXhg0S0+91CoxWHPMlXJe1HKZrO3UlmxDRQdKA9sUkoh2m3Yv1II3gR4GNnRkYpaI8+ZZQjl8fEYNnqfG8aOBL+0fY4wbmtlz0EJ3Zg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72176+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614223951551841.4837918002731; Wed, 24 Feb 2021 19:32:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id cx70YY1788612xF2y2w01Hlp; Wed, 24 Feb 2021 19:32:31 -0800 X-Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by mx.groups.io with SMTP id smtpd.web12.6891.1614223949684775392 for ; Wed, 24 Feb 2021 19:32:30 -0800 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=huangming@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UPVMN6Z_1614223933; X-Received: from 842effaa37a8.tbsite.net(mailfrom:huangming@linux.alibaba.com fp:SMTPD_---0UPVMN6Z_1614223933) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 11:32:26 +0800 From: "Ming Huang" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: guoheyi@linux.alibaba.com, Ming Huang Subject: [edk2-devel] [PATCH edk2 v2 2/2] ArmPkg/ArmGicLib: Fix GICR_IPRIORITYR address wrong issue Date: Thu, 25 Feb 2021 11:32:12 +0800 Message-Id: <20210225033212.2180-3-huangming@linux.alibaba.com> In-Reply-To: <20210225033212.2180-1-huangming@linux.alibaba.com> References: <20210225033212.2180-1-huangming@linux.alibaba.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,huangming@linux.alibaba.com X-Gm-Message-State: kTvAUbFteT5qUi3uGmWnOE3Yx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614223951; bh=l1NfI1hHovqAkv6Lcljk0SEBcYa1ACIBaZVFQaTu23c=; h=Cc:Date:From:Reply-To:Subject:To; b=stXCuRz7SV1TCzFQyRErT65dx0evQgbMVEDLRi5B43RPGB2mvdCrP+uCB5/kyrZYMMX IlAJqWfduPNeMLNopeKTP9gAWi157spfrfDLnG9Ra/YnjOaWLaR8r02mzK2yrfILG+wPR /7blXX3UkEdWeRe2CE1fJQPcOJr0df/UxQ4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The register address of GICR_IPRIORITYR is in SGI_base frame. Add IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise GIC RAS error(Uncorrected software error) may report in ArmGicDxe. Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 5d04ed3dac..6b01c88206 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -30,6 +30,9 @@ #define ICENABLER_ADDRESS(base,offset) ((base) + \ ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + 4 * (offset)) =20 +#define IPRIORITY_ADDRESS(base,offset) ((base) + \ + ARM_GICR_CTLR_FRAME_SIZE + ARM_GIC_ICDIPR + 4 * (offset)) + /** * * Return whether the Source interrupt index refers to a shared interrupt = (SPI) @@ -236,7 +239,7 @@ ArmGicSetInterruptPriority ( } =20 MmioAndThenOr32 ( - GicCpuRedistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset), + IPRIORITY_ADDRESS (GicCpuRedistributorBase, RegOffset), ~(0xff << RegShift), Priority << RegShift ); --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72176): https://edk2.groups.io/g/devel/message/72176 Mute This Topic: https://groups.io/mt/80895010/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-