From nobody Tue Feb 10 04:16:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72077+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72077+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086098; cv=none; d=zohomail.com; s=zohoarc; b=XjNx9VpDgpNAfFeh/1VyFpfEqNHK61NBKUWBZl47sCWfRpnd/Ij8niXhex06pBnPopkj9J/o6IBHOO2fzrztiItAGxJWC3AAqR0AFvnCiyFhH0viDMqNPrdNzAr1uqgUGc8iuR4YoK6e3qmHR9TJEX2RYXqhUFzyi3DNX049r60= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086098; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Q2WL6FuobQYsgHx1Ja/NGJK4lj7MABTtUm0jE4TrlNA=; b=eUdd2Aib1Aueb3u6urdgOBPh8bIxMFZOHInfyv12mG5CqCPnpd0clrK93ldtt3XRrPJOKo2bQTv5tr262CkHREMtldwYKP1iO+4BFvTohZeNVJOYllvlDkhFVZiY4FNNi3uNL7hKdmviLaudLery2MsLUnH4rS/BJkoU0QXFJiw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72077+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086098435151.27605446471023; Tue, 23 Feb 2021 05:14:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ykncYY1788612xAMOKjGgt6S; Tue, 23 Feb 2021 05:14:58 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.9481.1614086092566516900 for ; Tue, 23 Feb 2021 05:14:52 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 397D531B; Tue, 23 Feb 2021 05:14:52 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D787E3F70D; Tue, 23 Feb 2021 05:14:50 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE Date: Tue, 23 Feb 2021 13:14:03 +0000 Message-Id: <20210223131406.3484-24-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: zIpDpqW4mmgV5wX5L2Y0lwTyx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086098; bh=JIDvL9XhwpO0dS4bgaBBIdpediTWW4lW2ht/Y12jZWE=; h=Date:From:Reply-To:Subject:To; b=QLl/9cW5Z7AJi7y19L4lKwDB51R72CCMenq7W/7b18+REdrR0bJaw8a8PDIqk9j7tsE ZC/5vwHxb2Dfi77kyfN8gB7FD3W3wZ9PTrad81COXP2VxF2BtVV394NW5Lw3XzagEJp/r dhca5UUJWy3zGtcfkwmFPgLKVfXqqHPGNeI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 Notes: v3: - Import ScmiMessageIdBasexxx related changes from the patch 'ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK'. [Sami] ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 12 ++++++------ ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c b/ArmPkg/Drivers/= ArmScmiDxe/ScmiBaseProtocol.c index c84ce97f15ac..2c6206be9368 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c @@ -69,9 +69,9 @@ BaseGetTotalProtocols ( =20 /** Common function which returns vendor details. =20 - @param[in] MessageId SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR + @param[in] MessageId ScmiMessageIdBaseDiscoverVendor OR - SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR + ScmiMessageIdBaseDiscoverSubVendor =20 @param[out] VendorIdentifier ASCII name of the vendor/subvendor. =20 @@ -133,7 +133,7 @@ BaseDiscoverVendor ( ) { return BaseDiscoverVendorDetails ( - SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR, + ScmiMessageIdBaseDiscoverVendor, VendorIdentifier ); } @@ -156,7 +156,7 @@ BaseDiscoverSubVendor ( ) { return BaseDiscoverVendorDetails ( - SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR, + ScmiMessageIdBaseDiscoverSubVendor, VendorIdentifier ); } @@ -184,7 +184,7 @@ BaseDiscoverImplVersion ( UINT32 PayloadLength; =20 Cmd.ProtocolId =3D ScmiProtocolIdBase; - Cmd.MessageId =3D SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION; + Cmd.MessageId =3D ScmiMessageIdBaseDiscoverImplementationVersion; =20 PayloadLength =3D 0; =20 @@ -251,7 +251,7 @@ BaseDiscoverListProtocols ( } =20 Cmd.ProtocolId =3D ScmiProtocolIdBase; - Cmd.MessageId =3D SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS; + Cmd.MessageId =3D ScmiMessageIdBaseDiscoverListProtocols; =20 Skip =3D 0; =20 diff --git a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h b/ArmPkg/Include= /Protocol/ArmScmiBaseProtocol.h index 2f93ec92325e..73ad3e32a2f5 100644 --- a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -158,10 +158,10 @@ typedef struct _SCMI_BASE_PROTOCOL { =20 // SCMI Message IDs for Base protocol. typedef enum { - SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR =3D 0x3, - SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR =3D 0x4, - SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION =3D 0x5, - SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS =3D 0x6 + ScmiMessageIdBaseDiscoverVendor =3D 0x3, + ScmiMessageIdBaseDiscoverSubVendor =3D 0x4, + ScmiMessageIdBaseDiscoverImplementationVersion =3D 0x5, + ScmiMessageIdBaseDiscoverListProtocols =3D 0x6 } SCMI_MESSAGE_ID_BASE; =20 #endif /* ARM_SCMI_BASE_PROTOCOL_H_ */ --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72077): https://edk2.groups.io/g/devel/message/72077 Mute This Topic: https://groups.io/mt/80850103/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-