From nobody Mon Feb 9 23:04:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72075+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72075+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086096; cv=none; d=zohomail.com; s=zohoarc; b=LR5w2H2Br/Nkp98Gc9+MjOKxGR7ykXB4xIXEtpYA/g1oUDUJXBO5A2cjPf2G3uVTIDG5LMPmFLZuNjo7N77gWmIzXeVN4DsiyaKQEjtixhI0u8a7jIC0hDDMw4mG8uoaipUFa5g8AccY4c2QDGqcNFBdA2RSaJytnjSzHZuN0UE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086096; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=8bQUBsLg7rxNbmDOZWL8wMwyT1h65GmDkYHjCvAbFU8=; b=lohJYN8NaIWv7itrKnhZ4YH0zgZOPi6+l9lwOZyImTiHqcww7TgbfVjt148nX2WKq4xp67Z5LYgeXVqoMpw6a79HfQligBQ4jGzmU2n2bgXeeJnQKs71TMvBQpeIaVquEfj+hdUADuVBfqj/P0zAbzia6PTyTpdlHpgYzYGbPy8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72075+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086096026998.8786740127849; Tue, 23 Feb 2021 05:14:56 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id XW45YY1788612xv1bSpW6lLn; Tue, 23 Feb 2021 05:14:54 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.9480.1614086089182409955 for ; Tue, 23 Feb 2021 05:14:49 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D07E231B; Tue, 23 Feb 2021 05:14:48 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C681D3F70D; Tue, 23 Feb 2021 05:14:47 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS Date: Tue, 23 Feb 2021 13:14:01 +0000 Message-Id: <20210223131406.3484-22-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Bq0IKz4CQXWK9t7mDfMRQBC2x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086094; bh=RklaNZP/TdRq1yYAy2Oej4S1+GEfVkDYaEuWTzaZ1FI=; h=Date:From:Reply-To:Subject:To; b=IBLAfjHQ06aTemJD/Oa5/C/+zaBWb3XI3M0JIpvyJHc+uc6ArUcBjdicLqEyeRfFbfF F7f0QjQ6h5ZJ0AEkYNXa/tXtdT12e0J+s1526vUVAqqS4QVga6PdmelkbQKCj2gaJA5OV PXZMK3UgwVRZNavTsoiXIPszzEcyEDO7jRw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/S= cmi.c index 25f6cc3371af..a1bf1b95c052 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -123,7 +123,7 @@ ScmiCommandExecute ( =20 Response =3D (SCMI_MESSAGE_RESPONSE*)MtlGetChannelPayload (Channel); =20 - if (Response->Status !=3D SCMI_SUCCESS) { + if (Response->Status !=3D ScmiSuccess) { DEBUG ((DEBUG_ERROR, "SCMI error: ProtocolId =3D 0x%x, MessageId =3D 0= x%x, error =3D %d\n", Command->ProtocolId, Command->MessageId, diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmSc= miDxe/ScmiPrivate.h index 6de57a5c9514..118961dbe219 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -30,17 +30,17 @@ typedef enum { =20 // SCMI response error codes. typedef enum { - SCMI_SUCCESS =3D 0, - SCMI_NOT_SUPPORTED =3D -1, - SCMI_INVALID_PARAMETERS =3D -2, - SCMI_DENIED =3D -3, - SCMI_NOT_FOUND =3D -4, - SCMI_OUT_OF_RANGE =3D -5, - SCMI_BUSY =3D -6, - SCMI_COMMS_ERROR =3D -7, - SCMI_GENERIC_ERROR =3D -8, - SCMI_HARDWARE_ERROR =3D -9, - SCMI_PROTOCOL_ERROR =3D -10 + ScmiSuccess =3D 0, + ScmiNotSupported =3D -1, + ScmiInvalidParameters =3D -2, + ScmiDenied =3D -3, + ScmiNotFound =3D -4, + ScmiOutOfRange =3D -5, + ScmiBusy =3D -6, + ScmiCommsError =3D -7, + ScmiGenericError =3D -8, + ScmiHardwareError =3D -9, + ScmiProtocolError =3D -10 } SCMI_STATUS; =20 // SCMI message IDs common to all protocols. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72075): https://edk2.groups.io/g/devel/message/72075 Mute This Topic: https://groups.io/mt/80850100/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-