From nobody Tue Feb 10 01:33:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72074+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72074+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086093; cv=none; d=zohomail.com; s=zohoarc; b=mES0boaBMM/zL0431UejbPkTUwW65CnvfohWmRb9FEkZ5ytgoYrr/2NVaKEQ/hCADRsLPM7UiA4tWmXVtLZQOOoptTInz3CZfUxtMVXX6ZUTHzTwTvkuNygZ8TZ2bam6Zd3AQvN9y02ltw87GB7cS32o+Z+1ee3FabJH8UXcwGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086093; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=QDDRASyKX2GVLejOHL4wgzGSD0cVf2rOIDso47Ibiko=; b=RNCdb6NLqtA9jF0qU1HsVKqr8AYIwBbFiG3hSJXsLQb3znCABKR/LClG/wMYpRZp7GVLo4pvsp8c1kYlA+PCeKfTS6H+kwFIOL9KAKTXlpWS6cLoqoHaQ9KPMsRSKmrC4dxsJS26xknUO/AES7HO+XBjA5Wp3a9S+LPCqfHkaDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72074+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161408609353941.804190716366975; Tue, 23 Feb 2021 05:14:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id wdQTYY1788612xfbYwPTybh6; Tue, 23 Feb 2021 05:14:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9421.1614086087750764696 for ; Tue, 23 Feb 2021 05:14:47 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66A3331B; Tue, 23 Feb 2021 05:14:47 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2F34F3F70D; Tue, 23 Feb 2021 05:14:46 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE Date: Tue, 23 Feb 2021 13:14:00 +0000 Message-Id: <20210223131406.3484-21-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: wDwTrbQnaYjyOaV1LoiHhHmJx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086093; bh=WjrSTk2wri94itfCTmL2WsuUI2w0EIcnlmOTvI5pjq0=; h=Date:From:Reply-To:Subject:To; b=X6drj72WZubqGiqhcE5n1DKFscwNjYokx+gdf7SOIAYYm39usPH8Zj+M+XrRFCycilH DefiieCR2iclrZhKdD3tyI7ZItcshBdXfMKXmOMov/f9nlGzqJ1sQCUbfeaTZ+2tPIeRW fgSmDgPTznyYXj1nBJf2SixihFTzvuaaLlo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/S= cmi.c index 847868a7749e..25f6cc3371af 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -95,7 +95,7 @@ ScmiCommandExecute ( // Fill in message header. MessageHeader =3D SCMI_MESSAGE_HEADER ( Command->MessageId, - SCMI_MESSAGE_TYPE_COMMAND, + ScmiMessageTypeCommand, Command->ProtocolId ); =20 diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmSc= miDxe/ScmiPrivate.h index 5f1225f54cd9..6de57a5c9514 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -23,9 +23,9 @@ typedef enum { =20 // SCMI message types. typedef enum { - SCMI_MESSAGE_TYPE_COMMAND =3D 0, - SCMI_MESSAGE_TYPE_DELAYED_RESPONSE =3D 2, // Skipping 1 is deliberate. - SCMI_MESSAGE_TYPE_NOTIFICATION =3D 3 + ScmiMessageTypeCommand =3D 0, + ScmiMessageTypeDelayedResponse =3D 2, // Skipping 1 is deliberate. + ScmiMessageTypeNotification =3D 3 } SCMI_MESSAGE_TYPE; =20 // SCMI response error codes. --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72074): https://edk2.groups.io/g/devel/message/72074 Mute This Topic: https://groups.io/mt/80850099/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-