From nobody Tue Feb 10 10:55:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72070+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72070+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086082; cv=none; d=zohomail.com; s=zohoarc; b=NE9eeAiota+DOu7U+izA/b+HldJDnKEDTGMl8cEcNayt/zzqJQvwTpXBC/ZXEAEWRJu6gE0GyHtmYoqNJyDVq+Vue/gMydCNk2nXH0NQC8lGQChrIK/SM7skNgk1sql8akD9tWOS4QuD7O4ie6LerLQZ1MPwR5lsm/uTh06YPyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086082; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=UFDD5l+zG1sxNAYZwY8O2FFZbRqB9lM0r/eprnuOROo=; b=h7nPYzWqNGNI6hAROn0QwdNWGBVkQGGwiE/vFKahEeytFJ/VsaWxCxobXshfMT/xDv2L/oJXsaR1XILduszrFLfIh/ZDZ5MjZlMcFKF872A2ZZ4WrTu2SiBzQsNPRkGRIJs773mJUATAXIovvFZULIkPuqEfA/mODfknmOLPrgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72070+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16140860821281015.7107836728633; Tue, 23 Feb 2021 05:14:42 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lBuaYY1788612x6q1elH2wVz; Tue, 23 Feb 2021 05:14:41 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9506.1614086081305626609 for ; Tue, 23 Feb 2021 05:14:41 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ECBF231B; Tue, 23 Feb 2021 05:14:40 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E06DA3F70D; Tue, 23 Feb 2021 05:14:39 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE Date: Tue, 23 Feb 2021 13:13:56 +0000 Message-Id: <20210223131406.3484-17-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ImxoIvpkfrHfXubINNMAQ78ax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086081; bh=W+Y6Qvr3mXdUI2yMMkrbV0puq/CuXRJZFiJZT8U5gTI=; h=Date:From:Reply-To:Subject:To; b=JVXKNsvvLwkyPDUqgHLEjSkKTXOw2+HTeJ1ss64n84OSiXMHiQjkSBf4KIwxJhAcpO8 uXvuhmUmuV2a2s2fx1Yvr4glIldWq7GzJnmjXE0ATFeYdzcOLOa/VCZ6AW/qkgo2rpLK8 Hy9bx1gWr1hDOQAmAxNvuxgH6BIvsY2h7xk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 12 ++++++++---- ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 14 ++++++++++---- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers= /ArmScmiDxe/ScmiClockProtocol.c index c66c414385dd..5c06e31bda22 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -255,22 +255,26 @@ ClockDescribeRates ( for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { Rate =3D &DescribeRates->Rates[RateOffset++]; // Non-linear discrete rates. - RateArray[RateIndex++].Rate =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].DiscreteRate.Rate =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } else { for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { // Linear clock rates from minimum to maximum in steps // Minimum clock rate. Rate =3D &DescribeRates->Rates[RateOffset++]; - RateArray[RateIndex].Min =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Min =3D + ConvertTo64Bit (Rate->Low, Rate->High); =20 Rate =3D &DescribeRates->Rates[RateOffset++]; // Maximum clock rate. - RateArray[RateIndex].Max =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Max =3D + ConvertTo64Bit (Rate->Low, Rate->High); =20 Rate =3D &DescribeRates->Rates[RateOffset++]; // Step. - RateArray[RateIndex++].Step =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].ContinuousRate.Step =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } } while (NUM_REMAIN_RATES (DescribeRates->NumRatesFlags) !=3D 0); diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Includ= e/Protocol/ArmScmiClockProtocol.h index b4d970dee3e2..85b5b8d1e764 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -57,12 +57,18 @@ typedef enum { either Rate or Min/Max/Step triplet is valid. */ typedef struct { - union { UINT64 Min; - UINT64 Rate; - }; UINT64 Max; UINT64 Step; +} SCMI_CLOCK_RATE_CONTINUOUS; + +typedef struct { + UINT64 Rate; +} SCMI_CLOCK_RATE_DISCRETE; + +typedef union { + SCMI_CLOCK_RATE_CONTINUOUS ContinuousRate; + SCMI_CLOCK_RATE_DISCRETE DiscreteRate; } SCMI_CLOCK_RATE; =20 #pragma pack() --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72070): https://edk2.groups.io/g/devel/message/72070 Mute This Topic: https://groups.io/mt/80850094/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-