From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72055+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72055+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086069; cv=none; d=zohomail.com; s=zohoarc; b=ft9tpAjAuMTuWWtDt+KEFzZSQYpRse1G/XLL/cb2BdA7CfCYAWUgZHmdEA+rEAephufAUpjH0WlXAdKE4gchFlqQcVO+5L7YVAWuPH7r0cNBJsD5v7BSK/1pZoPWH37j8vnyvtfu1jhFzp4k7DUIdprB1XA/alqhz0SKYwNKfIs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086069; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=MnTT6PAUC4ya4Ps10LX5lbC35zOjMJkkaJPF/Z2C9lk=; b=OW+hHTu9zs7P5GWPcoz6r01w32/bAfmDXN9WbH/7GdZbzpGH5TSy4O90eLcrCehYoNIqr1aFnRrHXG0omNCrN6rgMIBU2R7J+aGloHuDz86jejTQoPhO3uwSBcKkKgsF4d9CfZ2zyD9JiyubeUVo/q6VZhjREH2ESJCKYoxEwb0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72055+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086069041298.836226065907; Tue, 23 Feb 2021 05:14:29 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id oBBFYY1788612xZB8wU6yneb; Tue, 23 Feb 2021 05:14:26 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9494.1614086060378892944 for ; Tue, 23 Feb 2021 05:14:20 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF122101E; Tue, 23 Feb 2021 05:14:19 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 21C353F70D; Tue, 23 Feb 2021 05:14:18 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 01/26] ArmPkg: Fix Ecc error 8001 in Chipset Date: Tue, 23 Feb 2021 13:13:41 +0000 Message-Id: <20210223131406.3484-2-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 7jomMvvZ3tCG1YCPUTgV6Hrmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086066; bh=4s6bDuMXKsoa9xzvkCYokQ5vjnCEabtgY4tAWpmpCd0=; h=Date:From:Reply-To:Subject:To; b=NSd2xAeY994mLqqbLxxmbhcbj0rEjy58hWZY0bYEABjZ7pod70OoogRFH0KkgvN3QF+ otQQRvW60OSgmIrBjOQpDAbGkpnIoqAI/jf2JpDDf7UccsUa+30/X7xcgAGb2Gt7spfkL oWDVkCtgVa8QEYTK709/v272qgX9kS2u5bM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard of ArmCortexA5x.h is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 Notes: v2: - Only use one trailing underscore for the ARM_CORTEX_A5x_H__ include guard. [Sami] - 2 patches had the same name and fixed the same Ecc error in V1. They are merged in V2. [Pierre] ArmPkg/Include/Chipset/AArch64.h | 12 ++++++------ ArmPkg/Include/Chipset/AArch64Mmu.h | 4 ++-- ArmPkg/Include/Chipset/ArmCortexA5x.h | 8 ++++---- ArmPkg/Include/Chipset/ArmV7.h | 4 ++-- .../ArmExceptionLib/AArch64/ExceptionSupport.S | 10 +++++----- ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 10 +++++----- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/Include/Chipset/AArc= h64.h index 7c2b592f92ee..09d4cfe28da7 100644 --- a/ArmPkg/Include/Chipset/AArch64.h +++ b/ArmPkg/Include/Chipset/AArch64.h @@ -1,7 +1,7 @@ /** @file =20 Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2017, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -39,7 +39,7 @@ // MIDR - Main ID Register definitions #define ARM_CPU_TYPE_SHIFT 4 #define ARM_CPU_TYPE_MASK 0xFFF -#define ARM_CPU_TYPE_AEMv8 0xD0F +#define ARM_CPU_TYPE_AEMV8 0xD0F #define ARM_CPU_TYPE_A53 0xD03 #define ARM_CPU_TYPE_A57 0xD07 #define ARM_CPU_TYPE_A72 0xD08 @@ -97,10 +97,10 @@ #define ARM_VECTOR_CUR_SP0_FIQ 0x100 #define ARM_VECTOR_CUR_SP0_SERR 0x180 =20 -#define ARM_VECTOR_CUR_SPx_SYNC 0x200 -#define ARM_VECTOR_CUR_SPx_IRQ 0x280 -#define ARM_VECTOR_CUR_SPx_FIQ 0x300 -#define ARM_VECTOR_CUR_SPx_SERR 0x380 +#define ARM_VECTOR_CUR_SPX_SYNC 0x200 +#define ARM_VECTOR_CUR_SPX_IRQ 0x280 +#define ARM_VECTOR_CUR_SPX_FIQ 0x300 +#define ARM_VECTOR_CUR_SPX_SERR 0x380 =20 #define ARM_VECTOR_LOW_A64_SYNC 0x400 #define ARM_VECTOR_LOW_A64_IRQ 0x480 diff --git a/ArmPkg/Include/Chipset/AArch64Mmu.h b/ArmPkg/Include/Chipset/A= Arch64Mmu.h index 606fe7420d67..6c7ada16b18a 100644 --- a/ArmPkg/Include/Chipset/AArch64Mmu.h +++ b/ArmPkg/Include/Chipset/AArch64Mmu.h @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2013, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -190,7 +190,7 @@ =20 // The value written to the T*SZ fields are defined as 2^(64-T*SZ). So a 3= 9Bit // Virtual address range for 512GB of virtual space sets T*SZ to 25 -#define INPUT_ADDRESS_SIZE_TO_TxSZ(a) (64 - a) +#define INPUT_ADDRESS_SIZE_TO_TXSZ(a) (64 - a) =20 // Uses LPAE Page Table format =20 diff --git a/ArmPkg/Include/Chipset/ArmCortexA5x.h b/ArmPkg/Include/Chipset= /ArmCortexA5x.h index 847a6e00430b..e597eee947cf 100644 --- a/ArmPkg/Include/Chipset/ArmCortexA5x.h +++ b/ArmPkg/Include/Chipset/ArmCortexA5x.h @@ -1,13 +1,13 @@ /** @file =20 - Copyright (c) 2012-2014, ARM Limited. All rights reserved. + Copyright (c) 2012 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ =20 -#ifndef __ARM_CORTEX_A5x_H__ -#define __ARM_CORTEX_A5x_H__ +#ifndef ARM_CORTEX_A5X_H_ +#define ARM_CORTEX_A5X_H_ =20 // // Cortex A5x feature bit definitions @@ -41,4 +41,4 @@ ArmUnsetCpuExCrBit ( IN UINT64 Bits ); =20 -#endif +#endif // ARM_CORTEX_A5X_H_ diff --git a/ArmPkg/Include/Chipset/ArmV7.h b/ArmPkg/Include/Chipset/ArmV7.h index fe91031ef33d..025f87a56d16 100644 --- a/ArmPkg/Include/Chipset/ArmV7.h +++ b/ArmPkg/Include/Chipset/ArmV7.h @@ -1,7 +1,7 @@ /** @file =20 Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011-2015, ARM Ltd. All rights reserved.
+ Copyright (c) 2011-2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -70,7 +70,7 @@ // MIDR - Main ID Register definitions #define ARM_CPU_TYPE_SHIFT 4 #define ARM_CPU_TYPE_MASK 0xFFF -#define ARM_CPU_TYPE_AEMv8 0xD0F +#define ARM_CPU_TYPE_AEMV8 0xD0F #define ARM_CPU_TYPE_A53 0xD03 #define ARM_CPU_TYPE_A57 0xD07 #define ARM_CPU_TYPE_A15 0xC0F diff --git a/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S b/Ar= mPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S index 5b10a1339ac1..9202952ee9c0 100644 --- a/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S +++ b/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S @@ -1,5 +1,5 @@ // -// Copyright (c) 2011 - 2014 ARM LTD. All rights reserved.
+// Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
// Portion of Copyright (c) 2014 NVIDIA Corporation. All rights reserved.<= BR> // Copyright (c) 2016 HP Development Company, L.P. // @@ -200,19 +200,19 @@ ASM_PFX(SErrorSP0): // // Current EL with SPx: 0x200 - 0x380 // -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_SYNC) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_SYNC) ASM_PFX(SynchronousExceptionSPx): ExceptionEntry EXCEPT_AARCH64_SYNCHRONOUS_EXCEPTIONS, SP0 =20 -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_IRQ) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_IRQ) ASM_PFX(IrqSPx): ExceptionEntry EXCEPT_AARCH64_IRQ =20 -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_FIQ) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_FIQ) ASM_PFX(FiqSPx): ExceptionEntry EXCEPT_AARCH64_FIQ =20 -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_SERR) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_SERR) ASM_PFX(SErrorSPx): ExceptionEntry EXCEPT_AARCH64_SERROR =20 diff --git a/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S b/ArmPlatformPkg= /PrePeiCore/AArch64/Exception.S index 59a3da2721e7..43e40f97c3ee 100644 --- a/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S +++ b/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S @@ -1,5 +1,5 @@ # -# Copyright (c) 2011-2014, ARM Limited. All rights reserved. +# Copyright (c) 2011-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -51,22 +51,22 @@ _DefaultSError_t: mov x0, #EXCEPT_AARCH64_SERROR TO_HANDLER =20 -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_SYNC) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_SYNC) _DefaultSyncExceptHandler_h: mov x0, #EXCEPT_AARCH64_SYNCHRONOUS_EXCEPTIONS TO_HANDLER =20 -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_IRQ) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_IRQ) _DefaultIrq_h: mov x0, #EXCEPT_AARCH64_IRQ TO_HANDLER =20 -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_FIQ) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_FIQ) _DefaultFiq_h: mov x0, #EXCEPT_AARCH64_FIQ TO_HANDLER =20 -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_SERR) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_SERR) _DefaultSError_h: mov x0, #EXCEPT_AARCH64_SERROR TO_HANDLER --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72055): https://edk2.groups.io/g/devel/message/72055 Mute This Topic: https://groups.io/mt/80850067/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72056+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72056+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086062; cv=none; d=zohomail.com; s=zohoarc; b=ALl11N0zGkAJKzJQa3dfD40Nsmp/YNwIT5gTZgyqpR6whIKz6yP6Y5ucUVWatmhQnB1+iz9xSRxi0ukoyJFp3gNhW4Qrs70gEOs2c98hyHLyVvjbfRsGOhC6jDbnf+qJQI8qdCYb8S3z80Ks118wj6NAkNYTkAyxjwMcux3G2c0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086062; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=qYVgLRmyk1PabCl1IBRQwjmDfjtL+oaq7a9AYhOTNh4=; b=KYBqRZWayh8k07PJiHSCUKAufZTi1o+QESEnlIoDxqZgxGW96eXhEv+3EJLVwpEfuz9cRfi6jG1m8U2blmjRE/pa++26/G/qyS7t3qNVPdCWdl8mib8laCDFIFTgCZqarM8QGpd9culNx0cuKIb38UFDhFsd9Kf/vwa3Wm6mc3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72056+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161408606279689.62150642260838; Tue, 23 Feb 2021 05:14:22 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id klvWYY1788612xy4IMe79Jsb; Tue, 23 Feb 2021 05:14:22 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9496.1614086061866430369 for ; Tue, 23 Feb 2021 05:14:22 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6443F31B; Tue, 23 Feb 2021 05:14:21 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 405DC3F70D; Tue, 23 Feb 2021 05:14:20 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib Date: Tue, 23 Feb 2021 13:13:42 +0000 Message-Id: <20210223131406.3484-3-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: cx5p9XVV8pMHY1Lhfla1v8T7x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086062; bh=GTCwIyYTHQug8lWmTY5zncmwqMkgAzx+n9vGjid6B6Y=; h=Date:From:Reply-To:Subject:To; b=p6wYzZPuprqmTp7pESlvVbKsyRY5K9sRuxytbzhFuo/bjVH1Fdy9UqALDA2Ddk+5r9q uo+RqrKGSCMU+5JoykbqIvLashLSZUnkBMYOElEkZkdjsWJ3WoeW72RywNLVSGjD3Tbj6 7ZdS0kLWk3AV0tw/Rr6NTaUc0ORVxD/JXEA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Library/SemihostLib/SemihostLib.c | 26 +++---- ArmPkg/Library/SemihostLib/SemihostPrivate.h | 80 ++++++++++---------- 2 files changed, 53 insertions(+), 53 deletions(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.c b/ArmPkg/Library/Semi= hostLib/SemihostLib.c index a75d45850d43..d66de71182c8 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.c +++ b/ArmPkg/Library/SemihostLib/SemihostLib.c @@ -44,7 +44,7 @@ SemihostFileOpen ( OpenBlock.Mode =3D Mode; OpenBlock.NameLength =3D AsciiStrLen(FileName); =20 - Result =3D Semihost_SYS_OPEN(&OpenBlock); + Result =3D SEMIHOST_SYS_OPEN (&OpenBlock); =20 if (Result =3D=3D -1) { return RETURN_NOT_FOUND; @@ -66,7 +66,7 @@ SemihostFileSeek ( SeekBlock.Handle =3D FileHandle; SeekBlock.Location =3D Offset; =20 - Result =3D Semihost_SYS_SEEK(&SeekBlock); + Result =3D SEMIHOST_SYS_SEEK (&SeekBlock); =20 // Semihosting does not behave as documented. It returns the offset on // success. @@ -95,7 +95,7 @@ SemihostFileRead ( ReadBlock.Buffer =3D Buffer; ReadBlock.Length =3D *Length; =20 - Result =3D Semihost_SYS_READ(&ReadBlock); + Result =3D SEMIHOST_SYS_READ (&ReadBlock); =20 if ((*Length !=3D 0) && (Result =3D=3D *Length)) { return RETURN_ABORTED; @@ -122,7 +122,7 @@ SemihostFileWrite ( WriteBlock.Buffer =3D Buffer; WriteBlock.Length =3D *Length; =20 - *Length =3D Semihost_SYS_WRITE(&WriteBlock); + *Length =3D SEMIHOST_SYS_WRITE (&WriteBlock); =20 if (*Length !=3D 0) return RETURN_ABORTED; @@ -135,7 +135,7 @@ SemihostFileClose ( IN UINTN FileHandle ) { - if (Semihost_SYS_CLOSE (&FileHandle) =3D=3D -1) { + if (SEMIHOST_SYS_CLOSE (&FileHandle) =3D=3D -1) { return RETURN_INVALID_PARAMETER; } else { return RETURN_SUCCESS; @@ -154,7 +154,7 @@ SemihostFileLength ( return RETURN_INVALID_PARAMETER; } =20 - Result =3D Semihost_SYS_FLEN(&FileHandle); + Result =3D SEMIHOST_SYS_FLEN (&FileHandle); =20 if (Result =3D=3D -1) { return RETURN_ABORTED; @@ -195,7 +195,7 @@ SemihostFileTmpName( TmpNameBlock.Identifier =3D Identifier; TmpNameBlock.Length =3D Length; =20 - Result =3D Semihost_SYS_TMPNAME (&TmpNameBlock); + Result =3D SEMIHOST_SYS_TMPNAME (&TmpNameBlock); =20 if (Result !=3D 0) { return RETURN_ABORTED; @@ -220,7 +220,7 @@ SemihostFileRemove ( RemoveBlock.FileName =3D FileName; RemoveBlock.NameLength =3D AsciiStrLen(FileName); =20 - Result =3D Semihost_SYS_REMOVE(&RemoveBlock); + Result =3D SEMIHOST_SYS_REMOVE (&RemoveBlock); =20 if (Result =3D=3D 0) { return RETURN_SUCCESS; @@ -258,7 +258,7 @@ SemihostFileRename( RenameBlock.NewFileName =3D NewFileName; RenameBlock.NewFileNameLength =3D AsciiStrLen (NewFileName); =20 - Result =3D Semihost_SYS_RENAME (&RenameBlock); + Result =3D SEMIHOST_SYS_RENAME (&RenameBlock); =20 if (Result !=3D 0) { return RETURN_ABORTED; @@ -272,7 +272,7 @@ SemihostReadCharacter ( VOID ) { - return Semihost_SYS_READC(); + return SEMIHOST_SYS_READC (); } =20 VOID @@ -280,7 +280,7 @@ SemihostWriteCharacter ( IN CHAR8 Character ) { - Semihost_SYS_WRITEC(&Character); + SEMIHOST_SYS_WRITEC (&Character); } =20 VOID @@ -288,7 +288,7 @@ SemihostWriteString ( IN CHAR8 *String ) { - Semihost_SYS_WRITE0(String); + SEMIHOST_SYS_WRITE0 (String); } =20 UINT32 @@ -301,5 +301,5 @@ SemihostSystem ( SystemBlock.CommandLine =3D CommandLine; SystemBlock.CommandLength =3D AsciiStrLen(CommandLine); =20 - return Semihost_SYS_SYSTEM(&SystemBlock); + return SEMIHOST_SYS_SYSTEM (&SystemBlock); } diff --git a/ArmPkg/Library/SemihostLib/SemihostPrivate.h b/ArmPkg/Library/= SemihostLib/SemihostPrivate.h index 8d1fc6d6eb5a..30103b04b53f 100644 --- a/ArmPkg/Library/SemihostLib/SemihostPrivate.h +++ b/ArmPkg/Library/SemihostLib/SemihostPrivate.h @@ -1,7 +1,7 @@ /** @file =20 Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2013 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -151,19 +151,19 @@ _Semihost_SYS_SYSTEM( IN SEMIHOST_SYSTEM_BLOCK *SystemBlock ); =20 -#define Semihost_SYS_OPEN(OpenBlock) _Semihost_SYS_OPEN(0x01, OpenB= lock) -#define Semihost_SYS_CLOSE(Handle) _Semihost_SYS_CLOSE(0x02, Hand= le) -#define Semihost_SYS_WRITE0(String) _Semihost_SYS_WRITE0(0x04, Str= ing) -#define Semihost_SYS_WRITEC(Character) _Semihost_SYS_WRITEC(0x03, Cha= racter) -#define Semihost_SYS_WRITE(WriteBlock) _Semihost_SYS_WRITE(0x05, Writ= eBlock) -#define Semihost_SYS_READ(ReadBlock) _Semihost_SYS_READ(0x06, ReadB= lock) -#define Semihost_SYS_READC() _Semihost_SYS_READC(0x07, 0) -#define Semihost_SYS_SEEK(SeekBlock) _Semihost_SYS_SEEK(0x0A, SeekB= lock) -#define Semihost_SYS_FLEN(Handle) _Semihost_SYS_FLEN(0x0C, Handl= e) -#define Semihost_SYS_TMPNAME(TmpNameBlock) _Semihost_SYS_TMPNAME(0x0D, Tm= pNameBlock) -#define Semihost_SYS_REMOVE(RemoveBlock) _Semihost_SYS_REMOVE(0x0E, Rem= oveBlock) -#define Semihost_SYS_RENAME(RenameBlock) _Semihost_SYS_RENAME(0x0F, Ren= ameBlock) -#define Semihost_SYS_SYSTEM(SystemBlock) _Semihost_SYS_SYSTEM(0x12, Sys= temBlock) +#define SEMIHOST_SYS_OPEN(OpenBlock) _Semihost_SYS_OPEN(0x01, OpenB= lock) +#define SEMIHOST_SYS_CLOSE(Handle) _Semihost_SYS_CLOSE(0x02, Hand= le) +#define SEMIHOST_SYS_WRITE0(String) _Semihost_SYS_WRITE0(0x04, Str= ing) +#define SEMIHOST_SYS_WRITEC(Character) _Semihost_SYS_WRITEC(0x03, Cha= racter) +#define SEMIHOST_SYS_WRITE(WriteBlock) _Semihost_SYS_WRITE(0x05, Writ= eBlock) +#define SEMIHOST_SYS_READ(ReadBlock) _Semihost_SYS_READ(0x06, ReadB= lock) +#define SEMIHOST_SYS_READC() _Semihost_SYS_READC(0x07, 0) +#define SEMIHOST_SYS_SEEK(SeekBlock) _Semihost_SYS_SEEK(0x0A, SeekB= lock) +#define SEMIHOST_SYS_FLEN(Handle) _Semihost_SYS_FLEN(0x0C, Handl= e) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) _Semihost_SYS_TMPNAME(0x0D, Tm= pNameBlock) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) _Semihost_SYS_REMOVE(0x0E, Rem= oveBlock) +#define SEMIHOST_SYS_RENAME(RenameBlock) _Semihost_SYS_RENAME(0x0F, Ren= ameBlock) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) _Semihost_SYS_SYSTEM(0x12, Sys= temBlock) =20 #elif defined(__GNUC__) // __CC_ARM =20 @@ -175,37 +175,37 @@ GccSemihostCall ( IN UINTN SystemBlockAddress ); // __attribute__ ((interrupt ("SVC"))); =20 -#define Semihost_SYS_OPEN(OpenBlock) GccSemihostCall(0x01, (UINTN)(= OpenBlock)) -#define Semihost_SYS_CLOSE(Handle) GccSemihostCall(0x02, (UINTN)(= Handle)) -#define Semihost_SYS_WRITE0(String) GccSemihostCall(0x04, (UINTN)(= String)) -#define Semihost_SYS_WRITEC(Character) GccSemihostCall(0x03, (UINTN)(= Character)) -#define Semihost_SYS_WRITE(WriteBlock) GccSemihostCall(0x05, (UINTN)(= WriteBlock)) -#define Semihost_SYS_READ(ReadBlock) GccSemihostCall(0x06, (UINTN)(= ReadBlock)) -#define Semihost_SYS_READC() GccSemihostCall(0x07, (UINTN)(= 0)) -#define Semihost_SYS_SEEK(SeekBlock) GccSemihostCall(0x0A, (UINTN)(= SeekBlock)) -#define Semihost_SYS_FLEN(Handle) GccSemihostCall(0x0C, (UINTN)(= Handle)) -#define Semihost_SYS_TMPNAME(TmpNameBlock) GccSemihostCall(0x0D, (UINTN)(= TmpNameBlock)) -#define Semihost_SYS_REMOVE(RemoveBlock) GccSemihostCall(0x0E, (UINTN)(= RemoveBlock)) -#define Semihost_SYS_RENAME(RenameBlock) GccSemihostCall(0x0F, (UINTN)(= RenameBlock)) -#define Semihost_SYS_SYSTEM(SystemBlock) GccSemihostCall(0x12, (UINTN)(= SystemBlock)) +#define SEMIHOST_SYS_OPEN(OpenBlock) GccSemihostCall(0x01, (UINTN)(= OpenBlock)) +#define SEMIHOST_SYS_CLOSE(Handle) GccSemihostCall(0x02, (UINTN)(= Handle)) +#define SEMIHOST_SYS_WRITE0(String) GccSemihostCall(0x04, (UINTN)(= String)) +#define SEMIHOST_SYS_WRITEC(Character) GccSemihostCall(0x03, (UINTN)(= Character)) +#define SEMIHOST_SYS_WRITE(WriteBlock) GccSemihostCall(0x05, (UINTN)(= WriteBlock)) +#define SEMIHOST_SYS_READ(ReadBlock) GccSemihostCall(0x06, (UINTN)(= ReadBlock)) +#define SEMIHOST_SYS_READC() GccSemihostCall(0x07, (UINTN)(= 0)) +#define SEMIHOST_SYS_SEEK(SeekBlock) GccSemihostCall(0x0A, (UINTN)(= SeekBlock)) +#define SEMIHOST_SYS_FLEN(Handle) GccSemihostCall(0x0C, (UINTN)(= Handle)) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) GccSemihostCall(0x0D, (UINTN)(= TmpNameBlock)) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) GccSemihostCall(0x0E, (UINTN)(= RemoveBlock)) +#define SEMIHOST_SYS_RENAME(RenameBlock) GccSemihostCall(0x0F, (UINTN)(= RenameBlock)) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) GccSemihostCall(0x12, (UINTN)(= SystemBlock)) =20 #else // __CC_ARM =20 #define SEMIHOST_SUPPORTED FALSE =20 -#define Semihost_SYS_OPEN(OpenBlock) (-1) -#define Semihost_SYS_CLOSE(Handle) (-1) -#define Semihost_SYS_WRITE0(String) -#define Semihost_SYS_WRITEC(Character) -#define Semihost_SYS_WRITE(WriteBlock) (0) -#define Semihost_SYS_READ(ReadBlock) ((ReadBlock)->Length) -#define Semihost_SYS_READC() ('x') -#define Semihost_SYS_SEEK(SeekBlock) (-1) -#define Semihost_SYS_FLEN(Handle) (-1) -#define Semihost_SYS_TMPNAME(TmpNameBlock) (-1) -#define Semihost_SYS_REMOVE(RemoveBlock) (-1) -#define Semihost_SYS_RENAME(RenameBlock) (-1) -#define Semihost_SYS_SYSTEM(SystemBlock) (-1) +#define SEMIHOST_SYS_OPEN(OpenBlock) (-1) +#define SEMIHOST_SYS_CLOSE(Handle) (-1) +#define SEMIHOST_SYS_WRITE0(String) +#define SEMIHOST_SYS_WRITEC(Character) +#define SEMIHOST_SYS_WRITE(WriteBlock) (0) +#define SEMIHOST_SYS_READ(ReadBlock) ((ReadBlock)->Length) +#define SEMIHOST_SYS_READC() ('x') +#define SEMIHOST_SYS_SEEK(SeekBlock) (-1) +#define SEMIHOST_SYS_FLEN(Handle) (-1) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) (-1) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) (-1) +#define SEMIHOST_SYS_RENAME(RenameBlock) (-1) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) (-1) =20 #endif // __CC_ARM =20 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72056): https://edk2.groups.io/g/devel/message/72056 Mute This Topic: https://groups.io/mt/80850068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72057+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72057+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086063; cv=none; d=zohomail.com; s=zohoarc; b=oE/QjPRzYLXvt8w8LYUJdIV35Sq3sP/1oWLEvgykuFxAQfuGMuA9ZY8IQS9aQHVzThzbOdmThqrIgp6DE2RGG/STeGStskrCWng93ubtEOl3YNQcohdveLQ0PMd2gox0TZpcWWe2tGS5a2jmVJIfA06WnDGcqOc9bizD0rtdfrc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086063; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=k0FHZAKVz9Azatv/WnAEOKB3CJ6IH3CsZl1qXmYMnWI=; b=migOqKD04B3A0SBI/zDJNTzq3Fl38WIKlf8om7Mhi9yA4COWg4dHaqHeGZHLnNG9Pl1HA8hpJwjMFQGM/C+yY4gN+LHXa58s4756ldliAJkYJk/lETSrLa4oLkACbSzox2ihlFepTLcCf5CtrnxOX7QHMlBLfMurpr9qXdPVUO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72057+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161408606370478.44537930692093; Tue, 23 Feb 2021 05:14:23 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id VJVJYY1788612xfElewMaWXl; Tue, 23 Feb 2021 05:14:23 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9497.1614086062910463315 for ; Tue, 23 Feb 2021 05:14:23 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 85B8A101E; Tue, 23 Feb 2021 05:14:22 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C33EF3F70D; Tue, 23 Feb 2021 05:14:21 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib Date: Tue, 23 Feb 2021 13:13:43 +0000 Message-Id: <20210223131406.3484-4-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: EkljhzsBI4NjR3VNGHha6qrIx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086063; bh=BzPKmraYsDS4JxXHc4uGh97uMS3m5kEgUZKd+B2hMD4=; h=Date:From:Reply-To:Subject:To; b=MquhRoOoAHXl40pMmsgDR3oWe+65onp4hDT7w3nu0uGOHO3JrfUhghU7GfHEFYO/3Zv mrcfUMDhE3Lx6V3I/OrP2MPEzvBTsmTFuVIpj1XrA7/5LX7JFzSX/QcCOatZRnGt/CXqy N80kiiEErJleawRgfioacNNJ3A5Bln3iJTw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c b/ArmPkg/Libr= ary/ArmArchTimerLib/ArmArchTimerLib.c index 24d9dae4e660..875c835706d6 100644 --- a/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c +++ b/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c @@ -1,7 +1,7 @@ /** @file Generic ARM implementation of TimerLib.h =20 - Copyright (c) 2011-2016, ARM Limited. All rights reserved. + Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,9 +20,9 @@ =20 // Select appropriate multiply function for platform architecture. #ifdef MDE_CPU_ARM -#define MultU64xN MultU64x32 +#define MULT_U64_X_N MultU64x32 #else -#define MultU64xN MultU64x64 +#define MULT_U64_X_N MultU64x64 #endif =20 =20 @@ -121,7 +121,7 @@ MicroSecondDelay ( // =3D MicroSeconds x TICKS_PER_MICRO_SEC // =3D MicroSeconds x Frequency.10^-6 TimerTicks64 =3D DivU64x32 ( - MultU64xN ( + MULT_U64_X_N ( MicroSeconds, GetPlatformTimerFreq () ), @@ -263,7 +263,7 @@ GetTimeInNanoSecond ( // Time =3D --------- x 1,000,000,000 // Frequency // - NanoSeconds =3D MultU64xN ( + NanoSeconds =3D MULT_U64_X_N ( DivU64x32Remainder ( Ticks, TimerFreq, @@ -276,7 +276,7 @@ GetTimeInNanoSecond ( // will not overflow 64-bit. // NanoSeconds +=3D DivU64x32 ( - MultU64xN ( + MULT_U64_X_N ( (UINT64) Remainder, 1000000000U), TimerFreq --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72057): https://edk2.groups.io/g/devel/message/72057 Mute This Topic: https://groups.io/mt/80850069/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72058+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72058+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086064; cv=none; d=zohomail.com; s=zohoarc; b=flqz9T5xEkil4pH+cXzP7SD7zcp/BrtMi/0xjLrFyYpgMdm9pthsM6/FW7czJRLDqc7kPLus/tDOCQq1uowGCNd4hu/0COXSrjhns2/kRb7kC9vTn9zK36qxaHxillqywUop8r+5cnx20nyzEQsuIVPQNMiTa3WAMJjEGBlImBw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086064; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=JwZu4efUoSz5YF9BcVabBkpfy4uaiCOpEH671HtXetg=; b=mFrLaC0HP9UGdAsgunOOmpcd7kE5lJ4oC1wxWJruvkOOjNew6kmvhp4l/TuVRkREAMPS1UsYxDhoCGRVi8rywkJdItYZ0L172HptCYdAVCwVWObnGIHk7y4qJF2RlQCondx7hxczxzRlnY9uhuc/wOc3R9ipe5WMg6QnFoiupcw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72058+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086064910693.0021196726824; Tue, 23 Feb 2021 05:14:24 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zDrIYY1788612xDtpBKs9gMm; Tue, 23 Feb 2021 05:14:24 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.9522.1614086064144932038 for ; Tue, 23 Feb 2021 05:14:24 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4B5331B; Tue, 23 Feb 2021 05:14:23 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CDB443F70D; Tue, 23 Feb 2021 05:14:22 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe Date: Tue, 23 Feb 2021 13:13:44 +0000 Message-Id: <20210223131406.3484-5-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 7KGXjl34ItzEdamEb0H2xXzjx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086064; bh=VQ1yXK21+A1lWH+IHyBhnNNfQtgmByyXeUBL5CujuW8=; h=Date:From:Reply-To:Subject:To; b=GTme0W0dev305EpQa4wfvJLAL2AkokekLrli9rhOBf7Cq9sVbzDyvz68bANPJvdOsHD Z6qCNV8OiF680rz48csNSwMwhigmSVLv/sRdREoHBAnSzPmatbJGoYsiZVq6vthC88LCJ xqBhVeUITOGzkzZb4/Ia28p2TfiSPObNFvE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@param', '@post', '@pre', '@retval', '@return', '@sa', '@since', '@test', '@note', '@par', '@endcode', '@code', '@{', '@}' are allowed to mark the code This patch removes the ":" character following the "@param" doxygen command. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/CpuDxe/CpuMpCore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c b/ArmPkg/Drivers/CpuDxe/CpuM= pCore.c index d16ae3979207..8a9e8c2fa3a2 100644 --- a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c +++ b/ArmPkg/Drivers/CpuDxe/CpuMpCore.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -32,7 +32,7 @@ ARM_PROCESSOR_TABLE mArmProcessorTableTemplate =3D { }; =20 /** Publish ARM Processor Data table in UEFI SYSTEM Table. - * @param: HobStart Pointer to the beginning of the HOB Lis= t from PEI. + * @param HobStart Pointer to the beginning of the HOB List= from PEI. * * Description : This function iterates through HOB list and finds ARM pro= cessor Table Entry HOB. * If the ARM processor Table Entry HOB is found, the HOB d= ata is copied to run-time memory --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72058): https://edk2.groups.io/g/devel/message/72058 Mute This Topic: https://groups.io/mt/80850071/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72059+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72059+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086071; cv=none; d=zohomail.com; s=zohoarc; b=EOKqeTJjbW3FG/gDyK6eg/++7iHsbc7EOrajpjrAeJGWtg/Vh/4fNfXU97OD5JUgxwm6Bpc+I/Z6aCFErw9E5zzYjbOFyRVA9/kh1ieygXV9jhCRKSpyt1UExnbhhRbU333b4rq4nyro995kRWy17QG7sct+8/K4a7tipJ4o6Ws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086071; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=LOBlA9Pu4CBdBo1dubJFJiHWVPDUpHdxtg2QL/aRl50=; b=NubPd/Vr6ndV8T/P2JyloD0bPuu8f8zND/cCdXgLRT/rLX2xUo4afClHPVrVUn2wz0FiWkKNTK0e9L0uZIpiq9wXwpZCr+nnQW4iG5WYUi4aYrGX3k61BOZl7baEz1ytaBmf+PWsPmls3pEHS403bj+Y89vUtBdKezbJbsHVtg8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72059+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086071074744.4509374925266; Tue, 23 Feb 2021 05:14:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FLPlYY1788612xECpVXaB0AU; Tue, 23 Feb 2021 05:14:30 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9411.1614086065325093761 for ; Tue, 23 Feb 2021 05:14:25 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF207101E; Tue, 23 Feb 2021 05:14:24 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1A2683F70D; Tue, 23 Feb 2021 05:14:23 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc Date: Tue, 23 Feb 2021 13:13:45 +0000 Message-Id: <20210223131406.3484-6-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: qxiexULJXgMv8j2GH0JCgPz2x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086070; bh=nuOIZfPy45j+RdtXBw6IAiWDRgdQqdb+XeRIQJ7mEVk=; h=Date:From:Reply-To:Subject:To; b=LNcU0Lg4FYDG0ylTRGaUdGYZUTxLdYVYWN1iUhIXaKCxF1rkb/HVKHnnLGZHpwEKeix jsl/xp4J6Od3DW9KZHCyQ/WEsK4BM0H4fOD3wfZsgZ7pr9i7Whe/vC3XT/e01wUCgW1lT ObfbAP56p0Yk9vqNf+NE4+MSmBnaVKS8pdE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no unnecessary inclusion of library classes in the INF file This comes with the additional information: The Library Class [BootLogoLib] is not used in any platform The Library Class [DxeServicesLib] is not used in any platform The Library Class [UefiBootManagerLib] is not used in any platform The Library Class [PeCoffExtraActionLib] is not used in any platform ArmPkg/ArmPkg.dsc builds the modules requiring thses libraries, but doesn't build the required libraries. This patch adds the missing libraries to the [LibraryClasses.common] section. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/ArmPkg.dsc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index 7194eb2d3c44..10df4963ca36 100644 --- a/ArmPkg/ArmPkg.dsc +++ b/ArmPkg/ArmPkg.dsc @@ -2,7 +2,7 @@ # ARM processor package. # # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
# Copyright (c) 2016, Linaro Ltd. All rights reserved.
# Copyright (c) Microsoft Corporation.
# @@ -35,14 +35,17 @@ [PcdsFixedAtBuild] [LibraryClasses.common] BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMainte= nanceLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManag= erLib.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf UefiLib|MdePkg/Library/UefiLib/UefiLib.inf @@ -50,6 +53,7 @@ [LibraryClasses.common] UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeC= offGetEntryPointLib.inf + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf =20 UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServic= esLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72059): https://edk2.groups.io/g/devel/message/72059 Mute This Topic: https://groups.io/mt/80850072/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72060+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72060+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086072; cv=none; d=zohomail.com; s=zohoarc; b=ZNnWPWR3g+7/IAj2CUhoNGv3WKpNSxx1MhaPR1bUExLYRlfrbwNMFLhtrlH81IvmlXO6x+RkL1nCBioBy+/RQ/Cx+Zo7gOode0yw5xrlbZeK22c64o4bt9DAEul12aj8lq3NhmqgbTK4KOYIuMEDyUxpbihcxD4LMgXSEITsi+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086072; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=nu0OOgx3jyWH9p84TdcKwIqOH1SM9Glvd2OOhAwsMGY=; b=H5kF4uuZOOGwrbCp5gd8JZ/F60/Rt0hKEf4PbwjSo9r65zGMTq91OZeB6e623qZmfqgx5WgWVb34LWBQZWDbULxKxM03ryq8d2cjEQhfiNr218plyXgFtNZ0HN7FScV4ixN1xl0ffz+cbrrWwGdx3PKPA9ogPPFWVC3yEl7g3cA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72060+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086072398149.6483340826626; Tue, 23 Feb 2021 05:14:32 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Ml6aYY1788612xxQ8d6ZUonV; Tue, 23 Feb 2021 05:14:32 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.9478.1614086066593515505 for ; Tue, 23 Feb 2021 05:14:26 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39D5F31B; Tue, 23 Feb 2021 05:14:26 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2BA903F70D; Tue, 23 Feb 2021 05:14:25 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib Date: Tue, 23 Feb 2021 13:13:46 +0000 Message-Id: <20210223131406.3484-7-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Zn4YEtyq2tyK2OWb3AIa7J1Kx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086072; bh=QdDk7wV1FqCEmySAXv27gK9LKEWGa1WAUe0Cc4fl5mc=; h=Date:From:Reply-To:Subject:To; b=rxwb8X0HpKTFEL6kgDk+ViCF0mRc8OH2pa093K61nl0SsT2at9xCIuN/M4qaEG0v9I6 hCW5dyV4YolW4z+TtN+hpc0wehqIb2hYDscYJrG1xTxscALUBZyjEeQ0x+FqLVcnFR/IV b5XHXXG+YuK2VNEWboqAmzwz5DfywOJSoRI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Module file has FILE_GUID collision with other module file The two .inf files with clashing GUID are: ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf As ArmMmuBaseLib.inf is older than ArmMmuStandaloneMmLib.inf, it has precedence. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf b/= ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf index 85973687f5ad..0a147fff18c0 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -10,7 +10,7 @@ [Defines] INF_VERSION =3D 0x0001001A BASE_NAME =3D ArmMmuStandaloneMmCoreLib - FILE_GUID =3D da8f0232-fb14-42f0-922c-63104d2c70bd + FILE_GUID =3D 44a741c2-655f-41fc-b066-179f5a9aa78a MODULE_TYPE =3D MM_CORE_STANDALONE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D StandaloneMmMmuLib --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72060): https://edk2.groups.io/g/devel/message/72060 Mute This Topic: https://groups.io/mt/80850074/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72061+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72061+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086069; cv=none; d=zohomail.com; s=zohoarc; b=YtQaeEbqJir27R2TVwv72IUfwaHylrn/gba0nsiyl4KkNtuk/xgUDi7l2AqBBbEiLTkdXeYlIaM1ieA2nhqDG9W4h5xQNClPTyvJ4WRK/N8qfYlY9e3AOcSi9mkghx06QlnVmk8G/mjcIC6hvxFjH/RRrNfe5Vm1hnEMu4lP2rE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086069; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=SGP9hvg8AEcOBIUh+P0/4pzVX/+krSjNn52hh7DUMxM=; b=dMN+fkpiVUoAKo54D9ISz2rUT7ogMy+LvxXPIk99VSBXtet4VOoBBEtGvDFPkdF7Sn8wt2tomau5GL4iuOnGK6NTDiGtyXVHNOIUows2eGUxeYWRFj9PzWlM67xWdctbdjGf8YT1D3V3s+6CSP2CuUlkNMzwVZgklGIjgtJH0Ps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72061+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086069977854.8415044407977; Tue, 23 Feb 2021 05:14:29 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id M9aTYY1788612xDwFEfF7IMH; Tue, 23 Feb 2021 05:14:29 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9413.1614086068075287983 for ; Tue, 23 Feb 2021 05:14:28 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD92231B; Tue, 23 Feb 2021 05:14:27 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 95C3E3F70D; Tue, 23 Feb 2021 05:14:26 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe Date: Tue, 23 Feb 2021 13:13:47 +0000 Message-Id: <20210223131406.3484-8-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 7wyX2NWnBVrqTLWqLyPkHgBcx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086069; bh=juBbl1RTCI8Y9QvQ9+YnArvMI5XfwJOZWgznE+BHbB8=; h=Date:From:Reply-To:Subject:To; b=XFWaMrkfDcbDoEMxfk6PcIxDzVq/5SmTaFOfy2LcvPMNo8Mphw5VeQzPi/Qw3t9Dc9g ShuQqFqi9u/b+VbA8ilioaRKPY9gh2wVh5/jvMof2sDgYjRykcnchxkusOVXuESZCofrZ PXHTRljqMRDJACPjNsrizQjHWAwWQ9+wCCc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h] [ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h] are existing in module ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf but are not described in INF the file. The patch also re-orders the files in the [Sources.common] section. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf b/ArmPkg/Drivers/ArmS= cmiDxe/ArmScmiDxe.inf index 6cd3aa1c82ec..fc5f841c2b7c 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf +++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017-2018, Arm Limited. All rights reserved. +# Copyright (c) 2017-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -18,11 +18,16 @@ [Defines] ENTRY_POINT =3D ArmScmiDxeEntryPoint =20 [Sources.common] - Scmi.c + ArmScmiBaseProtocolPrivate.h + ArmScmiClockProtocolPrivate.h + ArmScmiPerformanceProtocolPrivate.h ScmiBaseProtocol.c + Scmi.c ScmiClockProtocol.c ScmiDxe.c + ScmiDxe.h ScmiPerformanceProtocol.c + ScmiPrivate.h =20 [Packages] ArmPkg/ArmPkg.dec --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72061): https://edk2.groups.io/g/devel/message/72061 Mute This Topic: https://groups.io/mt/80850075/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72062+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72062+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086076; cv=none; d=zohomail.com; s=zohoarc; b=fZ9V7mWxV6lGScVzU19yLDPR9Trfxecq+AyaQVfpEKXAyo8BzAhMErk/IEtJK1kQcDMyD9RDHx7tQOqx6U7oFwwBTOw/cetI54lPqjrissw0r+7CNk0Z9mlHSX8YSuuSIPtfHIKizT+uM09617fAIDXrYLmiScPNDioaOqsVo58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086076; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZbMIqFG1iQNPVlO6XueOYd+byEm0060V1dS14odAC84=; b=Gf24I7PyE4xP2Ow6jPvqaT5bEG43pKmXn7pAIH/f5IcmUC3YUioyewhgE08cZ5k1lkCsIrCg373NP/WINt7vh8hqRiH64BbEMemCwT6D5Hj9ojx4b08vXQy6nkrgbKAYPZ8hk3mO+iEEcSQVgHODarXlxsH5J9qFtJnBuj76iYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72062+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086076873746.7727599630118; Tue, 23 Feb 2021 05:14:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id nU3DYY1788612xF4ckbH9LG7; Tue, 23 Feb 2021 05:14:36 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9501.1614086069487774144 for ; Tue, 23 Feb 2021 05:14:29 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15E4531B; Tue, 23 Feb 2021 05:14:29 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EAF5C3F70D; Tue, 23 Feb 2021 05:14:27 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe Date: Tue, 23 Feb 2021 13:13:48 +0000 Message-Id: <20210223131406.3484-9-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: DQwIl6Zh4Hetzdb2TtxIb1DUx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086076; bh=JDBUvb1JT9d2O7JlItCD97sGKQKrgelYqHgyiOz+lEY=; h=Date:From:Reply-To:Subject:To; b=qhbdgxz/yNEVksXu79rJMuGDDOG2MYEiVcpkHyyGOoIDRwBnDcIrkizxTiCHsmqz58y yvuiP/NKOZcBqOyIhX2jcwduQgjH01AFijgmFpMXKhuoj1iWlc88sqE3Cwu0Hh4+CRibE pOwJu2e1CY6p7pn57uQ+6em2B3HwKQD2KGs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h] is existing in module ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf but is not described in the INF file. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf b/Arm= Pkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf index d725a2c85839..7dbd30783892 100644 --- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf +++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2017, ARM Limited. All rights reserved. +# Copyright (c) 2013-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -13,6 +13,7 @@ [Defines] ENTRY_POINT =3D GenericWatchdogEntry =20 [Sources.common] + GenericWatchdog.h GenericWatchdogDxe.c =20 [Packages] --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72062): https://edk2.groups.io/g/devel/message/72062 Mute This Topic: https://groups.io/mt/80850077/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72063+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72063+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086077; cv=none; d=zohomail.com; s=zohoarc; b=PXjYmLuknPHF8a3WlX6hAaKz3RaTU1/4r0k7xhvsvgit9RkN+5G4Jw40EU+0AxuTfi8Z/eHzmYH05PhkRGj2FpCvpgdsTxLFLHChmoSRmr5DFmpn7aAxnnSeRPrxxw9w+u7WTMP2liqsCY2XAQnB7UkmJE1StTAxXQnPr89qsb0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086077; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Yn3VtrbRZkeE6F+uS5xT0aV0CuJ2brNg0ZQ7I/XBUMw=; b=W4RwqIlmbT1ontuJtHtc1XzFmOu7EphLMVORZVWjHFl6c1fgOaSCNxdS22TylDZHxFY2NVDEazX6UsrtLdr/xXSurSEiEIOZGtE4+RaiVbjjDORobjpPU22iRwKq54xCD0lcWtW7/grhCogQBt8kBqN2DvK+fgtyJmViLOwgZY4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72063+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086077032451.42398884936597; Tue, 23 Feb 2021 05:14:37 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id U4hhYY1788612xTiFYI2bWRV; Tue, 23 Feb 2021 05:14:36 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9415.1614086071055764750 for ; Tue, 23 Feb 2021 05:14:31 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B224631B; Tue, 23 Feb 2021 05:14:30 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 755CF3F70D; Tue, 23 Feb 2021 05:14:29 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe Date: Tue, 23 Feb 2021 13:13:49 +0000 Message-Id: <20210223131406.3484-10-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: pf89SlXa6phOCfzgqROoBn2Fx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086076; bh=u4IHLWeiIDE1SeZsSvtHYsJJh/26QqXuKE8BjXBe1aI=; h=Date:From:Reply-To:Subject:To; b=nUrizD94mvviBpkYXB+MTkhBOPVNzFIvx3pHstli9M76qOWa1VLGOLQey+u6FYjiuRP wJqaENjcIWdkzHvnWLX8vJ80ORDaFEesKHe6xJmfQm2ykww+78914SSh+ztY7uc5ZvMch e2n11Hgw+dPibezIVhoh7rSFRGjrTx9aMJk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h] is existing in module ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf but is not described in the INF file. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf b/ArmPkg= /Drivers/MmCommunicationDxe/MmCommunication.inf index 2465fb77c58e..05b6de73ff34 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf @@ -2,7 +2,7 @@ # # DXE MM Communicate driver # -# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. +# Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +24,7 @@ [Defines] # =20 [Sources.AARCH64] + MmCommunicate.h MmCommunication.c =20 [Packages] --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72063): https://edk2.groups.io/g/devel/message/72063 Mute This Topic: https://groups.io/mt/80850079/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72064+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72064+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086078; cv=none; d=zohomail.com; s=zohoarc; b=V+7W3OPu2u5FukFK19LyMUu+Gc/AjD3Ay1Qi+i37JiOMEo3r4NQTveR56tczBWdZDC8A9BbSQVuDo2A9qP1QWAvyIe4V7Rv+XR1Nr1gLHyC3pRV0nT3e43Vw/fa+xe2sZjWcZTfVvAXAapBlq5sEepUy2JpjiY9byReHwX+KnIs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086078; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=pyzlL7l9eA/3hV63Rlvu/x6afvXTDirv9mSrprYLD9c=; b=e4TIkMLMrtX/NxCgYXOtc9Trtjn75i/g+i0uNCbCpuZpbm8nwKW95gQoWus8xCWVa4kMBLFjMUhPcmeKlDvAvkx0SCW5+5R4P+bjGA10iC2vP5ZFOJ+bqwiEAglHm218RFIn9es00gEsBYOyi/MD/dVSNfMR5P3L9ZvlHQwflbc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72064+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086078901824.9314514386805; Tue, 23 Feb 2021 05:14:38 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id KnweYY1788612xdQDxWksDbH; Tue, 23 Feb 2021 05:14:38 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9416.1614086072625276183 for ; Tue, 23 Feb 2021 05:14:32 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EB5A31B; Tue, 23 Feb 2021 05:14:32 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1D0D83F70D; Tue, 23 Feb 2021 05:14:30 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib Date: Tue, 23 Feb 2021 13:13:50 +0000 Message-Id: <20210223131406.3484-11-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Z33869MTNjDiCsQEdstq2iuCx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086078; bh=8i0f+tI07IlVCd1u9JT4LPO9xgNDo9hH6+iTrSAmQzg=; h=Date:From:Reply-To:Subject:To; b=DPGQ+Ryx5xJnt0Xl+EUY7AUSyETJkGXOFYGKofaDnqj5WYYe4l+1uz7iAMCrsf97ucN 2z6lZMxZeNnDrFTRCmb9Kis4OZf49qI7aVnLUf2wnJysEXzJeporCyQ8Nntl+uFDDauOC /+rsV4ZP93MojOW986kjLC8SLOLjUBbGERE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Library/SemihostLib/SemihostPrivate.h] is existing in module ArmPkg/Library/SemihostLib/SemihostLib.inf but is not described in the INF file. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Library/SemihostLib/SemihostLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.inf b/ArmPkg/Library/Se= mihostLib/SemihostLib.inf index a46618d30eef..2a4409f6573b 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.inf +++ b/ArmPkg/Library/SemihostLib/SemihostLib.inf @@ -2,7 +2,7 @@ # Semihosting JTAG lib # # Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -25,6 +25,7 @@ [Defines] # [Sources.common] SemihostLib.c + SemihostPrivate.h =20 [Sources.ARM] Arm/GccSemihost.S | GCC --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72064): https://edk2.groups.io/g/devel/message/72064 Mute This Topic: https://groups.io/mt/80850083/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72065+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72065+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086075; cv=none; d=zohomail.com; s=zohoarc; b=c56/1sMsjob8zEzH3k36D5ZG9ovLe1VwZEtuBRGKl7KKy9RoCUh0IfAgnUQiN4Cb6GxY5LzMumPKWMTHbHT+xyNeph4Y/DvdkYyGr92Iex+6SA5LzoNVOuOsYcjrilDxZrTtPiPaTtwUTNja8oCj0JUedSukvFN8lYscZFrbGD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086075; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=8YGRNTbYqUm9/7n4gP1j68V+EsdgQN/KtGPsYtVGWBE=; b=QpodI5ZKlAwW9mcTjP99SnzQOqvf9eLmixXnaO+qFFhVpwta/F1Z6aWHkM7v887l51d/EZXIKeA3T5YX7HFH3x25hEmdLYnNdTFBQDiyljex5rHthJcUbUP6Zzv7vG0Bo9ZjCuoI1TksHZIdMmwUgDyFjXzG0lQSq2+8mjqxyk0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72065+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086075312937.640380869087; Tue, 23 Feb 2021 05:14:35 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id NqfgYY1788612xce06XukYHr; Tue, 23 Feb 2021 05:14:34 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9417.1614086074008210711 for ; Tue, 23 Feb 2021 05:14:34 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF68F101E; Tue, 23 Feb 2021 05:14:33 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A05453F70D; Tue, 23 Feb 2021 05:14:32 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c Date: Tue, 23 Feb 2021 13:13:51 +0000 Message-Id: <20210223131406.3484-12-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: pVysI2gCj2asMZNdMhTjCFXBx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086074; bh=rsjhPDbW6UXM9w1lZSXyX45dvOphZonJDCKRAi6j+sU=; h=Date:From:Reply-To:Subject:To; b=b1Yu87qwXqlUBQZK0VPT7QenE5bzOzAnPyqcaqr4+LhZb/8QsQWHqLMKgqRBaCfCphY w7N8JAQoV/KAkpfaTpydxhMVJ559jjOWpcExeSdO/uh6QiA8vRxNvL33Bo7VqQL/cy2eH oubMhPHrAxb8KYZ99uscWtPavVXOspdLC+M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Commit: 142fa386eb907df55c239311cd5fa2d40f5007dd removes the ArmGicSecLib. The file ArmGic/ArmGicSecLib.c was exclusively used by this library. Thus, this file should also be removed. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c | 58 ---------------------------- 1 file changed, 58 deletions(-) delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c diff --git a/ArmPkg/Drivers/ArmGic/ArmGicSecLib.c b/ArmPkg/Drivers/ArmGic/A= rmGicSecLib.c deleted file mode 100644 index 4af98bb6ec93..000000000000 --- a/ArmPkg/Drivers/ArmGic/ArmGicSecLib.c +++ /dev/null @@ -1,58 +0,0 @@ -/** @file -* -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. -* -* SPDX-License-Identifier: BSD-2-Clause-Patent -* -**/ - -#include -#include -#include -#include - -/* - * This function configures the interrupts set by the mask to be secure. - * - */ -VOID -EFIAPI -ArmGicSetSecureInterrupts ( - IN UINTN GicDistributorBase, - IN UINTN* GicSecureInterruptMask, - IN UINTN GicSecureInterruptMaskSize - ) -{ - UINTN Index; - UINT32 InterruptStatus; - - // We must not have more interrupts defined by the mask than the number = of available interrupts - ASSERT(GicSecureInterruptMaskSize <=3D (ArmGicGetMaxNumInterrupts (GicDi= stributorBase) / 32)); - - // Set all the interrupts defined by the mask as Secure - for (Index =3D 0; Index < GicSecureInterruptMaskSize; Index++) { - InterruptStatus =3D MmioRead32 (GicDistributorBase + ARM_GIC_ICDISR + = (Index * 4)); - MmioWrite32 (GicDistributorBase + ARM_GIC_ICDISR + (Index * 4), Interr= uptStatus & (~GicSecureInterruptMask[Index])); - } -} - -VOID -EFIAPI -ArmGicEnableDistributor ( - IN INTN GicDistributorBase - ) -{ - // Turn on the GIC distributor - MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 1); -} - -VOID -EFIAPI -ArmGicSetupNonSecure ( - IN UINTN MpId, - IN INTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase - ) -{ - ArmGicV2SetupNonSecure (MpId, GicDistributorBase, GicInterruptInterfaceB= ase); -} --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72065): https://edk2.groups.io/g/devel/message/72065 Mute This Topic: https://groups.io/mt/80850086/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72066+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72066+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086081; cv=none; d=zohomail.com; s=zohoarc; b=EdV9o1B5ZXp8N8dpi3e6sogaDsEAZCpUX13ZQL3+C7N6PpdCu64W4gCeezK8bJsA9FBturzkoAacdPMSJwtOPRvKncqJsybiZy+NUl3QEWDSanSffc/zP4g56GwzIe59owYB92/R/v0fQuYYowsTW6pjVShX/nkDyPdeDkLQsVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086081; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=EveAeEvOmH84h4Zalo3KnqqMH7FUegaYzKOvr9SVhuQ=; b=QOUzVMb0WvEd72FW3vKfihbOXQly/mexaUR7MdkPsWEO23nimN1/ihp/maqEn13HAntXrm0oprDkqcsbqA4BfSBvA3kDclXUXepmYq6Hc6nS1ToC63UNp/Wrh8raB1reJEsZEdmJtP9uFzjuy7nKrz4/Wew42VHB2G8swQBcQgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72066+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086081368386.5436636075352; Tue, 23 Feb 2021 05:14:41 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jm2kYY1788612xG6JzpfLvoB; Tue, 23 Feb 2021 05:14:40 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.9525.1614086075397823834 for ; Tue, 23 Feb 2021 05:14:35 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07D8431B; Tue, 23 Feb 2021 05:14:35 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 013A93F70D; Tue, 23 Feb 2021 05:14:33 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib Date: Tue, 23 Feb 2021 13:13:52 +0000 Message-Id: <20210223131406.3484-13-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ItjHkknOGbfz8pDSq3TgpiaTx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086080; bh=jYqLM0CHnHm5luQE/q6oxiw/lwaPJHtfpzhMUvLpLZ4=; h=Date:From:Reply-To:Subject:To; b=K+zLQBzpIACLKYzWDeBOc9HigiIGzG1/Vzfc/ccU4zC6LYUV7me03PLxIpVryiC/+Oi eEwDeR/WKTcLRygHiQqW/gtXl6hC3NCx3aUmvplgYwR6QfYbheOUmIViP1BzqrE60DD4w 6OIGuumVV/RKczoJOra8xVjGE4TD0n3cND0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Function name should be left justified, followed by the beginning of the parameter list, with the closing parenthesis on its own line, indented two spaces Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 4 +++- ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c b/Ar= mPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c index 514f80a2d47a..fcf3dd16443e 100644 --- a/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c +++ b/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c @@ -2,6 +2,7 @@ * Exception Handling support specific for AArch64 * * Copyright (c) 2016 HP Development Company, L.P. +* Copyright (c) 2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -27,7 +28,8 @@ RegisterEl0Stack ( IN VOID *Stack ); =20 -RETURN_STATUS ArchVectorConfig( +RETURN_STATUS +ArchVectorConfig ( IN UINTN VectorBaseAddress ) { diff --git a/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c b/ArmPkg/Lib= rary/ArmExceptionLib/Arm/ArmException.c index 36c9f3f92616..40857c7f1faf 100644 --- a/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c +++ b/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c @@ -2,7 +2,7 @@ * Exception handling support specific for ARM * * Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
-* Copyright (c) 2014, ARM Limited. All rights reserved.
+* Copyright (c) 2014 - 2021, Arm Limited. All rights reserved.
* Copyright (c) 2016 HP Development Company, L.P.
* * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -26,7 +26,8 @@ PHYSICAL_ADDRESS gExceptionVectorAlignmentMask =3D= ARM_VECTOR_TABLE_ALIGNME // NOTE: This code assumes vectors are ARM and not Thumb code UINTN gDebuggerNoHandlerValue =3D 0xEAFFFFFE; =20 -RETURN_STATUS ArchVectorConfig( +RETURN_STATUS +ArchVectorConfig ( IN UINTN VectorBaseAddress ) { --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72066): https://edk2.groups.io/g/devel/message/72066 Mute This Topic: https://groups.io/mt/80850089/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72067+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72067+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086082; cv=none; d=zohomail.com; s=zohoarc; b=HLCBqGi2zLTYLFhgaxG9g0T6zg5A3yW+VHXM4pwvzzUTyOxTD5oe570cxOcmSRtyOv/PUvWM2pX67VwxUajAd0VglYBazK/wa55uaU4HJvP8+cHqrjjVz1pWl1Heb/461vQgEzhc6JvQADDaf7n7WWgWECMGYE7cuICssiXc4H0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086082; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=MXFaGao5iFIOefeIgosmEkM3ogGyo89e+ubirhVtw5Q=; b=BlHPZqZmmk3Mg/HOGyEAn+RzQ+lEscss4vHA4Yo1rRzzH9vw/t4U9s0MMzxya2zwGOvXDz4yj1XUpSd3QyivXRP/q62YrrbYSgp3fJ+X9pfHF7tRHI4/I2Ymao/uDUM5oPDUXSnGkkrM0V+XlofmfLcuIDJyP2KMQ3Ghzzfoh70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72067+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086082769485.51267327370306; Tue, 23 Feb 2021 05:14:42 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DY46YY1788612xpdjTaRpQMe; Tue, 23 Feb 2021 05:14:42 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9414.1614086076867094629 for ; Tue, 23 Feb 2021 05:14:37 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ADD531B; Tue, 23 Feb 2021 05:14:36 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6662F3F70D; Tue, 23 Feb 2021 05:14:35 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe Date: Tue, 23 Feb 2021 13:13:53 +0000 Message-Id: <20210223131406.3484-14-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: hH1GjdxS7GyQJOdFcGhEZ68Wx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086082; bh=73nf8tBnWytyiNBkaYILnIA9OrngaU+MHuv8+O01N6Y=; h=Date:From:Reply-To:Subject:To; b=lh9MNHtsRxWeZtbF9asFYgym88H3KfckpBPdsMa29S7oTiG85pNd12c3jWg4Mqis8g4 4YTGO+BDuXG1bmP9TeDkWGtokHgWFitMEi3AeSllSXggV62W7FZWveXEXTvJD38PrGo8a otaSrRp6j23BY7224OjCVOHbS5yMBLSoz4o= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. This patch replaces a "#if !defined [...]" statement by a "#ifndef [...]" statement, preventing Ecc to throw an error. Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h b/ArmPkg/Dri= vers/MmCommunicationDxe/MmCommunicate.h index fcc346ba7e3e..32753947e1cb 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h @@ -1,13 +1,13 @@ /** @file =20 - Copyright (c) 2016-2018, ARM Limited. All rights reserved. + Copyright (c) 2016-2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ =20 -#if !defined _MM_COMMUNICATE_H_ -#define _MM_COMMUNICATE_H_ +#ifndef MM_COMMUNICATE_H_ +#define MM_COMMUNICATE_H_ =20 #define MM_MAJOR_VER_MASK 0xEFFF0000 #define MM_MINOR_VER_MASK 0x0000FFFF @@ -19,4 +19,4 @@ #define MM_CALLER_MAJOR_VER 0x1UL #define MM_CALLER_MINOR_VER 0x0 =20 -#endif /* _MM_COMMUNICATE_H_ */ +#endif /* MM_COMMUNICATE_H_ */ --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72067): https://edk2.groups.io/g/devel/message/72067 Mute This Topic: https://groups.io/mt/80850090/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72068+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72068+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086079; cv=none; d=zohomail.com; s=zohoarc; b=iV5Y/Hz375bgJ+sVQ0YY2+qDYkGg5T3wWR8x2lnkyJySabhDPXhdWwThGguNU2pSjJy9IYV3v8VtgPBNsAzHrgEHhXpbvrSbIJ9HIyuKBW7ChS1WUQtKwWHT5wuAL+B8OFyhxO8Derdkd20vl1A/yCQbFHpsZhN3Jg/TtLze5N0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086079; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=7TavbRIPCFpxjEaUQKNrhTtYBe10RM/30gykXqPjA38=; b=F5yKfF310Uqm8ruEAajMDUhPJ8Xk30OviC2umRSAg0Ew2aBpNATDlUSm1Qtx78eluSkL9gfJ2/RA2BQzDKZ6pxwnZY9+et8PTXmN+ypyYeF6QtBFXrO03Tb8RdhMyR4Y0dnbeoMKJQJzl0mh6GnhDt0Bx38kdm+ZHYrfqfnDEq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72068+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086079407458.2161875384214; Tue, 23 Feb 2021 05:14:39 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9nfHYY1788612xQazbM220AQ; Tue, 23 Feb 2021 05:14:39 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9415.1614086078488781528 for ; Tue, 23 Feb 2021 05:14:38 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27330101E; Tue, 23 Feb 2021 05:14:38 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E92463F70D; Tue, 23 Feb 2021 05:14:36 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib Date: Tue, 23 Feb 2021 13:13:54 +0000 Message-Id: <20210223131406.3484-15-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: CEAcfvFghji3z4kV7FyyhOxax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086079; bh=MAzToqMUPeEIFqZZTOIuUHjKs4yTWXhFV2yKhKw48H4=; h=Date:From:Reply-To:Subject:To; b=KCsoziZdFxAmqbRIuE+nthCuq99twTcwH8dyNi5r8dtb64QcU1mSCJdWWi/HK0LENbd H1owgvQiJmnAJcLwJkEOUTINUtbEN4XldXg8chhn95+jWjBnMz5iodCi3gnBcPi85qUgj CODa+vU6qpVpq4fdhaKFYztGvt3EvGqL+Ho= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Library/ArmSoftFloatLib/platform.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ArmPkg/Library/ArmSoftFloatLib/platform.h b/ArmPkg/Library/Arm= SoftFloatLib/platform.h index 07800a9d5b79..fddf9de04d52 100644 --- a/ArmPkg/Library/ArmSoftFloatLib/platform.h +++ b/ArmPkg/Library/ArmSoftFloatLib/platform.h @@ -1,11 +1,17 @@ /* * Copyright (c) 2019, Linaro Limited + * Copyright (c) 2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent */ =20 +#ifndef ARM_SOFT_FLOAT_LIB_H_ +#define ARM_SOFT_FLOAT_LIB_H_ + #define LITTLEENDIAN 1 #define INLINE static inline #define SOFTFLOAT_BUILTIN_CLZ 1 #define SOFTFLOAT_FAST_INT64 #include "opts-GCC.h" + +#endif // ARM_SOFT_FLOAT_LIB_H_ --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72068): https://edk2.groups.io/g/devel/message/72068 Mute This Topic: https://groups.io/mt/80850091/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72069+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72069+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086086; cv=none; d=zohomail.com; s=zohoarc; b=HhrtmJAs0mJvOZCnH2XXaQZQHX5taTJseawtABZ279JZnOGOijrjceN+IJDeWXia/mYQfZ3sT04d3154zakh1i51qhLaFVNJ4LHs73I9hAdVWvYpJiXEIFI2jL5NnBXpyWyLFIZ3Cn9O3nJ83XSvIlMcH8bD9k0iT57OecssOz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086086; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=xoHscU/L/LAp3x12XRWMVuhnL855iR+uYCj5vyphDkE=; b=EWozQ1vCjyxvS0owf8dM46Q3yxXAc6UvrNqw+RcmmbEL8qauiINmmYO6X2Q6Mc1KGY7W6SBZOqdvq/jjuGi7SKGVVl14SNM/FU28gItRua/rwIBxhjKkfL9CZ6vKz5lNvl+FvNkmV85CmwNCaug5xIV153TorlMDzJ8CPRsvi+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72069+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086086243910.0068305218338; Tue, 23 Feb 2021 05:14:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id x7giYY1788612x1sgniwqe8B; Tue, 23 Feb 2021 05:14:45 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.9526.1614086079988409246 for ; Tue, 23 Feb 2021 05:14:40 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9F9DD31B; Tue, 23 Feb 2021 05:14:39 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 78A7A3F70D; Tue, 23 Feb 2021 05:14:38 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 15/26] ArmPkg: Rename include guard in ArmGicLib.h Date: Tue, 23 Feb 2021 13:13:55 +0000 Message-Id: <20210223131406.3484-16-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 1OfcHjjj6RCKS7NbgrHUTOagx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086085; bh=DDKoZM3ha3W5F1G8NOrBYW8ivq9GkqjFEXZnrQ/aOTc=; h=Date:From:Reply-To:Subject:To; b=MQRAa2fsy58E/sjrUFWz4aa9aN9w7+i1Fnk7j/gt7vCNzX5w95YH9NLHwTBiYVKNLYO 7JnmY+jJ+bQZjRd5y0sJyhyDb7FnGm9VANCRtB4D7y/guMk7wPWRiLOgLN/qGu7OnYpjc MlU99L8stPyfSfyElJSm1EG5Qn9RB5k0G3w= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Edk2 coding standard states that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Include/Library/ArmGicLib.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 7bcfc001115b..b4c320be119b 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -1,13 +1,13 @@ /** @file * -* Copyright (c) 2011-2018, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * **/ =20 -#ifndef __ARMGIC_H -#define __ARMGIC_H +#ifndef ARMGIC_H_ +#define ARMGIC_H_ =20 #include =20 @@ -333,4 +333,4 @@ ArmGicV3SetPriorityMask ( IN UINTN Priority ); =20 -#endif +#endif // ARMGIC_H_ --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72069): https://edk2.groups.io/g/devel/message/72069 Mute This Topic: https://groups.io/mt/80850093/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72070+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72070+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086082; cv=none; d=zohomail.com; s=zohoarc; b=NE9eeAiota+DOu7U+izA/b+HldJDnKEDTGMl8cEcNayt/zzqJQvwTpXBC/ZXEAEWRJu6gE0GyHtmYoqNJyDVq+Vue/gMydCNk2nXH0NQC8lGQChrIK/SM7skNgk1sql8akD9tWOS4QuD7O4ie6LerLQZ1MPwR5lsm/uTh06YPyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086082; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=UFDD5l+zG1sxNAYZwY8O2FFZbRqB9lM0r/eprnuOROo=; b=h7nPYzWqNGNI6hAROn0QwdNWGBVkQGGwiE/vFKahEeytFJ/VsaWxCxobXshfMT/xDv2L/oJXsaR1XILduszrFLfIh/ZDZ5MjZlMcFKF872A2ZZ4WrTu2SiBzQsNPRkGRIJs773mJUATAXIovvFZULIkPuqEfA/mODfknmOLPrgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72070+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16140860821281015.7107836728633; Tue, 23 Feb 2021 05:14:42 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lBuaYY1788612x6q1elH2wVz; Tue, 23 Feb 2021 05:14:41 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9506.1614086081305626609 for ; Tue, 23 Feb 2021 05:14:41 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ECBF231B; Tue, 23 Feb 2021 05:14:40 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E06DA3F70D; Tue, 23 Feb 2021 05:14:39 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE Date: Tue, 23 Feb 2021 13:13:56 +0000 Message-Id: <20210223131406.3484-17-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ImxoIvpkfrHfXubINNMAQ78ax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086081; bh=W+Y6Qvr3mXdUI2yMMkrbV0puq/CuXRJZFiJZT8U5gTI=; h=Date:From:Reply-To:Subject:To; b=JVXKNsvvLwkyPDUqgHLEjSkKTXOw2+HTeJ1ss64n84OSiXMHiQjkSBf4KIwxJhAcpO8 uXvuhmUmuV2a2s2fx1Yvr4glIldWq7GzJnmjXE0ATFeYdzcOLOa/VCZ6AW/qkgo2rpLK8 Hy9bx1gWr1hDOQAmAxNvuxgH6BIvsY2h7xk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 12 ++++++++---- ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 14 ++++++++++---- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers= /ArmScmiDxe/ScmiClockProtocol.c index c66c414385dd..5c06e31bda22 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -255,22 +255,26 @@ ClockDescribeRates ( for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { Rate =3D &DescribeRates->Rates[RateOffset++]; // Non-linear discrete rates. - RateArray[RateIndex++].Rate =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].DiscreteRate.Rate =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } else { for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { // Linear clock rates from minimum to maximum in steps // Minimum clock rate. Rate =3D &DescribeRates->Rates[RateOffset++]; - RateArray[RateIndex].Min =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Min =3D + ConvertTo64Bit (Rate->Low, Rate->High); =20 Rate =3D &DescribeRates->Rates[RateOffset++]; // Maximum clock rate. - RateArray[RateIndex].Max =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Max =3D + ConvertTo64Bit (Rate->Low, Rate->High); =20 Rate =3D &DescribeRates->Rates[RateOffset++]; // Step. - RateArray[RateIndex++].Step =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].ContinuousRate.Step =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } } while (NUM_REMAIN_RATES (DescribeRates->NumRatesFlags) !=3D 0); diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Includ= e/Protocol/ArmScmiClockProtocol.h index b4d970dee3e2..85b5b8d1e764 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -57,12 +57,18 @@ typedef enum { either Rate or Min/Max/Step triplet is valid. */ typedef struct { - union { UINT64 Min; - UINT64 Rate; - }; UINT64 Max; UINT64 Step; +} SCMI_CLOCK_RATE_CONTINUOUS; + +typedef struct { + UINT64 Rate; +} SCMI_CLOCK_RATE_DISCRETE; + +typedef union { + SCMI_CLOCK_RATE_CONTINUOUS ContinuousRate; + SCMI_CLOCK_RATE_DISCRETE DiscreteRate; } SCMI_CLOCK_RATE; =20 #pragma pack() --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72070): https://edk2.groups.io/g/devel/message/72070 Mute This Topic: https://groups.io/mt/80850094/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72071+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72071+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086083; cv=none; d=zohomail.com; s=zohoarc; b=GYWXC2y6TEx8TAnLiWONIjoWlK4FxJR2wveFxVVnGbmfL970YALJi1jeJenKfMUKLmeF5XEruUrfif5RoUcDX7vu0ynkUOBcepdqBfWmyQeLeaG7h2s4bOLEkfrRlbk2LOpxny3R1oukLFO6dKD/b43OFAmRVtrJmX9lE9gGHnQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086083; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=0WNJfEXFJZZLN6m0l3x99Ak4A9RHBKmbOjwUbD8okbw=; b=ahEbcZASoK6CZtOiJxij3xQ5mfuVWOosNlEc/7YzM5xPCeOWALZwRzqEEA3FGTuizyUrvz6jjcO2fOlGtTGh4WcrhgZANdyD33ObIL4reBsOF0RmVW92V//6a7l6Dn4UTwq9NX3oTGhmYgtcjUtyYkXSb49TeeobGoCMRy8BY/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72071+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614086083835862.3539549081719; Tue, 23 Feb 2021 05:14:43 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4UAZYY1788612xPUSpHcPc6l; Tue, 23 Feb 2021 05:14:43 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9419.1614086083037716043 for ; Tue, 23 Feb 2021 05:14:43 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD8F831B; Tue, 23 Feb 2021 05:14:42 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 708B33F70D; Tue, 23 Feb 2021 05:14:41 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM Date: Tue, 23 Feb 2021 13:13:57 +0000 Message-Id: <20210223131406.3484-18-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: CbWRBcNSd0lJCxwoIi3S5ocfx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086083; bh=INbK/7hJbH6mS3Zy9wJPfDmYbx7X1MZFQ06tXPsiq9U=; h=Date:From:Reply-To:Subject:To; b=buPVqolHpwDhkUlqj0Q5yHlBPZ8zAW1pzF7b2doxRZNmllp8Isk7BJhQ5mZKGkDcwJR aPC6vxb1fXZkj088zj6bN4paRJ9w16pb6zvnHlGj7c4YVoTr6H1GO3OUtTSGxKGpriPPn 8xVwQazHDJP/he8/sSUzHwI9gY/Ke2rx3uQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 ArmPkg/Include/Library/OpteeLib.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Include/Library/OpteeLib.h b/ArmPkg/Include/Library/Opt= eeLib.h index d71636143373..8ceab117d132 100644 --- a/ArmPkg/Include/Library/OpteeLib.h +++ b/ArmPkg/Include/Library/OpteeLib.h @@ -2,6 +2,7 @@ OP-TEE specific header file. =20 Copyright (c) 2018, Linaro Ltd. All rights reserved.
+ Copyright (c) 2021, Arm Limited. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -45,12 +46,14 @@ typedef struct { UINT64 C; } OPTEE_MESSAGE_PARAM_VALUE; =20 +typedef union { + OPTEE_MESSAGE_PARAM_MEMORY Memory; + OPTEE_MESSAGE_PARAM_VALUE Value; +} OPTEE_MESSAGE_PARAM_UNION; + typedef struct { UINT64 Attribute; - union { - OPTEE_MESSAGE_PARAM_MEMORY Memory; - OPTEE_MESSAGE_PARAM_VALUE Value; - } Union; + OPTEE_MESSAGE_PARAM_UNION Union; } OPTEE_MESSAGE_PARAM; =20 #define OPTEE_MAX_CALL_PARAMS 4 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72071): https://edk2.groups.io/g/devel/message/72071 Mute This Topic: https://groups.io/mt/80850095/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 02:20:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72072+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72072+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1614086090; cv=none; d=zohomail.com; s=zohoarc; b=XeLP0PRrQtEUa9+iOjU146oC+x1ptiPJxkwSN14vw3XTz+anXaak8z6g18ozVzdUN4tCot51umwJUO7lSWTldiJ9YQo70Ce2TtocodwamBhkfgejNKawSte+wwVJPOm4fImW6ir9C+mbHpwobozaPknpIiQk/1oJfCZck6CnieU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614086090; h=Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=rIsutcrZJ5AlQZGEo6p+Tgo9ff5Nt8qpyTK3jPqz54Q=; b=JmWLLNfYIE2JFMPJJpo92CrpCOfGf5rkCNfF4pDAy1wCfIiM4XCqPHAwDAaAqxFSlw8w3fdVI0lP0K5ew0LKUAf1AE0DIeDK8qfrVOBOztm+Budk2FhonYsg66KoX1F+jlv0bz+Bq9nyMeewjBi8SGBoe4MlFj/fQJzaj05o5s0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72072+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161408609052278.94776114018839; Tue, 23 Feb 2021 05:14:50 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id njcOYY1788612xLttBKOt1JQ; Tue, 23 Feb 2021 05:14:50 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.9507.1614086084692074317 for ; Tue, 23 Feb 2021 05:14:44 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57F1C31B; Tue, 23 Feb 2021 05:14:44 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0D1883F70D; Tue, 23 Feb 2021 05:14:42 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v3 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib Date: Tue, 23 Feb 2021 13:13:58 +0000 Message-Id: <20210223131406.3484-19-Pierre.Gondois@arm.com> In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: SiX36IxfwDkMh4YgLR0bVNdTx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614086090; bh=BG2v6Jtn39A+c7JaJj7MTQkX3dqG9PHUHldX6mG5KSc=; h=Date:From:Reply-To:Subject:To; b=UWTw4vOR0UXDgqGn3XyETjFZ+xMp4W69nv+PPctXtk7s70wU5ob0zCxpmsbVi0dMPq7 qK3hE8sExzLFkfR92aKfDL1TnTrfutlGTRrEV4rAPOmhmigvDNFS2Ml+gOSO3ZDdv+fWK iuQJhjQQT7vunRKrzhvloo1ettnDHXqjVi4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: 8005: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' 8007: There should be no use of short (single character) variable names Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v3 .../ArmDisassemblerLib/ArmDisassembler.c | 159 +++++++++--------- .../ArmDisassemblerLib/ThumbDisassembler.c | 158 ++++++++--------- 2 files changed, 163 insertions(+), 154 deletions(-) diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/L= ibrary/ArmDisassemblerLib/ArmDisassembler.c index e67e13a50ace..03a9f1fbe2e5 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -71,7 +71,7 @@ CHAR8 *gLdmStack[] =3D { =20 =20 #define SIGN(_U) ((_U) ? "" : "-") -#define WRITE(_W) ((_W) ? "!" : "") +#define WRITE(_Write) ((_Write) ? "!" : "") #define BYTE(_B) ((_B) ? "B":"") #define USER(_B) ((_B) ? "^" : "") =20 @@ -159,23 +159,24 @@ DisassembleArmInstruction ( ) { UINT32 OpCode; - CHAR8 *Type, *Root; - BOOLEAN I, P, U, B, W, L, S, H; + CHAR8 *Type; + CHAR8 *Root; + BOOLEAN Imm, Pre, Up, WriteBack, Write, Load, Sign, Half; UINT32 Rn, Rd, Rm; - UINT32 imode, offset_8, offset_12; + UINT32 IMod, Offset8, Offset12; UINT32 Index; - UINT32 shift_imm, shift; + UINT32 ShiftImm, Shift; =20 OpCode =3D **OpCodePtr; =20 - I =3D (OpCode & BIT25) =3D=3D BIT25; - P =3D (OpCode & BIT24) =3D=3D BIT24; - U =3D (OpCode & BIT23) =3D=3D BIT23; - B =3D (OpCode & BIT22) =3D=3D BIT22; // Also called S - W =3D (OpCode & BIT21) =3D=3D BIT21; - L =3D (OpCode & BIT20) =3D=3D BIT20; - S =3D (OpCode & BIT6) =3D=3D BIT6; - H =3D (OpCode & BIT5) =3D=3D BIT5; + Imm =3D (OpCode & BIT25) =3D=3D BIT25; // I + Pre =3D (OpCode & BIT24) =3D=3D BIT24; // P + Up =3D (OpCode & BIT23) =3D=3D BIT23; // U + WriteBack =3D (OpCode & BIT22) =3D=3D BIT22; // B, also called S + Write =3D (OpCode & BIT21) =3D=3D BIT21; // W + Load =3D (OpCode & BIT20) =3D=3D BIT20; // L + Sign =3D (OpCode & BIT6) =3D=3D BIT6; // S + Half =3D (OpCode & BIT5) =3D=3D BIT5; // H Rn =3D (OpCode >> 16) & 0xf; Rd =3D (OpCode >> 12) & 0xf; Rm =3D (OpCode & 0xf); @@ -189,7 +190,7 @@ DisassembleArmInstruction ( =20 // LDREX, STREX if ((OpCode & 0x0fe000f0) =3D=3D 0x01800090) { - if (L) { + if (Load) { // A4.1.27 LDREX{} , [] AsciiSPrint (Buf, Size, "LDREX%a %a, [%a]", COND (OpCode), gReg[Rd],= gReg[Rn]); } else { @@ -201,89 +202,89 @@ DisassembleArmInstruction ( =20 // LDM/STM if ((OpCode & 0x0e000000) =3D=3D 0x08000000) { - if (L) { + if (Load) { // A4.1.20 LDM{} {!}, // A4.1.21 LDM{} , ^ // A4.1.22 LDM{} {!}, ^ - AsciiSPrint (Buf, Size, "LDM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (W), MRegList (OpCode), USER (B)); + AsciiSPrint (Buf, Size, "LDM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (Write), MRegList (OpCode), USER = (WriteBack)); } else { // A4.1.97 STM{} {!}, // A4.1.98 STM{} , ^ - AsciiSPrint (Buf, Size, "STM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (W), MRegList (OpCode), USER (B)); + AsciiSPrint (Buf, Size, "STM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (Write), MRegList (OpCode), USER = (WriteBack)); } return; } =20 // LDR/STR Address Mode 2 if ( ((OpCode & 0x0c000000) =3D=3D 0x04000000) || ((OpCode & 0xfd70f000= ) =3D=3D 0xf550f000) ) { - offset_12 =3D OpCode & 0xfff; + Offset12 =3D OpCode & 0xfff; if ((OpCode & 0xfd70f000 ) =3D=3D 0xf550f000) { Index =3D AsciiSPrint (Buf, Size, "PLD"); } else { - Index =3D AsciiSPrint (Buf, Size, "%a%a%a%a %a, ", L ? "LDR" : "STR"= , COND (OpCode), BYTE (B), (!(P) && W) ? "T":"", gReg[Rd]); + Index =3D AsciiSPrint (Buf, Size, "%a%a%a%a %a, ", Load ? "LDR" : "S= TR", COND (OpCode), BYTE (WriteBack), (!(Pre) && Write) ? "T":"", gReg[Rd]); } - if (P) { - if (!I) { + if (Pre) { + if (!Imm) { // A5.2.2 [, #+/-] // A5.2.5 [, #+/-] - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a0x%x]%a", gReg[Rn= ], SIGN (U), offset_12, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a0x%x]%a", gReg[Rn= ], SIGN (Up), Offset12, WRITE (Write)); } else if ((OpCode & 0x03000ff0) =3D=3D 0x03000000) { // A5.2.3 [, +/-] // A5.2.6 [, +/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a]%a", gReg[Rn],= SIGN (U), WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a]%a", gReg[Rn],= SIGN (Up), WRITE (Write)); } else { // A5.2.4 [, +/-, LSL #] // A5.2.7 [, +/-, LSL #]! - shift_imm =3D (OpCode >> 7) & 0x1f; - shift =3D (OpCode >> 5) & 0x3; - if (shift =3D=3D 0x0) { + ShiftImm =3D (OpCode >> 7) & 0x1f; + Shift =3D (OpCode >> 5) & 0x3; + if (Shift =3D=3D 0x0) { Type =3D "LSL"; - } else if (shift =3D=3D 0x1) { + } else if (Shift =3D=3D 0x1) { Type =3D "LSR"; - if (shift_imm =3D=3D 0) { - shift_imm =3D 32; + if (ShiftImm =3D=3D 0) { + ShiftImm =3D 32; } - } else if (shift =3D=3D 0x2) { + } else if (Shift =3D=3D 0x2) { Type =3D "ASR"; - } else if (shift_imm =3D=3D 0) { - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, RRX]%a"= , gReg[Rn], SIGN (U), gReg[Rm], WRITE (W)); + } else if (ShiftImm =3D=3D 0) { + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, RRX]%a"= , gReg[Rn], SIGN (Up), gReg[Rm], WRITE (Write)); return; } else { Type =3D "ROR"; } =20 - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, #%d]%a", = gReg[Rn], SIGN (U), gReg[Rm], Type, shift_imm, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, #%d]%a", = gReg[Rn], SIGN (Up), gReg[Rm], Type, ShiftImm, WRITE (Write)); } - } else { // !P - if (!I) { + } else { // !Pre + if (!Imm) { // A5.2.8 [], #+/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a0x%x", gReg[Rn],= SIGN (U), offset_12); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a0x%x", gReg[Rn],= SIGN (Up), Offset12); } else if ((OpCode & 0x03000ff0) =3D=3D 0x03000000) { // A5.2.9 [], +/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], S= IGN (U), gReg[Rm]); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], S= IGN (Up), gReg[Rm]); } else { // A5.2.10 [], +/-, LSL # - shift_imm =3D (OpCode >> 7) & 0x1f; - shift =3D (OpCode >> 5) & 0x3; + ShiftImm =3D (OpCode >> 7) & 0x1f; + Shift =3D (OpCode >> 5) & 0x3; =20 - if (shift =3D=3D 0x0) { + if (Shift =3D=3D 0x0) { Type =3D "LSL"; - } else if (shift =3D=3D 0x1) { + } else if (Shift =3D=3D 0x1) { Type =3D "LSR"; - if (shift_imm =3D=3D 0) { - shift_imm =3D 32; + if (ShiftImm =3D=3D 0) { + ShiftImm =3D 32; } - } else if (shift =3D=3D 0x2) { + } else if (Shift =3D=3D 0x2) { Type =3D "ASR"; - } else if (shift_imm =3D=3D 0) { - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, RRX", = gReg[Rn], SIGN (U), gReg[Rm]); + } else if (ShiftImm =3D=3D 0) { + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, RRX", = gReg[Rn], SIGN (Up), gReg[Rm]); // FIx me return; } else { Type =3D "ROR"; } =20 - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, #%d", gR= eg[Rn], SIGN (U), gReg[Rm], Type, shift_imm); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, #%d", gR= eg[Rn], SIGN (Up), gReg[Rm], Type, ShiftImm); } } return; @@ -292,18 +293,18 @@ DisassembleArmInstruction ( if ((OpCode & 0x0e000000) =3D=3D 0x00000000) { // LDR/STR address mode 3 // LDR|STR{}H|SH|SB|D , - if (L) { - if (!S) { + if (Load) { + if (!Sign) { Root =3D "LDR%aH %a, "; - } else if (!H) { + } else if (!Half) { Root =3D "LDR%aSB %a, "; } else { Root =3D "LDR%aSH %a, "; } } else { - if (!S) { + if (!Sign) { Root =3D "STR%aH %a "; - } else if (!H) { + } else if (!Half) { Root =3D "LDR%aD %a "; } else { Root =3D "STR%aD %a "; @@ -312,28 +313,28 @@ DisassembleArmInstruction ( =20 Index =3D AsciiSPrint (Buf, Size, Root, COND (OpCode), gReg[Rd]); =20 - S =3D (OpCode & BIT6) =3D=3D BIT6; - H =3D (OpCode & BIT5) =3D=3D BIT5; - offset_8 =3D ((OpCode >> 4) | (OpCode * 0xf)) & 0xff; - if (P & !W) { + Sign =3D (OpCode & BIT6) =3D=3D BIT6; + Half =3D (OpCode & BIT5) =3D=3D BIT5; + Offset8 =3D ((OpCode >> 4) | (OpCode * 0xf)) & 0xff; + if (Pre & !Write) { // Immediate offset/index - if (B) { + if (WriteBack) { // A5.3.2 [, #+/-] // A5.3.4 [, #+/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%d]%a", gReg[Rn]= , SIGN (U), offset_8, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%d]%a", gReg[Rn]= , SIGN (Up), Offset8, WRITE (Write)); } else { // A5.3.3 [, +/-] // A5.3.5 [, +/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%]a", gReg[Rn], = SIGN (U), gReg[Rm], WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%]a", gReg[Rn], = SIGN (Up), gReg[Rm], WRITE (Write)); } } else { // Register offset/index - if (B) { + if (WriteBack) { // A5.3.6 [], #+/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%d", gReg[Rn], = SIGN (U), offset_8); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%d", gReg[Rn], = SIGN (Up), Offset8); } else { // A5.3.7 [], +/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], = SIGN (U), gReg[Rm]); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], = SIGN (Up), gReg[Rm]); } } return; @@ -342,19 +343,19 @@ DisassembleArmInstruction ( if ((OpCode & 0x0fb000f0) =3D=3D 0x01000050) { // A4.1.108 SWP SWP{}B , , [] // A4.1.109 SWPB SWP{}B , , [] - AsciiSPrint (Buf, Size, "SWP%a%a %a, %a, [%a]", COND (OpCode), BYTE (B= ), gReg[Rd], gReg[Rm], gReg[Rn]); + AsciiSPrint (Buf, Size, "SWP%a%a %a, %a, [%a]", COND (OpCode), BYTE (W= riteBack), gReg[Rd], gReg[Rm], gReg[Rn]); return; } =20 if ((OpCode & 0xfe5f0f00) =3D=3D 0xf84d0500) { // A4.1.90 SRS SRS #{!} - AsciiSPrint (Buf, Size, "SRS%a #0x%x%a", gLdmStack[(OpCode >> 23) & 3]= , OpCode & 0x1f, WRITE (W)); + AsciiSPrint (Buf, Size, "SRS%a #0x%x%a", gLdmStack[(OpCode >> 23) & 3]= , OpCode & 0x1f, WRITE (Write)); return; } =20 if ((OpCode & 0xfe500f00) =3D=3D 0xf8100500) { // A4.1.59 RFE {!} - AsciiSPrint (Buf, Size, "RFE%a %a", gLdmStack[(OpCode >> 23) & 3], gRe= g[Rn], WRITE (W)); + AsciiSPrint (Buf, Size, "RFE%a %a", gLdmStack[(OpCode >> 23) & 3], gRe= g[Rn], WRITE (Write)); return; } =20 @@ -369,9 +370,9 @@ DisassembleArmInstruction ( if (((OpCode >> 6) & 0x7) =3D=3D 0) { AsciiSPrint (Buf, Size, "CPS #0x%x", (OpCode & 0x2f)); } else { - imode =3D (OpCode >> 18) & 0x3; + IMod =3D (OpCode >> 18) & 0x3; Index =3D AsciiSPrint (Buf, Size, "CPS%a %a%a%a", - (imode =3D=3D 3) ? "ID":"IE", + (IMod =3D=3D 3) ? "ID":"IE", ((OpCode & BIT8) !=3D 0) ? "A":"", ((OpCode & BIT7) !=3D 0) ? "I":"", ((OpCode & BIT6) !=3D 0) ? "F":""); @@ -390,19 +391,19 @@ DisassembleArmInstruction ( =20 if ((OpCode & 0x0fb00000) =3D=3D 0x01000000) { // A4.1.38 MRS{} , CPSR MRS{} , SPSR - AsciiSPrint (Buf, Size, "MRS%a %a, %a", COND (OpCode), gReg[Rd], B ? "= SPSR" : "CPSR"); + AsciiSPrint (Buf, Size, "MRS%a %a, %a", COND (OpCode), gReg[Rd], Write= Back ? "SPSR" : "CPSR"); return; } =20 =20 if ((OpCode & 0x0db00000) =3D=3D 0x01200000) { // A4.1.38 MSR{} CPSR_, # MSR{} CPSR_, - if (I) { + if (Imm) { // MSR{} CPSR_, # - AsciiSPrint (Buf, Size, "MRS%a %a_%a, #0x%x", COND (OpCode), B ? "S= PSR" : "CPSR", FieldMask ((OpCode >> 16) & 0xf), RotateRight (OpCode & 0xf,= ((OpCode >> 8) & 0xf) *2)); + AsciiSPrint (Buf, Size, "MRS%a %a_%a, #0x%x", COND (OpCode), WriteB= ack ? "SPSR" : "CPSR", FieldMask ((OpCode >> 16) & 0xf), RotateRight (OpCod= e & 0xf, ((OpCode >> 8) & 0xf) *2)); } else { // MSR{} CPSR_, - AsciiSPrint (Buf, Size, "MRS%a %a_%a, %a", COND (OpCode), B ? "SPSR"= : "CPSR", gReg[Rd]); + AsciiSPrint (Buf, Size, "MRS%a %a_%a, %a", COND (OpCode), WriteBack = ? "SPSR" : "CPSR", gReg[Rd]); } return; } @@ -416,35 +417,35 @@ DisassembleArmInstruction ( if ((OpCode & 0x0e000000) =3D=3D 0x0c000000) { // A4.1.19 LDC and A4.1.96 SDC if ((OpCode & 0xf0000000) =3D=3D 0xf0000000) { - Index =3D AsciiSPrint (Buf, Size, "%a2 0x%x, CR%d, ", L ? "LDC":"SDC= ", (OpCode >> 8) & 0xf, Rd); + Index =3D AsciiSPrint (Buf, Size, "%a2 0x%x, CR%d, ", Load ? "LDC":"= SDC", (OpCode >> 8) & 0xf, Rd); } else { - Index =3D AsciiSPrint (Buf, Size, "%a%a 0x%x, CR%d, ", L ? "LDC":"S= DC", COND (OpCode), (OpCode >> 8) & 0xf, Rd); + Index =3D AsciiSPrint (Buf, Size, "%a%a 0x%x, CR%d, ", Load ? "LDC"= :"SDC", COND (OpCode), (OpCode >> 8) & 0xf, Rd); } =20 - if (!P) { - if (!W) { + if (!Pre) { + if (!Write) { // A5.5.5.5 [],