From nobody Tue Feb 10 03:39:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71890+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71890+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1613878157; cv=none; d=zohomail.com; s=zohoarc; b=E1qA5dOUDL6Zv1ho6BvgUnx0VqpihoF+Gs5G0HJEmmwd4bCiAioywdWReEQuNLSbFZYNLgxFLO7QIapEBAO+a8jH9m8LWRaQkLEmR3sZaoZH7wCsd9B5QNZcNSlveUbvubrFq5gtgiRtkpJBAHLWA2qeiVPnQ6JluqGfbKtIPmA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613878157; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=jyGzfjUWlRh9qZYz4eTEHgluMwEC/Xdout5FiIskyqE=; b=VyAoQ4Ysg0nSBHW1EwpwexkvuWY95jS7VvvcT8Pau9nzPObOR81IuhjHQvA1ZlpjW/YoH7CS8CJU8amONENYZEB11jSwmN3dplFe15fh9P3iztusZlCbkb8ehDsSplKJW+5RG5QUh7xKtvTTRysqS2KAqQJQ9G1769KJ3lslFCc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71890+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1613878157218139.2848333885446; Sat, 20 Feb 2021 19:29:17 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7UO4YY1788612xtc8LV3estL; Sat, 20 Feb 2021 19:29:16 -0800 X-Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mx.groups.io with SMTP id smtpd.web09.16455.1613878151473257398 for ; Sat, 20 Feb 2021 19:29:11 -0800 X-Received: by mail-il1-f179.google.com with SMTP id e2so7989431ilu.0 for ; Sat, 20 Feb 2021 19:29:11 -0800 (PST) X-Gm-Message-State: Sk0QKYCHfJJZBuUwxsD6rceMx1787277AA= X-Google-Smtp-Source: ABdhPJyhQ7fb3YNOf3dpamrnr3lPhHi2HxMRP1iYapcdhDgL1YHwPBH9nU2J+b78d16nCdEGeppfyw== X-Received: by 2002:a92:4151:: with SMTP id o78mr10068756ila.117.1613878150638; Sat, 20 Feb 2021 19:29:10 -0800 (PST) X-Received: from cube.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id x17sm1098785ilm.40.2021.02.20.19.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 19:29:10 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 3/3] ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE Date: Sat, 20 Feb 2021 20:29:00 -0700 Message-Id: <20210221032900.6485-4-rebecca@nuviainc.com> In-Reply-To: <20210221032900.6485-1-rebecca@nuviainc.com> References: <20210221032900.6485-1-rebecca@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1613878156; bh=JEtm84AtQnM5EOw9p0Swgykg3+22O5gT/F53tBj9eGo=; h=Cc:Date:From:Reply-To:Subject:To; b=ZCeWM+dfW85IbLh/ThkE1ksVKm/wH5iYK3OYt3mWwnILkoZNS7Ni48Ldzg6eyh9beI7 qxm/UGGGRuutJRoHxGvAiwNETJliZJUxzlROup5B7FTVjVEqxKwbJDUV7r4dCbzcgtX2i GxcX/L9RcTmyNx3ma9cPUdjKEig3LohlY5A= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Update OemGetChassisType in OemMiscLib to return MISC_CHASSIS_TYPE instead of EFI_STATUS, which matches other OemMiscLib functions. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Include/Library/OemMiscLib.h | 8 +++----- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 11 ++++------- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 31dfe7dac2a6..5f71b2ad48c7 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -128,14 +128,12 @@ OemGetMaxProcessors ( =20 /** Gets the type of chassis for the system. =20 - @param ChassisType The type of the chassis. - - @retval EFI_SUCCESS The chassis type was fetched successfully. + @retval The type of the chassis. **/ -EFI_STATUS +MISC_CHASSIS_TYPE EFIAPI OemGetChassisType ( - OUT UINT8 *ChassisType + VOID ); =20 /** Returns whether the specified processor is present or not. diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/U= niversal/Smbios/OemMiscLibNull/OemMiscLib.c index b02a568426dd..6b233742feb0 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -95,19 +95,16 @@ OemGetMaxProcessors ( =20 /** Gets the type of chassis for the system. =20 - @param ChassisType The type of the chassis. - - @retval EFI_SUCCESS The chassis type was fetched successfully. + @retval The type of the chassis. **/ -EFI_STATUS +MISC_CHASSIS_TYPE EFIAPI OemGetChassisType ( - UINT8 *ChassisType + VOID ) { ASSERT (FALSE); - *ChassisType =3D MiscChassisTypeUnknown; - return EFI_SUCCESS; + return MiscChassisTypeUnknown; } =20 /** Returns whether the specified processor is present or not. --=20 2.26.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71890): https://edk2.groups.io/g/devel/message/71890 Mute This Topic: https://groups.io/mt/80794230/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-