From nobody Tue Feb 10 01:31:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71740+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71740+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1613570467951878.6321365149115; Wed, 17 Feb 2021 06:01:07 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Zw5EYY1788612xipCT0ozPOU; Wed, 17 Feb 2021 06:01:06 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.4213.1613542705685877884 for ; Tue, 16 Feb 2021 22:18:25 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 523F831B; Tue, 16 Feb 2021 22:18:25 -0800 (PST) X-Received: from u200856.usa.arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0135D3F73B; Tue, 16 Feb 2021 22:18:24 -0800 (PST) From: jlinton To: devel@edk2.groups.io Cc: pete@akeo.ie, awarkentin@vmware.com, samer.el-haj-mahmoud@arm.com, leif@nuviainc.com, ardb+tianocore@kernel.org, Jeremy Linton Subject: [edk2-devel] [PATCH v3 1/4] Platform/RaspberryPi: Add Negative table check Date: Wed, 17 Feb 2021 00:18:06 -0600 Message-Id: <20210217061809.307479-2-lintonrjeremy@gmail.com> In-Reply-To: <20210217061809.307479-1-lintonrjeremy@gmail.com> References: <20210217061809.307479-1-lintonrjeremy@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lintonrjeremy@gmail.com X-Gm-Message-State: 3uf79RmznjJHsP6p3CC1ZU7Ix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1613570466; bh=/qaEwroz673rTNP8N4TgzU1aGKaELdnlcpXk6PHddzc=; h=Cc:Date:From:Reply-To:Subject:To; b=l3CWcbm3CEN2StWRpg7oNAm+QWHAMTIKlAg15jFplLan6XngSvGG/UxGF2Sy8LL+fni PfeBt7rMcYuR73Zns8bjjakx4McKx/ngDJTd9k4Oaa895NTPgs0pXoIJZP8e9WxfNDzJM MMSkyqdsLUdm1LkWqsMTGy0yjMI0dcLy348= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Jeremy Linton Turns out its helpful to have a !PcdToken flag that enables a DSDT/SSDT. That simplifies both the emmc2 SSDT (it only installs when !SdIsArasan) and later for the XHCI/PCIe switch where we want to install one of two tables depending on whether a single Pcd is set. Signed-off-by: Jeremy Linton Reviewed-by: Pete Batard Reviewed-by: Andrei Warkentin --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 578f5ead8f..fc1b5f3420 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -606,6 +606,7 @@ typedef struct { typedef struct { UINT64 OemTableId; UINTN PcdToken; + UINTN PcdTokenNot; CONST AML_NAME_OP_REPLACE *SdtNameOpReplace; } NAMESPACE_TABLES; =20 @@ -703,6 +704,9 @@ VerifyUpdateTable ( if (SdtTable->PcdToken && !LibPcdGet32 (SdtTable->PcdToken)) { Result =3D FALSE; } + if (SdtTable->PcdTokenNot && LibPcdGet32 (SdtTable->PcdTokenNot)) { + Result =3D FALSE; + } if (Result && SdtTable->SdtNameOpReplace) { UpdateSdtNameOps (AcpiHeader, SdtTable->SdtNameOpReplace); } @@ -720,11 +724,13 @@ STATIC CONST NAMESPACE_TABLES SdtTables[] =3D { { SIGNATURE_64 ('R', 'P', 'I', 'T', 'H', 'F', 'A', 'N'), PcdToken(PcdFanOnGpio), + 0, SsdtNameOpReplace }, { SIGNATURE_64 ('R', 'P', 'I', 0, 0, 0, 0, 0), 0, + 0, NULL }, { } --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71740): https://edk2.groups.io/g/devel/message/71740 Mute This Topic: https://groups.io/mt/80703636/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-