From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71442+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71442+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782259; cv=none; d=zohomail.com; s=zohoarc; b=i+qQOI+nyeiO9wwcuGGRxdojrWk2oA6muIYNaf0dx3AJzaUrH7Jz9ZwFU7sAdLhJ3+8LoXL/ncmwozGKRG5I4bNYVJM/Ht+RQTDZmRB+oKfb+EcavWPy4eVfNhz8Ye0sO9XC/yjddERn7qOc6dpRhTKLmKBOz6aXbOqBl4sGnS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782259; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=2U0uexW7PGIlb+wRO2j1L4R7DkXd1uPVZs+VKVsyzSw=; b=dCBPxhlCm63liBx/tY0SEAz23Mz4GXNqYy+CZBoh2hlFBdJuR9p8I+Im4y9ggLbF1ETd/weohkeSVF7SYn+lZtcJw2E5OqKKh9TH7TscSx9+gaFjb6M6Za6VczLAehepnAEyZCFXTZfXVvVbPTvGObjsba70EbblD+jN+20KH68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71442+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782259793543.9391814592607; Mon, 8 Feb 2021 03:04:19 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id y91xYY1788612xz2H4rPb7fp; Mon, 08 Feb 2021 03:04:19 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.33498.1612782258563445872 for ; Mon, 08 Feb 2021 03:04:18 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45462ED1; Mon, 8 Feb 2021 03:04:08 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 458A23F719; Mon, 8 Feb 2021 03:04:07 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 01/26] ArmPkg: Fix Ecc error 8001 in Chipset Date: Mon, 8 Feb 2021 11:03:21 +0000 Message-Id: <20210208110346.31211-2-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: dAh5CDc0Xkp0yMojUqH8PHsZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782259; bh=ub04bNHAINTMuIrZ8UZGW3gmj/SVVgS+FZtmxJ0Ghy8=; h=Cc:Date:From:Reply-To:Subject:To; b=f4339qHLOI1kBBAy+rh0zLHmQH77M/lY6n+RMSBQsh8fqg0qNACAtfT+Xjull2KrtSs 5G8CHTKItHJOjIOjQEpY8hm22y9XrxndP+h752ZF08KDUuZWPCE2UK83Fe41U4HrPM+7p nJkAaE9/vsnN3gHsDbAmX4FGfo2TYT1uH+I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard of ArmCortexA5x.h is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 Notes: v2: - Only use one trailing underscore for the ARM_CORTEX_A5x_H__ include guard. [Sami] - 2 patches had the same name and fixed the same Ecc error in V1. They are merged in V2. [Pierre] ArmPkg/Include/Chipset/AArch64.h | 12 ++++++------ ArmPkg/Include/Chipset/AArch64Mmu.h | 4 ++-- ArmPkg/Include/Chipset/ArmCortexA5x.h | 8 ++++---- ArmPkg/Include/Chipset/ArmV7.h | 4 ++-- .../ArmExceptionLib/AArch64/ExceptionSupport.S | 10 +++++----- ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 10 +++++----- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/Include/Chipset/AArc= h64.h index 0ade5cce91c3..d49f4d60b15d 100644 --- a/ArmPkg/Include/Chipset/AArch64.h +++ b/ArmPkg/Include/Chipset/AArch64.h @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2017, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -39,7 +39,7 @@ // MIDR - Main ID Register definitions #define ARM_CPU_TYPE_SHIFT 4 #define ARM_CPU_TYPE_MASK 0xFFF -#define ARM_CPU_TYPE_AEMv8 0xD0F +#define ARM_CPU_TYPE_AEMV8 0xD0F #define ARM_CPU_TYPE_A53 0xD03 #define ARM_CPU_TYPE_A57 0xD07 #define ARM_CPU_TYPE_A72 0xD08 @@ -97,10 +97,10 @@ #define ARM_VECTOR_CUR_SP0_FIQ 0x100 #define ARM_VECTOR_CUR_SP0_SERR 0x180 -#define ARM_VECTOR_CUR_SPx_SYNC 0x200 -#define ARM_VECTOR_CUR_SPx_IRQ 0x280 -#define ARM_VECTOR_CUR_SPx_FIQ 0x300 -#define ARM_VECTOR_CUR_SPx_SERR 0x380 +#define ARM_VECTOR_CUR_SPX_SYNC 0x200 +#define ARM_VECTOR_CUR_SPX_IRQ 0x280 +#define ARM_VECTOR_CUR_SPX_FIQ 0x300 +#define ARM_VECTOR_CUR_SPX_SERR 0x380 #define ARM_VECTOR_LOW_A64_SYNC 0x400 #define ARM_VECTOR_LOW_A64_IRQ 0x480 diff --git a/ArmPkg/Include/Chipset/AArch64Mmu.h b/ArmPkg/Include/Chipset/A= Arch64Mmu.h index 606fe7420d67..6c7ada16b18a 100644 --- a/ArmPkg/Include/Chipset/AArch64Mmu.h +++ b/ArmPkg/Include/Chipset/AArch64Mmu.h @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2013, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -190,7 +190,7 @@ // The value written to the T*SZ fields are defined as 2^(64-T*SZ). So a 3= 9Bit // Virtual address range for 512GB of virtual space sets T*SZ to 25 -#define INPUT_ADDRESS_SIZE_TO_TxSZ(a) (64 - a) +#define INPUT_ADDRESS_SIZE_TO_TXSZ(a) (64 - a) // Uses LPAE Page Table format diff --git a/ArmPkg/Include/Chipset/ArmCortexA5x.h b/ArmPkg/Include/Chipset= /ArmCortexA5x.h index 847a6e00430b..e597eee947cf 100644 --- a/ArmPkg/Include/Chipset/ArmCortexA5x.h +++ b/ArmPkg/Include/Chipset/ArmCortexA5x.h @@ -1,13 +1,13 @@ /** @file - Copyright (c) 2012-2014, ARM Limited. All rights reserved. + Copyright (c) 2012 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ -#ifndef __ARM_CORTEX_A5x_H__ -#define __ARM_CORTEX_A5x_H__ +#ifndef ARM_CORTEX_A5X_H_ +#define ARM_CORTEX_A5X_H_ // // Cortex A5x feature bit definitions @@ -41,4 +41,4 @@ ArmUnsetCpuExCrBit ( IN UINT64 Bits ); -#endif +#endif // ARM_CORTEX_A5X_H_ diff --git a/ArmPkg/Include/Chipset/ArmV7.h b/ArmPkg/Include/Chipset/ArmV7.h index fe91031ef33d..025f87a56d16 100644 --- a/ArmPkg/Include/Chipset/ArmV7.h +++ b/ArmPkg/Include/Chipset/ArmV7.h @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011-2015, ARM Ltd. All rights reserved.
+ Copyright (c) 2011-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -70,7 +70,7 @@ // MIDR - Main ID Register definitions #define ARM_CPU_TYPE_SHIFT 4 #define ARM_CPU_TYPE_MASK 0xFFF -#define ARM_CPU_TYPE_AEMv8 0xD0F +#define ARM_CPU_TYPE_AEMV8 0xD0F #define ARM_CPU_TYPE_A53 0xD03 #define ARM_CPU_TYPE_A57 0xD07 #define ARM_CPU_TYPE_A15 0xC0F diff --git a/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S b/Ar= mPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S index 5b10a1339ac1..9202952ee9c0 100644 --- a/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S +++ b/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S @@ -1,5 +1,5 @@ // -// Copyright (c) 2011 - 2014 ARM LTD. All rights reserved.
+// Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
// Portion of Copyright (c) 2014 NVIDIA Corporation. All rights reserved.<= BR> // Copyright (c) 2016 HP Development Company, L.P. // @@ -200,19 +200,19 @@ ASM_PFX(SErrorSP0): // // Current EL with SPx: 0x200 - 0x380 // -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_SYNC) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_SYNC) ASM_PFX(SynchronousExceptionSPx): ExceptionEntry EXCEPT_AARCH64_SYNCHRONOUS_EXCEPTIONS, SP0 -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_IRQ) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_IRQ) ASM_PFX(IrqSPx): ExceptionEntry EXCEPT_AARCH64_IRQ -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_FIQ) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_FIQ) ASM_PFX(FiqSPx): ExceptionEntry EXCEPT_AARCH64_FIQ -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_SERR) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_SERR) ASM_PFX(SErrorSPx): ExceptionEntry EXCEPT_AARCH64_SERROR diff --git a/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S b/ArmPlatformPkg= /PrePeiCore/AArch64/Exception.S index 59a3da2721e7..43e40f97c3ee 100644 --- a/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S +++ b/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S @@ -1,5 +1,5 @@ # -# Copyright (c) 2011-2014, ARM Limited. All rights reserved. +# Copyright (c) 2011-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -51,22 +51,22 @@ _DefaultSError_t: mov x0, #EXCEPT_AARCH64_SERROR TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_SYNC) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_SYNC) _DefaultSyncExceptHandler_h: mov x0, #EXCEPT_AARCH64_SYNCHRONOUS_EXCEPTIONS TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_IRQ) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_IRQ) _DefaultIrq_h: mov x0, #EXCEPT_AARCH64_IRQ TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_FIQ) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_FIQ) _DefaultFiq_h: mov x0, #EXCEPT_AARCH64_FIQ TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_SERR) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_SERR) _DefaultSError_h: mov x0, #EXCEPT_AARCH64_SERROR TO_HANDLER -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71442): https://edk2.groups.io/g/devel/message/71442 Mute This Topic: https://groups.io/mt/80474622/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71435+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71435+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782263; cv=none; d=zohomail.com; s=zohoarc; b=i9IXARC1+2cCyl7P5ySin7DuyRsjP3Le+SearFZ7VNwhiSly09/kgf8UMDpyA967ynutXULaxwNsItbT/T3USFZrR0uf9nMCL1S8ZEYvNaoXeuvHNcdAtog8udt0cJBol42JPcdt8ol2vQfo7UKDK5DQSVyj5UL3e4pvaxMIrE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782263; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=R/a73kG4ehMmPLX2Rsuk4xQgspOXoY56eG62NlZMhtA=; b=SS9vF6dBqXqxlIb4AGMW4hvb74Uw7ZwP1vc4CIIA+Uc4PcENUOLeRDlINotYUk3X63yITAhoQTEFNxxQoq18d1sNRRoJ5iWIKkwBgRFasp4gj+Amcl85Cj3vX2nB97KWfBdPyo3+9QNL5SpQcmHCBvYq2LOL6Thd9ONgUGHpfX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71435+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161278226317268.70264752089099; Mon, 8 Feb 2021 03:04:23 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9i7QYY1788612xkPssJeVyUP; Mon, 08 Feb 2021 03:04:21 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.33541.1612782255118681743 for ; Mon, 08 Feb 2021 03:04:15 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C01C81042; Mon, 8 Feb 2021 03:04:09 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 80A5C3F719; Mon, 8 Feb 2021 03:04:08 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib Date: Mon, 8 Feb 2021 11:03:22 +0000 Message-Id: <20210208110346.31211-3-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ubCfwJXqqHr0mja7yT42EsyTx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782261; bh=EpJY4Jb2wel7znhA97L+M7E5BjsjyQ0WVCDp4YXh7K0=; h=Cc:Date:From:Reply-To:Subject:To; b=Mu3kLzeeGavNr2LBnDi/oJDUoWxCLP/oUBp6BSqJYci53qcGn+5N9DRNbk8p2Kw/z0n El93RweG6H0oIQD4EdPa5Lt0VQTDZdQ3VnnKb9lfpw/74Q8Q7CNZq193sGc96s7D6CFf4 eOSwh54epEXZ6h0hhigJ9jlQqZOaHzK0M58= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Library/SemihostLib/SemihostLib.c | 26 +++---- ArmPkg/Library/SemihostLib/SemihostPrivate.h | 80 ++++++++++---------- 2 files changed, 53 insertions(+), 53 deletions(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.c b/ArmPkg/Library/Semi= hostLib/SemihostLib.c index a75d45850d43..d66de71182c8 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.c +++ b/ArmPkg/Library/SemihostLib/SemihostLib.c @@ -44,7 +44,7 @@ SemihostFileOpen ( OpenBlock.Mode =3D Mode; OpenBlock.NameLength =3D AsciiStrLen(FileName); - Result =3D Semihost_SYS_OPEN(&OpenBlock); + Result =3D SEMIHOST_SYS_OPEN (&OpenBlock); if (Result =3D=3D -1) { return RETURN_NOT_FOUND; @@ -66,7 +66,7 @@ SemihostFileSeek ( SeekBlock.Handle =3D FileHandle; SeekBlock.Location =3D Offset; - Result =3D Semihost_SYS_SEEK(&SeekBlock); + Result =3D SEMIHOST_SYS_SEEK (&SeekBlock); // Semihosting does not behave as documented. It returns the offset on // success. @@ -95,7 +95,7 @@ SemihostFileRead ( ReadBlock.Buffer =3D Buffer; ReadBlock.Length =3D *Length; - Result =3D Semihost_SYS_READ(&ReadBlock); + Result =3D SEMIHOST_SYS_READ (&ReadBlock); if ((*Length !=3D 0) && (Result =3D=3D *Length)) { return RETURN_ABORTED; @@ -122,7 +122,7 @@ SemihostFileWrite ( WriteBlock.Buffer =3D Buffer; WriteBlock.Length =3D *Length; - *Length =3D Semihost_SYS_WRITE(&WriteBlock); + *Length =3D SEMIHOST_SYS_WRITE (&WriteBlock); if (*Length !=3D 0) return RETURN_ABORTED; @@ -135,7 +135,7 @@ SemihostFileClose ( IN UINTN FileHandle ) { - if (Semihost_SYS_CLOSE (&FileHandle) =3D=3D -1) { + if (SEMIHOST_SYS_CLOSE (&FileHandle) =3D=3D -1) { return RETURN_INVALID_PARAMETER; } else { return RETURN_SUCCESS; @@ -154,7 +154,7 @@ SemihostFileLength ( return RETURN_INVALID_PARAMETER; } - Result =3D Semihost_SYS_FLEN(&FileHandle); + Result =3D SEMIHOST_SYS_FLEN (&FileHandle); if (Result =3D=3D -1) { return RETURN_ABORTED; @@ -195,7 +195,7 @@ SemihostFileTmpName( TmpNameBlock.Identifier =3D Identifier; TmpNameBlock.Length =3D Length; - Result =3D Semihost_SYS_TMPNAME (&TmpNameBlock); + Result =3D SEMIHOST_SYS_TMPNAME (&TmpNameBlock); if (Result !=3D 0) { return RETURN_ABORTED; @@ -220,7 +220,7 @@ SemihostFileRemove ( RemoveBlock.FileName =3D FileName; RemoveBlock.NameLength =3D AsciiStrLen(FileName); - Result =3D Semihost_SYS_REMOVE(&RemoveBlock); + Result =3D SEMIHOST_SYS_REMOVE (&RemoveBlock); if (Result =3D=3D 0) { return RETURN_SUCCESS; @@ -258,7 +258,7 @@ SemihostFileRename( RenameBlock.NewFileName =3D NewFileName; RenameBlock.NewFileNameLength =3D AsciiStrLen (NewFileName); - Result =3D Semihost_SYS_RENAME (&RenameBlock); + Result =3D SEMIHOST_SYS_RENAME (&RenameBlock); if (Result !=3D 0) { return RETURN_ABORTED; @@ -272,7 +272,7 @@ SemihostReadCharacter ( VOID ) { - return Semihost_SYS_READC(); + return SEMIHOST_SYS_READC (); } VOID @@ -280,7 +280,7 @@ SemihostWriteCharacter ( IN CHAR8 Character ) { - Semihost_SYS_WRITEC(&Character); + SEMIHOST_SYS_WRITEC (&Character); } VOID @@ -288,7 +288,7 @@ SemihostWriteString ( IN CHAR8 *String ) { - Semihost_SYS_WRITE0(String); + SEMIHOST_SYS_WRITE0 (String); } UINT32 @@ -301,5 +301,5 @@ SemihostSystem ( SystemBlock.CommandLine =3D CommandLine; SystemBlock.CommandLength =3D AsciiStrLen(CommandLine); - return Semihost_SYS_SYSTEM(&SystemBlock); + return SEMIHOST_SYS_SYSTEM (&SystemBlock); } diff --git a/ArmPkg/Library/SemihostLib/SemihostPrivate.h b/ArmPkg/Library/= SemihostLib/SemihostPrivate.h index 8d1fc6d6eb5a..30103b04b53f 100644 --- a/ArmPkg/Library/SemihostLib/SemihostPrivate.h +++ b/ArmPkg/Library/SemihostLib/SemihostPrivate.h @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2013 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -151,19 +151,19 @@ _Semihost_SYS_SYSTEM( IN SEMIHOST_SYSTEM_BLOCK *SystemBlock ); -#define Semihost_SYS_OPEN(OpenBlock) _Semihost_SYS_OPEN(0x01, OpenB= lock) -#define Semihost_SYS_CLOSE(Handle) _Semihost_SYS_CLOSE(0x02, Hand= le) -#define Semihost_SYS_WRITE0(String) _Semihost_SYS_WRITE0(0x04, Str= ing) -#define Semihost_SYS_WRITEC(Character) _Semihost_SYS_WRITEC(0x03, Cha= racter) -#define Semihost_SYS_WRITE(WriteBlock) _Semihost_SYS_WRITE(0x05, Writ= eBlock) -#define Semihost_SYS_READ(ReadBlock) _Semihost_SYS_READ(0x06, ReadB= lock) -#define Semihost_SYS_READC() _Semihost_SYS_READC(0x07, 0) -#define Semihost_SYS_SEEK(SeekBlock) _Semihost_SYS_SEEK(0x0A, SeekB= lock) -#define Semihost_SYS_FLEN(Handle) _Semihost_SYS_FLEN(0x0C, Handl= e) -#define Semihost_SYS_TMPNAME(TmpNameBlock) _Semihost_SYS_TMPNAME(0x0D, Tm= pNameBlock) -#define Semihost_SYS_REMOVE(RemoveBlock) _Semihost_SYS_REMOVE(0x0E, Rem= oveBlock) -#define Semihost_SYS_RENAME(RenameBlock) _Semihost_SYS_RENAME(0x0F, Ren= ameBlock) -#define Semihost_SYS_SYSTEM(SystemBlock) _Semihost_SYS_SYSTEM(0x12, Sys= temBlock) +#define SEMIHOST_SYS_OPEN(OpenBlock) _Semihost_SYS_OPEN(0x01, OpenB= lock) +#define SEMIHOST_SYS_CLOSE(Handle) _Semihost_SYS_CLOSE(0x02, Hand= le) +#define SEMIHOST_SYS_WRITE0(String) _Semihost_SYS_WRITE0(0x04, Str= ing) +#define SEMIHOST_SYS_WRITEC(Character) _Semihost_SYS_WRITEC(0x03, Cha= racter) +#define SEMIHOST_SYS_WRITE(WriteBlock) _Semihost_SYS_WRITE(0x05, Writ= eBlock) +#define SEMIHOST_SYS_READ(ReadBlock) _Semihost_SYS_READ(0x06, ReadB= lock) +#define SEMIHOST_SYS_READC() _Semihost_SYS_READC(0x07, 0) +#define SEMIHOST_SYS_SEEK(SeekBlock) _Semihost_SYS_SEEK(0x0A, SeekB= lock) +#define SEMIHOST_SYS_FLEN(Handle) _Semihost_SYS_FLEN(0x0C, Handl= e) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) _Semihost_SYS_TMPNAME(0x0D, Tm= pNameBlock) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) _Semihost_SYS_REMOVE(0x0E, Rem= oveBlock) +#define SEMIHOST_SYS_RENAME(RenameBlock) _Semihost_SYS_RENAME(0x0F, Ren= ameBlock) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) _Semihost_SYS_SYSTEM(0x12, Sys= temBlock) #elif defined(__GNUC__) // __CC_ARM @@ -175,37 +175,37 @@ GccSemihostCall ( IN UINTN SystemBlockAddress ); // __attribute__ ((interrupt ("SVC"))); -#define Semihost_SYS_OPEN(OpenBlock) GccSemihostCall(0x01, (UINTN)(= OpenBlock)) -#define Semihost_SYS_CLOSE(Handle) GccSemihostCall(0x02, (UINTN)(= Handle)) -#define Semihost_SYS_WRITE0(String) GccSemihostCall(0x04, (UINTN)(= String)) -#define Semihost_SYS_WRITEC(Character) GccSemihostCall(0x03, (UINTN)(= Character)) -#define Semihost_SYS_WRITE(WriteBlock) GccSemihostCall(0x05, (UINTN)(= WriteBlock)) -#define Semihost_SYS_READ(ReadBlock) GccSemihostCall(0x06, (UINTN)(= ReadBlock)) -#define Semihost_SYS_READC() GccSemihostCall(0x07, (UINTN)(= 0)) -#define Semihost_SYS_SEEK(SeekBlock) GccSemihostCall(0x0A, (UINTN)(= SeekBlock)) -#define Semihost_SYS_FLEN(Handle) GccSemihostCall(0x0C, (UINTN)(= Handle)) -#define Semihost_SYS_TMPNAME(TmpNameBlock) GccSemihostCall(0x0D, (UINTN)(= TmpNameBlock)) -#define Semihost_SYS_REMOVE(RemoveBlock) GccSemihostCall(0x0E, (UINTN)(= RemoveBlock)) -#define Semihost_SYS_RENAME(RenameBlock) GccSemihostCall(0x0F, (UINTN)(= RenameBlock)) -#define Semihost_SYS_SYSTEM(SystemBlock) GccSemihostCall(0x12, (UINTN)(= SystemBlock)) +#define SEMIHOST_SYS_OPEN(OpenBlock) GccSemihostCall(0x01, (UINTN)(= OpenBlock)) +#define SEMIHOST_SYS_CLOSE(Handle) GccSemihostCall(0x02, (UINTN)(= Handle)) +#define SEMIHOST_SYS_WRITE0(String) GccSemihostCall(0x04, (UINTN)(= String)) +#define SEMIHOST_SYS_WRITEC(Character) GccSemihostCall(0x03, (UINTN)(= Character)) +#define SEMIHOST_SYS_WRITE(WriteBlock) GccSemihostCall(0x05, (UINTN)(= WriteBlock)) +#define SEMIHOST_SYS_READ(ReadBlock) GccSemihostCall(0x06, (UINTN)(= ReadBlock)) +#define SEMIHOST_SYS_READC() GccSemihostCall(0x07, (UINTN)(= 0)) +#define SEMIHOST_SYS_SEEK(SeekBlock) GccSemihostCall(0x0A, (UINTN)(= SeekBlock)) +#define SEMIHOST_SYS_FLEN(Handle) GccSemihostCall(0x0C, (UINTN)(= Handle)) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) GccSemihostCall(0x0D, (UINTN)(= TmpNameBlock)) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) GccSemihostCall(0x0E, (UINTN)(= RemoveBlock)) +#define SEMIHOST_SYS_RENAME(RenameBlock) GccSemihostCall(0x0F, (UINTN)(= RenameBlock)) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) GccSemihostCall(0x12, (UINTN)(= SystemBlock)) #else // __CC_ARM #define SEMIHOST_SUPPORTED FALSE -#define Semihost_SYS_OPEN(OpenBlock) (-1) -#define Semihost_SYS_CLOSE(Handle) (-1) -#define Semihost_SYS_WRITE0(String) -#define Semihost_SYS_WRITEC(Character) -#define Semihost_SYS_WRITE(WriteBlock) (0) -#define Semihost_SYS_READ(ReadBlock) ((ReadBlock)->Length) -#define Semihost_SYS_READC() ('x') -#define Semihost_SYS_SEEK(SeekBlock) (-1) -#define Semihost_SYS_FLEN(Handle) (-1) -#define Semihost_SYS_TMPNAME(TmpNameBlock) (-1) -#define Semihost_SYS_REMOVE(RemoveBlock) (-1) -#define Semihost_SYS_RENAME(RenameBlock) (-1) -#define Semihost_SYS_SYSTEM(SystemBlock) (-1) +#define SEMIHOST_SYS_OPEN(OpenBlock) (-1) +#define SEMIHOST_SYS_CLOSE(Handle) (-1) +#define SEMIHOST_SYS_WRITE0(String) +#define SEMIHOST_SYS_WRITEC(Character) +#define SEMIHOST_SYS_WRITE(WriteBlock) (0) +#define SEMIHOST_SYS_READ(ReadBlock) ((ReadBlock)->Length) +#define SEMIHOST_SYS_READC() ('x') +#define SEMIHOST_SYS_SEEK(SeekBlock) (-1) +#define SEMIHOST_SYS_FLEN(Handle) (-1) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) (-1) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) (-1) +#define SEMIHOST_SYS_RENAME(RenameBlock) (-1) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) (-1) #endif // __CC_ARM -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71435): https://edk2.groups.io/g/devel/message/71435 Mute This Topic: https://groups.io/mt/80474615/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71438+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71438+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782463; cv=none; d=zohomail.com; s=zohoarc; b=FaRwqrldF5PxLj2w0lHEUqWdx+WIhMVavTCA+3r3BUTR0mO/jJ6Fscy/CGvJN2ehnSNBY4M4Pd1h530z59jupwOL6ymaO14fv/fv9zvA+GuCCkzdgRB0q1lxjS8vjl21aoE7KLAjpDL39X9ffpJGEJ6RnSQGVYF8dZkxQt0JTPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782463; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=2au0GoTdG3mCsRnpgFErlBogbgfEVC22QwUun5PvikY=; b=BrjU381bwWETm50oIfqhhWc7IFPWWJDlIC7I9Jm33i6zgce5NZCSDOIFyh46XPjI/qjaVTDNr21qKtRQBDyQcIbg305V3AmfN2AnLT7+SF5RXYNfnVzoIMQB2rTirjE+8VDe0ryXkWA2SvErT0vVFcwPASoLeITy8Y2RkrW29Pc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71438+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782463152985.0962069912506; Mon, 8 Feb 2021 03:07:43 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7Xh4YY1788612xtOBmGMXnpI; Mon, 08 Feb 2021 03:07:42 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.33804.1612782256273572573 for ; Mon, 08 Feb 2021 03:04:16 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF9B81063; Mon, 8 Feb 2021 03:04:10 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0D7723F719; Mon, 8 Feb 2021 03:04:09 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib Date: Mon, 8 Feb 2021 11:03:23 +0000 Message-Id: <20210208110346.31211-4-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: HAcxGcipyUrmwxsfafS6cVM8x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782462; bh=FOUT563e9ZZhzbe9XQ6WG1tyFTpBqAHNwn9DK//WANE=; h=Cc:Date:From:Reply-To:Subject:To; b=IyyQN6vZNfF5T2DHkV1i/bdhc+d9p7OjzqpVtOR/2ibpN31A2STk27mYOusWPtiNkql fr46EobhPt2tLcXfUZpQ3TJC/lEqoNhyQLTF701VTI7WwgJ23SponryF6FWogDMFh15Dt F7Pj98i94ogKxws7AKrvSn125K2nnYuzH0k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c b/ArmPkg/Libr= ary/ArmArchTimerLib/ArmArchTimerLib.c index 24d9dae4e660..875c835706d6 100644 --- a/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c +++ b/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c @@ -1,7 +1,7 @@ /** @file Generic ARM implementation of TimerLib.h - Copyright (c) 2011-2016, ARM Limited. All rights reserved. + Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -20,9 +20,9 @@ // Select appropriate multiply function for platform architecture. #ifdef MDE_CPU_ARM -#define MultU64xN MultU64x32 +#define MULT_U64_X_N MultU64x32 #else -#define MultU64xN MultU64x64 +#define MULT_U64_X_N MultU64x64 #endif @@ -121,7 +121,7 @@ MicroSecondDelay ( // =3D MicroSeconds x TICKS_PER_MICRO_SEC // =3D MicroSeconds x Frequency.10^-6 TimerTicks64 =3D DivU64x32 ( - MultU64xN ( + MULT_U64_X_N ( MicroSeconds, GetPlatformTimerFreq () ), @@ -263,7 +263,7 @@ GetTimeInNanoSecond ( // Time =3D --------- x 1,000,000,000 // Frequency // - NanoSeconds =3D MultU64xN ( + NanoSeconds =3D MULT_U64_X_N ( DivU64x32Remainder ( Ticks, TimerFreq, @@ -276,7 +276,7 @@ GetTimeInNanoSecond ( // will not overflow 64-bit. // NanoSeconds +=3D DivU64x32 ( - MultU64xN ( + MULT_U64_X_N ( (UINT64) Remainder, 1000000000U), TimerFreq -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71438): https://edk2.groups.io/g/devel/message/71438 Mute This Topic: https://groups.io/mt/80474618/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71440+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71440+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782325; cv=none; d=zohomail.com; s=zohoarc; b=hZqEisO5V1jHHWRGqHRtm1D+S6JmHqTqcLVfutOZy5IXovAIxYi3mBoSG20p66DlyNFzxGlmEu5ZBOv1YPaDvFeX4pD7m7kfBmAi4i51QWylIbbdWJkAXHTHLcWZ6yDWPY5rNzSN/ZbqFpd+phCyN6Y0wUP28w5ggHuWaw9mrbc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782325; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=f4CR0sfP6NXZt1H+k4IXE7dSh5EGQTgO9xQUGur31XU=; b=L5eRojvmVOff2ukrATNDNJKz11rsZFRJzzQ8S9ok4ulTZ6af53+Zk3j6POWhD/2nHeYyUrW4Ifhxso9Hvl70xneeSEJpRZr7XzZPwFE6DgpHduCLjD5B6hAGkP+Yy8VcxIC8qQg3z0/1A3i6aVux/7niV3SBY6aug8TQKYjWQMg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71440+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782325193243.79555330774735; Mon, 8 Feb 2021 03:05:25 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id xjQXYY1788612xfaAHYttogq; Mon, 08 Feb 2021 03:05:24 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.33806.1612782257774628036 for ; Mon, 08 Feb 2021 03:04:17 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75EB711B3; Mon, 8 Feb 2021 03:04:12 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 486AF3F719; Mon, 8 Feb 2021 03:04:11 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe Date: Mon, 8 Feb 2021 11:03:24 +0000 Message-Id: <20210208110346.31211-5-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: XjIhPqnMjjdQKF9CoVIRRzzfx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782324; bh=AjV1l57i2a24Bs+P/C0+fs+hQYRQu+KKqKJf8AMIoVk=; h=Cc:Date:From:Reply-To:Subject:To; b=dXJSUOsu+k+9DBZHB5GBdZw2Iy6i8vBBmnWC2c/LTPO2z7cGM+13YTUoCttGMvKMZZ8 4ISmOyy/cNL0mXCBTli5Q7qIbfg2BbPtecvRsV50ltls7Oubw8jCnJydWp84rEy8iLxYH WSDDyHjO7jdObgALTn6sXH19kmFJDr3zp00= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@param', '@post', '@pre', '@retval', '@return', '@sa', '@since', '@test', '@note', '@par', '@endcode', '@code', '@{', '@}' are allowed to mark the code This patch removes the ":" character following the "@param" doxygen command. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/CpuDxe/CpuMpCore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c b/ArmPkg/Drivers/CpuDxe/CpuM= pCore.c index d16ae3979207..8a9e8c2fa3a2 100644 --- a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c +++ b/ArmPkg/Drivers/CpuDxe/CpuMpCore.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -32,7 +32,7 @@ ARM_PROCESSOR_TABLE mArmProcessorTableTemplate =3D { }; /** Publish ARM Processor Data table in UEFI SYSTEM Table. - * @param: HobStart Pointer to the beginning of the HOB Lis= t from PEI. + * @param HobStart Pointer to the beginning of the HOB List= from PEI. * * Description : This function iterates through HOB list and finds ARM pro= cessor Table Entry HOB. * If the ARM processor Table Entry HOB is found, the HOB d= ata is copied to run-time memory -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71440): https://edk2.groups.io/g/devel/message/71440 Mute This Topic: https://groups.io/mt/80474620/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71437+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71437+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782257; cv=none; d=zohomail.com; s=zohoarc; b=FiOrwxLLpA27DRKQQwZAjUkjslNCZbmYr37nAvZVU1efk5XETV4A4yk+4qqz6B7CBKbKH/uZuwoGlGUF32cwmwGjHBLjcZB6LG00mnltgrFuWy7bshEOcYTOeVAqPY3rGm4l6ABDlBWUEMHjgHazVsBtTmBi2Fl9APsWBY8M0Nc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782257; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ESkXhrDlpafIMK5GpR66hhbM7sZo0liz+zYv3X4G9bw=; b=czVIcbnoJDjjDNIwMKrhSqeRHjdPlpjQf2QJbNhtKZlVeJfepUjttCGZlfPAMQmOBlhUDc+6lwE8W4n/lHEOcdbgcuBjNKOzxnm60bNBOzq0QygWzDSp9pBT+Blzb2qGjevy2WhpbzP24V17qKNY3GKF5pPvDZR9eNGHKIiTyrg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71437+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782257273887.6473000996716; Mon, 8 Feb 2021 03:04:17 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id LwYBYY1788612xuBrsr1eZQ0; Mon, 08 Feb 2021 03:04:16 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.33496.1612782256012774264 for ; Mon, 08 Feb 2021 03:04:16 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA2FD139F; Mon, 8 Feb 2021 03:04:13 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BBDA43F719; Mon, 8 Feb 2021 03:04:12 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc Date: Mon, 8 Feb 2021 11:03:25 +0000 Message-Id: <20210208110346.31211-6-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: HGaLevTr6ODta1CqVHMlWvLAx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782256; bh=99CjT/SSPIZZ2vUhwoAyt0kdrldLeKgbO5JTizwHfmc=; h=Cc:Date:From:Reply-To:Subject:To; b=cLKNl6KmWGtgIJWtt3edh2yptJhq6EsnkWoEM2VIqNVFefyOdZhwCoDRt9U54Evwm0h X21DdZ3SjHtav0/ZGKEvzsg9RZWs2MkLHavdcKtDRzH5HlxBJrtRifSwD1Yjc4y/id0uw WhCymZogpNHEyTEnO2tpjqfDZw9iCigWGfo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no unnecessary inclusion of library classes in the INF file This comes with the additional information: The Library Class [BootLogoLib] is not used in any platform The Library Class [DxeServicesLib] is not used in any platform The Library Class [UefiBootManagerLib] is not used in any platform The Library Class [PeCoffExtraActionLib] is not used in any platform ArmPkg/ArmPkg.dsc builds the modules requiring thses libraries, but doesn't build the required libraries. This patch adds the missing libraries to the [LibraryClasses.common] section. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/ArmPkg.dsc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index 48059cf38ed3..ddab84f92165 100644 --- a/ArmPkg/ArmPkg.dsc +++ b/ArmPkg/ArmPkg.dsc @@ -2,7 +2,7 @@ # ARM processor package. # # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
# Copyright (c) 2016, Linaro Ltd. All rights reserved.
# Copyright (c) Microsoft Corporation.
# @@ -35,14 +35,17 @@ [PcdsFixedAtBuild] [LibraryClasses.common] BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMainte= nanceLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManag= erLib.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf UefiLib|MdePkg/Library/UefiLib/UefiLib.inf @@ -50,6 +53,7 @@ [LibraryClasses.common] UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeC= offGetEntryPointLib.inf + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServic= esLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71437): https://edk2.groups.io/g/devel/message/71437 Mute This Topic: https://groups.io/mt/80474617/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71436+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71436+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782324; cv=none; d=zohomail.com; s=zohoarc; b=C3jFm/BeBFpsckyL1OTJFMRkWFYpXZifVcR3xrEKlzLqm0WcUr8Kd3mNasa/ju1XNzrsYkxOR9jzSkHjljmVDEX+EmgLsdgs+c8IdcWnr+59rdMR6Wg9C+ASTzjB/EzkfDCoQR65vHauiNinx6B9OMwxtzBTf9SzqMeBb5ICjmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782324; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=u5L4xbvC52SZt93iBNWkqCCylmw2zfOhX+XTDCMmk6E=; b=l0w+9E2XbBVpB0xy3Nx1X414MPY1Mvtp8frPyU/fx5x4UGb0wnRbAshGWsqJZPrUSK1vvo05ZqaFpDkaU8kRPLTihACUM0jPDetI6wPHuMSGIhGzFLlIIwSaGHM9XfJ79umS4gljP8SNLRm9zGUPKZzcaiIPMj8yFS97ocJGDlU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71436+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16127823244127.983615971242102; Mon, 8 Feb 2021 03:05:24 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id fu2jYY1788612xg5OSnmVoxa; Mon, 08 Feb 2021 03:05:23 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.33495.1612782255984176275 for ; Mon, 08 Feb 2021 03:04:16 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A717413A1; Mon, 8 Feb 2021 03:04:15 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3E0413F719; Mon, 8 Feb 2021 03:04:13 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib Date: Mon, 8 Feb 2021 11:03:26 +0000 Message-Id: <20210208110346.31211-7-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: QuxFyFD6Od9B2z2DiqcufaSQx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782323; bh=FLOd8QSByDHnVfzCdBkhBR72XKMFB7cGJ9Y6/74nQmE=; h=Cc:Date:From:Reply-To:Subject:To; b=Xc4/7TNQdMPiBOi8069hnUxOKwdmXoxwfXqBdGqTvnWhoUhmwgnH7M0kI6DwvZ4BO9Z vwxYPVw88pIWyAHDuWzK/uCI8ksMxfh1eW4rzSWMWXkAB0vwfB9t8SFsxAJCQ3/AwHkaC C1n+vhDlKwv2lpkYoGjhYB08l6OkVteU3vI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Module file has FILE_GUID collision with other module file The two .inf files with clashing GUID are: ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf As ArmMmuBaseLib.inf is older than ArmMmuStandaloneMmLib.inf, it has precedence. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf b/= ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf index 85973687f5ad..0a147fff18c0 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -10,7 +10,7 @@ [Defines] INF_VERSION =3D 0x0001001A BASE_NAME =3D ArmMmuStandaloneMmCoreLib - FILE_GUID =3D da8f0232-fb14-42f0-922c-63104d2c70bd + FILE_GUID =3D 44a741c2-655f-41fc-b066-179f5a9aa78a MODULE_TYPE =3D MM_CORE_STANDALONE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D StandaloneMmMmuLib -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71436): https://edk2.groups.io/g/devel/message/71436 Mute This Topic: https://groups.io/mt/80474616/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71441+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71441+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782266; cv=none; d=zohomail.com; s=zohoarc; b=EbqI76/YjRNwKQzvwY/i2ZgWKp2V/rXFLX5Y29UZ/+aPzFRDhuj+FL35GPUsIRJzpJNPdIeqq3Ws0RiHKKE0kvZxU6XpVNq52O2EuWtZLJ7TWPE7TveeZ2+jEm4FTkqIusw7/iMOgquotHFHO1Ro1tevwpKSqrAtHzAvTzvOhXc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782266; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=qTOdbW7f2d4hf0fHlE6u5cB+cEZoLdnXJ6M6nCj0kGQ=; b=Yb+6YES5bmmRORedkbggFPkk84hoz20pTdcmrxQSX9cIufLIZTKwtFnQzenQf8NbYO5XPWrAgIquwXwQMAYzmmO82oMlYaJqKTlPt57dfEJbv/ayx7uXpSZVnG+dzFcWcEMxwdaPA900k9Ym2spou8/gYFRY2UF3UYdU3/p+kzU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71441+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782266321288.89087187992914; Mon, 8 Feb 2021 03:04:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DslJYY1788612x5gkSQIfh2h; Mon, 08 Feb 2021 03:04:25 -0800 X-Received: from foss.arm.com (foss.arm.com []) by mx.groups.io with SMTP id smtpd.web09.33495.1612782255984176275 for ; Mon, 08 Feb 2021 03:04:18 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81A8F1063; Mon, 8 Feb 2021 03:04:17 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1285D3F719; Mon, 8 Feb 2021 03:04:15 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe Date: Mon, 8 Feb 2021 11:03:27 +0000 Message-Id: <20210208110346.31211-8-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ufBgYfirrsphLgYptx8me33nx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782265; bh=4X+pk67ilXu8qFiDsCH0QsZKTYuWmhT9nKaYLc5n2EE=; h=Cc:Date:From:Reply-To:Subject:To; b=eMtgG8FRXXK+KzTt8FrryNZwPU1o9OA9UOjT4hbJOuyc9DnlyECeCf6Y+uATNqQ9AOD 16nyLn/CzTsjCmfC9B/yOmL6/zJN5kLN1V1/A7hkd3MzK9UYl07E7jLEsB9Pu8TUrUVjd pqAWeVf+7x/pLRO2ZE4OlIkwpPkksov7kiY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h] [ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h] are existing in module ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf but are not described in INF the file. The patch also re-orders the files in the [Sources.common] section. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf b/ArmPkg/Drivers/ArmS= cmiDxe/ArmScmiDxe.inf index 6cd3aa1c82ec..fc5f841c2b7c 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf +++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017-2018, Arm Limited. All rights reserved. +# Copyright (c) 2017-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -18,11 +18,16 @@ [Defines] ENTRY_POINT =3D ArmScmiDxeEntryPoint [Sources.common] - Scmi.c + ArmScmiBaseProtocolPrivate.h + ArmScmiClockProtocolPrivate.h + ArmScmiPerformanceProtocolPrivate.h ScmiBaseProtocol.c + Scmi.c ScmiClockProtocol.c ScmiDxe.c + ScmiDxe.h ScmiPerformanceProtocol.c + ScmiPrivate.h [Packages] ArmPkg/ArmPkg.dec -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71441): https://edk2.groups.io/g/devel/message/71441 Mute This Topic: https://groups.io/mt/80474621/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71443+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71443+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782261; cv=none; d=zohomail.com; s=zohoarc; b=MqpmJgVxfAMw/bKGtlKxaG0Gaa/CvbsOGM27Injw/2gxuGjCBgrMqawuJy5xefT5CRQ0qv2MroHfbR9AjdX71RsaBUqC7iL/VbkQ4Qlf1nvxFvntPHc+zZgVBTUlXzco8vfLh5c7bLv6KERtjjVbBF/RMZfkzZAn2curTrXbZo8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782261; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Gvqi9SdiqCA9+tgEJ+f6+pfSdzdDJIdYIO68tyLei4k=; b=jpcQGBTLtWMwiTuYRG49pLcY0CK3k+uGJ1IoUl5sv0CYZGbOJW5igagY48IAXTfSrcZQ8ZIJ9Gglp7EB51W/P6oeScJOB4sAD/zbdc0Ij4KxfqDmewG0cpcK3/Si4293xCnYVcUutMjKrQIAIBWApw1NSWUFafzH1zKx74uodmY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71443+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16127822619197.247541832237175; Mon, 8 Feb 2021 03:04:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id eG63YY1788612xDBY7mNJ4Sx; Mon, 08 Feb 2021 03:04:21 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.33807.1612782259187891326 for ; Mon, 08 Feb 2021 03:04:19 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D252231B; Mon, 8 Feb 2021 03:04:18 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C5FF53F719; Mon, 8 Feb 2021 03:04:17 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe Date: Mon, 8 Feb 2021 11:03:28 +0000 Message-Id: <20210208110346.31211-9-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: henQG24gTTcWhTCgRyGms6z9x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782261; bh=OBMaWkyWc0U1hmNc/OTtOkZiEBelDCJD1UQ76P0DGsA=; h=Cc:Date:From:Reply-To:Subject:To; b=R4H2zVNghEfwUCWS22Mk0FKA0TwJq+z+Cbr1/IbhVq89/uLBrPVx+Dsoxcv2OgusU0m UYghH7W/z4B3fU0s8Ej4I1R0lMXJk7wef22Tk2lQFpTsREysvWcGb75Bb0CPrPOSS6ieH GPUqrPpuzQfLjPTLhd3uGG5AcF6z5IulZoI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h] is existing in module ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf but is not described in the INF file. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf b/Arm= Pkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf index d725a2c85839..7dbd30783892 100644 --- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf +++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2017, ARM Limited. All rights reserved. +# Copyright (c) 2013-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -13,6 +13,7 @@ [Defines] ENTRY_POINT =3D GenericWatchdogEntry [Sources.common] + GenericWatchdog.h GenericWatchdogDxe.c [Packages] -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71443): https://edk2.groups.io/g/devel/message/71443 Mute This Topic: https://groups.io/mt/80474623/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71444+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71444+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782464; cv=none; d=zohomail.com; s=zohoarc; b=jrqK/BQmQgc0DERvHBo20juPQ0bmQBR8QOaQjdHsYwYZMFjYOJGYWm3N8nukRw8Mo1BYJizugS4lQonpxsyfpj0pjf3OHcaTTWMRK+CqibaWOT36V3DvseWf/YdaVfYx4KAaLPZhytIb6dJ2UcHNQUUYcLdxusBJjtnUTh3YZZs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782464; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=5smFLEIh9IDaF4NIsh6u9TY1pIkBrXjoN/Skp/f1ZS0=; b=GUijiU8apnqrxdrFFZYWBqNkAxvIFLgQL9IFhZWA3liPYE2YrF+3CuNfB9lmcCNdMrEIKrsdij8sWnXd/IQZYrs6vznyKFljJUPD9ZVJXdabSk2uU++9xDUmvfwWX1Ms85FY0FmwLC8L5cqbU/OwmIHnYfi85+ggpJ4yNrmJmI0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71444+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782464571896.7987886973765; Mon, 8 Feb 2021 03:07:44 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qSFkYY1788612xcWC7lCXfw2; Mon, 08 Feb 2021 03:07:44 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.33544.1612782260513184719 for ; Mon, 08 Feb 2021 03:04:20 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2434AED1; Mon, 8 Feb 2021 03:04:20 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3A3AA3F719; Mon, 8 Feb 2021 03:04:19 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe Date: Mon, 8 Feb 2021 11:03:29 +0000 Message-Id: <20210208110346.31211-10-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 7ol2tFQKfqv8XS1gYu90WWn5x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782464; bh=MD+Cvku53cIEC5FYKeOAhHTG1Q3+nCgoZ1+LssSnFIE=; h=Cc:Date:From:Reply-To:Subject:To; b=SMQNijCQ6RP6TSKiTw4QAUFYUnHKQwhVVulpbSEVYdcJurslTfZlFr1TJ4hu5KNubIO BbbN7I43qMwpupygz1HcIW6gAYp04y1RNyLrBDKICQ5AAT9DqCaUwVzY6isrRmuN+3iXe xX6+qavQdAO0LavMT0fv6ekwU4zUJhna/nM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h] is existing in module ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf but is not described in the INF file. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf b/ArmPkg= /Drivers/MmCommunicationDxe/MmCommunication.inf index 2465fb77c58e..05b6de73ff34 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf @@ -2,7 +2,7 @@ # # DXE MM Communicate driver # -# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. +# Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +24,7 @@ [Defines] # [Sources.AARCH64] + MmCommunicate.h MmCommunication.c [Packages] -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71444): https://edk2.groups.io/g/devel/message/71444 Mute This Topic: https://groups.io/mt/80474624/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71448+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71448+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782463; cv=none; d=zohomail.com; s=zohoarc; b=dwiIK3DOyb97X6qU/H0MAi5JVEAWkDAMdPeFvknMJ/6LbPYIRgbKzpRqySRGukVmie1hjEw/86iFBrKADyZT4Mg7v0kW/ylxbfKHqKo4SOG4/V8PZS2PU7+U1muEnMeX/xqEyol4h5lnQ0PJeXokg433H6PnIAGg3ndJRoyhDlU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782463; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=heyxzaqdj4Y9SVOgsHXoksxQrWQhgiWsADBNMr1Y5ic=; b=ZjfqXOU6ArgDTjn/f3bBA1aXyZfzxlJmeV57gL6M8H5uFh/hoNPpL2rF2d+kUQ9dxADVEZSZA5tN8npmoF6cuAdUHmXFlwBjkTU6/cX9lsGGeIRpKwqoPvnZtL5eielIe8LBtXYSB58LFvAc77wQZWnBsjARMLREWlzMScuvIrU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71448+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782463605497.2228658878048; Mon, 8 Feb 2021 03:07:43 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id mwyaYY1788612xTILyZncg9l; Mon, 08 Feb 2021 03:07:43 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.33623.1612782266991699568 for ; Mon, 08 Feb 2021 03:04:27 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9859131B; Mon, 8 Feb 2021 03:04:21 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6664F3F719; Mon, 8 Feb 2021 03:04:20 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib Date: Mon, 8 Feb 2021 11:03:30 +0000 Message-Id: <20210208110346.31211-11-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: kmiNIsangxnbwmKlD2PBJLb1x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782463; bh=EP7yc/hUEufu9ZsF8h4mUwUcTXPdmAcCX9mB1csh8jw=; h=Cc:Date:From:Reply-To:Subject:To; b=HrtL7KOCWFgrizSBRg09sbdbnW05KyJdjWPjyxEVZg9yjCG+UCUEwn9pTZ1Ifg7K1jE llZ4kpas5QKJjW/dpvhwtSoGAEaqSE5O+t5LJnRzjkSpyLPda2bPrtvUMU+XtosXIgdlf wVxBZtEJ4WQL33NEIzzxXl6lyK1M8Uyk1QE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Library/SemihostLib/SemihostPrivate.h] is existing in module ArmPkg/Library/SemihostLib/SemihostLib.inf but is not described in the INF file. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Library/SemihostLib/SemihostLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.inf b/ArmPkg/Library/Se= mihostLib/SemihostLib.inf index a46618d30eef..2a4409f6573b 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.inf +++ b/ArmPkg/Library/SemihostLib/SemihostLib.inf @@ -2,7 +2,7 @@ # Semihosting JTAG lib # # Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -25,6 +25,7 @@ [Defines] # [Sources.common] SemihostLib.c + SemihostPrivate.h [Sources.ARM] Arm/GccSemihost.S | GCC -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71448): https://edk2.groups.io/g/devel/message/71448 Mute This Topic: https://groups.io/mt/80474629/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71445+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71445+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782271; cv=none; d=zohomail.com; s=zohoarc; b=Y5HM7Obdh1BO/BrYmXj61hFBOiyhCsu++uLzhE4m0yqPpM/8eGBbwFXm7/Mkyu1i+pllEXhMx1f94q0hZZM4jJ5L/w493AmU4Sr6ABIil+bA0zQUDUIjtoLnnP2hNIQyjEWAbXp9cPhg6glO+onCN4hu7Hw0qOW/7VtWlHhVBYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782271; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=yxUfDVN7yvPgwDjG/9D7uSvgTpvgqE5wEHaPCM/tJEs=; b=D+HHpl/73Oz5vQbAFCW5cR3hR62bcWIz5PEXNobuS+v/HpJ7AFAD7J57yFDEaTm4kjKD+Rrw6G+6IgNV02m0ZKBkd1dy2OBdISbIXv8UNRw4d/TFRByTkffvfn4C4dgwiV+hDvDj5z8r7NUf7pUCE28dgjw/jJqj3UGmebU11lw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71445+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782271034275.63701899296177; Mon, 8 Feb 2021 03:04:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TxCTYY1788612x5z9jMtT46i; Mon, 08 Feb 2021 03:04:29 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.33546.1612782263654916786 for ; Mon, 08 Feb 2021 03:04:23 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58E40ED1; Mon, 8 Feb 2021 03:04:23 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 02F353F719; Mon, 8 Feb 2021 03:04:21 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c Date: Mon, 8 Feb 2021 11:03:31 +0000 Message-Id: <20210208110346.31211-12-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: gXgJrrui2ScepnjqjV7VXvokx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782269; bh=3MsE4Us66PTwqXDEP2d0xSM8YIz0y054VDPCxuKforI=; h=Cc:Date:From:Reply-To:Subject:To; b=T9pCadQeePjwHiIUhje0KKxXbtVyyx2o/D0laGY87sK1Pv1lujZcmiYkeo4u67ND/06 1I6MX3Y4kECS0UkwXAIv3zVBixFB94l5iZxaHpkMwukM3gJ5uuj9PqbLU9in8knOqO+LX NOyo0yrPA+haFqqmGOKYJFSFSJmNeo1put4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Commit: 142fa386eb907df55c239311cd5fa2d40f5007dd removes the ArmGicSecLib. The file ArmGic/ArmGicSecLib.c was exclusively used by this library. Thus, this file should also be removed. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c | 58 ---------------------------- 1 file changed, 58 deletions(-) delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c diff --git a/ArmPkg/Drivers/ArmGic/ArmGicSecLib.c b/ArmPkg/Drivers/ArmGic/A= rmGicSecLib.c deleted file mode 100644 index 4af98bb6ec93..000000000000 --- a/ArmPkg/Drivers/ArmGic/ArmGicSecLib.c +++ /dev/null @@ -1,58 +0,0 @@ -/** @file -* -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. -* -* SPDX-License-Identifier: BSD-2-Clause-Patent -* -**/ - -#include -#include -#include -#include - -/* - * This function configures the interrupts set by the mask to be secure. - * - */ -VOID -EFIAPI -ArmGicSetSecureInterrupts ( - IN UINTN GicDistributorBase, - IN UINTN* GicSecureInterruptMask, - IN UINTN GicSecureInterruptMaskSize - ) -{ - UINTN Index; - UINT32 InterruptStatus; - - // We must not have more interrupts defined by the mask than the number = of available interrupts - ASSERT(GicSecureInterruptMaskSize <=3D (ArmGicGetMaxNumInterrupts (GicDi= stributorBase) / 32)); - - // Set all the interrupts defined by the mask as Secure - for (Index =3D 0; Index < GicSecureInterruptMaskSize; Index++) { - InterruptStatus =3D MmioRead32 (GicDistributorBase + ARM_GIC_ICDISR + = (Index * 4)); - MmioWrite32 (GicDistributorBase + ARM_GIC_ICDISR + (Index * 4), Interr= uptStatus & (~GicSecureInterruptMask[Index])); - } -} - -VOID -EFIAPI -ArmGicEnableDistributor ( - IN INTN GicDistributorBase - ) -{ - // Turn on the GIC distributor - MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 1); -} - -VOID -EFIAPI -ArmGicSetupNonSecure ( - IN UINTN MpId, - IN INTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase - ) -{ - ArmGicV2SetupNonSecure (MpId, GicDistributorBase, GicInterruptInterfaceB= ase); -} -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71445): https://edk2.groups.io/g/devel/message/71445 Mute This Topic: https://groups.io/mt/80474626/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71446+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71446+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782331; cv=none; d=zohomail.com; s=zohoarc; b=KmKhIyCs7ktO2d/od3X0ju0aKa6nR6Z6QpQkK6UKCPic1+MZv6Ds2aa0BZ7clgR8L0X0q1HMKvPjzJd3BzszW/MIjlm69NIeZKsDJcPfC1SO4wgAGKtqHVHsudByqAxxMrOtXroT8TBe/iC4vc5sj7ckafJdgD0kzHsy7OwsP4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782331; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Et0lXiaXoJiZran2DVokCGvnZ4C7Ido3zjAp/4p2SAA=; b=nqcEZNeHP0gd96SgD7rzu5o5p/lhLgzVA5+B2iLDPNQwn+vWGmHvexu1GnwP+2nTfnt0iC56Rz0fRnPY/NzMCZynKAerw0xOJpIE0yTR+zrIrqdTZSVDeD7YrAKHt85z3/Kh3JaYOm6J27voIoA4jD704WUyy/zz7gWa3vuwvaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71446+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782331003461.32480534158196; Mon, 8 Feb 2021 03:05:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id z1ldYY1788612xyekq4ETyOu; Mon, 08 Feb 2021 03:05:30 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.33548.1612782265339502836 for ; Mon, 08 Feb 2021 03:04:25 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 036C6ED1; Mon, 8 Feb 2021 03:04:25 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A7BC33F719; Mon, 8 Feb 2021 03:04:23 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib Date: Mon, 8 Feb 2021 11:03:32 +0000 Message-Id: <20210208110346.31211-13-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: JpOfYD5OYgEBgcRlfAPNgNT4x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782330; bh=klzZjzhtp0e4XFKmbnBL/AKh4TbzM4n1SyVSfyAndOE=; h=Cc:Date:From:Reply-To:Subject:To; b=BJ58cNjufl549a7FXwxN2qmebou8YuTPmQbFj1ItZ8X6hqzEz9ROwWAB5ZYcwzy9x+s lJydR4v2gNNVrHh9O6T5Y5IKz2VTBXtJoOhoJ7GLZbzHoII+xE5a1F2LskyRPpRFmHK2G MEOb89G6MXZOgY4t7VVXA7M2K7UxH0QyPfE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Function name should be left justified, followed by the beginning of the parameter list, with the closing parenthesis on its own line, indented two spaces Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 4 +++- ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c b/Ar= mPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c index 514f80a2d47a..fcf3dd16443e 100644 --- a/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c +++ b/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c @@ -2,6 +2,7 @@ * Exception Handling support specific for AArch64 * * Copyright (c) 2016 HP Development Company, L.P. +* Copyright (c) 2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -27,7 +28,8 @@ RegisterEl0Stack ( IN VOID *Stack ); -RETURN_STATUS ArchVectorConfig( +RETURN_STATUS +ArchVectorConfig ( IN UINTN VectorBaseAddress ) { diff --git a/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c b/ArmPkg/Lib= rary/ArmExceptionLib/Arm/ArmException.c index 36c9f3f92616..40857c7f1faf 100644 --- a/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c +++ b/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c @@ -2,7 +2,7 @@ * Exception handling support specific for ARM * * Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
-* Copyright (c) 2014, ARM Limited. All rights reserved.
+* Copyright (c) 2014 - 2021, Arm Limited. All rights reserved.
* Copyright (c) 2016 HP Development Company, L.P.
* * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -26,7 +26,8 @@ PHYSICAL_ADDRESS gExceptionVectorAlignmentMask =3D= ARM_VECTOR_TABLE_ALIGNME // NOTE: This code assumes vectors are ARM and not Thumb code UINTN gDebuggerNoHandlerValue =3D 0xEAFFFFFE; -RETURN_STATUS ArchVectorConfig( +RETURN_STATUS +ArchVectorConfig ( IN UINTN VectorBaseAddress ) { -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71446): https://edk2.groups.io/g/devel/message/71446 Mute This Topic: https://groups.io/mt/80474627/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71447+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71447+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782461; cv=none; d=zohomail.com; s=zohoarc; b=MHpvMWkU6dX4jeEHV3a16HmQevtaAuAlpJ69c/nLJT7j26njt9zbIYG2gbwioiaBS3OAn0DOV4WAa+geE4aaJYnZZuzTdfSD6o7noy6ypLOE8/ml6KC+TIBxUN6wXPgqkflu/C1LjkqDLHZhv92tWV7F3J6NvOud3Ijx0V4NG0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782461; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=EizT23p4l4EnkOuEUTxN3mk/F32glwqBe28SrURhIGU=; b=Vzf0XNyw5oFDp1v81BxqeYioATBspXwU4YQVx2nWZmp9jEQzTQ9DzBNPn+SSrva3gp+cNFWOQG09ZeSMxUZdxdqFMqYIFqQ2l8jD2mbab/CmcgMbnxR+2FTmhWRaj/K5H2IWo82k4ez50j9ggorJweu4jFlMgiYeFdhd21LWpbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71447+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782461609267.110599692082; Mon, 8 Feb 2021 03:07:41 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jhAOYY1788612xK05Cfnbe6g; Mon, 08 Feb 2021 03:07:41 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.33503.1612782266736887733 for ; Mon, 08 Feb 2021 03:04:26 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D12CED1; Mon, 8 Feb 2021 03:04:26 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 421323F719; Mon, 8 Feb 2021 03:04:25 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe Date: Mon, 8 Feb 2021 11:03:33 +0000 Message-Id: <20210208110346.31211-14-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 31Uy6VQdmSPwgjle71jQHhubx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782461; bh=AT7e+LKkv72Lk5cJSEPQRm8pmgb/q1NfDn4arLzemgw=; h=Cc:Date:From:Reply-To:Subject:To; b=sEUitc8nuVy4DUiGBg7xu72XAEGVfxyEtBdgv7Xz3DI9fdjcqoGH+ZbU/2u281eldTh SxcaqKYi3dYU6fXIK1gTkAOs36zYWnIPpP0bF5CoWPGH9Z4zQw6j8spQ/cDxZcyLBqSyP 5c6PPwZzV9kOFKPlRyUfOtCB0S+0wnPId8k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. This patch replaces a "#if !defined [...]" statement by a "#ifndef [...]" statement, preventing Ecc to throw an error. Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h b/ArmPkg/Dri= vers/MmCommunicationDxe/MmCommunicate.h index fcc346ba7e3e..32753947e1cb 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h @@ -1,13 +1,13 @@ /** @file - Copyright (c) 2016-2018, ARM Limited. All rights reserved. + Copyright (c) 2016-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ -#if !defined _MM_COMMUNICATE_H_ -#define _MM_COMMUNICATE_H_ +#ifndef MM_COMMUNICATE_H_ +#define MM_COMMUNICATE_H_ #define MM_MAJOR_VER_MASK 0xEFFF0000 #define MM_MINOR_VER_MASK 0x0000FFFF @@ -19,4 +19,4 @@ #define MM_CALLER_MAJOR_VER 0x1UL #define MM_CALLER_MINOR_VER 0x0 -#endif /* _MM_COMMUNICATE_H_ */ +#endif /* MM_COMMUNICATE_H_ */ -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71447): https://edk2.groups.io/g/devel/message/71447 Mute This Topic: https://groups.io/mt/80474628/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71449+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71449+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782458; cv=none; d=zohomail.com; s=zohoarc; b=CPyy56mVFqoZE95U4qj+liiigvVxbKPUJVCWlmS1YgSYSXtRwz+Bo9bGGhPdVLj4dGy1HRlTr8ZOC65x2YM37KM2dOPZrgr8E7U4OZ1iHBFhErbHLMZoJ72fa9lsgdi3IU/DW8FKXNNynbf7euDlDPr8HWwgzfpAoTYGndE1HKs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782458; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ozWEDjPk/uNnb+erXW77TTcpRSGZNQ7oW02CZ5/Lcpc=; b=TNo46Pk4xZunFqWVSACpJN+svjoizhcT1rApbBLWlCe6Z1SmnfH/I92/1/oE/CStMKhhrNp9cMsLVI9t3VDEpcWxGbLQUcZC54KrYgaUlveNPI7gdr4I2WPcInZfx3iy5+HQsDM4UoHGvo/cfagbr392g00H57J0CCnpQEJECJ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71449+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782458828587.2711657481242; Mon, 8 Feb 2021 03:07:38 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id pKfTYY1788612x6xNxgRa9zW; Mon, 08 Feb 2021 03:07:38 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.33549.1612782268065330792 for ; Mon, 08 Feb 2021 03:04:28 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC9CE31B; Mon, 8 Feb 2021 03:04:27 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B79E83F719; Mon, 8 Feb 2021 03:04:26 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib Date: Mon, 8 Feb 2021 11:03:34 +0000 Message-Id: <20210208110346.31211-15-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: AcfS3AtTBDExVsZgETmHgnPOx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782458; bh=k68j7L5+RbeprCi7nXRBYf2CeVYuDys+1e9HeRtJBDI=; h=Cc:Date:From:Reply-To:Subject:To; b=HXIDlJy+7w3UHZslPaFl1kKWl4QGFbFNuLn4XBSUrYDJW9rJyJjJZccK4XFr6soPpt0 +TDb8lDBAM6A4nG/sBARlgpZ8krGCC5u6oZi54bOjhNFYaB2TtEzUPntK8Kupxt73g5or /GCbIoEaP+kXUXzaP4kvNMdOivapVAaz+Ok= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Library/ArmSoftFloatLib/platform.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ArmPkg/Library/ArmSoftFloatLib/platform.h b/ArmPkg/Library/Arm= SoftFloatLib/platform.h index 07800a9d5b79..fddf9de04d52 100644 --- a/ArmPkg/Library/ArmSoftFloatLib/platform.h +++ b/ArmPkg/Library/ArmSoftFloatLib/platform.h @@ -1,11 +1,17 @@ /* * Copyright (c) 2019, Linaro Limited + * Copyright (c) 2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent */ +#ifndef ARM_SOFT_FLOAT_LIB_H_ +#define ARM_SOFT_FLOAT_LIB_H_ + #define LITTLEENDIAN 1 #define INLINE static inline #define SOFTFLOAT_BUILTIN_CLZ 1 #define SOFTFLOAT_FAST_INT64 #include "opts-GCC.h" + +#endif // ARM_SOFT_FLOAT_LIB_H_ -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71449): https://edk2.groups.io/g/devel/message/71449 Mute This Topic: https://groups.io/mt/80474630/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71450+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71450+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782326; cv=none; d=zohomail.com; s=zohoarc; b=gTXzTDE94AVMJkojFPoZQsnGeW4Gw9riB/QgXKPIlWXpo1/LY+x9jRR8QQ0HR7yFJe1qas1h7RVnEulUv7KLiR2rmnbiZY9NpvMMjjNmxQZJAQwZpyjiUzphR5hO5RVeU4Ur7cyGc98SUZ3K+Vc2EMMSHRRgGxiTipI9YfMajJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782326; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=i0duIYLt5hUtMnU8D6a00rLVVrT6Uo9fj7E1Z/F40T8=; b=RnwB4rrzY05Ioq3Z/7uq+GcYvsqlyoY7Bj2QHvgZSC9fjhPAQP1r0bixeiOOQcfp4LFMehfgWjg1lIuHhkwsyu2ypqMcKo3rOa7ug4SS5WTejCG2Ig+YShwF3vJ96l6v94vfs3tlz8gxX6dEZOmx2wOH+KF/fbGPIQfhyIIuotI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71450+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782326382522.3059032212143; Mon, 8 Feb 2021 03:05:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id W6dlYY1788612xhTei4BeNiI; Mon, 08 Feb 2021 03:05:25 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.33635.1612782269563616945 for ; Mon, 08 Feb 2021 03:04:29 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3137931B; Mon, 8 Feb 2021 03:04:29 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 263213F719; Mon, 8 Feb 2021 03:04:27 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 15/26] ArmPkg: Rename include guard in ArmGicLib.h Date: Mon, 8 Feb 2021 11:03:35 +0000 Message-Id: <20210208110346.31211-16-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ieweqvyPiLodcItCVDUWw9Htx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782325; bh=xZcKEWB9zGwj1WhOojD7lKO6up5+fhmLcSsh3MPmZg4=; h=Cc:Date:From:Reply-To:Subject:To; b=Y2fBMtkiuPG/KPqutrnTl3/741f7/PhzFEqTMsl7IW/L49IJPPrAY0jeCzlteuazqh+ nRLbOVfgSK8lYlPFbjDH1PMuhUhk+uqa4Cvru+kHGoEohmn904Bqu0jdQ5DNIL0CTpQV3 MmkPIKDoffifNEatF53vK2/de7oqnNwcQ7c= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Edk2 coding standard states that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Include/Library/ArmGicLib.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 7bcfc001115b..b4c320be119b 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -1,13 +1,13 @@ /** @file * -* Copyright (c) 2011-2018, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * **/ -#ifndef __ARMGIC_H -#define __ARMGIC_H +#ifndef ARMGIC_H_ +#define ARMGIC_H_ #include @@ -333,4 +333,4 @@ ArmGicV3SetPriorityMask ( IN UINTN Priority ); -#endif +#endif // ARMGIC_H_ -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71450): https://edk2.groups.io/g/devel/message/71450 Mute This Topic: https://groups.io/mt/80474631/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71451+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71451+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782465; cv=none; d=zohomail.com; s=zohoarc; b=Xbmp85UIJc/yIVOey/2Vj000m2zUG1dAAxbVa6RgNc8MvniJ9a4GoYiHrPFFOs9B1TDu3eXVUt9ZANLNSF4WlOBARBiNPfFhD6nFK0Thx94gJgChgNgbnhD6XOSpwltNWblu9Dned/IgzxFnB/7rp8ZOzkvGxyDvwSxIYE9mHrg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782465; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=PWWuWDJH3wrzvIZe06Jt0dUHRIMBCJnHp+CQeU4iAc4=; b=mrbfKNL8yEAeJUe2TbXFiD27saIo2RzMkk6/6UvbHOIBT4abmWyOX1HOkh361RTuNqwdbjlKvW7RzGqF32a3iv7v98rNpEdxenBwxXSA/4DoEUi0bnJVh664jH7wgzCIQT1v1TFjqYExH/uhRQTOnn6dTAMTe+MSxzOf14FlR7Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71451+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782465020385.46841027286473; Mon, 8 Feb 2021 03:07:45 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id gcHEYY1788612xhuTRtXXlCv; Mon, 08 Feb 2021 03:07:44 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.33625.1612782271149021468 for ; Mon, 08 Feb 2021 03:04:31 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D137C31B; Mon, 8 Feb 2021 03:04:30 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9008C3F719; Mon, 8 Feb 2021 03:04:29 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE Date: Mon, 8 Feb 2021 11:03:36 +0000 Message-Id: <20210208110346.31211-17-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: JLYsh9bF4BjC2DML7MDI9eeRx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782464; bh=tpgHcewuTZBe91dw3Knsr/wTVka6BMOp5pK+gTpfrBQ=; h=Cc:Date:From:Reply-To:Subject:To; b=vbp5QMNfV0MHW1jJnhjL+sIyvM30H5hzOk8qLUSMZFat6VXK5qa8Gx/cv44S8tgY0nW NvMMObnzz6mc33kBwc73vN7wJY2vmsUcxsXF3Blp9iW+aJEvyf3HqRoz1RFpsS2n2lz06 PEjevUGYLMkSmvfv3R0SJ/YdT/PgcioGBCA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 12 ++++++++---- ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 14 ++++++++++---- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers= /ArmScmiDxe/ScmiClockProtocol.c index c66c414385dd..5c06e31bda22 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -255,22 +255,26 @@ ClockDescribeRates ( for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { Rate =3D &DescribeRates->Rates[RateOffset++]; // Non-linear discrete rates. - RateArray[RateIndex++].Rate =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].DiscreteRate.Rate =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } else { for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { // Linear clock rates from minimum to maximum in steps // Minimum clock rate. Rate =3D &DescribeRates->Rates[RateOffset++]; - RateArray[RateIndex].Min =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Min =3D + ConvertTo64Bit (Rate->Low, Rate->High); Rate =3D &DescribeRates->Rates[RateOffset++]; // Maximum clock rate. - RateArray[RateIndex].Max =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Max =3D + ConvertTo64Bit (Rate->Low, Rate->High); Rate =3D &DescribeRates->Rates[RateOffset++]; // Step. - RateArray[RateIndex++].Step =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].ContinuousRate.Step =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } } while (NUM_REMAIN_RATES (DescribeRates->NumRatesFlags) !=3D 0); diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Includ= e/Protocol/ArmScmiClockProtocol.h index b4d970dee3e2..85b5b8d1e764 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -57,12 +57,18 @@ typedef enum { either Rate or Min/Max/Step triplet is valid. */ typedef struct { - union { UINT64 Min; - UINT64 Rate; - }; UINT64 Max; UINT64 Step; +} SCMI_CLOCK_RATE_CONTINUOUS; + +typedef struct { + UINT64 Rate; +} SCMI_CLOCK_RATE_DISCRETE; + +typedef union { + SCMI_CLOCK_RATE_CONTINUOUS ContinuousRate; + SCMI_CLOCK_RATE_DISCRETE DiscreteRate; } SCMI_CLOCK_RATE; #pragma pack() -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71451): https://edk2.groups.io/g/devel/message/71451 Mute This Topic: https://groups.io/mt/80474632/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71452+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71452+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782331; cv=none; d=zohomail.com; s=zohoarc; b=SoI9wJYsysDUKCDrss11iQi4TvgSIlT07J0WBChgDyndxH2IPR6BtfhWUKxrqbQCLbLFarjIP8daBlLUw0H8GU9EDcCYy0CsSmuhL/WMjuXkM9iR76qicnhgoqLjHbaowfA24t8jl/vw7QMF+qLiPsE1zac4P28lP4mDhgvH5Ho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782331; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=nh/FQ8xM/CQXBKIPLMDUGz+d9hb/DB6ZoJrdJCo/LbE=; b=a12JyJN/VbEhHAP/6uy7aY3WZGl1e4iFDZZreRR5N0Eaon710p23T26TmZBc/6xamj3VID4EpEevDqS3o1K1he9OISliyV4fX805DDr/rAsNyIGVle/x5Q1G75l/F4bQllHY3aD4NsPArOsuSXsA7hOLXeC5M/eOMh5tMy/xxm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71452+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782331939843.3466482778531; Mon, 8 Feb 2021 03:05:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Fs07YY1788612xjDxhucjrkD; Mon, 08 Feb 2021 03:05:31 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.33626.1612782272528351199 for ; Mon, 08 Feb 2021 03:04:32 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3100031B; Mon, 8 Feb 2021 03:04:32 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1EAE83F719; Mon, 8 Feb 2021 03:04:30 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM Date: Mon, 8 Feb 2021 11:03:37 +0000 Message-Id: <20210208110346.31211-18-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: PotTc1IZBkdPisYuE4O4UfyZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782331; bh=6LREC/2ftrFs1g1ro3cjhfB+Z9W2BfDNJ/iJ1O0j4hc=; h=Cc:Date:From:Reply-To:Subject:To; b=WV/DJGfAIvEEwDdNQtWwAk8+JmjAHYE5WwBmm/g0NhfzDRJWeUAj4FhZLbzNZ+PRnGG KlDd1CyeTxhPYGj0F53i4E//NV0WNYCDoOjKaI2XIy6HH7K1UUS8XniOMfjXKkbYruVrJ 7H/jaW5rg77spOotZufnftOZVpccmjTqCfk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 ArmPkg/Include/Library/OpteeLib.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Include/Library/OpteeLib.h b/ArmPkg/Include/Library/Opt= eeLib.h index d71636143373..8ceab117d132 100644 --- a/ArmPkg/Include/Library/OpteeLib.h +++ b/ArmPkg/Include/Library/OpteeLib.h @@ -2,6 +2,7 @@ OP-TEE specific header file. Copyright (c) 2018, Linaro Ltd. All rights reserved.
+ Copyright (c) 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -45,12 +46,14 @@ typedef struct { UINT64 C; } OPTEE_MESSAGE_PARAM_VALUE; +typedef union { + OPTEE_MESSAGE_PARAM_MEMORY Memory; + OPTEE_MESSAGE_PARAM_VALUE Value; +} OPTEE_MESSAGE_PARAM_UNION; + typedef struct { UINT64 Attribute; - union { - OPTEE_MESSAGE_PARAM_MEMORY Memory; - OPTEE_MESSAGE_PARAM_VALUE Value; - } Union; + OPTEE_MESSAGE_PARAM_UNION Union; } OPTEE_MESSAGE_PARAM; #define OPTEE_MAX_CALL_PARAMS 4 -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71452): https://edk2.groups.io/g/devel/message/71452 Mute This Topic: https://groups.io/mt/80474633/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 05:23:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71453+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71453+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612782425; cv=none; d=zohomail.com; s=zohoarc; b=CTxQ1msxcNHzqvis8LeVyNix95i5RxZcdhAoOiee3YQ/SNO+Ou2Yygrel2rJraeOmP2z7jSqI82qt8iswDE7PDPZl29U737BvieWZZwOemxhZwGQEDnnimHSiuwB4sgIXsw+eb8D0V8hwRVo6mIo6CvC74/4alxbzkuevnKXjV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612782425; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=xh8cSBg319njL59wmMQwIu6HugkgpB/24jvs12EapoU=; b=mHTIr3urnOW3GCXOZpLS9Z3l5XKX68x5DZQicJA3zdqPujemtxeVmQqqHmNPV30sbSEoJMKY+vQiF/viNwR7K1XOyZjFck9x+/irzFtzH7TAsYMsnK4KnoL2CWjEAyeQZJu7e1K0PiFBtHk5bMJn+yghw1A3RX5jXaedVJqOQr8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71453+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612782425396559.7080433542661; Mon, 8 Feb 2021 03:07:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id gcwXYY1788612xQMBp5xsuXN; Mon, 08 Feb 2021 03:07:05 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.33627.1612782274128530912 for ; Mon, 08 Feb 2021 03:04:34 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC78231B; Mon, 8 Feb 2021 03:04:33 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 74E4B3F719; Mon, 8 Feb 2021 03:04:32 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v2 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib Date: Mon, 8 Feb 2021 11:03:38 +0000 Message-Id: <20210208110346.31211-19-Pierre.Gondois@arm.com> In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com> References: <20210208110346.31211-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: gMyA5iSOTQN4GqAi7RBq2CFzx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612782425; bh=yoO9CV4Sgcf3Q+sUkldOqiEWh4uns/s35osRdpkeb8k=; h=Cc:Date:From:Reply-To:Subject:To; b=D6xJ/lNNkrq7jCpYB3yjos/4WOKpClL7HZRzLjSP/lCTq3U8o15zO0bOeza2ruXhf3+ NQHwbPaZGbnUnPwp7lRnBzHWM7dVNYqR08KSGsqt7SzbY2zkItNp0DGuGFir0+dALZIfw 08H418Dh3n83ZbMaKvLf56YP0lgQyDZrDhg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: 8005: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' 8007: There should be no use of short (single character) variable names Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v2 .../ArmDisassemblerLib/ArmDisassembler.c | 159 +++++++++--------- .../ArmDisassemblerLib/ThumbDisassembler.c | 158 ++++++++--------- 2 files changed, 163 insertions(+), 154 deletions(-) diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/L= ibrary/ArmDisassemblerLib/ArmDisassembler.c index e67e13a50ace..03a9f1fbe2e5 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -71,7 +71,7 @@ CHAR8 *gLdmStack[] =3D { #define SIGN(_U) ((_U) ? "" : "-") -#define WRITE(_W) ((_W) ? "!" : "") +#define WRITE(_Write) ((_Write) ? "!" : "") #define BYTE(_B) ((_B) ? "B":"") #define USER(_B) ((_B) ? "^" : "") @@ -159,23 +159,24 @@ DisassembleArmInstruction ( ) { UINT32 OpCode; - CHAR8 *Type, *Root; - BOOLEAN I, P, U, B, W, L, S, H; + CHAR8 *Type; + CHAR8 *Root; + BOOLEAN Imm, Pre, Up, WriteBack, Write, Load, Sign, Half; UINT32 Rn, Rd, Rm; - UINT32 imode, offset_8, offset_12; + UINT32 IMod, Offset8, Offset12; UINT32 Index; - UINT32 shift_imm, shift; + UINT32 ShiftImm, Shift; OpCode =3D **OpCodePtr; - I =3D (OpCode & BIT25) =3D=3D BIT25; - P =3D (OpCode & BIT24) =3D=3D BIT24; - U =3D (OpCode & BIT23) =3D=3D BIT23; - B =3D (OpCode & BIT22) =3D=3D BIT22; // Also called S - W =3D (OpCode & BIT21) =3D=3D BIT21; - L =3D (OpCode & BIT20) =3D=3D BIT20; - S =3D (OpCode & BIT6) =3D=3D BIT6; - H =3D (OpCode & BIT5) =3D=3D BIT5; + Imm =3D (OpCode & BIT25) =3D=3D BIT25; // I + Pre =3D (OpCode & BIT24) =3D=3D BIT24; // P + Up =3D (OpCode & BIT23) =3D=3D BIT23; // U + WriteBack =3D (OpCode & BIT22) =3D=3D BIT22; // B, also called S + Write =3D (OpCode & BIT21) =3D=3D BIT21; // W + Load =3D (OpCode & BIT20) =3D=3D BIT20; // L + Sign =3D (OpCode & BIT6) =3D=3D BIT6; // S + Half =3D (OpCode & BIT5) =3D=3D BIT5; // H Rn =3D (OpCode >> 16) & 0xf; Rd =3D (OpCode >> 12) & 0xf; Rm =3D (OpCode & 0xf); @@ -189,7 +190,7 @@ DisassembleArmInstruction ( // LDREX, STREX if ((OpCode & 0x0fe000f0) =3D=3D 0x01800090) { - if (L) { + if (Load) { // A4.1.27 LDREX{} , [] AsciiSPrint (Buf, Size, "LDREX%a %a, [%a]", COND (OpCode), gReg[Rd],= gReg[Rn]); } else { @@ -201,89 +202,89 @@ DisassembleArmInstruction ( // LDM/STM if ((OpCode & 0x0e000000) =3D=3D 0x08000000) { - if (L) { + if (Load) { // A4.1.20 LDM{} {!}, // A4.1.21 LDM{} , ^ // A4.1.22 LDM{} {!}, ^ - AsciiSPrint (Buf, Size, "LDM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (W), MRegList (OpCode), USER (B)); + AsciiSPrint (Buf, Size, "LDM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (Write), MRegList (OpCode), USER = (WriteBack)); } else { // A4.1.97 STM{} {!}, // A4.1.98 STM{} , ^ - AsciiSPrint (Buf, Size, "STM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (W), MRegList (OpCode), USER (B)); + AsciiSPrint (Buf, Size, "STM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (Write), MRegList (OpCode), USER = (WriteBack)); } return; } // LDR/STR Address Mode 2 if ( ((OpCode & 0x0c000000) =3D=3D 0x04000000) || ((OpCode & 0xfd70f000= ) =3D=3D 0xf550f000) ) { - offset_12 =3D OpCode & 0xfff; + Offset12 =3D OpCode & 0xfff; if ((OpCode & 0xfd70f000 ) =3D=3D 0xf550f000) { Index =3D AsciiSPrint (Buf, Size, "PLD"); } else { - Index =3D AsciiSPrint (Buf, Size, "%a%a%a%a %a, ", L ? "LDR" : "STR"= , COND (OpCode), BYTE (B), (!(P) && W) ? "T":"", gReg[Rd]); + Index =3D AsciiSPrint (Buf, Size, "%a%a%a%a %a, ", Load ? "LDR" : "S= TR", COND (OpCode), BYTE (WriteBack), (!(Pre) && Write) ? "T":"", gReg[Rd]); } - if (P) { - if (!I) { + if (Pre) { + if (!Imm) { // A5.2.2 [, #+/-] // A5.2.5 [, #+/-] - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a0x%x]%a", gReg[Rn= ], SIGN (U), offset_12, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a0x%x]%a", gReg[Rn= ], SIGN (Up), Offset12, WRITE (Write)); } else if ((OpCode & 0x03000ff0) =3D=3D 0x03000000) { // A5.2.3 [, +/-] // A5.2.6 [, +/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a]%a", gReg[Rn],= SIGN (U), WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a]%a", gReg[Rn],= SIGN (Up), WRITE (Write)); } else { // A5.2.4 [, +/-, LSL #] // A5.2.7 [, +/-, LSL #]! - shift_imm =3D (OpCode >> 7) & 0x1f; - shift =3D (OpCode >> 5) & 0x3; - if (shift =3D=3D 0x0) { + ShiftImm =3D (OpCode >> 7) & 0x1f; + Shift =3D (OpCode >> 5) & 0x3; + if (Shift =3D=3D 0x0) { Type =3D "LSL"; - } else if (shift =3D=3D 0x1) { + } else if (Shift =3D=3D 0x1) { Type =3D "LSR"; - if (shift_imm =3D=3D 0) { - shift_imm =3D 32; + if (ShiftImm =3D=3D 0) { + ShiftImm =3D 32; } - } else if (shift =3D=3D 0x2) { + } else if (Shift =3D=3D 0x2) { Type =3D "ASR"; - } else if (shift_imm =3D=3D 0) { - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, RRX]%a"= , gReg[Rn], SIGN (U), gReg[Rm], WRITE (W)); + } else if (ShiftImm =3D=3D 0) { + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, RRX]%a"= , gReg[Rn], SIGN (Up), gReg[Rm], WRITE (Write)); return; } else { Type =3D "ROR"; } - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, #%d]%a", = gReg[Rn], SIGN (U), gReg[Rm], Type, shift_imm, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, #%d]%a", = gReg[Rn], SIGN (Up), gReg[Rm], Type, ShiftImm, WRITE (Write)); } - } else { // !P - if (!I) { + } else { // !Pre + if (!Imm) { // A5.2.8 [], #+/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a0x%x", gReg[Rn],= SIGN (U), offset_12); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a0x%x", gReg[Rn],= SIGN (Up), Offset12); } else if ((OpCode & 0x03000ff0) =3D=3D 0x03000000) { // A5.2.9 [], +/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], S= IGN (U), gReg[Rm]); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], S= IGN (Up), gReg[Rm]); } else { // A5.2.10 [], +/-, LSL # - shift_imm =3D (OpCode >> 7) & 0x1f; - shift =3D (OpCode >> 5) & 0x3; + ShiftImm =3D (OpCode >> 7) & 0x1f; + Shift =3D (OpCode >> 5) & 0x3; - if (shift =3D=3D 0x0) { + if (Shift =3D=3D 0x0) { Type =3D "LSL"; - } else if (shift =3D=3D 0x1) { + } else if (Shift =3D=3D 0x1) { Type =3D "LSR"; - if (shift_imm =3D=3D 0) { - shift_imm =3D 32; + if (ShiftImm =3D=3D 0) { + ShiftImm =3D 32; } - } else if (shift =3D=3D 0x2) { + } else if (Shift =3D=3D 0x2) { Type =3D "ASR"; - } else if (shift_imm =3D=3D 0) { - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, RRX", = gReg[Rn], SIGN (U), gReg[Rm]); + } else if (ShiftImm =3D=3D 0) { + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, RRX", = gReg[Rn], SIGN (Up), gReg[Rm]); // FIx me return; } else { Type =3D "ROR"; } - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, #%d", gR= eg[Rn], SIGN (U), gReg[Rm], Type, shift_imm); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, #%d", gR= eg[Rn], SIGN (Up), gReg[Rm], Type, ShiftImm); } } return; @@ -292,18 +293,18 @@ DisassembleArmInstruction ( if ((OpCode & 0x0e000000) =3D=3D 0x00000000) { // LDR/STR address mode 3 // LDR|STR{}H|SH|SB|D , - if (L) { - if (!S) { + if (Load) { + if (!Sign) { Root =3D "LDR%aH %a, "; - } else if (!H) { + } else if (!Half) { Root =3D "LDR%aSB %a, "; } else { Root =3D "LDR%aSH %a, "; } } else { - if (!S) { + if (!Sign) { Root =3D "STR%aH %a "; - } else if (!H) { + } else if (!Half) { Root =3D "LDR%aD %a "; } else { Root =3D "STR%aD %a "; @@ -312,28 +313,28 @@ DisassembleArmInstruction ( Index =3D AsciiSPrint (Buf, Size, Root, COND (OpCode), gReg[Rd]); - S =3D (OpCode & BIT6) =3D=3D BIT6; - H =3D (OpCode & BIT5) =3D=3D BIT5; - offset_8 =3D ((OpCode >> 4) | (OpCode * 0xf)) & 0xff; - if (P & !W) { + Sign =3D (OpCode & BIT6) =3D=3D BIT6; + Half =3D (OpCode & BIT5) =3D=3D BIT5; + Offset8 =3D ((OpCode >> 4) | (OpCode * 0xf)) & 0xff; + if (Pre & !Write) { // Immediate offset/index - if (B) { + if (WriteBack) { // A5.3.2 [, #+/-] // A5.3.4 [, #+/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%d]%a", gReg[Rn]= , SIGN (U), offset_8, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%d]%a", gReg[Rn]= , SIGN (Up), Offset8, WRITE (Write)); } else { // A5.3.3 [, +/-] // A5.3.5 [, +/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%]a", gReg[Rn], = SIGN (U), gReg[Rm], WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%]a", gReg[Rn], = SIGN (Up), gReg[Rm], WRITE (Write)); } } else { // Register offset/index - if (B) { + if (WriteBack) { // A5.3.6 [], #+/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%d", gReg[Rn], = SIGN (U), offset_8); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%d", gReg[Rn], = SIGN (Up), Offset8); } else { // A5.3.7 [], +/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], = SIGN (U), gReg[Rm]); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], = SIGN (Up), gReg[Rm]); } } return; @@ -342,19 +343,19 @@ DisassembleArmInstruction ( if ((OpCode & 0x0fb000f0) =3D=3D 0x01000050) { // A4.1.108 SWP SWP{}B , , [] // A4.1.109 SWPB SWP{}B , , [] - AsciiSPrint (Buf, Size, "SWP%a%a %a, %a, [%a]", COND (OpCode), BYTE (B= ), gReg[Rd], gReg[Rm], gReg[Rn]); + AsciiSPrint (Buf, Size, "SWP%a%a %a, %a, [%a]", COND (OpCode), BYTE (W= riteBack), gReg[Rd], gReg[Rm], gReg[Rn]); return; } if ((OpCode & 0xfe5f0f00) =3D=3D 0xf84d0500) { // A4.1.90 SRS SRS #{!} - AsciiSPrint (Buf, Size, "SRS%a #0x%x%a", gLdmStack[(OpCode >> 23) & 3]= , OpCode & 0x1f, WRITE (W)); + AsciiSPrint (Buf, Size, "SRS%a #0x%x%a", gLdmStack[(OpCode >> 23) & 3]= , OpCode & 0x1f, WRITE (Write)); return; } if ((OpCode & 0xfe500f00) =3D=3D 0xf8100500) { // A4.1.59 RFE {!} - AsciiSPrint (Buf, Size, "RFE%a %a", gLdmStack[(OpCode >> 23) & 3], gRe= g[Rn], WRITE (W)); + AsciiSPrint (Buf, Size, "RFE%a %a", gLdmStack[(OpCode >> 23) & 3], gRe= g[Rn], WRITE (Write)); return; } @@ -369,9 +370,9 @@ DisassembleArmInstruction ( if (((OpCode >> 6) & 0x7) =3D=3D 0) { AsciiSPrint (Buf, Size, "CPS #0x%x", (OpCode & 0x2f)); } else { - imode =3D (OpCode >> 18) & 0x3; + IMod =3D (OpCode >> 18) & 0x3; Index =3D AsciiSPrint (Buf, Size, "CPS%a %a%a%a", - (imode =3D=3D 3) ? "ID":"IE", + (IMod =3D=3D 3) ? "ID":"IE", ((OpCode & BIT8) !=3D 0) ? "A":"", ((OpCode & BIT7) !=3D 0) ? "I":"", ((OpCode & BIT6) !=3D 0) ? "F":""); @@ -390,19 +391,19 @@ DisassembleArmInstruction ( if ((OpCode & 0x0fb00000) =3D=3D 0x01000000) { // A4.1.38 MRS{} , CPSR MRS{} , SPSR - AsciiSPrint (Buf, Size, "MRS%a %a, %a", COND (OpCode), gReg[Rd], B ? "= SPSR" : "CPSR"); + AsciiSPrint (Buf, Size, "MRS%a %a, %a", COND (OpCode), gReg[Rd], Write= Back ? "SPSR" : "CPSR"); return; } if ((OpCode & 0x0db00000) =3D=3D 0x01200000) { // A4.1.38 MSR{} CPSR_, # MSR{} CPSR_, - if (I) { + if (Imm) { // MSR{} CPSR_, # - AsciiSPrint (Buf, Size, "MRS%a %a_%a, #0x%x", COND (OpCode), B ? "S= PSR" : "CPSR", FieldMask ((OpCode >> 16) & 0xf), RotateRight (OpCode & 0xf,= ((OpCode >> 8) & 0xf) *2)); + AsciiSPrint (Buf, Size, "MRS%a %a_%a, #0x%x", COND (OpCode), WriteB= ack ? "SPSR" : "CPSR", FieldMask ((OpCode >> 16) & 0xf), RotateRight (OpCod= e & 0xf, ((OpCode >> 8) & 0xf) *2)); } else { // MSR{} CPSR_, - AsciiSPrint (Buf, Size, "MRS%a %a_%a, %a", COND (OpCode), B ? "SPSR"= : "CPSR", gReg[Rd]); + AsciiSPrint (Buf, Size, "MRS%a %a_%a, %a", COND (OpCode), WriteBack = ? "SPSR" : "CPSR", gReg[Rd]); } return; } @@ -416,35 +417,35 @@ DisassembleArmInstruction ( if ((OpCode & 0x0e000000) =3D=3D 0x0c000000) { // A4.1.19 LDC and A4.1.96 SDC if ((OpCode & 0xf0000000) =3D=3D 0xf0000000) { - Index =3D AsciiSPrint (Buf, Size, "%a2 0x%x, CR%d, ", L ? "LDC":"SDC= ", (OpCode >> 8) & 0xf, Rd); + Index =3D AsciiSPrint (Buf, Size, "%a2 0x%x, CR%d, ", Load ? "LDC":"= SDC", (OpCode >> 8) & 0xf, Rd); } else { - Index =3D AsciiSPrint (Buf, Size, "%a%a 0x%x, CR%d, ", L ? "LDC":"S= DC", COND (OpCode), (OpCode >> 8) & 0xf, Rd); + Index =3D AsciiSPrint (Buf, Size, "%a%a 0x%x, CR%d, ", Load ? "LDC"= :"SDC", COND (OpCode), (OpCode >> 8) & 0xf, Rd); } - if (!P) { - if (!W) { + if (!Pre) { + if (!Write) { // A5.5.5.5 [],