[edk2-devel] [PATCH v2 00/26] Fix Ecc reported errors in ArmPkg

PierreGondois posted 26 patches 3 years, 1 month ago
Failed in applying to current master (apply log)
There is a newer version of this series
ArmPkg/ArmPkg.dsc                             |   6 +-
ArmPkg/Drivers/ArmGic/ArmGicSecLib.c          |  58 -------
ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf      |   9 +-
.../ArmScmiPerformanceProtocolPrivate.h       |   4 +-
ArmPkg/Drivers/ArmScmiDxe/Scmi.c              |  10 +-
ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c  |  24 +--
ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c |  44 ++---
ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c           |  10 +-
.../ArmScmiDxe/ScmiPerformanceProtocol.c      |  30 ++--
ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h       |  48 +++---
ArmPkg/Drivers/CpuDxe/CpuMpCore.c             |   4 +-
.../GenericWatchdogDxe/GenericWatchdogDxe.inf |   3 +-
.../MmCommunicationDxe/MmCommunicate.h        |   8 +-
.../MmCommunicationDxe/MmCommunication.inf    |   3 +-
ArmPkg/Include/Chipset/AArch64.h              |  12 +-
ArmPkg/Include/Chipset/AArch64Mmu.h           |   4 +-
ArmPkg/Include/Chipset/ArmCortexA5x.h         |   8 +-
ArmPkg/Include/Chipset/ArmV7.h                |   4 +-
ArmPkg/Include/Library/ArmGicLib.h            |   8 +-
ArmPkg/Include/Library/OpteeLib.h             |  11 +-
ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h |  10 +-
.../Include/Protocol/ArmScmiClock2Protocol.h  |   6 +-
.../Include/Protocol/ArmScmiClockProtocol.h   |  32 ++--
.../Protocol/ArmScmiPerformanceProtocol.h     |  14 +-
.../Library/ArmArchTimerLib/ArmArchTimerLib.c |  12 +-
.../ArmDisassemblerLib/ArmDisassembler.c      | 159 +++++++++---------
.../ArmDisassemblerLib/ThumbDisassembler.c    | 158 ++++++++---------
.../AArch64/AArch64Exception.c                |   4 +-
.../AArch64/ExceptionSupport.S                |  10 +-
.../ArmExceptionLib/Arm/ArmException.c        |   5 +-
ArmPkg/Library/ArmSoftFloatLib/platform.h     |   6 +
ArmPkg/Library/SemihostLib/SemihostLib.c      |  26 +--
ArmPkg/Library/SemihostLib/SemihostLib.inf    |   3 +-
ArmPkg/Library/SemihostLib/SemihostPrivate.h  |  80 ++++-----
.../ArmMmuStandaloneMmLib.inf                 |   4 +-
ArmPlatformPkg/PrePeiCore/AArch64/Exception.S |  10 +-
36 files changed, 416 insertions(+), 431 deletions(-)
delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c
[edk2-devel] [PATCH v2 00/26] Fix Ecc reported errors in ArmPkg
Posted by PierreGondois 3 years, 1 month ago
From: Pierre Gondois <Pierre.Gondois@arm.com>

The Ecc tools available in the BaseTools package checks for
good practice coding standards. Some errors reported while
running Ecc on the ArmPkg require modifications.

The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2

v2:
For ArmPkg: Fix Ecc error 8001 in Chipset
 - Only use one trailing underscore for the
   ARM_CORTEX_A5x_H__ include guard. [Sami]
 - 2 patches had the same name and fixed the same
   Ecc error in V1. They are merged in V2. [Pierre]

Pierre Gondois (26):
  ArmPkg: Fix Ecc error 8001 in Chipset
  ArmPkg: Fix Ecc error 8001 in SemihostLib
  ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib
  ArmPkg: Fix Ecc error 9005 in CpuDxe
  ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc
  ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib
  ArmPkg: Fix Ecc error 10014 in ArmScmiDxe
  ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe
  ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe
  ArmPkg: Fix Ecc error 10014 in SemihostLib
  ArmPkg: Remove ArmGic/ArmGicSecLib.c
  ArmPkg: Fix Ecc error 5003 in ArmExceptionLib
  ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe
  ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib
  ArmPkg: Rename include guard in ArmGicLib.h
  ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE
  ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM
  ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib
  ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE
  ArmPkg: Fix Ecc error 8005 for SCMI_STATUS
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK
  ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE

 ArmPkg/ArmPkg.dsc                             |   6 +-
 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c          |  58 -------
 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf      |   9 +-
 .../ArmScmiPerformanceProtocolPrivate.h       |   4 +-
 ArmPkg/Drivers/ArmScmiDxe/Scmi.c              |  10 +-
 ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c  |  24 +--
 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c |  44 ++---
 ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c           |  10 +-
 .../ArmScmiDxe/ScmiPerformanceProtocol.c      |  30 ++--
 ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h       |  48 +++---
 ArmPkg/Drivers/CpuDxe/CpuMpCore.c             |   4 +-
 .../GenericWatchdogDxe/GenericWatchdogDxe.inf |   3 +-
 .../MmCommunicationDxe/MmCommunicate.h        |   8 +-
 .../MmCommunicationDxe/MmCommunication.inf    |   3 +-
 ArmPkg/Include/Chipset/AArch64.h              |  12 +-
 ArmPkg/Include/Chipset/AArch64Mmu.h           |   4 +-
 ArmPkg/Include/Chipset/ArmCortexA5x.h         |   8 +-
 ArmPkg/Include/Chipset/ArmV7.h                |   4 +-
 ArmPkg/Include/Library/ArmGicLib.h            |   8 +-
 ArmPkg/Include/Library/OpteeLib.h             |  11 +-
 ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h |  10 +-
 .../Include/Protocol/ArmScmiClock2Protocol.h  |   6 +-
 .../Include/Protocol/ArmScmiClockProtocol.h   |  32 ++--
 .../Protocol/ArmScmiPerformanceProtocol.h     |  14 +-
 .../Library/ArmArchTimerLib/ArmArchTimerLib.c |  12 +-
 .../ArmDisassemblerLib/ArmDisassembler.c      | 159 +++++++++---------
 .../ArmDisassemblerLib/ThumbDisassembler.c    | 158 ++++++++---------
 .../AArch64/AArch64Exception.c                |   4 +-
 .../AArch64/ExceptionSupport.S                |  10 +-
 .../ArmExceptionLib/Arm/ArmException.c        |   5 +-
 ArmPkg/Library/ArmSoftFloatLib/platform.h     |   6 +
 ArmPkg/Library/SemihostLib/SemihostLib.c      |  26 +--
 ArmPkg/Library/SemihostLib/SemihostLib.inf    |   3 +-
 ArmPkg/Library/SemihostLib/SemihostPrivate.h  |  80 ++++-----
 .../ArmMmuStandaloneMmLib.inf                 |   4 +-
 ArmPlatformPkg/PrePeiCore/AArch64/Exception.S |  10 +-
 36 files changed, 416 insertions(+), 431 deletions(-)
 delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c

--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71439): https://edk2.groups.io/g/devel/message/71439
Mute This Topic: https://groups.io/mt/80474619/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-