From nobody Tue Feb 10 05:44:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71034+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71034+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1612220033; cv=none; d=zohomail.com; s=zohoarc; b=CSsGm1gXNjFgeqh/PiggGc1B6P2de1ReiO7EB2IgvxNKpQ6aNB9ynKVE8QW8/xGf78/bCfuGnNj3qg+PisnBVZ/9b4I9n36mFAU/ta71PLK+5ILUpS7nXKaymjHKldb7+gzdVudA98bIfa1JIR71BYxkb0NgYgD0PGemfSavFtY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612220033; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=T7js8MQ2+OZH4g6lWUkydLOkpATqFREd7hKTtqDEZEQ=; b=dU4KphK4u/yA+cJgJ+4pvIcJ793O7wh3EvpjwN8le8W7/A+YJ7Af2kXh03Wb/YHV49Z2b2OlhcgQCnJovibEXikWzjSnCOuw4VU1hxr8swRUDV8RB5tF6e1u5vGdou/B6MNJwCXp8pQ1N/Ve6UdyEASBnygKbxYtO5Wi+fRW1/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71034+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1612220033742388.9053244979483; Mon, 1 Feb 2021 14:53:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TR2kYY1788612x8v7nfLZlsf; Mon, 01 Feb 2021 14:53:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.43794.1612220027949705724 for ; Mon, 01 Feb 2021 14:53:48 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DAE91509; Mon, 1 Feb 2021 14:53:47 -0800 (PST) X-Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8602D3F718; Mon, 1 Feb 2021 14:53:47 -0800 (PST) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: pete@akeo.ie, awarkentin@vmware.com, samer.el-haj-mahmoud@arm.com, leif@nuviainc.com, ardb+tianocore@kernel.org, Jeremy Linton Subject: [edk2-devel] [PATCH v2 1/4] Platform/RaspberryPi: Add Negative table check Date: Mon, 1 Feb 2021 16:53:40 -0600 Message-Id: <20210201225343.2001835-2-jeremy.linton@arm.com> In-Reply-To: <20210201225343.2001835-1-jeremy.linton@arm.com> References: <20210201225343.2001835-1-jeremy.linton@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com X-Gm-Message-State: bj0sfq4g4awqIIw49vUX7viax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1612220033; bh=pMWcylFoVLrpekdsL7Cr81RhbqrOuNkVBkeSHqQIVKg=; h=Cc:Date:From:Reply-To:Subject:To; b=AfReqkCUXUBXnU3WIJWo53rv3I7gCDiHFr9bJJR+3Zy2GDzQv55Q4vlcIHdRdwpu+2G HN1D/m0ib2PaFP50ft/b9kPaunGEhTkSnN6xWy80EzuZdz2hY0aCIZlCXHggLoL6oul6S qjC0eE1xIYxOIQT1xSF2p1mWgIW9W5GJIYU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Turns out its helpful to have a !PcdToken flag that enables a DSDT/SSDT. That simplifies both the emmc2 SSDT (it only installs when !SdIsArasan) and later for the XHCI/PCIe switch where we want to install one of two tables depending on whether a single Pcd is set. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin Reviewed-by: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 9581bc41e1..ca7533cbee 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -616,6 +616,7 @@ typedef struct { typedef struct { UINT64 OemTableId; UINTN PcdToken; + UINTN PcdTokenNot; CONST AML_NAME_OP_REPLACE *SdtNameOpReplace; } NAMESPACE_TABLES; =20 @@ -713,6 +714,9 @@ VerifyUpdateTable ( if (SdtTable->PcdToken && !LibPcdGet32 (SdtTable->PcdToken)) { Result =3D FALSE; } + if (SdtTable->PcdTokenNot && LibPcdGet32 (SdtTable->PcdTokenNot)) { + Result =3D FALSE; + } if (Result && SdtTable->SdtNameOpReplace) { UpdateSdtNameOps (AcpiHeader, SdtTable->SdtNameOpReplace); } @@ -730,11 +734,13 @@ STATIC CONST NAMESPACE_TABLES SdtTables[] =3D { { SIGNATURE_64 ('R', 'P', 'I', 'T', 'H', 'F', 'A', 'N'), PcdToken(PcdFanOnGpio), + 0, SsdtNameOpReplace }, { SIGNATURE_64 ('R', 'P', 'I', 0, 0, 0, 0, 0), 0, + 0, NULL }, { } --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71034): https://edk2.groups.io/g/devel/message/71034 Mute This Topic: https://groups.io/mt/80300531/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-