From nobody Thu Nov 14 17:07:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70869+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70869+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=oracle.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611882008349600.0522122241207; Thu, 28 Jan 2021 17:00:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jUefYY1788612xelItrOrCGu; Thu, 28 Jan 2021 17:00:07 -0800 X-Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by mx.groups.io with SMTP id smtpd.web11.3118.1611882007258327765 for ; Thu, 28 Jan 2021 17:00:07 -0800 X-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10T0eiEb064360; Fri, 29 Jan 2021 01:00:03 GMT X-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 368brkxs2x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Jan 2021 01:00:03 +0000 X-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10T0eGVE081743; Fri, 29 Jan 2021 01:00:02 GMT X-Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172]) by userp3030.oracle.com with ESMTP id 368wr13e5c-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Jan 2021 01:00:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jzZy+CLqVnw8wc2I359COi06FtUXZZ+e3yAbI5IVlNCwNFp/czT+KRO3IuG7il04ehavPtOTWbH5FoKw7535q8QNW+Ir0JBLlpYsfIlxShPwSqpL7VNl7eydgDMZ2yKVaPpRhRrK3SIHZdT4tSBT3SQ42DZjBrhicdSwLYCZm3mJsGFpQadHjDKCNIeAt4AVlS1BHgMqD9C2owyI56bq4R/krXqP7delX7c4EPM6hDlbQg9442P53uo7rCH6zfQAoC1fEwWyQZKU+WVpVH0qgIgCGHWOpeJWwt0CmxuMTSYjcv6bf+sdJjbbN7uMns8WwdWnf7hDBOFSeoYP1ppGoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hufg5L/JF8z4aY4/F926/QJQgWmg4i5ZA1TQCxd4MIg=; b=TkNqpLYFpnTRmVUQ62zSCo2rkIZ8dyCvDN2qzX7pff/CFQEHZ8Urz3Rnqia6CbHkND4M0LoIAo5mZsV6/amOSZga7VUnQR4/hPwrHcXBbyn99BjIu4W34o1ButzBg/iRx65YakGMXPjBL2rlBNyHetLRYOyGztW6GfoQhkqp4zSDbvQksXl6u06e9O5L0ioOe4Vva39i2PDzlu//Adbgc6pU+47oThPkv2wUqOhxAFks/bY+eZPObnfFWozdT6lFrTrQUjZS4njwHnXQsPq73ZuQN9hEMs485KBT/Waqto2Ncz3wdG5PXorpFRIE5zRmT1POf+rmKVVGTalwMQwJPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none X-Received: from CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) by CY4PR1001MB2246.namprd10.prod.outlook.com (2603:10b6:910:41::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.16; Fri, 29 Jan 2021 00:59:59 +0000 X-Received: from CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6]) by CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6%6]) with mapi id 15.20.3805.019; Fri, 29 Jan 2021 00:59:59 +0000 From: "Ankur Arora" To: devel@edk2.groups.io Cc: lersek@redhat.com, imammedo@redhat.com, boris.ostrovsky@oracle.com, Ankur Arora , Jordan Justen , Ard Biesheuvel , Aaron Young Subject: [edk2-devel] [PATCH v6 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic Date: Thu, 28 Jan 2021 16:59:42 -0800 Message-Id: <20210129005950.467638-2-ankur.a.arora@oracle.com> In-Reply-To: <20210129005950.467638-1-ankur.a.arora@oracle.com> References: <20210129005950.467638-1-ankur.a.arora@oracle.com> X-Originating-IP: [148.87.23.8] X-ClientProxiedBy: MWHPR1401CA0022.namprd14.prod.outlook.com (2603:10b6:301:4b::32) To CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from prion.us.oracle.com (148.87.23.8) by MWHPR1401CA0022.namprd14.prod.outlook.com (2603:10b6:301:4b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17 via Frontend Transport; Fri, 29 Jan 2021 00:59:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5a112c4-8594-4afe-b320-08d8c3f13346 X-MS-TrafficTypeDiagnostic: CY4PR1001MB2246: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 3EqZRgG3dTTcUGiZ2SvPXMW4H3o2g9vzDV4cfwmbOnAVf+TB6CBIb0yipmHlOXfo6k/66Luu+pfcAxTRSw16A9f0YDfgPDugWrGNr7sQX+kljE47LjB+qLduZ7ACWZSNGjL51vGCfKFgY8J3HVylsKhxSMoGADfIBtQWesHXOlG3iFI/RkTfiIcQB8Psl/Nj7NG4QQhneYIgkmfQvdCSXa0fjKbXsYbkdolGu9B/DoLdm2jTGDJCKHv3aE4VxWTAmKrzak0GgtrVL0hOTjLtVRmWelQUtqze1nDgdA+LZilffxK5kq2DcQDzPPfhSQZYv1Xtns7EgtRA5jOdYY/5vaVUQZEuGFWBSuYGxtFczEWzVoVH03LLw4tU2w36v4ilFdyDlTwhfYmxGkWvqTxouniDQLa+aoDAJj0MkJ6aVXAoDOgTJgeIoBu0ZPhkgaorfRpF5hy9pEtvC31lNJTqeOPDbOiMaOMcVeM5f6dpbGvbF/ccFTeJUkFpoOR68SK78xWwmHLh8QyyAhBf4aD7lYt0G+djwRFP5ybY+K6vxgGS5AKNyBQDIgHuLuxDeVfwT+1Vdqqh11+Kr8xlFdhVBBVtQSa1JYeIGNHa1DgjtQA= X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?h1TAsnOGSiM42u1pyzpzccfPW7WrrJHldyUOAGDSB+t0+ydJz8BqqHtbqTw2?= =?us-ascii?Q?fQR9ylj0P953s21AsuW5G/zLNxudfgrQd9v2s3gz8jVwdMc0bPprGaLb0LZ8?= =?us-ascii?Q?uml5sS1boUgmbEoteTMZzCd1EGlCxq3XNBTDpeMIZiyXr55AZOcXiJasAr6e?= =?us-ascii?Q?Cb5uYXbVvCJnwEvp+Xd13Grd0Ud5jzJLbNcwd1m0Di1Qh6/XJXtxm3Ym6ACb?= =?us-ascii?Q?B3/vBnr7vTvLiEKeC/ec/1UgaL5qKtvPTSaCFvm5KsNYFROD4wn2a1y/E8gp?= =?us-ascii?Q?6twnA5y4zd/aMw/xT0eO8h6DatKDXtEaiFx/eV4QSzFSdxoodJqepy9kRZpw?= =?us-ascii?Q?s6plgMcnSK722khyIuXsIDpBiy9GWfWOLPFAAI9NhXY6WIW/qNX+atNvylRN?= =?us-ascii?Q?0f1grPms9WR7PldQx/DIbkeNUYqERSC89+0fnCdQ7QEAz6w794bolRvH3sHc?= =?us-ascii?Q?nRvxrIM8GDLa2s4cfymUidAx3ZBMI30wiiA/QKwvmW6YJw5pkNPEnOz/TVu9?= =?us-ascii?Q?EcbzMH5tcf0EG75degdtS1y1Vsd3XdtUZGMRYZ8O6odwqrLVyrTjEB45a08B?= =?us-ascii?Q?QQhE5zJdVrSXLK8QM85TFLX04TT93ACKWekRdilyY2UsejcYnA6ExXvwRJ0E?= =?us-ascii?Q?Kxj/5Jc2sy7+HHuHrIEjmAXnP/CDQaGyBG7TVgDnaHdBGAQY0e1wGnTtp/dn?= =?us-ascii?Q?ShBMOrZgL7pefmml4zAhO1aP7QoF8kwv78+DCsdN4IBqBFVtAaprcduyW+RW?= =?us-ascii?Q?YMPIB+gH8QwehuSTbT/iGdu/lm27co8evwAGJzdHdDy/r1jJ11vvk3QFs9rN?= =?us-ascii?Q?wf8V8kB4Umm4gh3LXxYttqmfQeLotj8NOvKy0NNJCR06uG+y8DmXBDL5AfDL?= =?us-ascii?Q?5hvIXLpiZEvER26k6u6GIokOQa5JMQZ+wTeJMKerjsS3lZWM0HTB7D7fIjkV?= =?us-ascii?Q?05FyuX9cqq65S6HJweU67GpVSps8nffvrDAwTLZbv6wLq5vX7ztOvdW0n4eb?= =?us-ascii?Q?K61pEkCTTQQ94jdx6Y6ZJT749yv39YpnoUq+TpVOTKwTl4fda7MShbmAA9iG?= =?us-ascii?Q?CvlCqXJ6?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5a112c4-8594-4afe-b320-08d8c3f13346 X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1718.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2021 00:59:59.0090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QnWupg6F2dW/u36jvwcc6cwKQmt2mIn4K+qX8NzYQEG8CJghwfsPqeG0yJQpWVPNBn8h3p66QLYvwppbOyALHcHrFvD2Ns6Oe+eoDJ0Txl0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2246 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ankur.a.arora@oracle.com X-Gm-Message-State: ZQHoMAGDe8ohCCA1fPZsSFjLx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611882007; bh=Faxq+3Ot7ppI1Mrw693uaA7okS0ok9efLmMX0Vle8D4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Z9ZwFeZA3E3y2exP1+gBg0NelKSYuRKjXs76nc5YdLhFhvlY1R/dNJWNCN3T4cSgpvg AIYRsUxUIH+kdY7NWMLrzwCX768yicgvQEtu77T9N8RbQ7NFZFjNhJ+wWSKs1WkHYlZve xMh7prmfXW6WBsAclBJYZqYUg1aX9hxzfu0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into ProcessHotAddedCpus(). This is in preparation for supporting CPU hot-unplug. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Igor Mammedov Cc: Boris Ostrovsky Cc: Aaron Young Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3132 Signed-off-by: Ankur Arora Reviewed-by: Laszlo Ersek --- Notes: > + if (EFI_ERROR(Status)) { > + goto Fatal; > } =20 (13) Without having seen the rest of the patches, I think this error check should be nested under the same (PluggedCount > 0) condition; in other words, I think it only makes sense to check Status after we actually call ProcessHotAddedCpus(). =20 Addresses all comments from v5, except for this one, since the (lack) of nesting makes more sense after patch 4, "OvmfPkg/CpuHotplugSmm: introdu= ce UnplugCpus()". OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 214 ++++++++++++++++++++++-----------= ---- 1 file changed, 129 insertions(+), 85 deletions(-) diff --git a/OvmfPkg/CpuHotplugSmm/CpuHotplug.c b/OvmfPkg/CpuHotplugSmm/Cpu= Hotplug.c index cfe698ed2b5e..05b1f8cb63a6 100644 --- a/OvmfPkg/CpuHotplugSmm/CpuHotplug.c +++ b/OvmfPkg/CpuHotplugSmm/CpuHotplug.c @@ -62,6 +62,130 @@ STATIC UINT32 mPostSmmPenAddress; // STATIC EFI_HANDLE mDispatchHandle; =20 +/** + Process CPUs that have been hot-added, per QemuCpuhpCollectApicIds(). + + For each such CPU, relocate the SMBASE, and report the CPU to PiSmmCpuDx= eSmm + via EFI_SMM_CPU_SERVICE_PROTOCOL. If the supposedly hot-added CPU is alr= eady + known, skip it silently. + + @param[in] PluggedApicIds The APIC IDs of the CPUs that have been + hot-plugged. + + @param[in] PluggedCount The number of filled-in APIC IDs in + PluggedApicIds. + + @retval EFI_SUCCESS CPUs corresponding to all the APIC IDs are + populated. + + @retval EFI_OUT_OF_RESOURCES Out of APIC ID space in "mCpuHotPlugData". + + @return Error codes propagated from SmbaseRelocate() + and mMmCpuService->AddProcessor(). + +**/ +STATIC +EFI_STATUS +ProcessHotAddedCpus ( + IN APIC_ID *PluggedApicIds, + IN UINT32 PluggedCount + ) +{ + EFI_STATUS Status; + UINT32 PluggedIdx; + UINT32 NewSlot; + + // + // The Post-SMM Pen need not be reinstalled multiple times within a sing= le + // root MMI handling. Even reinstalling once per root MMI is only pruden= ce; + // in theory installing the pen in the driver's entry point function sho= uld + // suffice. + // + SmbaseReinstallPostSmmPen (mPostSmmPenAddress); + + PluggedIdx =3D 0; + NewSlot =3D 0; + while (PluggedIdx < PluggedCount) { + APIC_ID NewApicId; + UINT32 CheckSlot; + UINTN NewProcessorNumberByProtocol; + + NewApicId =3D PluggedApicIds[PluggedIdx]; + + // + // Check if the supposedly hot-added CPU is already known to us. + // + for (CheckSlot =3D 0; + CheckSlot < mCpuHotPlugData->ArrayLength; + CheckSlot++) { + if (mCpuHotPlugData->ApicId[CheckSlot] =3D=3D NewApicId) { + break; + } + } + if (CheckSlot < mCpuHotPlugData->ArrayLength) { + DEBUG ((DEBUG_VERBOSE, "%a: APIC ID " FMT_APIC_ID " was hot-plugged " + "before; ignoring it\n", __FUNCTION__, NewApicId)); + PluggedIdx++; + continue; + } + + // + // Find the first empty slot in CPU_HOT_PLUG_DATA. + // + while (NewSlot < mCpuHotPlugData->ArrayLength && + mCpuHotPlugData->ApicId[NewSlot] !=3D MAX_UINT64) { + NewSlot++; + } + if (NewSlot =3D=3D mCpuHotPlugData->ArrayLength) { + DEBUG ((DEBUG_ERROR, "%a: no room for APIC ID " FMT_APIC_ID "\n", + __FUNCTION__, NewApicId)); + return EFI_OUT_OF_RESOURCES; + } + + // + // Store the APIC ID of the new processor to the slot. + // + mCpuHotPlugData->ApicId[NewSlot] =3D NewApicId; + + // + // Relocate the SMBASE of the new CPU. + // + Status =3D SmbaseRelocate (NewApicId, mCpuHotPlugData->SmBase[NewSlot], + mPostSmmPenAddress); + if (EFI_ERROR (Status)) { + goto RevokeNewSlot; + } + + // + // Add the new CPU with EFI_SMM_CPU_SERVICE_PROTOCOL. + // + Status =3D mMmCpuService->AddProcessor (mMmCpuService, NewApicId, + &NewProcessorNumberByProtocol); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a: AddProcessor(" FMT_APIC_ID "): %r\n", + __FUNCTION__, NewApicId, Status)); + goto RevokeNewSlot; + } + + DEBUG ((DEBUG_INFO, "%a: hot-added APIC ID " FMT_APIC_ID ", SMBASE 0x%= Lx, " + "EFI_SMM_CPU_SERVICE_PROTOCOL assigned number %Lu\n", __FUNCTION__, + NewApicId, (UINT64)mCpuHotPlugData->SmBase[NewSlot], + (UINT64)NewProcessorNumberByProtocol)); + + NewSlot++; + PluggedIdx++; + } + + // + // We've processed this batch of hot-added CPUs. + // + return EFI_SUCCESS; + +RevokeNewSlot: + mCpuHotPlugData->ApicId[NewSlot] =3D MAX_UINT64; + + return Status; +} =20 /** CPU Hotplug MMI handler function. @@ -122,8 +246,6 @@ CpuHotplugMmi ( UINT8 ApmControl; UINT32 PluggedCount; UINT32 ToUnplugCount; - UINT32 PluggedIdx; - UINT32 NewSlot; =20 // // Assert that we are entering this function due to our root MMI handler @@ -179,87 +301,12 @@ CpuHotplugMmi ( goto Fatal; } =20 - // - // Process hot-added CPUs. - // - // The Post-SMM Pen need not be reinstalled multiple times within a sing= le - // root MMI handling. Even reinstalling once per root MMI is only pruden= ce; - // in theory installing the pen in the driver's entry point function sho= uld - // suffice. - // - SmbaseReinstallPostSmmPen (mPostSmmPenAddress); + if (PluggedCount > 0) { + Status =3D ProcessHotAddedCpus (mPluggedApicIds, PluggedCount); + } =20 - PluggedIdx =3D 0; - NewSlot =3D 0; - while (PluggedIdx < PluggedCount) { - APIC_ID NewApicId; - UINT32 CheckSlot; - UINTN NewProcessorNumberByProtocol; - - NewApicId =3D mPluggedApicIds[PluggedIdx]; - - // - // Check if the supposedly hot-added CPU is already known to us. - // - for (CheckSlot =3D 0; - CheckSlot < mCpuHotPlugData->ArrayLength; - CheckSlot++) { - if (mCpuHotPlugData->ApicId[CheckSlot] =3D=3D NewApicId) { - break; - } - } - if (CheckSlot < mCpuHotPlugData->ArrayLength) { - DEBUG ((DEBUG_VERBOSE, "%a: APIC ID " FMT_APIC_ID " was hot-plugged " - "before; ignoring it\n", __FUNCTION__, NewApicId)); - PluggedIdx++; - continue; - } - - // - // Find the first empty slot in CPU_HOT_PLUG_DATA. - // - while (NewSlot < mCpuHotPlugData->ArrayLength && - mCpuHotPlugData->ApicId[NewSlot] !=3D MAX_UINT64) { - NewSlot++; - } - if (NewSlot =3D=3D mCpuHotPlugData->ArrayLength) { - DEBUG ((DEBUG_ERROR, "%a: no room for APIC ID " FMT_APIC_ID "\n", - __FUNCTION__, NewApicId)); - goto Fatal; - } - - // - // Store the APIC ID of the new processor to the slot. - // - mCpuHotPlugData->ApicId[NewSlot] =3D NewApicId; - - // - // Relocate the SMBASE of the new CPU. - // - Status =3D SmbaseRelocate (NewApicId, mCpuHotPlugData->SmBase[NewSlot], - mPostSmmPenAddress); - if (EFI_ERROR (Status)) { - goto RevokeNewSlot; - } - - // - // Add the new CPU with EFI_SMM_CPU_SERVICE_PROTOCOL. - // - Status =3D mMmCpuService->AddProcessor (mMmCpuService, NewApicId, - &NewProcessorNumberByProtocol); - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: AddProcessor(" FMT_APIC_ID "): %r\n", - __FUNCTION__, NewApicId, Status)); - goto RevokeNewSlot; - } - - DEBUG ((DEBUG_INFO, "%a: hot-added APIC ID " FMT_APIC_ID ", SMBASE 0x%= Lx, " - "EFI_SMM_CPU_SERVICE_PROTOCOL assigned number %Lu\n", __FUNCTION__, - NewApicId, (UINT64)mCpuHotPlugData->SmBase[NewSlot], - (UINT64)NewProcessorNumberByProtocol)); - - NewSlot++; - PluggedIdx++; + if (EFI_ERROR(Status)) { + goto Fatal; } =20 // @@ -267,9 +314,6 @@ CpuHotplugMmi ( // return EFI_SUCCESS; =20 -RevokeNewSlot: - mCpuHotPlugData->ApicId[NewSlot] =3D MAX_UINT64; - Fatal: ASSERT (FALSE); CpuDeadLoop (); --=20 2.9.3 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70869): https://edk2.groups.io/g/devel/message/70869 Mute This Topic: https://groups.io/mt/80199901/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-