[edk2-devel] [Wiki] Add update notes for incomaptible patches that fix typos in SmBios.h

Zhiguang Liu posted 1 patch 3 years, 2 months ago
Failed in applying to current master (apply log)
EDK-II-Release-Planning.md | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [Wiki] Add update notes for incomaptible patches that fix typos in SmBios.h
Posted by Zhiguang Liu 3 years, 2 months ago
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
 EDK-II-Release-Planning.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
index 336d8d2..bbb5f18 100644
--- a/EDK-II-Release-Planning.md
+++ b/EDK-II-Release-Planning.md
@@ -32,6 +32,7 @@
 * If the user has the windows bat script that calls Split in it,it needs to change to "call Split" because Split will be a bat script but not an executable file.
 * Shell depends on library class OrderedCollectionLib. Platform DSC needs to configure it in [LibraryClasses]
 OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
+* Some struct fields in SmBios.h have typos and get fixed in these code change [0db8](https://github.com/tianocore/edk2/commit/0db89a661f38b10012ff4f62e1853bfc48efd462), [bd9d](https://github.com/tianocore/edk2/commit/bd9da7b1da2639fcea8a156fa92a32bbc4209367), [e157](https://github.com/tianocore/edk2/commit/e157c8f9ed173a390d2c9d29069a46e9662e0d04). Platform code that uses those fields need modifications.
 * TBD
 
 # edk2-stable202105 tag planning
-- 
2.30.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70819): https://edk2.groups.io/g/devel/message/70819
Mute This Topic: https://groups.io/mt/80148487/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


[edk2-devel] 回复: [Wiki] Add update notes for incomaptible patches that fix typos in SmBios.h
Posted by gaoliming 3 years, 2 months ago
Zhiguang:
  Can you summary the code change in the notes? And, also include the edk2 commits for the detail. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Zhiguang Liu <zhiguang.liu@intel.com>
> 发送时间: 2021年1月27日 10:09
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>
> 主题: [Wiki] Add update notes for incomaptible patches that fix typos in
> SmBios.h
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  EDK-II-Release-Planning.md | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
> index 336d8d2..bbb5f18 100644
> --- a/EDK-II-Release-Planning.md
> +++ b/EDK-II-Release-Planning.md
> @@ -32,6 +32,7 @@
>  * If the user has the windows bat script that calls Split in it,it needs to
> change to "call Split" because Split will be a bat script but not an executable
> file.
>  * Shell depends on library class OrderedCollectionLib. Platform DSC needs to
> configure it in [LibraryClasses]
> 
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
> +* Some struct fields in SmBios.h have typos and get fixed in these code
> change
> [0db8](https://github.com/tianocore/edk2/commit/0db89a661f38b10012ff4f
> 62e1853bfc48efd462),
> [bd9d](https://github.com/tianocore/edk2/commit/bd9da7b1da2639fcea8a1
> 56fa92a32bbc4209367),
> [e157](https://github.com/tianocore/edk2/commit/e157c8f9ed173a390d2c9
> d29069a46e9662e0d04). Platform code that uses those fields need
> modifications.
>  * TBD
> 
>  # edk2-stable202105 tag planning
> --
> 2.30.0.windows.2





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70830): https://edk2.groups.io/g/devel/message/70830
Mute This Topic: https://groups.io/mt/80173923/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] 回复: [Wiki] Add update notes for incomaptible patches that fix typos in SmBios.h
Posted by Zhiguang Liu 3 years, 1 month ago
Hi Liming,

The edk2 commits that fixes the typo has been included using the hyper link.
The platforms side's modification doesn't have example to show here.
Do you think it is necessary to list all the typo these commits fixed, like below?
FirwareVersion                 -> FirmwareVersion
ProcessorManufacture           -> ProcessorManufacturer
Processor64BitCapble           -> Processor64BitCapable
ProcessorEnhancedVirtulization -> ProcessorEnhancedVirtualization
Processor128bitCapble          -> Processor128BitCapable  

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Thursday, January 28, 2021 9:21 AM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Subject: [edk2-devel] 回复: [Wiki] Add update notes for incomaptible
> patches that fix typos in SmBios.h
> 
> Zhiguang:
>   Can you summary the code change in the notes? And, also include the edk2
> commits for the detail.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Zhiguang Liu <zhiguang.liu@intel.com>
> > 发送时间: 2021年1月27日 10:09
> > 收件人: devel@edk2.groups.io
> > 抄送: Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: [Wiki] Add update notes for incomaptible patches that fix typos in
> > SmBios.h
> >
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> >  EDK-II-Release-Planning.md | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
> > index 336d8d2..bbb5f18 100644
> > --- a/EDK-II-Release-Planning.md
> > +++ b/EDK-II-Release-Planning.md
> > @@ -32,6 +32,7 @@
> >  * If the user has the windows bat script that calls Split in it,it needs to
> > change to "call Split" because Split will be a bat script but not an executable
> > file.
> >  * Shell depends on library class OrderedCollectionLib. Platform DSC needs
> to
> > configure it in [LibraryClasses]
> >
> >
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> i
> > b/BaseOrderedCollectionRedBlackTreeLib.inf
> > +* Some struct fields in SmBios.h have typos and get fixed in these code
> > change
> >
> [0db8](https://github.com/tianocore/edk2/commit/0db89a661f38b10012ff4f
> > 62e1853bfc48efd462),
> >
> [bd9d](https://github.com/tianocore/edk2/commit/bd9da7b1da2639fcea8a
> 1
> > 56fa92a32bbc4209367),
> >
> [e157](https://github.com/tianocore/edk2/commit/e157c8f9ed173a390d2c9
> > d29069a46e9662e0d04). Platform code that uses those fields need
> > modifications.
> >  * TBD
> >
> >  # edk2-stable202105 tag planning
> > --
> > 2.30.0.windows.2
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71005): https://edk2.groups.io/g/devel/message/71005
Mute This Topic: https://groups.io/mt/80173923/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] 回复: [Wiki] Add update notes for incomaptible patches that fix typos in SmBios.h
Posted by gaoliming 3 years, 1 month ago
Zhiguang:
  Yes. If the information includes structure name SMBIOS_TABLE_TYPE17, it will be better. 

  For example, SMBIOS_TABLE_TYPE17.FirwareVersion ==> SMBIOS_TABLE_TYPE17.FirmwareVersion

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+71005+4905953+8761045@groups.io
> <bounce+27952+71005+4905953+8761045@groups.io> 代表 Zhiguang Liu
> 发送时间: 2021年2月1日 14:55
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 主题: Re: [edk2-devel] 回复: [Wiki] Add update notes for incomaptible
> patches that fix typos in SmBios.h
> 
> Hi Liming,
> 
> The edk2 commits that fixes the typo has been included using the hyper link.
> The platforms side's modification doesn't have example to show here.
> Do you think it is necessary to list all the typo these commits fixed, like below?
> FirwareVersion                 -> FirmwareVersion
> ProcessorManufacture           -> ProcessorManufacturer
> Processor64BitCapble           -> Processor64BitCapable
> ProcessorEnhancedVirtulization -> ProcessorEnhancedVirtualization
> Processor128bitCapble          -> Processor128BitCapable
> 
> Thanks
> Zhiguang
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > gaoliming
> > Sent: Thursday, January 28, 2021 9:21 AM
> > To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> > Subject: [edk2-devel] 回复: [Wiki] Add update notes for incomaptible
> > patches that fix typos in SmBios.h
> >
> > Zhiguang:
> >   Can you summary the code change in the notes? And, also include the
> edk2
> > commits for the detail.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Zhiguang Liu <zhiguang.liu@intel.com>
> > > 发送时间: 2021年1月27日 10:09
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Liming Gao <gaoliming@byosoft.com.cn>
> > > 主题: [Wiki] Add update notes for incomaptible patches that fix typos in
> > > SmBios.h
> > >
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > > ---
> > >  EDK-II-Release-Planning.md | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
> > > index 336d8d2..bbb5f18 100644
> > > --- a/EDK-II-Release-Planning.md
> > > +++ b/EDK-II-Release-Planning.md
> > > @@ -32,6 +32,7 @@
> > >  * If the user has the windows bat script that calls Split in it,it needs to
> > > change to "call Split" because Split will be a bat script but not an
> executable
> > > file.
> > >  * Shell depends on library class OrderedCollectionLib. Platform DSC
> needs
> > to
> > > configure it in [LibraryClasses]
> > >
> > >
> >
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> > i
> > > b/BaseOrderedCollectionRedBlackTreeLib.inf
> > > +* Some struct fields in SmBios.h have typos and get fixed in these code
> > > change
> > >
> >
> [0db8](https://github.com/tianocore/edk2/commit/0db89a661f38b10012ff4f
> > > 62e1853bfc48efd462),
> > >
> >
> [bd9d](https://github.com/tianocore/edk2/commit/bd9da7b1da2639fcea8a
> > 1
> > > 56fa92a32bbc4209367),
> > >
> >
> [e157](https://github.com/tianocore/edk2/commit/e157c8f9ed173a390d2c9
> > > d29069a46e9662e0d04). Platform code that uses those fields need
> > > modifications.
> > >  * TBD
> > >
> > >  # edk2-stable202105 tag planning
> > > --
> > > 2.30.0.windows.2
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71044): https://edk2.groups.io/g/devel/message/71044
Mute This Topic: https://groups.io/mt/80306600/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-