[edk2-devel] [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe

Patrick Rudolph posted 1 patch 3 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210125150506.3848562-1-patrick.rudolph@9elements.com
UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
1 file changed, 5 insertions(+)
[edk2-devel] [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
Posted by Patrick Rudolph 3 years, 2 months ago
The PciLib depends on PCDs
- PcdPciExpressBaseAddress
- PcdPciExpressBaseSize
being updated by BlSupportDxe before MMCONF accesses are working.

Add BlSupportDxe to APRIORI to start it first and get the system into
an useable state where at least PCI accesses work reliable.

Fixes a bug where BlSupportDxe is scheduled too late and other DXEs fail
to load due to broken PCI access.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
 UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index a97ace7395..1ae260c13a 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -80,6 +80,11 @@ READ_STATUS        = TRUE
 READ_LOCK_CAP      = TRUE
 READ_LOCK_STATUS   = TRUE
 
+APRIORI DXE {
+  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
+  INF  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
+  INF  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
+}
 
 #
 # DXE Phase modules
-- 
2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70722): https://edk2.groups.io/g/devel/message/70722
Mute This Topic: https://groups.io/mt/80105370/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
Posted by Ma, Maurice 3 years, 2 months ago
Reviewed-by:  Maurice Ma <maurice.ma@intel.com>

Regards
Maurice

> -----Original Message-----
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> Sent: Monday, January 25, 2021 7:05
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe
> 
> The PciLib depends on PCDs
> - PcdPciExpressBaseAddress
> - PcdPciExpressBaseSize
> being updated by BlSupportDxe before MMCONF accesses are working.
> 
> Add BlSupportDxe to APRIORI to start it first and get the system into an
> useable state where at least PCI accesses work reliable.
> 
> Fixes a bug where BlSupportDxe is scheduled too late and other DXEs fail to
> load due to broken PCI access.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index a97ace7395..1ae260c13a 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -80,6 +80,11 @@ READ_STATUS        = TRUE
>  READ_LOCK_CAP      = TRUE READ_LOCK_STATUS   = TRUE +APRIORI DXE {+
> INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf+  INF
> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf+  INF
> UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf+}  # # DXE Phase modules--
> 2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70723): https://edk2.groups.io/g/devel/message/70723
Mute This Topic: https://groups.io/mt/80105370/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-