From nobody Tue Feb 10 03:38:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70642+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70642+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222739; cv=none; d=zohomail.com; s=zohoarc; b=nYIQiU0ZXEOh/2Aa1XCcHiQXJRya7CWdvypb6WYvh5tQt6AJrn4z9GYuI2dQrdzsN6AOyNqnlV88C6yGHoOdakpyxltc4+ORQf0+56tWgGUrzkUe3D0SQ7jSLm20J0/2sii72wewUigU3RTi7MW6UxDhwT1aQ9qAVsHVXpbWH3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222739; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=jTmvAT6eUjuoo0aBAtDAc+pgcOMkeoZgyVq3h1dazF0=; b=RJE+KJbhUnBPnO+lI38KlHYAXPsQHP3Qv6NbUr1lHCf2ljIMa7sZ1710aeO6cx/SN6+7oJqdS6hSDPsOADcbhkRlePUByCbpaB8E4GusvTyd31dgwQvnI8rJ8uw22hCZ/Rk2YhLKrvNiMVkn0N+kkwkWB0jZbhYiOKZjDhmkDI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70642+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222739030579.3377731374793; Thu, 21 Jan 2021 01:52:19 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id EFcFYY1788612xrIUSSNZQSp; Thu, 21 Jan 2021 01:52:18 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.5058.1611222735890074675 for ; Thu, 21 Jan 2021 01:52:16 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94F46D6E; Thu, 21 Jan 2021 01:52:15 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5099F3F719; Thu, 21 Jan 2021 01:52:14 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 26/27] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT Date: Thu, 21 Jan 2021 09:51:18 +0000 Message-Id: <20210121095119.22143-27-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: TD2aeFOygnHYKHRPCQORGEF4x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222738; bh=RVnL8z08Gh+lbwkN2mBmdXFQuoQW5FNP4XWccPeEXig=; h=Cc:Date:From:Reply-To:Subject:To; b=qxbuoq8U5lx8UHl0Qw5iiq8QIzzdkl8Lg7JV2VVbOmzOoawtWOOVSCag/LDBW+NQn22 TFAKWwt7mM8cY2ewp+4VrlWoaHS05u+xAWhMX2qJVfKq//WM1yiJSuw8M577xIgYK9FYS a18EefzwNG4HMq8TYZVyQnNnLUP3u4o4uL8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 8 ++++---- ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h | 6 +++--- ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 8 ++++---- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers= /ArmScmiDxe/ScmiClockProtocol.c index 9cd3a7ed232d..cc223d672028 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -152,10 +152,10 @@ ClockGetClockAttributes ( @param[in] This A pointer to SCMI_CLOCK_PROTOCOL Instance. @param[in] ClockId Identifier for the clock device. - @param[out] Format SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device + @param[out] Format ScmiClockRateFormatDiscrete: Clock device supports range of clock rates which are non-line= ar. - SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supp= orts + ScmiClockRateFormatLinear: Clock device supports range of linear clock rates from Min to Max in s= teps. @param[out] TotalRates Total number of rates. @@ -236,7 +236,7 @@ ClockDescribeRates ( *TotalRates =3D NUM_RATES (DescribeRates->NumRatesFlags) + NUM_REMAIN_RATES (DescribeRates->NumRatesFlags); - if (*Format =3D=3D SCMI_CLOCK_RATE_FORMAT_DISCRETE) { + if (*Format =3D=3D ScmiClockRateFormatDiscrete) { RequiredArraySize =3D (*TotalRates) * sizeof (UINT64); } else { // We need to return triplet of 64 bit value for each rate @@ -251,7 +251,7 @@ ClockDescribeRates ( RateOffset =3D 0; - if (*Format =3D=3D SCMI_CLOCK_RATE_FORMAT_DISCRETE) { + if (*Format =3D=3D ScmiClockRateFormatDiscrete) { for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { Rate =3D &DescribeRates->Rates[RateOffset++]; // Non-linear discrete rates. diff --git a/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h b/ArmPkg/Inclu= de/Protocol/ArmScmiClock2Protocol.h index 950141cbd2da..0e26491a62c4 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -89,10 +89,10 @@ EFI_STATUS @param[in] This A pointer to SCMI_CLOCK2_PROTOCOL Instance. @param[in] ClockId Identifier for the clock device. - @param[out] Format SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device + @param[out] Format ScmiClockRateFormatDiscrete: Clock device supports range of clock rates which are non-line= ar. - SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supp= orts + ScmiClockRateFormatLinear: Clock device supports range of linear clock rates from Min to Max in s= teps. @param[out] TotalRates Total number of rates. diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Includ= e/Protocol/ArmScmiClockProtocol.h index cd62f05a58fd..4210a53cf98d 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -30,8 +30,8 @@ typedef enum { } SCMI_MESSAGE_ID_CLOCK; typedef enum { - SCMI_CLOCK_RATE_FORMAT_DISCRETE, // Non-linear range. - SCMI_CLOCK_RATE_FORMAT_LINEAR // Linear range. + ScmiClockRateFormatDiscrete, // Non-linear range. + ScmiClockRateFormatLinear // Linear range. } SCMI_CLOCK_RATE_FORMAT; // Clock management protocol version. @@ -139,10 +139,10 @@ EFI_STATUS @param[in] This A pointer to SCMI_CLOCK_PROTOCOL Instance. @param[in] ClockId Identifier for the clock device. - @param[out] Format SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device + @param[out] Format ScmiClockRateFormatDiscrete: Clock device supports range of clock rates which are non-line= ar. - SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supp= orts + ScmiClockRateFormatLinear: Clock device supports range of linear clock rates from Min to Max in s= teps. @param[out] TotalRates Total number of rates. -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70642): https://edk2.groups.io/g/devel/message/70642 Mute This Topic: https://groups.io/mt/80000401/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-