From nobody Mon Feb 9 23:03:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70639+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70639+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222736; cv=none; d=zohomail.com; s=zohoarc; b=Zc0NTB1wO+VjkhDg4ICvg6Me1CwgXTD9j3hmaMnv+x2V8xck89stNoRSp4Gv33Ff4JivPr82k+uqY0/Qsh8TEgxROj45lln4jmjZ4ue5Lw1i0Zz76S3zad7Q/cfnN9lUUvN0FgR5CEwARG1+Zd1pCQjtthZ/0aMDOLS7+qGuZnc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222736; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Ot5jv8TfPYeNwlTO/OoapIxyCO5Se0NuxcWzPMXwuC0=; b=l2xgYdkKUhg5Xnwd4Ftb6JVMIiVxSg6OEYzxrAW6j8jI3u410zA1hzPw1bjJtDQVLYMVWFKivZ5GpjBoxDALbM7Rsrs+Rlq5gxnvh3KSrRaUjbtkQYSoeDSHpfBd/ALz/2YLqgTV7xuLen7x9G2mBQrScbs5W21Uz/1FQ7U+iCU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70639+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222736953817.2273967693945; Thu, 21 Jan 2021 01:52:16 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id XzzLYY1788612xc620UGlfuW; Thu, 21 Jan 2021 01:52:16 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.5075.1611222731137477235 for ; Thu, 21 Jan 2021 01:52:11 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA58F14FF; Thu, 21 Jan 2021 01:52:10 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B991A3F719; Thu, 21 Jan 2021 01:52:09 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 23/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID Date: Thu, 21 Jan 2021 09:51:15 +0000 Message-Id: <20210121095119.22143-24-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: yRSepIWDH3za0UiIVMlLo8HNx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222736; bh=l0hv5ULff/7133zr1o4cU7/Z9z2eZKr1t4q4REDCg8o=; h=Cc:Date:From:Reply-To:Subject:To; b=IXRqLWUxymh1w6cZ6CuqadFACDhVGtAYKqjrppMEuDqksM/oFTyTWk7PCsRVEr9Iujj ZK3O4i7T8ZzBsYQx/6OTS9GLSfwkvUcarKMj104PVBNg7uUbxBfINFA7bhh6xCPbrhtwB YNqPzlveMBt4uk2TQ4odFP+Gf8+0Lkva9CQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 6 +++--- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/S= cmi.c index a1bf1b95c052..3793c0663666 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -195,7 +195,7 @@ ScmiGetProtocolVersion ( Status =3D ScmiProtocolDiscoveryCommon ( ProtocolId, - SCMI_MESSAGE_ID_PROTOCOL_VERSION, + ScmiMessageIdProtocolVersion, (UINT32**)&ProtocolVersion ); if (EFI_ERROR (Status)) { @@ -224,7 +224,7 @@ ScmiGetProtocolAttributes ( { return ScmiProtocolDiscoveryCommon ( ProtocolId, - SCMI_MESSAGE_ID_PROTOCOL_ATTRIBUTES, + ScmiMessageIdProtocolAttributes, ReturnValues ); } @@ -246,7 +246,7 @@ ScmiGetProtocolMessageAttributes ( { return ScmiProtocolDiscoveryCommon ( ProtocolId, - SCMI_MESSAGE_ID_PROTOCOL_MESSAGE_ATTRIBUTES, + ScmiMessageIdProtocolMessageAttributes, ReturnValues ); } diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmSc= miDxe/ScmiPrivate.h index 118961dbe219..e56c9e0dc342 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -45,9 +45,9 @@ typedef enum { // SCMI message IDs common to all protocols. typedef enum { - SCMI_MESSAGE_ID_PROTOCOL_VERSION =3D 0x0, - SCMI_MESSAGE_ID_PROTOCOL_ATTRIBUTES =3D 0x1, - SCMI_MESSAGE_ID_PROTOCOL_MESSAGE_ATTRIBUTES =3D 0x2 + ScmiMessageIdProtocolVersion =3D 0x0, + ScmiMessageIdProtocolAttributes =3D 0x1, + ScmiMessageIdProtocolMessageAttributes =3D 0x2 } SCMI_MESSAGE_ID; // Not defined in SCMI specification but will help to identify a message. -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70639): https://edk2.groups.io/g/devel/message/70639 Mute This Topic: https://groups.io/mt/80000398/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-