From nobody Mon Feb 9 23:03:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70638+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70638+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222735; cv=none; d=zohomail.com; s=zohoarc; b=i9mQW8mlFsJc8JIHcxbzmOkHprX05yMpziaXffnekRYHKZqAG0FEb7xc5aK1YT2NzZqGBt8Ci8uhkxKdzjGywgsxuXkXwSNka68/5b00VrNuI0NaWHJLpGZlCvZRK/dEvVRqX3INwBsLcwOeTqdoSYDvzZzTDRwrD4/K9jDQcMw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222735; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=W3UOlBo8KlaIHXF/tfqxWI7dCdzW6jtBy8iJBnvOjD8=; b=cvSLlCPnmh8B8QYsqAiVPbNDGooupnlhLLRRlxqozi1W59CqkTTv/MZwIwQZUDMXWue7/OQKpt274VewUhtB58z+Q4XDZunfnVdrjm0rpkn8NgB5ZURN8nEeQ05+tOs/crrKolQmpKe9hZObiZYTma8VFDHjezuXGf7A/t56n08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70638+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222735494138.67512768167035; Thu, 21 Jan 2021 01:52:15 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id BhfoYY1788612xkEilBihMsM; Thu, 21 Jan 2021 01:52:15 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4997.1611222729642892171 for ; Thu, 21 Jan 2021 01:52:09 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57BE1D6E; Thu, 21 Jan 2021 01:52:09 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1C8D93F719; Thu, 21 Jan 2021 01:52:07 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 22/27] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS Date: Thu, 21 Jan 2021 09:51:14 +0000 Message-Id: <20210121095119.22143-23-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 9rxJub2j6Cny2OJA97AannSZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222735; bh=gZt8f9yZCwhwIFjQZlFReiYwkYJmXrR5r9kcb/wmnYA=; h=Cc:Date:From:Reply-To:Subject:To; b=o9q+w8P1/C4MbZAPZhfaXKzBqbp8A5eg5rxxsv/g0WEXPbTFX2HRIPVAU5+MBM58h0s e1PlkWR2o/L1iHQnfp7kq14XaIMes1rs+QlZzyxoVLG34N2PkAaZqTgaNczUS1yH1I1Vn QwWPVkoKU9CE+4BzpGbXRk75NbBr17vA3iw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/S= cmi.c index 25f6cc3371af..a1bf1b95c052 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -123,7 +123,7 @@ ScmiCommandExecute ( Response =3D (SCMI_MESSAGE_RESPONSE*)MtlGetChannelPayload (Channel); - if (Response->Status !=3D SCMI_SUCCESS) { + if (Response->Status !=3D ScmiSuccess) { DEBUG ((DEBUG_ERROR, "SCMI error: ProtocolId =3D 0x%x, MessageId =3D 0= x%x, error =3D %d\n", Command->ProtocolId, Command->MessageId, diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmSc= miDxe/ScmiPrivate.h index 6de57a5c9514..118961dbe219 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -30,17 +30,17 @@ typedef enum { // SCMI response error codes. typedef enum { - SCMI_SUCCESS =3D 0, - SCMI_NOT_SUPPORTED =3D -1, - SCMI_INVALID_PARAMETERS =3D -2, - SCMI_DENIED =3D -3, - SCMI_NOT_FOUND =3D -4, - SCMI_OUT_OF_RANGE =3D -5, - SCMI_BUSY =3D -6, - SCMI_COMMS_ERROR =3D -7, - SCMI_GENERIC_ERROR =3D -8, - SCMI_HARDWARE_ERROR =3D -9, - SCMI_PROTOCOL_ERROR =3D -10 + ScmiSuccess =3D 0, + ScmiNotSupported =3D -1, + ScmiInvalidParameters =3D -2, + ScmiDenied =3D -3, + ScmiNotFound =3D -4, + ScmiOutOfRange =3D -5, + ScmiBusy =3D -6, + ScmiCommsError =3D -7, + ScmiGenericError =3D -8, + ScmiHardwareError =3D -9, + ScmiProtocolError =3D -10 } SCMI_STATUS; // SCMI message IDs common to all protocols. -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70638): https://edk2.groups.io/g/devel/message/70638 Mute This Topic: https://groups.io/mt/80000397/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-