From nobody Tue Feb 10 03:39:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70637+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70637+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222734; cv=none; d=zohomail.com; s=zohoarc; b=ApRWIK/njPxNwVOzxXfVZ3jW541UjOphB5Xidj9KM6MIFhxpKjUpDpkq8sI+WqDjl08gUbAODDsBWiAldVWGgfqgi20NZWnsmxflq9iH7iT+UYaURUwFvc+krjQ4P79HBL2vxQupYqDkdmkS/J+YQA5N/LhcChq7h4UpaLjS41A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222734; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=EgeGCrP1JGqvzmQgiaCMKWwfHveIuF7tlbSQFHE4pUw=; b=FAIjsES8NTYkjCWFddW1/HmBzjgOJ24d/0DXi8RHGnk8C8Rj86StYbGncTKsBOFKcl7lwDzLDDmb6ukIOv+ovbTJfgNEfCW4doj0nCSFrcJ42+4XTLjS2Ii2ZsBszf/cSqNBQdLP/8yYpUBfxaIgrP0ZHxkTyz0wx2z2ejnSj3s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70637+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222734506414.262527898627; Thu, 21 Jan 2021 01:52:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id YzLsYY1788612xgSo5NEQUb6; Thu, 21 Jan 2021 01:52:13 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4977.1611222727967053584 for ; Thu, 21 Jan 2021 01:52:08 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFE1714FF; Thu, 21 Jan 2021 01:52:07 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7505A3F719; Thu, 21 Jan 2021 01:52:06 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 21/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE Date: Thu, 21 Jan 2021 09:51:13 +0000 Message-Id: <20210121095119.22143-22-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ALzJYE8jTWE693xOOc2uuR6ox1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222733; bh=90QSgcKmJbLib9oWJQ6ffoshBIR4vrZXUlPisIuq92E=; h=Cc:Date:From:Reply-To:Subject:To; b=shcKmosrM5q0FrC/PACcuJbLxxIzRlBYLy4JNRLUb6V2QucCBpoZLP0YJskB3kZo2sh r1En3P6GZcRxduYC2A8k8m317VhNFIsM1H456dhcha0IBVPHJ0oAuFmuYLxCpGQty8g7h 1hV4QE9qe0A1iHRegpD46fraiq0+TX+IlfE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/S= cmi.c index 847868a7749e..25f6cc3371af 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -95,7 +95,7 @@ ScmiCommandExecute ( // Fill in message header. MessageHeader =3D SCMI_MESSAGE_HEADER ( Command->MessageId, - SCMI_MESSAGE_TYPE_COMMAND, + ScmiMessageTypeCommand, Command->ProtocolId ); diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmSc= miDxe/ScmiPrivate.h index 5f1225f54cd9..6de57a5c9514 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -23,9 +23,9 @@ typedef enum { // SCMI message types. typedef enum { - SCMI_MESSAGE_TYPE_COMMAND =3D 0, - SCMI_MESSAGE_TYPE_DELAYED_RESPONSE =3D 2, // Skipping 1 is deliberate. - SCMI_MESSAGE_TYPE_NOTIFICATION =3D 3 + ScmiMessageTypeCommand =3D 0, + ScmiMessageTypeDelayedResponse =3D 2, // Skipping 1 is deliberate. + ScmiMessageTypeNotification =3D 3 } SCMI_MESSAGE_TYPE; // SCMI response error codes. -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70637): https://edk2.groups.io/g/devel/message/70637 Mute This Topic: https://groups.io/mt/80000396/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-