From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70623+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70623+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222709; cv=none; d=zohomail.com; s=zohoarc; b=ameA2iMmEQ+RAQzjiN3wuDxdjxlKsSYyPoXzemfPxwHZiL/wuCtUqGfmki56jbzNQF5OxoHxiz7a6Aze8ebB/SQMFvjW0vFhtm0KqhGSlwbFw3co/+o3GFvCBZQSMdoLDKsrdWoSpRhSgydMBrZSfxercloLKG5ajEa464tuWxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222709; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=7VKj3DyZvOBRY62cDTF7gklblKJNyIQQQ3MrU6oSFGo=; b=B362j0NM7mU2SwgbukZh7wlYp8Y7Ax4x/3qZ52R9LMZdaBTcp0X89z0iDYkdybD8rqMdNfcbtne3SrMqfJ0t8/h1kjK25VhqbZzuKTTjfNnxOveW6X4DC7NbqOZoP4seWKDofAl49Xr50tj3PQyQn1oMVe0Lsw4h5YLOUQlq0Es= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70623+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222709371922.216419708058; Thu, 21 Jan 2021 01:51:49 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id IZlmYY1788612x6dXohhMvf6; Thu, 21 Jan 2021 01:51:48 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4986.1611222708318398151 for ; Thu, 21 Jan 2021 01:51:48 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37EEC1509; Thu, 21 Jan 2021 01:51:38 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1F3403F719; Thu, 21 Jan 2021 01:51:36 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 01/27] ArmPkg: Fix Ecc error 8001 in Chipset Date: Thu, 21 Jan 2021 09:50:53 +0000 Message-Id: <20210121095119.22143-2-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 5YFXS3G2lrpaPj2Y78XtrUKrx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222708; bh=+xhkM9LiM0Bs8BgcOlq8u4VMhVxZDl2WUivDQ2Pbgzk=; h=Cc:Date:From:Reply-To:Subject:To; b=OmMNAXg7jxzg7/0FzSzU5VLIUTqCvi4eOaJb+7i+zE1RE0uTLihGi5RxOqrdfd4sngs htjZHhefR2myKdpzSeP3Abp/fct6BUNRKhETVNQDSzGkDV1NJDXHKIesXrWVPHXb1DhAW TD2uwEDTQssUB99nWMtyfsLAr9UQbDV5y08= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard of ArmCortexA5x.h is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Include/Chipset/AArch64.h | 12 ++++++------ ArmPkg/Include/Chipset/ArmCortexA5x.h | 6 +++--- ArmPkg/Include/Chipset/ArmV7.h | 4 ++-- .../ArmExceptionLib/AArch64/ExceptionSupport.S | 10 +++++----- ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 10 +++++----- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/Include/Chipset/AArc= h64.h index 0ade5cce91c3..d49f4d60b15d 100644 --- a/ArmPkg/Include/Chipset/AArch64.h +++ b/ArmPkg/Include/Chipset/AArch64.h @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2017, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -39,7 +39,7 @@ // MIDR - Main ID Register definitions #define ARM_CPU_TYPE_SHIFT 4 #define ARM_CPU_TYPE_MASK 0xFFF -#define ARM_CPU_TYPE_AEMv8 0xD0F +#define ARM_CPU_TYPE_AEMV8 0xD0F #define ARM_CPU_TYPE_A53 0xD03 #define ARM_CPU_TYPE_A57 0xD07 #define ARM_CPU_TYPE_A72 0xD08 @@ -97,10 +97,10 @@ #define ARM_VECTOR_CUR_SP0_FIQ 0x100 #define ARM_VECTOR_CUR_SP0_SERR 0x180 -#define ARM_VECTOR_CUR_SPx_SYNC 0x200 -#define ARM_VECTOR_CUR_SPx_IRQ 0x280 -#define ARM_VECTOR_CUR_SPx_FIQ 0x300 -#define ARM_VECTOR_CUR_SPx_SERR 0x380 +#define ARM_VECTOR_CUR_SPX_SYNC 0x200 +#define ARM_VECTOR_CUR_SPX_IRQ 0x280 +#define ARM_VECTOR_CUR_SPX_FIQ 0x300 +#define ARM_VECTOR_CUR_SPX_SERR 0x380 #define ARM_VECTOR_LOW_A64_SYNC 0x400 #define ARM_VECTOR_LOW_A64_IRQ 0x480 diff --git a/ArmPkg/Include/Chipset/ArmCortexA5x.h b/ArmPkg/Include/Chipset= /ArmCortexA5x.h index 847a6e00430b..2661ed8c0182 100644 --- a/ArmPkg/Include/Chipset/ArmCortexA5x.h +++ b/ArmPkg/Include/Chipset/ArmCortexA5x.h @@ -6,8 +6,8 @@ **/ -#ifndef __ARM_CORTEX_A5x_H__ -#define __ARM_CORTEX_A5x_H__ +#ifndef ARM_CORTEX_A5X_H__ +#define ARM_CORTEX_A5X_H__ // // Cortex A5x feature bit definitions @@ -41,4 +41,4 @@ ArmUnsetCpuExCrBit ( IN UINT64 Bits ); -#endif +#endif // ARM_CORTEX_A5X_H__ diff --git a/ArmPkg/Include/Chipset/ArmV7.h b/ArmPkg/Include/Chipset/ArmV7.h index fe91031ef33d..025f87a56d16 100644 --- a/ArmPkg/Include/Chipset/ArmV7.h +++ b/ArmPkg/Include/Chipset/ArmV7.h @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011-2015, ARM Ltd. All rights reserved.
+ Copyright (c) 2011-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -70,7 +70,7 @@ // MIDR - Main ID Register definitions #define ARM_CPU_TYPE_SHIFT 4 #define ARM_CPU_TYPE_MASK 0xFFF -#define ARM_CPU_TYPE_AEMv8 0xD0F +#define ARM_CPU_TYPE_AEMV8 0xD0F #define ARM_CPU_TYPE_A53 0xD03 #define ARM_CPU_TYPE_A57 0xD07 #define ARM_CPU_TYPE_A15 0xC0F diff --git a/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S b/Ar= mPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S index 5b10a1339ac1..9202952ee9c0 100644 --- a/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S +++ b/ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S @@ -1,5 +1,5 @@ // -// Copyright (c) 2011 - 2014 ARM LTD. All rights reserved.
+// Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
// Portion of Copyright (c) 2014 NVIDIA Corporation. All rights reserved.<= BR> // Copyright (c) 2016 HP Development Company, L.P. // @@ -200,19 +200,19 @@ ASM_PFX(SErrorSP0): // // Current EL with SPx: 0x200 - 0x380 // -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_SYNC) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_SYNC) ASM_PFX(SynchronousExceptionSPx): ExceptionEntry EXCEPT_AARCH64_SYNCHRONOUS_EXCEPTIONS, SP0 -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_IRQ) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_IRQ) ASM_PFX(IrqSPx): ExceptionEntry EXCEPT_AARCH64_IRQ -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_FIQ) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_FIQ) ASM_PFX(FiqSPx): ExceptionEntry EXCEPT_AARCH64_FIQ -VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPx_SERR) +VECTOR_ENTRY(ExceptionHandlersStart, ARM_VECTOR_CUR_SPX_SERR) ASM_PFX(SErrorSPx): ExceptionEntry EXCEPT_AARCH64_SERROR diff --git a/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S b/ArmPlatformPkg= /PrePeiCore/AArch64/Exception.S index 59a3da2721e7..43e40f97c3ee 100644 --- a/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S +++ b/ArmPlatformPkg/PrePeiCore/AArch64/Exception.S @@ -1,5 +1,5 @@ # -# Copyright (c) 2011-2014, ARM Limited. All rights reserved. +# Copyright (c) 2011-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -51,22 +51,22 @@ _DefaultSError_t: mov x0, #EXCEPT_AARCH64_SERROR TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_SYNC) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_SYNC) _DefaultSyncExceptHandler_h: mov x0, #EXCEPT_AARCH64_SYNCHRONOUS_EXCEPTIONS TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_IRQ) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_IRQ) _DefaultIrq_h: mov x0, #EXCEPT_AARCH64_IRQ TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_FIQ) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_FIQ) _DefaultFiq_h: mov x0, #EXCEPT_AARCH64_FIQ TO_HANDLER -VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPx_SERR) +VECTOR_ENTRY(PeiVectorTable, ARM_VECTOR_CUR_SPX_SERR) _DefaultSError_h: mov x0, #EXCEPT_AARCH64_SERROR TO_HANDLER -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70623): https://edk2.groups.io/g/devel/message/70623 Mute This Topic: https://groups.io/mt/80000379/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70616+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70616+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222707; cv=none; d=zohomail.com; s=zohoarc; b=XIlRQ9GJGxtmbTxWr/8m4MhzZPZbhSN6WrCojD11gpGu2sc9EZfqUCB45bp5xJI83+uBIypRSord1S5XFuC6DsCOmFQ5wn2LJSJ1LXqhHOb7gsXLuuTbFApgFS+CMdjKOM3a0iMZGZ4MvFws8fDqJZK8Jsbg1uLkeMvJ3e96pwM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222707; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=EtebqrWfRsGq+RXh6sefm6euyxzn/0oQnF7xPsbOdZI=; b=OK6XuOaJ/7My5+n1E76g13761eA+TXEcwWRCUY3jCGVf+nlMe7FpnzIiLT4EqwterycTZr93VAeQExd9FDnoIglXsH7+6cVA6v4UovEsNe9od7mnw86mN/OqENHCAvQDpZP7W7l2hTuBvUMMzx3NEe8BjNO7VSf78UuYzP0CIgY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70616+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222707471571.7737556910283; Thu, 21 Jan 2021 01:51:47 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id sqSGYY1788612xccZmZkjwbE; Thu, 21 Jan 2021 01:51:47 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4984.1611222705156992336 for ; Thu, 21 Jan 2021 01:51:45 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3E4C152D; Thu, 21 Jan 2021 01:51:39 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 987463F719; Thu, 21 Jan 2021 01:51:38 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 02/27] ArmPkg: Fix Ecc error 8001 in SemihostLib Date: Thu, 21 Jan 2021 09:50:54 +0000 Message-Id: <20210121095119.22143-3-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 4HMKi8Krwf8ILhUgoL3YFGy5x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222707; bh=W226BpxQmezx8OJpbswpMtsAohYQB5PPFgJ2I7ECEHE=; h=Cc:Date:From:Reply-To:Subject:To; b=HA7i/aMsXVH9y3hsUes4/kkGdM4Iahq2leXHlFH1sxNbYatsYsHIV4Fy8lTyQf21wsH a0BpA0eMj3xXqiRIVz/qwJnQkgqxWnoTcMBvsY/aaSuUQ02a3owBmeVHGRhVrWP0z0Dg4 jygrlzL2kOeoIOeiUObxD06nOhDgvShv0RA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Library/SemihostLib/SemihostLib.c | 26 +++---- ArmPkg/Library/SemihostLib/SemihostPrivate.h | 80 ++++++++++---------- 2 files changed, 53 insertions(+), 53 deletions(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.c b/ArmPkg/Library/Semi= hostLib/SemihostLib.c index a75d45850d43..d66de71182c8 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.c +++ b/ArmPkg/Library/SemihostLib/SemihostLib.c @@ -44,7 +44,7 @@ SemihostFileOpen ( OpenBlock.Mode =3D Mode; OpenBlock.NameLength =3D AsciiStrLen(FileName); - Result =3D Semihost_SYS_OPEN(&OpenBlock); + Result =3D SEMIHOST_SYS_OPEN (&OpenBlock); if (Result =3D=3D -1) { return RETURN_NOT_FOUND; @@ -66,7 +66,7 @@ SemihostFileSeek ( SeekBlock.Handle =3D FileHandle; SeekBlock.Location =3D Offset; - Result =3D Semihost_SYS_SEEK(&SeekBlock); + Result =3D SEMIHOST_SYS_SEEK (&SeekBlock); // Semihosting does not behave as documented. It returns the offset on // success. @@ -95,7 +95,7 @@ SemihostFileRead ( ReadBlock.Buffer =3D Buffer; ReadBlock.Length =3D *Length; - Result =3D Semihost_SYS_READ(&ReadBlock); + Result =3D SEMIHOST_SYS_READ (&ReadBlock); if ((*Length !=3D 0) && (Result =3D=3D *Length)) { return RETURN_ABORTED; @@ -122,7 +122,7 @@ SemihostFileWrite ( WriteBlock.Buffer =3D Buffer; WriteBlock.Length =3D *Length; - *Length =3D Semihost_SYS_WRITE(&WriteBlock); + *Length =3D SEMIHOST_SYS_WRITE (&WriteBlock); if (*Length !=3D 0) return RETURN_ABORTED; @@ -135,7 +135,7 @@ SemihostFileClose ( IN UINTN FileHandle ) { - if (Semihost_SYS_CLOSE (&FileHandle) =3D=3D -1) { + if (SEMIHOST_SYS_CLOSE (&FileHandle) =3D=3D -1) { return RETURN_INVALID_PARAMETER; } else { return RETURN_SUCCESS; @@ -154,7 +154,7 @@ SemihostFileLength ( return RETURN_INVALID_PARAMETER; } - Result =3D Semihost_SYS_FLEN(&FileHandle); + Result =3D SEMIHOST_SYS_FLEN (&FileHandle); if (Result =3D=3D -1) { return RETURN_ABORTED; @@ -195,7 +195,7 @@ SemihostFileTmpName( TmpNameBlock.Identifier =3D Identifier; TmpNameBlock.Length =3D Length; - Result =3D Semihost_SYS_TMPNAME (&TmpNameBlock); + Result =3D SEMIHOST_SYS_TMPNAME (&TmpNameBlock); if (Result !=3D 0) { return RETURN_ABORTED; @@ -220,7 +220,7 @@ SemihostFileRemove ( RemoveBlock.FileName =3D FileName; RemoveBlock.NameLength =3D AsciiStrLen(FileName); - Result =3D Semihost_SYS_REMOVE(&RemoveBlock); + Result =3D SEMIHOST_SYS_REMOVE (&RemoveBlock); if (Result =3D=3D 0) { return RETURN_SUCCESS; @@ -258,7 +258,7 @@ SemihostFileRename( RenameBlock.NewFileName =3D NewFileName; RenameBlock.NewFileNameLength =3D AsciiStrLen (NewFileName); - Result =3D Semihost_SYS_RENAME (&RenameBlock); + Result =3D SEMIHOST_SYS_RENAME (&RenameBlock); if (Result !=3D 0) { return RETURN_ABORTED; @@ -272,7 +272,7 @@ SemihostReadCharacter ( VOID ) { - return Semihost_SYS_READC(); + return SEMIHOST_SYS_READC (); } VOID @@ -280,7 +280,7 @@ SemihostWriteCharacter ( IN CHAR8 Character ) { - Semihost_SYS_WRITEC(&Character); + SEMIHOST_SYS_WRITEC (&Character); } VOID @@ -288,7 +288,7 @@ SemihostWriteString ( IN CHAR8 *String ) { - Semihost_SYS_WRITE0(String); + SEMIHOST_SYS_WRITE0 (String); } UINT32 @@ -301,5 +301,5 @@ SemihostSystem ( SystemBlock.CommandLine =3D CommandLine; SystemBlock.CommandLength =3D AsciiStrLen(CommandLine); - return Semihost_SYS_SYSTEM(&SystemBlock); + return SEMIHOST_SYS_SYSTEM (&SystemBlock); } diff --git a/ArmPkg/Library/SemihostLib/SemihostPrivate.h b/ArmPkg/Library/= SemihostLib/SemihostPrivate.h index 8d1fc6d6eb5a..30103b04b53f 100644 --- a/ArmPkg/Library/SemihostLib/SemihostPrivate.h +++ b/ArmPkg/Library/SemihostLib/SemihostPrivate.h @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2013 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -151,19 +151,19 @@ _Semihost_SYS_SYSTEM( IN SEMIHOST_SYSTEM_BLOCK *SystemBlock ); -#define Semihost_SYS_OPEN(OpenBlock) _Semihost_SYS_OPEN(0x01, OpenB= lock) -#define Semihost_SYS_CLOSE(Handle) _Semihost_SYS_CLOSE(0x02, Hand= le) -#define Semihost_SYS_WRITE0(String) _Semihost_SYS_WRITE0(0x04, Str= ing) -#define Semihost_SYS_WRITEC(Character) _Semihost_SYS_WRITEC(0x03, Cha= racter) -#define Semihost_SYS_WRITE(WriteBlock) _Semihost_SYS_WRITE(0x05, Writ= eBlock) -#define Semihost_SYS_READ(ReadBlock) _Semihost_SYS_READ(0x06, ReadB= lock) -#define Semihost_SYS_READC() _Semihost_SYS_READC(0x07, 0) -#define Semihost_SYS_SEEK(SeekBlock) _Semihost_SYS_SEEK(0x0A, SeekB= lock) -#define Semihost_SYS_FLEN(Handle) _Semihost_SYS_FLEN(0x0C, Handl= e) -#define Semihost_SYS_TMPNAME(TmpNameBlock) _Semihost_SYS_TMPNAME(0x0D, Tm= pNameBlock) -#define Semihost_SYS_REMOVE(RemoveBlock) _Semihost_SYS_REMOVE(0x0E, Rem= oveBlock) -#define Semihost_SYS_RENAME(RenameBlock) _Semihost_SYS_RENAME(0x0F, Ren= ameBlock) -#define Semihost_SYS_SYSTEM(SystemBlock) _Semihost_SYS_SYSTEM(0x12, Sys= temBlock) +#define SEMIHOST_SYS_OPEN(OpenBlock) _Semihost_SYS_OPEN(0x01, OpenB= lock) +#define SEMIHOST_SYS_CLOSE(Handle) _Semihost_SYS_CLOSE(0x02, Hand= le) +#define SEMIHOST_SYS_WRITE0(String) _Semihost_SYS_WRITE0(0x04, Str= ing) +#define SEMIHOST_SYS_WRITEC(Character) _Semihost_SYS_WRITEC(0x03, Cha= racter) +#define SEMIHOST_SYS_WRITE(WriteBlock) _Semihost_SYS_WRITE(0x05, Writ= eBlock) +#define SEMIHOST_SYS_READ(ReadBlock) _Semihost_SYS_READ(0x06, ReadB= lock) +#define SEMIHOST_SYS_READC() _Semihost_SYS_READC(0x07, 0) +#define SEMIHOST_SYS_SEEK(SeekBlock) _Semihost_SYS_SEEK(0x0A, SeekB= lock) +#define SEMIHOST_SYS_FLEN(Handle) _Semihost_SYS_FLEN(0x0C, Handl= e) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) _Semihost_SYS_TMPNAME(0x0D, Tm= pNameBlock) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) _Semihost_SYS_REMOVE(0x0E, Rem= oveBlock) +#define SEMIHOST_SYS_RENAME(RenameBlock) _Semihost_SYS_RENAME(0x0F, Ren= ameBlock) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) _Semihost_SYS_SYSTEM(0x12, Sys= temBlock) #elif defined(__GNUC__) // __CC_ARM @@ -175,37 +175,37 @@ GccSemihostCall ( IN UINTN SystemBlockAddress ); // __attribute__ ((interrupt ("SVC"))); -#define Semihost_SYS_OPEN(OpenBlock) GccSemihostCall(0x01, (UINTN)(= OpenBlock)) -#define Semihost_SYS_CLOSE(Handle) GccSemihostCall(0x02, (UINTN)(= Handle)) -#define Semihost_SYS_WRITE0(String) GccSemihostCall(0x04, (UINTN)(= String)) -#define Semihost_SYS_WRITEC(Character) GccSemihostCall(0x03, (UINTN)(= Character)) -#define Semihost_SYS_WRITE(WriteBlock) GccSemihostCall(0x05, (UINTN)(= WriteBlock)) -#define Semihost_SYS_READ(ReadBlock) GccSemihostCall(0x06, (UINTN)(= ReadBlock)) -#define Semihost_SYS_READC() GccSemihostCall(0x07, (UINTN)(= 0)) -#define Semihost_SYS_SEEK(SeekBlock) GccSemihostCall(0x0A, (UINTN)(= SeekBlock)) -#define Semihost_SYS_FLEN(Handle) GccSemihostCall(0x0C, (UINTN)(= Handle)) -#define Semihost_SYS_TMPNAME(TmpNameBlock) GccSemihostCall(0x0D, (UINTN)(= TmpNameBlock)) -#define Semihost_SYS_REMOVE(RemoveBlock) GccSemihostCall(0x0E, (UINTN)(= RemoveBlock)) -#define Semihost_SYS_RENAME(RenameBlock) GccSemihostCall(0x0F, (UINTN)(= RenameBlock)) -#define Semihost_SYS_SYSTEM(SystemBlock) GccSemihostCall(0x12, (UINTN)(= SystemBlock)) +#define SEMIHOST_SYS_OPEN(OpenBlock) GccSemihostCall(0x01, (UINTN)(= OpenBlock)) +#define SEMIHOST_SYS_CLOSE(Handle) GccSemihostCall(0x02, (UINTN)(= Handle)) +#define SEMIHOST_SYS_WRITE0(String) GccSemihostCall(0x04, (UINTN)(= String)) +#define SEMIHOST_SYS_WRITEC(Character) GccSemihostCall(0x03, (UINTN)(= Character)) +#define SEMIHOST_SYS_WRITE(WriteBlock) GccSemihostCall(0x05, (UINTN)(= WriteBlock)) +#define SEMIHOST_SYS_READ(ReadBlock) GccSemihostCall(0x06, (UINTN)(= ReadBlock)) +#define SEMIHOST_SYS_READC() GccSemihostCall(0x07, (UINTN)(= 0)) +#define SEMIHOST_SYS_SEEK(SeekBlock) GccSemihostCall(0x0A, (UINTN)(= SeekBlock)) +#define SEMIHOST_SYS_FLEN(Handle) GccSemihostCall(0x0C, (UINTN)(= Handle)) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) GccSemihostCall(0x0D, (UINTN)(= TmpNameBlock)) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) GccSemihostCall(0x0E, (UINTN)(= RemoveBlock)) +#define SEMIHOST_SYS_RENAME(RenameBlock) GccSemihostCall(0x0F, (UINTN)(= RenameBlock)) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) GccSemihostCall(0x12, (UINTN)(= SystemBlock)) #else // __CC_ARM #define SEMIHOST_SUPPORTED FALSE -#define Semihost_SYS_OPEN(OpenBlock) (-1) -#define Semihost_SYS_CLOSE(Handle) (-1) -#define Semihost_SYS_WRITE0(String) -#define Semihost_SYS_WRITEC(Character) -#define Semihost_SYS_WRITE(WriteBlock) (0) -#define Semihost_SYS_READ(ReadBlock) ((ReadBlock)->Length) -#define Semihost_SYS_READC() ('x') -#define Semihost_SYS_SEEK(SeekBlock) (-1) -#define Semihost_SYS_FLEN(Handle) (-1) -#define Semihost_SYS_TMPNAME(TmpNameBlock) (-1) -#define Semihost_SYS_REMOVE(RemoveBlock) (-1) -#define Semihost_SYS_RENAME(RenameBlock) (-1) -#define Semihost_SYS_SYSTEM(SystemBlock) (-1) +#define SEMIHOST_SYS_OPEN(OpenBlock) (-1) +#define SEMIHOST_SYS_CLOSE(Handle) (-1) +#define SEMIHOST_SYS_WRITE0(String) +#define SEMIHOST_SYS_WRITEC(Character) +#define SEMIHOST_SYS_WRITE(WriteBlock) (0) +#define SEMIHOST_SYS_READ(ReadBlock) ((ReadBlock)->Length) +#define SEMIHOST_SYS_READC() ('x') +#define SEMIHOST_SYS_SEEK(SeekBlock) (-1) +#define SEMIHOST_SYS_FLEN(Handle) (-1) +#define SEMIHOST_SYS_TMPNAME(TmpNameBlock) (-1) +#define SEMIHOST_SYS_REMOVE(RemoveBlock) (-1) +#define SEMIHOST_SYS_RENAME(RenameBlock) (-1) +#define SEMIHOST_SYS_SYSTEM(SystemBlock) (-1) #endif // __CC_ARM -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70616): https://edk2.groups.io/g/devel/message/70616 Mute This Topic: https://groups.io/mt/80000372/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70619+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70619+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222712; cv=none; d=zohomail.com; s=zohoarc; b=MAqTfsCb1r6uZu0LEIal2qcn1zfWq10bDjoCkmw6zH/0m1qw+lSsjjTDB1jqcIXRZdRJLgmlnrtCt6+ldywhdQJSLdw4fP3UKlASxxcdytVjt4PaAtaBtBJ9OwuTMCSGFagepeFLzqF6f331wrei2O3Oso9wrBWvFdrlga6YTLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222712; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Fsxf06k7JDP7Ov8rLfVwRrqSK9c6xk/722qJCeXMqvs=; b=MRbNzm7JPtDnHpsvzoGUTcINpQipP98ReXSgkQ855STfsuT/5Il9T0V05jDgV10cpN1wuMeKOXwsdd8OJkvlP4UXTxP+yWBAgOzPOuPM8jriaGmuX7O/VniJy5brJdDT6wBQCpZFW82+ab7tGoZpdp+DfofjgiZUPRcFAkrvLas= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70619+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161122271295576.56174018731053; Thu, 21 Jan 2021 01:51:52 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jEzoYY1788612xf7oSB5pl1l; Thu, 21 Jan 2021 01:51:52 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4969.1611222706522760486 for ; Thu, 21 Jan 2021 01:51:46 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6217C152F; Thu, 21 Jan 2021 01:51:41 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2736B3F719; Thu, 21 Jan 2021 01:51:39 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 03/27] ArmPkg: Fix Ecc error 8001 in Chipset Date: Thu, 21 Jan 2021 09:50:55 +0000 Message-Id: <20210121095119.22143-4-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: MpMQKx1QDdWJ5747uBSVeEY2x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222712; bh=DOTEsOTjkKMeyjyQYdee3RWP7Nv9+FBxW7hSP3p1vX0=; h=Cc:Date:From:Reply-To:Subject:To; b=D+odl8UJVNlN9w9wHTkFfS8S6Jr9zxpLKCvAUB1JfaedxeVyxWVMifBujBbZWQb2gQk Sldp037qB2rPliRjtq6Eo3qaylfVtyV5amSeNorfDj4wSDitH6+eO7aizgVk4K5lcIBYJ 3IOLTJHKeD53nuRe+DbIP5jWhfoHyivPhqY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Include/Chipset/AArch64Mmu.h | 4 ++-- ArmPkg/Include/Chipset/ArmCortexA5x.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Include/Chipset/AArch64Mmu.h b/ArmPkg/Include/Chipset/A= Arch64Mmu.h index 606fe7420d67..6c7ada16b18a 100644 --- a/ArmPkg/Include/Chipset/AArch64Mmu.h +++ b/ArmPkg/Include/Chipset/AArch64Mmu.h @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2013, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -190,7 +190,7 @@ // The value written to the T*SZ fields are defined as 2^(64-T*SZ). So a 3= 9Bit // Virtual address range for 512GB of virtual space sets T*SZ to 25 -#define INPUT_ADDRESS_SIZE_TO_TxSZ(a) (64 - a) +#define INPUT_ADDRESS_SIZE_TO_TXSZ(a) (64 - a) // Uses LPAE Page Table format diff --git a/ArmPkg/Include/Chipset/ArmCortexA5x.h b/ArmPkg/Include/Chipset= /ArmCortexA5x.h index 2661ed8c0182..2cce9f7e2bbb 100644 --- a/ArmPkg/Include/Chipset/ArmCortexA5x.h +++ b/ArmPkg/Include/Chipset/ArmCortexA5x.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2012-2014, ARM Limited. All rights reserved. + Copyright (c) 2012 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70619): https://edk2.groups.io/g/devel/message/70619 Mute This Topic: https://groups.io/mt/80000375/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70622+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70622+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222714; cv=none; d=zohomail.com; s=zohoarc; b=YbylGcj5wgE2DK98aDW3O1zTztnJ2aD8bjsYyYqQOqYZ54IAi6z4mDb9k3S+msEkT3IOK+T6DXVPDBhaZPbxFciTNU5obmnMDguFeoLUMBwy7t0dE0SGHYc+5t6o4xeXf8UtXIqi4ScogCOYPH6JYyy1q/bAYMkMhz7vp1Cof8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222714; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ytY3hBg5yeN2Ns4rKuFN0v1JjErlBrNhDwwCPhAsLXk=; b=QsM6nloaZ9cUqGid4BjYzBAyQ+OZDV3bMPiA5+J3aL2umLAZy0byGCB/L6i666FSfej/Lg9ovWOdUBPU4/OwdzLBJF4huIioBpsmT8YdjomZX2WgNY6n0G5kLOMm3G7mW6QnPCx+SNkqkt7ZZXuk/O4GO7mxdfls6VriQ147ALQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70622+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222714613729.4918046335723; Thu, 21 Jan 2021 01:51:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id rEDzYY1788612xGhdKyVRn3d; Thu, 21 Jan 2021 01:51:54 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.4953.1611222708226325831 for ; Thu, 21 Jan 2021 01:51:48 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E53E6153B; Thu, 21 Jan 2021 01:51:42 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AA1C53F719; Thu, 21 Jan 2021 01:51:41 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 04/27] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib Date: Thu, 21 Jan 2021 09:50:56 +0000 Message-Id: <20210121095119.22143-5-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 4g9WUsAxlw5mH1y74hTbKLTEx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222714; bh=61Mub6iwy8n3r03QPrm4R4YZGXi8+t6Ysb06QLtEOYM=; h=Cc:Date:From:Reply-To:Subject:To; b=lrFQDJLhRikXnTDw9y1X5YAnzZFJ2bZ3/Rm9rayH89RDKoAvNdX06V/Mry/T8wD3uk7 nup3+I8FW+xL8jrG1yWmScfIpcZKt04jwXwg+kTUB0rz22MGZlK9ogsI1m7MIWKkB2RVK NO0dJmbMD7Vp/QrL0LDSTwIMSu+Zgr0tkdE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c b/ArmPkg/Libr= ary/ArmArchTimerLib/ArmArchTimerLib.c index 24d9dae4e660..875c835706d6 100644 --- a/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c +++ b/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c @@ -1,7 +1,7 @@ /** @file Generic ARM implementation of TimerLib.h - Copyright (c) 2011-2016, ARM Limited. All rights reserved. + Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -20,9 +20,9 @@ // Select appropriate multiply function for platform architecture. #ifdef MDE_CPU_ARM -#define MultU64xN MultU64x32 +#define MULT_U64_X_N MultU64x32 #else -#define MultU64xN MultU64x64 +#define MULT_U64_X_N MultU64x64 #endif @@ -121,7 +121,7 @@ MicroSecondDelay ( // =3D MicroSeconds x TICKS_PER_MICRO_SEC // =3D MicroSeconds x Frequency.10^-6 TimerTicks64 =3D DivU64x32 ( - MultU64xN ( + MULT_U64_X_N ( MicroSeconds, GetPlatformTimerFreq () ), @@ -263,7 +263,7 @@ GetTimeInNanoSecond ( // Time =3D --------- x 1,000,000,000 // Frequency // - NanoSeconds =3D MultU64xN ( + NanoSeconds =3D MULT_U64_X_N ( DivU64x32Remainder ( Ticks, TimerFreq, @@ -276,7 +276,7 @@ GetTimeInNanoSecond ( // will not overflow 64-bit. // NanoSeconds +=3D DivU64x32 ( - MultU64xN ( + MULT_U64_X_N ( (UINT64) Remainder, 1000000000U), TimerFreq -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70622): https://edk2.groups.io/g/devel/message/70622 Mute This Topic: https://groups.io/mt/80000378/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70617+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70617+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222711; cv=none; d=zohomail.com; s=zohoarc; b=bHeUGeKuhjKyEe7AbdN/Juf0ya7C0z4+rzWFktskKemrJiVFdL9ue6quBMc1CfhdwYjbIjK0v9BQbO/xDOIBLe+2AZB0CF+6CMnwHpUaFOBQY8cvXGwRWcDR5TvCGAXc+bL/iYad0ZeUCutFZhSoK/+prgWBQLEkW4qRZsHIskM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222711; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=1zOyyoWhPUQGjFmmF7cYK5wapm1VQGWCgtTpBUDix7A=; b=dxRL9g/WqocXQ7tsOkis6tsA1zHvxRmbHniuyNyOB3bGTP0DpP+/5148MXZ1fpye0PwPLX3f6SjQQ+zDVMiZ8f1+WpF8FYKJtcr3at3LLJvrV9BtpScYZSbPg1JQM5Jwqq+K2ghbaRpii9w6izgI34nKw/rcMbuFLFmmVORt0Wk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70617+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222711785782.0977563563309; Thu, 21 Jan 2021 01:51:51 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id PVTqYY1788612x7tPY3v8uON; Thu, 21 Jan 2021 01:51:51 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.5041.1611222705954321043 for ; Thu, 21 Jan 2021 01:51:46 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CEC21570; Thu, 21 Jan 2021 01:51:44 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 531303F719; Thu, 21 Jan 2021 01:51:43 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 05/27] ArmPkg: Fix Ecc error 9005 in CpuDxe Date: Thu, 21 Jan 2021 09:50:57 +0000 Message-Id: <20210121095119.22143-6-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: DPWSwowdh7t7aUa90JjTg4Twx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222711; bh=7Vv++cyx68SkNK5+v/6/ItvEmF4IXMNLrjEkQ4dY+7A=; h=Cc:Date:From:Reply-To:Subject:To; b=bk/n4+HkACkEsWN76eWjsPBCWkzIiPB4hnIVGZynB9hs+Ru2gAV67aPJzbq57cGHyxP hmzzVLCWF2L87SNcV98FtnmchiMtXlx6rzne+AFmcRlX/m9nESCgz1dbXxIaRqrqDBrO2 w/Pj/gMP3eK8jibKv81yDNYlBdcvHmzCP7E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@param', '@post', '@pre', '@retval', '@return', '@sa', '@since', '@test', '@note', '@par', '@endcode', '@code', '@{', '@}' are allowed to mark the code This patch removes the ":" character following the "@param" doxygen command. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/CpuDxe/CpuMpCore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c b/ArmPkg/Drivers/CpuDxe/CpuM= pCore.c index d16ae3979207..8a9e8c2fa3a2 100644 --- a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c +++ b/ArmPkg/Drivers/CpuDxe/CpuMpCore.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -32,7 +32,7 @@ ARM_PROCESSOR_TABLE mArmProcessorTableTemplate =3D { }; /** Publish ARM Processor Data table in UEFI SYSTEM Table. - * @param: HobStart Pointer to the beginning of the HOB Lis= t from PEI. + * @param HobStart Pointer to the beginning of the HOB List= from PEI. * * Description : This function iterates through HOB list and finds ARM pro= cessor Table Entry HOB. * If the ARM processor Table Entry HOB is found, the HOB d= ata is copied to run-time memory -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70617): https://edk2.groups.io/g/devel/message/70617 Mute This Topic: https://groups.io/mt/80000373/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70618+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70618+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222712; cv=none; d=zohomail.com; s=zohoarc; b=G/ZpJgTVyH7XbQfLIdHch4QQ/8QTzyS8sIhSrT9t74Tbw6Mh4RgdCX16ct7VBjODX+VTVW8Q4FBdjDX1ya5zdyzWqPjJAkwUlQBMW5+Um0kW9uv6GqrI4NiCpXZZ8ak+XvROE9DOvYHENy51lLRDM36X07p3r+WE+/bG3x+2GWU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222712; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=HaOaAzvaz9tS9ohlWOD6xcLh37gL9j0z3aTP4fpql7I=; b=h/mUsdPsUibP0LPmme7R91q/MbTIFrhtCNeXIT1z+q2XODFkvrV7D0Or2h5zOF79YjcuSRrFVi43SZJRwUEj/x6V4wgg+3AF35fsCEgzeEn6Ssm1Mg3z1phPSUN7gI9+lWYl/TAa0wHQJ2vyEBnmtPOBRnslv/Rnt5R3m0ysp6Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70618+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222712258156.8428662317108; Thu, 21 Jan 2021 01:51:52 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0qe4YY1788612xZNMV58Hofb; Thu, 21 Jan 2021 01:51:51 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.5070.1611222706326127283 for ; Thu, 21 Jan 2021 01:51:46 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 02AA4152D; Thu, 21 Jan 2021 01:51:46 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D048F3F719; Thu, 21 Jan 2021 01:51:44 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 06/27] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc Date: Thu, 21 Jan 2021 09:50:58 +0000 Message-Id: <20210121095119.22143-7-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: OCBm0ypzJnNDojls6E0dAceBx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222711; bh=w15bhrm0oFThkn7kpqyhKFh8wcF18xzYLZfz5MzXv3U=; h=Cc:Date:From:Reply-To:Subject:To; b=OonbRQ3PTGuJtn6amA5o9re3FBzsa2l5HXEpoJiriwJbMEPZHZVuJPpfDYSRYWTCp2/ R1cacRG3tZ47yTPWtfaprJ8i5pb/c8KqkTlU0hodyUXSCkD3t9ogUTSJr2F/+alzeho6E 1a8kDBCRvjUwZ6Q96v/bCtbvQ8sU7qxDFqI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no unnecessary inclusion of library classes in the INF file This comes with the additional information: The Library Class [BootLogoLib] is not used in any platform The Library Class [DxeServicesLib] is not used in any platform The Library Class [UefiBootManagerLib] is not used in any platform The Library Class [PeCoffExtraActionLib] is not used in any platform ArmPkg/ArmPkg.dsc builds the modules requiring thses libraries, but doesn't build the required libraries. This patch adds the missing libraries to the [LibraryClasses.common] section. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/ArmPkg.dsc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index 48059cf38ed3..ddab84f92165 100644 --- a/ArmPkg/ArmPkg.dsc +++ b/ArmPkg/ArmPkg.dsc @@ -2,7 +2,7 @@ # ARM processor package. # # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
# Copyright (c) 2016, Linaro Ltd. All rights reserved.
# Copyright (c) Microsoft Corporation.
# @@ -35,14 +35,17 @@ [PcdsFixedAtBuild] [LibraryClasses.common] BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMainte= nanceLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManag= erLib.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf UefiLib|MdePkg/Library/UefiLib/UefiLib.inf @@ -50,6 +53,7 @@ [LibraryClasses.common] UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeC= offGetEntryPointLib.inf + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServic= esLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70618): https://edk2.groups.io/g/devel/message/70618 Mute This Topic: https://groups.io/mt/80000374/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70621+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70621+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222719; cv=none; d=zohomail.com; s=zohoarc; b=Pmsdo4Hry4jjT63q3lbhbgdLQZOvXVwmoXnydxfMHjtdmZGPmCWH4GAMUGaa5tF/cIxAULMEw5C3FyDQtepY3x9eRPfp1yiVcdEY4FssXVCsDZqt4hNRIHL8NEsFf2TvBgCRc3Od7WY5tKhyXauXWUVwYX+1idnClRjks9cuO4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222719; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZWNbCybc0st4MPE8Ye61I4ltQiyj2IjpdQ6YWL9tBjI=; b=lWMQGtFQT071S2lUbVPVa35vEXfU9tMb6W2vNloVXPZTocZGD3VzKrDqSv9fX3sul2WBqm2rs63OF1GpH5CoCKwxr1UX7imGdJiIh2xXxoGcGEecyTH+qR03CClgS7cQIUymjkWUZEiVFqquRPfWM9hHpLIGfwiO5+GdxAtUkPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70621+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222719110120.54661389087585; Thu, 21 Jan 2021 01:51:59 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FRSFYY1788612xLDRSQEbmWF; Thu, 21 Jan 2021 01:51:58 -0800 X-Received: from foss.arm.com (foss.arm.com []) by mx.groups.io with SMTP id smtpd.web09.5041.1611222705954321043 for ; Thu, 21 Jan 2021 01:51:48 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8584414FF; Thu, 21 Jan 2021 01:51:47 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 53FFA3F719; Thu, 21 Jan 2021 01:51:46 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 07/27] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib Date: Thu, 21 Jan 2021 09:50:59 +0000 Message-Id: <20210121095119.22143-8-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 5ZFZJDihelVcyHug1kuIXi9Lx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222718; bh=9zpge3T3j28/Fm92t9RAD0Xxo/2COa6XzwNN0yT/aKM=; h=Cc:Date:From:Reply-To:Subject:To; b=JFdjgihcTUhQet4YzEHdRWhCzLkm9ovT6M+H7eW8vgotq7WMUSTnZj9Pc+pvF8jnFtX 8YaODllAN6/BhB35WwmPu8hZTwRGBVVxHMxaRSo43gb4u9J8TFWQ/lqQZnkPHBNzDIReW nnZTHoBfPpuByIxXWI9riTB4/P393P/2h8k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Module file has FILE_GUID collision with other module file The two .inf files with clashing GUID are: ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf As ArmMmuBaseLib.inf is older than ArmMmuStandaloneMmLib.inf, it has precedence. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf b/= ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf index 85973687f5ad..0a147fff18c0 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -10,7 +10,7 @@ [Defines] INF_VERSION =3D 0x0001001A BASE_NAME =3D ArmMmuStandaloneMmCoreLib - FILE_GUID =3D da8f0232-fb14-42f0-922c-63104d2c70bd + FILE_GUID =3D 44a741c2-655f-41fc-b066-179f5a9aa78a MODULE_TYPE =3D MM_CORE_STANDALONE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D StandaloneMmMmuLib -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70621): https://edk2.groups.io/g/devel/message/70621 Mute This Topic: https://groups.io/mt/80000377/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70624+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70624+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222710; cv=none; d=zohomail.com; s=zohoarc; b=US6QmLAzVlf8Va1wPpRl9MUTs8TbrfMIt1Z/uHWi7AVMtLlGHUIH0PD6DXZmdruKpCOAD0HZqJ002V5lhyIxZ3QFZwOWcauiQEMOsZVe0A6vZLYFRxdeRWAhb5YQiFO+YFIktw0RuKn8/7T2Lr45VV5wKcSqdGMnxMkE9wztBf4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222710; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=l2g96cCLQnXRZYqjy2vt9lh09mFlZ5+5Ersc1d9IuAs=; b=FDc6JARRrj1z1sfvTjGp8SiUDFELgb0UecsNllcal0W0AFtpGsn1qJyYQdKk5x9JfVuiKg/2Aep7L3fFSTvYqU2MTZZMK1usiHYJop2n3LWyx2/XZl2hBwQLHuPvQrM9UtFBB49Bb48fqG8m8X9ETlOf1Cr5GKV+bqr4i4xvJrQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70624+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222710047260.45614996303675; Thu, 21 Jan 2021 01:51:50 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qxXVYY1788612xAXOkykMTjj; Thu, 21 Jan 2021 01:51:49 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4987.1611222709195886998 for ; Thu, 21 Jan 2021 01:51:49 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCC2C1509; Thu, 21 Jan 2021 01:51:48 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E65AC3F719; Thu, 21 Jan 2021 01:51:47 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 08/27] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe Date: Thu, 21 Jan 2021 09:51:00 +0000 Message-Id: <20210121095119.22143-9-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 6H94brgliUmP7nEGP44EerMvx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222709; bh=0LM7B020MbHff1hGSdoSnFdiCyM44WvbMDogOZWjgRI=; h=Cc:Date:From:Reply-To:Subject:To; b=XSYFP/zLABbiIisTzCRej20f14MmnFo0h2I3KJJN5k8XR1u7K/T7XYDTNWOGZpLi/8C LmQIxxYF/31Yn7ngMhZsfI4EwFSTm9lmpvQTG7EJR2P0aDKnpkU8zvB6tmr9+h9ajCWY4 CjbXW1URyHNM5MePk0hJbYMs7tw2ZOgji4s= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h] [ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h] are existing in module ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf but are not described in INF the file. The patch also re-orders the files in the [Sources.common] section. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf b/ArmPkg/Drivers/ArmS= cmiDxe/ArmScmiDxe.inf index 6cd3aa1c82ec..fc5f841c2b7c 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf +++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017-2018, Arm Limited. All rights reserved. +# Copyright (c) 2017-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -18,11 +18,16 @@ [Defines] ENTRY_POINT =3D ArmScmiDxeEntryPoint [Sources.common] - Scmi.c + ArmScmiBaseProtocolPrivate.h + ArmScmiClockProtocolPrivate.h + ArmScmiPerformanceProtocolPrivate.h ScmiBaseProtocol.c + Scmi.c ScmiClockProtocol.c ScmiDxe.c + ScmiDxe.h ScmiPerformanceProtocol.c + ScmiPrivate.h [Packages] ArmPkg/ArmPkg.dec -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70624): https://edk2.groups.io/g/devel/message/70624 Mute This Topic: https://groups.io/mt/80000380/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70625+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70625+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222711; cv=none; d=zohomail.com; s=zohoarc; b=H2350C+6FpYxprj/Bnlk3wCSPfM/jr8Z21zX9g4mofhMPG+/FGiLcKvdFqCjfpDweynctvB7XpVcW6m4Eeujw5k22EAQ4nxDXG3oCE5i1xApcAZ3IsDXJjOY+BUCvDQRiCCDIYubE3d6YiJ6hc9iLISnx3shjTmaRk9UxrcJ75I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222711; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=FkSWeHBokJoVAvzSPQMkLBCDBit7hm9/5K3w7HzaDgg=; b=k4qWMvde4ud5zlFQSIF2KB7yJbeFGSYyi+LflSb52EkitanY440KE0AnUd0f3mCE4TI723RwZ5zzs/xX/BoU42Dcf3cbmnmTwNBtCJMHNST7E+ne+ZkbIaZT1XbRWnskHGusqevqEpU5SDhdy0riHhlKyU2/KmOLivheQCTNUnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70625+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161122271132596.27080706818117; Thu, 21 Jan 2021 01:51:51 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id M0FyYY1788612x43fVRk3DfJ; Thu, 21 Jan 2021 01:51:51 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.5042.1611222710434801725 for ; Thu, 21 Jan 2021 01:51:50 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 258E614FF; Thu, 21 Jan 2021 01:51:50 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1A36D3F719; Thu, 21 Jan 2021 01:51:48 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 09/27] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe Date: Thu, 21 Jan 2021 09:51:01 +0000 Message-Id: <20210121095119.22143-10-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: qNYbLb6ORQZyfSt7Ye2rHU0px1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222711; bh=baMuZ/nCnePTlSu01efu7nFI3JCp+gmV3yLqvXatHzQ=; h=Cc:Date:From:Reply-To:Subject:To; b=Rzr3Tq8tb0QUiBzWJTkk/gUStA569lVBhX4BuMAIAKB3m5EQ71i20kgHGuZNQk+/cGd uFVYpQjuLkFEAWjkkCg59D00myKD1a2VCop+0yfoBc/R8KL5EN0xSgVke9v+x9+uV+Nxm fAtG1eG5TXk0g8sWQVbQzUXyJ9gVCq5cqiQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h] is existing in module ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf but is not described in the INF file. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf b/Arm= Pkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf index d725a2c85839..7dbd30783892 100644 --- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf +++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2017, ARM Limited. All rights reserved. +# Copyright (c) 2013-2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -13,6 +13,7 @@ [Defines] ENTRY_POINT =3D GenericWatchdogEntry [Sources.common] + GenericWatchdog.h GenericWatchdogDxe.c [Packages] -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70625): https://edk2.groups.io/g/devel/message/70625 Mute This Topic: https://groups.io/mt/80000381/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70626+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70626+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222713; cv=none; d=zohomail.com; s=zohoarc; b=IyJniwIZJj3xSdZa16XcavZlGXuosV85e0467kiaMyegSAFQUx3aLROjcBVB0Xz4zoFdliQkPBm77Kl4MNclzHciB0zHhzpBM57FgSbdVtw6mNSkPnr7WHPm5+NdFB/BaFCxDFbmN2SkZB+kyAxoVT7uPBfRyeXgO0Wf2EGMCMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222713; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=dXlM8eXL4P8KL22sAwTd2SmW7zGYKI+cS2L+4Y9d0Os=; b=XoD+PjSvwwiAxOhgstYwjvLNiBbVRWN7PneuEBN/iSXj9+1uk2D3f5R0wy8hTsgNEnzw5SLlEHjfEQk/fqvhUM7I9pzt5bXNzE6cNo6LMd8QyjGCZMovyLNTrccts9SNF+gOkXA2fkbXly1DjtLOg9gky/qzpYQ29NM+1T1rPP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70626+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222713370232.08058728829758; Thu, 21 Jan 2021 01:51:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DUQOYY1788612xU3fI9GJipe; Thu, 21 Jan 2021 01:51:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.5071.1611222711755439947 for ; Thu, 21 Jan 2021 01:51:51 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72CE91509; Thu, 21 Jan 2021 01:51:51 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 677853F719; Thu, 21 Jan 2021 01:51:50 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 10/27] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe Date: Thu, 21 Jan 2021 09:51:02 +0000 Message-Id: <20210121095119.22143-11-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: KNGe7rfPCMOd7puBoVtpPxiGx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222713; bh=qs2tbZXYUmLO+gnTLl/+GYO5Q30rHLmRAcPobJPYPh8=; h=Cc:Date:From:Reply-To:Subject:To; b=T3iVyeZwg4KKSEQHjZ3lLLfjPUzNQU39t8odzdqpc7jkQ59QaX0M+OajB0sWionh4Ru 8PMVzHg14Y6+CWf9d64bq8TOSQyiObhrkhq5C8UJMMBBgHrbaSdQsNZWz6R0+iMXXV13Q Y3IdpFj2vF1Ca1uY3+NFE0qQu8xYyfLZi1g= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h] is existing in module ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf but is not described in the INF file. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf b/ArmPkg= /Drivers/MmCommunicationDxe/MmCommunication.inf index 2465fb77c58e..05b6de73ff34 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf @@ -2,7 +2,7 @@ # # DXE MM Communicate driver # -# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. +# Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +24,7 @@ [Defines] # [Sources.AARCH64] + MmCommunicate.h MmCommunication.c [Packages] -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70626): https://edk2.groups.io/g/devel/message/70626 Mute This Topic: https://groups.io/mt/80000383/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70627+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70627+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222714; cv=none; d=zohomail.com; s=zohoarc; b=gyTm1xQfqow4mCUIZmHy1MAE3vxf2xojXll+V0RNCWSYt5Tp37VMMGq3R27Px5Zx2MV+wKWBS+YStiNbRPaHWbv+W4YQaomlJH1g56CW5ZAu920LpTkLRtHTTN9J4ESpCr2E5H0eRhGs5CWJpV0+ucOCBqfSsP1o8T666eFNf58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222714; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=0Pqo8gk6c1b5oabBFJ3C3FqhV5TDLDZ7SYVS4wZoJX4=; b=UPqnvGHud/7pd5vb0Nfbyg/gkW9Mrkkfn9VjfQQJqZtSAta5yTbQpilyZvPJakW8C4VAy/ao+2TrPFQXmvOMHCC9i2dxQiFzpceXZW8zY+z7vWAdtnBEYgebv8UGZbojMZIqVdUWM/7Q4qfo5UaA9GvcZaA2GaHaaBhjkJcagoA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70627+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222714178318.3563249129602; Thu, 21 Jan 2021 01:51:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id oHqhYY1788612xpR87S6REaA; Thu, 21 Jan 2021 01:51:53 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4989.1611222713115646516 for ; Thu, 21 Jan 2021 01:51:53 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D50E714FF; Thu, 21 Jan 2021 01:51:52 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B902E3F719; Thu, 21 Jan 2021 01:51:51 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 11/27] ArmPkg: Fix Ecc error 10014 in SemihostLib Date: Thu, 21 Jan 2021 09:51:03 +0000 Message-Id: <20210121095119.22143-12-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: vcJcfXS9cdqqVf21zdvLhSxWx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222713; bh=ZLAQozHErpUSfZ8XNakMliun1x6vya+gCx3snO4DVTw=; h=Cc:Date:From:Reply-To:Subject:To; b=PM8b4BgvWgB0NzisqydnqP8Oon4tIRBVVTmPC/SIU8iz97XlvoljQYjaBHwFS5f9Wia 53niE9sns/ITyclz8CEHiTRvZIf9Euv6y10ocGxobqRCeGDk895adCBn3jS5NU6iTQ7CL +LAValnU5OVpBVFLAoPYGEYnzVfX9PQTfgc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Library/SemihostLib/SemihostPrivate.h] is existing in module ArmPkg/Library/SemihostLib/SemihostLib.inf but is not described in the INF file. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Library/SemihostLib/SemihostLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.inf b/ArmPkg/Library/Se= mihostLib/SemihostLib.inf index a46618d30eef..2a4409f6573b 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.inf +++ b/ArmPkg/Library/SemihostLib/SemihostLib.inf @@ -2,7 +2,7 @@ # Semihosting JTAG lib # # Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2021, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -25,6 +25,7 @@ [Defines] # [Sources.common] SemihostLib.c + SemihostPrivate.h [Sources.ARM] Arm/GccSemihost.S | GCC -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70627): https://edk2.groups.io/g/devel/message/70627 Mute This Topic: https://groups.io/mt/80000384/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70628+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70628+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222720; cv=none; d=zohomail.com; s=zohoarc; b=hNnhpXGB2UIw/qqoOZQE3YubfGGOkAettazj5/PbnHvU1YECyrU1RgaebgAfZyYU8YpB2asX3pCl0aqGrfPOvUHzS31WUZ7CVPRzlPhlPSVXhPVsa82TbQxBqwW8PLjzvmqRoy0zv6ggaEM7QbJBDmA4DsJDi8OaOQXp0xpvH4o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222720; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=wUY5ZYD0bdzdygleivomW54/2T1Pjl3VpyV0g0HVePw=; b=cuQSUwFfBuRIJA3LcKQfVCzUxRtvXF+JDrRWTWbd9lwwmiz9ypY62iQwyI/+UGzwRLEYpP0kTOMjDXHsidUQC/sKKNiFg1Iznq/Hgce2acxv6LORKTQTlDvVeh4Bn+QoVWALHl84xqnGQrmPN0Q+5L0hqo2VHH2/xtzMlV37Tzw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70628+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222720567816.0762475179595; Thu, 21 Jan 2021 01:52:00 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9QWkYY1788612xJ2IYwAwc04; Thu, 21 Jan 2021 01:52:00 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.4956.1611222714761150020 for ; Thu, 21 Jan 2021 01:51:54 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7CE4914FF; Thu, 21 Jan 2021 01:51:54 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 41B423F719; Thu, 21 Jan 2021 01:51:53 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 12/27] ArmPkg: Remove ArmGic/ArmGicSecLib.c Date: Thu, 21 Jan 2021 09:51:04 +0000 Message-Id: <20210121095119.22143-13-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: eb2tbUzbWU6PU38H38f0OPXYx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222720; bh=5X7ZmBiOV53eRmE4mycSeLjdQz+MbhMcbbDsCOQQfyA=; h=Cc:Date:From:Reply-To:Subject:To; b=uQvSWyTgO9y2yTTs4Ssch7Lq00EimbRyA9KKMJFMncAAsWl0kRtFIIniaj3BREoSqHX FpMjTTletSuyaHAz98qfJ52xSyylc/uLaRzVZdYOnWWOy0eRX5nAt7MMbv3mbciFv2XtA ebrXLhv+yoNIcHS7a5+I/X1velcRdRMC1so= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Commit: 142fa386eb907df55c239311cd5fa2d40f5007dd removes the ArmGicSecLib. The file ArmGic/ArmGicSecLib.c was exclusively used by this library. Thus, this file should also be removed. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c | 58 ---------------------------- 1 file changed, 58 deletions(-) delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c diff --git a/ArmPkg/Drivers/ArmGic/ArmGicSecLib.c b/ArmPkg/Drivers/ArmGic/A= rmGicSecLib.c deleted file mode 100644 index 4af98bb6ec93..000000000000 --- a/ArmPkg/Drivers/ArmGic/ArmGicSecLib.c +++ /dev/null @@ -1,58 +0,0 @@ -/** @file -* -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. -* -* SPDX-License-Identifier: BSD-2-Clause-Patent -* -**/ - -#include -#include -#include -#include - -/* - * This function configures the interrupts set by the mask to be secure. - * - */ -VOID -EFIAPI -ArmGicSetSecureInterrupts ( - IN UINTN GicDistributorBase, - IN UINTN* GicSecureInterruptMask, - IN UINTN GicSecureInterruptMaskSize - ) -{ - UINTN Index; - UINT32 InterruptStatus; - - // We must not have more interrupts defined by the mask than the number = of available interrupts - ASSERT(GicSecureInterruptMaskSize <=3D (ArmGicGetMaxNumInterrupts (GicDi= stributorBase) / 32)); - - // Set all the interrupts defined by the mask as Secure - for (Index =3D 0; Index < GicSecureInterruptMaskSize; Index++) { - InterruptStatus =3D MmioRead32 (GicDistributorBase + ARM_GIC_ICDISR + = (Index * 4)); - MmioWrite32 (GicDistributorBase + ARM_GIC_ICDISR + (Index * 4), Interr= uptStatus & (~GicSecureInterruptMask[Index])); - } -} - -VOID -EFIAPI -ArmGicEnableDistributor ( - IN INTN GicDistributorBase - ) -{ - // Turn on the GIC distributor - MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 1); -} - -VOID -EFIAPI -ArmGicSetupNonSecure ( - IN UINTN MpId, - IN INTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase - ) -{ - ArmGicV2SetupNonSecure (MpId, GicDistributorBase, GicInterruptInterfaceB= ase); -} -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70628): https://edk2.groups.io/g/devel/message/70628 Mute This Topic: https://groups.io/mt/80000385/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70629+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70629+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222717; cv=none; d=zohomail.com; s=zohoarc; b=i9o5II8ue1QDwZpLMNBc88Kuysrcmv7aX2jd9MHeKNvjLfIwwc+2Ixmwy2gHaS79fdWniv+scSVHiIsozXhG/qkMu8NM0mVVQ57JmbRfHh6HsDwd+Tw/gq8fDR4QV0vznfcfhy9yy5PSc2eW2h8RyCZZli0KTOE4m4/x8qf9Axs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222717; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=gJgYQUCDS2VhfXNSTIMXUvIlaapEiGYwsd3EHc2dDYs=; b=TEcN+FVaq0Ng405xZlKsHl24ZjWrgEnC8XccOzmx6nDSvVFsBwyw4FfFu4jgHpNM3zS+4/k5BYTCn+XLedqOvLILWqEa/VSrvZFWVlLwrgnG6hqTnpyC3LmmpOvxrDtODWpnmpJ1S8nYMCjsdR8a8e0vlRHg5BSjrz90dyEa4U4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70629+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222717748320.1003891240274; Thu, 21 Jan 2021 01:51:57 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id RItcYY1788612xgwfzayLN4F; Thu, 21 Jan 2021 01:51:57 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.5043.1611222715897784445 for ; Thu, 21 Jan 2021 01:51:56 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9EFCE1509; Thu, 21 Jan 2021 01:51:55 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BECB13F719; Thu, 21 Jan 2021 01:51:54 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 13/27] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib Date: Thu, 21 Jan 2021 09:51:05 +0000 Message-Id: <20210121095119.22143-14-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: jtzGt0tEysSrWpKXki2UDWQHx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222717; bh=jTC4b43CH6QsfTj1Mf2kQBSjhunluP7ATPyZoNphh6Q=; h=Cc:Date:From:Reply-To:Subject:To; b=GqqknJdrASE2p1PFUkxCbvWoRxBq+oU/9B5+A5qJapHTb4rn3K2iFCyJ2jg3TGMHiMU tsNyg9igQaSkpNFDr9w8jVQ7Cw79rb3nTHyaOHZomu6Q3z2xTzmQWUmGXiSc2bKjEFSzr R7BraRH0IV1dPgiB+ikmOWumYrlAvbAoh80= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Function name should be left justified, followed by the beginning of the parameter list, with the closing parenthesis on its own line, indented two spaces Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 4 +++- ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c b/Ar= mPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c index 514f80a2d47a..fcf3dd16443e 100644 --- a/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c +++ b/ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c @@ -2,6 +2,7 @@ * Exception Handling support specific for AArch64 * * Copyright (c) 2016 HP Development Company, L.P. +* Copyright (c) 2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -27,7 +28,8 @@ RegisterEl0Stack ( IN VOID *Stack ); -RETURN_STATUS ArchVectorConfig( +RETURN_STATUS +ArchVectorConfig ( IN UINTN VectorBaseAddress ) { diff --git a/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c b/ArmPkg/Lib= rary/ArmExceptionLib/Arm/ArmException.c index 36c9f3f92616..40857c7f1faf 100644 --- a/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c +++ b/ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c @@ -2,7 +2,7 @@ * Exception handling support specific for ARM * * Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
-* Copyright (c) 2014, ARM Limited. All rights reserved.
+* Copyright (c) 2014 - 2021, Arm Limited. All rights reserved.
* Copyright (c) 2016 HP Development Company, L.P.
* * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -26,7 +26,8 @@ PHYSICAL_ADDRESS gExceptionVectorAlignmentMask =3D= ARM_VECTOR_TABLE_ALIGNME // NOTE: This code assumes vectors are ARM and not Thumb code UINTN gDebuggerNoHandlerValue =3D 0xEAFFFFFE; -RETURN_STATUS ArchVectorConfig( +RETURN_STATUS +ArchVectorConfig ( IN UINTN VectorBaseAddress ) { -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70629): https://edk2.groups.io/g/devel/message/70629 Mute This Topic: https://groups.io/mt/80000386/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70630+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70630+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222723; cv=none; d=zohomail.com; s=zohoarc; b=kVUwGzAiS12WEiLynRSgAr44rAEaapbZeWgNTfndusnGb9nNEJkY1CEnfE3UcHJt/taCOIJYds2PoJT2lKdjSWC1tomnOalfzcMASge3INKm41YAtCd5vhupou1qWZ4gkxmv47eu+DuuVDL8QENbTwji2ekf/KyvtRu07gYjzWs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222723; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Hg7XR4i/tgypidhna/C8Yxi7FCGijELimfGkKbqJDAE=; b=kP3LteEB5+SWjz3c0eTuzei8QrfnGVm2AIautkSIPKcuncNS1jMOUf8OntpPbIunCiALEbIQ9+FGGslO8vRHwMNRpyQD0e/3f6470pw4dgkt5RzJW2AphhE1W8I8YD2FjjxjjdV/osLM5T8EkHlCZWNdDdMveNZhzN1iLlqghDw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70630+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161122272321765.73220619487381; Thu, 21 Jan 2021 01:52:03 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qn2gYY1788612xoeSeaM3xnj; Thu, 21 Jan 2021 01:52:02 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.4957.1611222717355793228 for ; Thu, 21 Jan 2021 01:51:57 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B42914FF; Thu, 21 Jan 2021 01:51:57 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E14E33F719; Thu, 21 Jan 2021 01:51:55 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 14/27] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe Date: Thu, 21 Jan 2021 09:51:06 +0000 Message-Id: <20210121095119.22143-15-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: nWt8DTwQ5NUa3h1SlmAo5sAEx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222722; bh=5uUbX3/FwSeBw3cPjuifJBy2tp1XH+XgaXZUOGEXNJo=; h=Cc:Date:From:Reply-To:Subject:To; b=csuUsnljZ85NJCoDeX1aUWLPIWeLu9Za6v//jmv+GHmHhTS1qiWlEAJ6vs30/wXPVAO xLHTLjCO1N/kBTGn1TEcBep/Ov5yOeEBP8mNCfvz9dyWfJHKbfmXStiBL7tr1BVote8UW CXMp67bnOYT6nfbu2D8Of8bgZbRfIrZHaPM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. This patch replaces a "#if !defined [...]" statement by a "#ifndef [...]" statement, preventing Ecc to throw an error. Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h b/ArmPkg/Dri= vers/MmCommunicationDxe/MmCommunicate.h index fcc346ba7e3e..32753947e1cb 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h @@ -1,13 +1,13 @@ /** @file - Copyright (c) 2016-2018, ARM Limited. All rights reserved. + Copyright (c) 2016-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ -#if !defined _MM_COMMUNICATE_H_ -#define _MM_COMMUNICATE_H_ +#ifndef MM_COMMUNICATE_H_ +#define MM_COMMUNICATE_H_ #define MM_MAJOR_VER_MASK 0xEFFF0000 #define MM_MINOR_VER_MASK 0x0000FFFF @@ -19,4 +19,4 @@ #define MM_CALLER_MAJOR_VER 0x1UL #define MM_CALLER_MINOR_VER 0x0 -#endif /* _MM_COMMUNICATE_H_ */ +#endif /* MM_COMMUNICATE_H_ */ -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70630): https://edk2.groups.io/g/devel/message/70630 Mute This Topic: https://groups.io/mt/80000387/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70631+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70631+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222719; cv=none; d=zohomail.com; s=zohoarc; b=AFSIXhu0npAmZBERDqFiggmRAGpsR1azGHYgOTjJoRz0xYra/qJAotiJiFzErwhIheVqc3pM1EBkc0B18KgU2p5NFGzsNsa3cfcsHRytu91LjgdQq3flVEh+qihHUhvcxuYhIT9yXWi1GMgMHmGx7IWNz12H74fvp61T0UZwWqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222719; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=XL89Or/SRwAoA532GxIktOaLewIFRGQbfdHrJGHbEz0=; b=VpszhoPR1DWsegkx7Ejmt5UnT700uTTVWrXqp8CfbGA9qC4tQoioBiWtar5YdcWr5nsIn8GvcQENSEZceBidAB0CLqTB0UiwQzLjAHIz1WLgT+w93CioVxzXo1XXXHyYMqi9Lx5GsLRaEWW5A+d5NR5fbspyD6WHj1MUOOsNQAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70631+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222719741600.9586983873286; Thu, 21 Jan 2021 01:51:59 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0r0OYY1788612xKhLlushwfk; Thu, 21 Jan 2021 01:51:59 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.5072.1611222718888019778 for ; Thu, 21 Jan 2021 01:51:59 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93E38D6E; Thu, 21 Jan 2021 01:51:58 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 64EF13F719; Thu, 21 Jan 2021 01:51:57 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 15/27] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib Date: Thu, 21 Jan 2021 09:51:07 +0000 Message-Id: <20210121095119.22143-16-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: risr8kFj3f1ua3b4NQLdDricx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222719; bh=2QmzzZrN++yvWs06xkwDlDUuv96mul9jwYd5Vi4l2qw=; h=Cc:Date:From:Reply-To:Subject:To; b=GrEk2EYMlNaaOORWSFg3gqZPbaF9/b1NBqGWwI+vvBDF+wau43M7G/bXJWNHPxFVn0x 1hzhWN+O1y0sVbRhlIX9Q8j8ruHlXtbtJ8n7ekDB9kkizPk8tvysISIOiAeRO7EConm0X 7DN6hF1cI69V/Mtg9uv6gyIhP2M8alCwVtM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Library/ArmSoftFloatLib/platform.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ArmPkg/Library/ArmSoftFloatLib/platform.h b/ArmPkg/Library/Arm= SoftFloatLib/platform.h index 07800a9d5b79..fddf9de04d52 100644 --- a/ArmPkg/Library/ArmSoftFloatLib/platform.h +++ b/ArmPkg/Library/ArmSoftFloatLib/platform.h @@ -1,11 +1,17 @@ /* * Copyright (c) 2019, Linaro Limited + * Copyright (c) 2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent */ +#ifndef ARM_SOFT_FLOAT_LIB_H_ +#define ARM_SOFT_FLOAT_LIB_H_ + #define LITTLEENDIAN 1 #define INLINE static inline #define SOFTFLOAT_BUILTIN_CLZ 1 #define SOFTFLOAT_FAST_INT64 #include "opts-GCC.h" + +#endif // ARM_SOFT_FLOAT_LIB_H_ -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70631): https://edk2.groups.io/g/devel/message/70631 Mute This Topic: https://groups.io/mt/80000388/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70632+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70632+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222721; cv=none; d=zohomail.com; s=zohoarc; b=d+rvjO3HxsQawWIbk67fY+H2rh+o9EjJTkVdwjB4OTSPtvbd4i7RQsIGuo/8ybJdiPalolDD+w564mvSK6577ni87qUGzQpvW8AmIpb3i2ko82JyL9ehkPwaHgczuME05oxpASx8dGbEmNNbaUvwSS/bXuEW9MWubP6MmJ/WA2s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222721; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=M+JJhA0aaTjC6K/tO4ib6sHaGl2KpSkjV3fjnLnlOek=; b=HA5Zdgb/T+qKS2Tkj7Fwk1HDOi+uXAqNEZiAhqrj+VA2zPJuuVeCv/D2ruElWwQtdXQxTUkqcwfdRydPIdVYGgibwk0FNvIei7A6C8qEfgqE6o3/7SqP99cBYYET2m4eswK/9CtdV8afi+/sbfkoVKyUI0wPYIp8JFO42BxvwRQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70632+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222721241183.61831367463708; Thu, 21 Jan 2021 01:52:01 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id kipDYY1788612xWxg4RdJjz9; Thu, 21 Jan 2021 01:52:00 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4992.1611222720372244275 for ; Thu, 21 Jan 2021 01:52:00 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F77914FF; Thu, 21 Jan 2021 01:52:00 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 01E773F719; Thu, 21 Jan 2021 01:51:58 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 16/27] ArmPkg: Rename include guard in ArmGicLib.h Date: Thu, 21 Jan 2021 09:51:08 +0000 Message-Id: <20210121095119.22143-17-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: iotI9KETTdQIdMIBOJp1THVmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222720; bh=1KAsCb29RDv5owGqwdcHE1B7RzS0M7aDbl0jdgPJgH0=; h=Cc:Date:From:Reply-To:Subject:To; b=mt2Mc61Z7fQuVYQGr7JXXlJoBhc/UCtVXOaS3NXPKSy1P4I18eipk8NZV2ggqRYtauo dry1dIsFajS+ca8V6kANtRbCvcoJ7YMr40RHI7wBGhPdXvDL+NAAnuKMQyhR2LleuT9lw D3WXuSo3X4HFBNbtQxGuJjSQqmtp6SdDgE0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Edk2 coding standard states that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Include/Library/ArmGicLib.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 7bcfc001115b..b4c320be119b 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -1,13 +1,13 @@ /** @file * -* Copyright (c) 2011-2018, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * **/ -#ifndef __ARMGIC_H -#define __ARMGIC_H +#ifndef ARMGIC_H_ +#define ARMGIC_H_ #include @@ -333,4 +333,4 @@ ArmGicV3SetPriorityMask ( IN UINTN Priority ); -#endif +#endif // ARMGIC_H_ -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70632): https://edk2.groups.io/g/devel/message/70632 Mute This Topic: https://groups.io/mt/80000390/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70633+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70633+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222722; cv=none; d=zohomail.com; s=zohoarc; b=A/+7LTg5PekxSGICjThlpgsmdrzZwxvDBd7JL4nZxQVB8W2Nj8MOoWKqsa7eteVf1jKJSgopFjexSN501yn0Gj0CWaPT8PEBwemYyd7eCEAgR2ilFqYTswqgZVmN1w3D4CQki+1u8yuHOtVwJ58Qpk2hgGJM8GBex6pXp03cbSE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222722; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=YZzG89iph9EK/9dmNcW/3C56zA/aujIKoE/W0oWKzUE=; b=IrRA7fhXpkVXL6PzJMob3XnzAZVPLtahPDUW0pvRn74LGmiJzfHGeBgJ6ojsh3ms4LP1TzXhtSSTYgHCoIQz6EMDUvPWq6ebCRJboKHsGr5b0/4QHHCAcxX2dNJfHMlvT/9f5kW3kgnR4EiGbFw5vXz+3K3MsUyRQwLqRVhLZy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70633+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222722689773.6845760385348; Thu, 21 Jan 2021 01:52:02 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id LI6rYY1788612xILxGlgxLWb; Thu, 21 Jan 2021 01:52:02 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4974.1611222721771489344 for ; Thu, 21 Jan 2021 01:52:01 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76B27D6E; Thu, 21 Jan 2021 01:52:01 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 62A3D3F719; Thu, 21 Jan 2021 01:52:00 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 17/27] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE Date: Thu, 21 Jan 2021 09:51:09 +0000 Message-Id: <20210121095119.22143-18-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: tld78241VAmmpcnzwe4rAkjnx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222722; bh=SsbUBkGM+2925OLNGK7Y9IHGxWH+RlrHfagKq0DAsxg=; h=Cc:Date:From:Reply-To:Subject:To; b=qxIFx+hoAEFN0U8LFsg5n1/gLjVJqeSdOi+2tlnfWhYf4bZKuP78H1VssHy8ifs/1IO /K4Bt2n7L7zGaTPu/Sb8L+M0K7PRfFN5NuwBXgXw+ukDWAA0WJdoKURxLYztsZVR4o1qv wxjpEvmVUOBralBLq4P06b+CQUZfZKLTsto= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 12 ++++++++---- ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 14 ++++++++++---- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers= /ArmScmiDxe/ScmiClockProtocol.c index c66c414385dd..5c06e31bda22 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -255,22 +255,26 @@ ClockDescribeRates ( for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { Rate =3D &DescribeRates->Rates[RateOffset++]; // Non-linear discrete rates. - RateArray[RateIndex++].Rate =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].DiscreteRate.Rate =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } else { for (RateNo =3D 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags)= ; RateNo++) { // Linear clock rates from minimum to maximum in steps // Minimum clock rate. Rate =3D &DescribeRates->Rates[RateOffset++]; - RateArray[RateIndex].Min =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Min =3D + ConvertTo64Bit (Rate->Low, Rate->High); Rate =3D &DescribeRates->Rates[RateOffset++]; // Maximum clock rate. - RateArray[RateIndex].Max =3D ConvertTo64Bit (Rate->Low, Rate->High= ); + RateArray[RateIndex].ContinuousRate.Max =3D + ConvertTo64Bit (Rate->Low, Rate->High); Rate =3D &DescribeRates->Rates[RateOffset++]; // Step. - RateArray[RateIndex++].Step =3D ConvertTo64Bit (Rate->Low, Rate->H= igh); + RateArray[RateIndex++].ContinuousRate.Step =3D + ConvertTo64Bit (Rate->Low, Rate->High); } } } while (NUM_REMAIN_RATES (DescribeRates->NumRatesFlags) !=3D 0); diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Includ= e/Protocol/ArmScmiClockProtocol.h index b4d970dee3e2..85b5b8d1e764 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -57,12 +57,18 @@ typedef enum { either Rate or Min/Max/Step triplet is valid. */ typedef struct { - union { UINT64 Min; - UINT64 Rate; - }; UINT64 Max; UINT64 Step; +} SCMI_CLOCK_RATE_CONTINUOUS; + +typedef struct { + UINT64 Rate; +} SCMI_CLOCK_RATE_DISCRETE; + +typedef union { + SCMI_CLOCK_RATE_CONTINUOUS ContinuousRate; + SCMI_CLOCK_RATE_DISCRETE DiscreteRate; } SCMI_CLOCK_RATE; #pragma pack() -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70633): https://edk2.groups.io/g/devel/message/70633 Mute This Topic: https://groups.io/mt/80000391/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70634+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70634+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222723; cv=none; d=zohomail.com; s=zohoarc; b=DNw3aWbIN+ye5qidjsa8gkPdFnDZSEd7lP7ainjS/9i9yzsOkZc8WvbGSz6tNF4P5Was0NkTDMU9a9Vo7V4eYdSh5aLPfaL+4H/I7i9V9Yxy8mLAxSN1pNHjlVKG0Zj2NK35fOTh5JMVoiuQ4qy36UINc9bhoTSnHC846rsOPLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222723; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=qMP5w+jz4lXr6urGRaKu6mR3SDPgekOwITiCCh8o9Ww=; b=UOdrVTrMFYT5Fev8mNk8DnCSpJj4t5ZgHdptHRiVZYvXsGQoEADIgW5yYUVz0vQiA+1y0p5lKlMTOpaB58HQ6owCCsdnKRRU70jntbDtZ4vNAZYC8wz27lF5CDaoHxQA43W61XVlF0J7kpT178eop7llTbUqk9s+weDI0eoMVxk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70634+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222723914978.4819481232248; Thu, 21 Jan 2021 01:52:03 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 2B02YY1788612xBIQf5FuHEB; Thu, 21 Jan 2021 01:52:03 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4975.1611222723058317833 for ; Thu, 21 Jan 2021 01:52:03 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C448114FF; Thu, 21 Jan 2021 01:52:02 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B839E3F719; Thu, 21 Jan 2021 01:52:01 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 18/27] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM Date: Thu, 21 Jan 2021 09:51:10 +0000 Message-Id: <20210121095119.22143-19-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: WoNeExqQvHp7JyunZfa4Yh6tx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222723; bh=VCBbAFQp9m8CDc8OZsC7+nRuF2v5XmpV3esvTAOFCTk=; h=Cc:Date:From:Reply-To:Subject:To; b=Mk9cNlKNIYTe7/9SgF7U+YMC8vknMLNKWbvhTYuHWuQCWen/ZYXm3BJp8wymGVFlSmN gzdj2ZcN51kAsrviKbUwitEHanuSJEqPumFESTyGI7nQfBMCYJtygGjfehNJgpTJUNKp9 O8pvAPAeH9OOE0cfB/eIWTNgHZh2FxKiRzQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 ArmPkg/Include/Library/OpteeLib.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Include/Library/OpteeLib.h b/ArmPkg/Include/Library/Opt= eeLib.h index d71636143373..8ceab117d132 100644 --- a/ArmPkg/Include/Library/OpteeLib.h +++ b/ArmPkg/Include/Library/OpteeLib.h @@ -2,6 +2,7 @@ OP-TEE specific header file. Copyright (c) 2018, Linaro Ltd. All rights reserved.
+ Copyright (c) 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -45,12 +46,14 @@ typedef struct { UINT64 C; } OPTEE_MESSAGE_PARAM_VALUE; +typedef union { + OPTEE_MESSAGE_PARAM_MEMORY Memory; + OPTEE_MESSAGE_PARAM_VALUE Value; +} OPTEE_MESSAGE_PARAM_UNION; + typedef struct { UINT64 Attribute; - union { - OPTEE_MESSAGE_PARAM_MEMORY Memory; - OPTEE_MESSAGE_PARAM_VALUE Value; - } Union; + OPTEE_MESSAGE_PARAM_UNION Union; } OPTEE_MESSAGE_PARAM; #define OPTEE_MAX_CALL_PARAMS 4 -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70634): https://edk2.groups.io/g/devel/message/70634 Mute This Topic: https://groups.io/mt/80000392/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 11:47:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70635+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70635+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1611222731; cv=none; d=zohomail.com; s=zohoarc; b=bHy1Do7EB7nrq9OonC7QSHEPeNfGi5oVdzo/bhC0w/5JY4dw0l50A4H1OMd4wAgfea/ZgW/fGBG+HNFRQJw6JfnhxX6vZjEXxvx8s4EhVqmoOYlj/H1Dp2RqNjizP767yploDWLB6LR8lsJwz7RvYRMbbBu174eI7AeZBSLX11I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611222731; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=8cN5wNit6jDmAkO+KtE38BMgDxzZNpw2aRmZ1fU7Ljs=; b=i63YeqpuoOGRca5P9J93hKSPgcSA0F+embQryK/icVIjZNk3LG6cTxBcWBBwsma/SOJ1o6Smz4VAdtW7PPIE0y84Qm2cq1NRffZyO6KiqldT3V4Bh0GXD3kqfkD1P890jlzn9rGeawGPQJ5xziVWQi072BE+mqUd9jMUn0qs/vI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70635+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611222731259747.0009966906397; Thu, 21 Jan 2021 01:52:11 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FPmHYY1788612x5KLC1oPiom; Thu, 21 Jan 2021 01:52:10 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4994.1611222724827958785 for ; Thu, 21 Jan 2021 01:52:05 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 85983D6E; Thu, 21 Jan 2021 01:52:04 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 311533F719; Thu, 21 Jan 2021 01:52:03 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 19/27] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib Date: Thu, 21 Jan 2021 09:51:11 +0000 Message-Id: <20210121095119.22143-20-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: D5RaKp2jWqRXoPnYpQ91muZAx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611222730; bh=WG8f3YfLV9lud6QM/93icCX6L64hPB353AHtFzFIKCQ=; h=Cc:Date:From:Reply-To:Subject:To; b=eboNdZ8TojCEgx32LKQ+n50Ka6uIN9hAdgjtNpUT4w7pLzDefW5K31HyL4QqJKoZ3X4 HHA9+qhpc9Ld7eq8zZZcaifHld4UmeJrHcLkRj+cHl2HRjZ+B0rfADE30PTYZU0+jsoAv fcHHhy8gXTNG0rOoAG6o0T5UguwM6vUE8hE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: 8005: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' 8007: There should be no use of short (single character) variable names Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc= _ArmPkg_BIS_v1 .../ArmDisassemblerLib/ArmDisassembler.c | 159 +++++++++--------- .../ArmDisassemblerLib/ThumbDisassembler.c | 158 ++++++++--------- 2 files changed, 163 insertions(+), 154 deletions(-) diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/L= ibrary/ArmDisassemblerLib/ArmDisassembler.c index e67e13a50ace..03a9f1fbe2e5 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -71,7 +71,7 @@ CHAR8 *gLdmStack[] =3D { #define SIGN(_U) ((_U) ? "" : "-") -#define WRITE(_W) ((_W) ? "!" : "") +#define WRITE(_Write) ((_Write) ? "!" : "") #define BYTE(_B) ((_B) ? "B":"") #define USER(_B) ((_B) ? "^" : "") @@ -159,23 +159,24 @@ DisassembleArmInstruction ( ) { UINT32 OpCode; - CHAR8 *Type, *Root; - BOOLEAN I, P, U, B, W, L, S, H; + CHAR8 *Type; + CHAR8 *Root; + BOOLEAN Imm, Pre, Up, WriteBack, Write, Load, Sign, Half; UINT32 Rn, Rd, Rm; - UINT32 imode, offset_8, offset_12; + UINT32 IMod, Offset8, Offset12; UINT32 Index; - UINT32 shift_imm, shift; + UINT32 ShiftImm, Shift; OpCode =3D **OpCodePtr; - I =3D (OpCode & BIT25) =3D=3D BIT25; - P =3D (OpCode & BIT24) =3D=3D BIT24; - U =3D (OpCode & BIT23) =3D=3D BIT23; - B =3D (OpCode & BIT22) =3D=3D BIT22; // Also called S - W =3D (OpCode & BIT21) =3D=3D BIT21; - L =3D (OpCode & BIT20) =3D=3D BIT20; - S =3D (OpCode & BIT6) =3D=3D BIT6; - H =3D (OpCode & BIT5) =3D=3D BIT5; + Imm =3D (OpCode & BIT25) =3D=3D BIT25; // I + Pre =3D (OpCode & BIT24) =3D=3D BIT24; // P + Up =3D (OpCode & BIT23) =3D=3D BIT23; // U + WriteBack =3D (OpCode & BIT22) =3D=3D BIT22; // B, also called S + Write =3D (OpCode & BIT21) =3D=3D BIT21; // W + Load =3D (OpCode & BIT20) =3D=3D BIT20; // L + Sign =3D (OpCode & BIT6) =3D=3D BIT6; // S + Half =3D (OpCode & BIT5) =3D=3D BIT5; // H Rn =3D (OpCode >> 16) & 0xf; Rd =3D (OpCode >> 12) & 0xf; Rm =3D (OpCode & 0xf); @@ -189,7 +190,7 @@ DisassembleArmInstruction ( // LDREX, STREX if ((OpCode & 0x0fe000f0) =3D=3D 0x01800090) { - if (L) { + if (Load) { // A4.1.27 LDREX{} , [] AsciiSPrint (Buf, Size, "LDREX%a %a, [%a]", COND (OpCode), gReg[Rd],= gReg[Rn]); } else { @@ -201,89 +202,89 @@ DisassembleArmInstruction ( // LDM/STM if ((OpCode & 0x0e000000) =3D=3D 0x08000000) { - if (L) { + if (Load) { // A4.1.20 LDM{} {!}, // A4.1.21 LDM{} , ^ // A4.1.22 LDM{} {!}, ^ - AsciiSPrint (Buf, Size, "LDM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (W), MRegList (OpCode), USER (B)); + AsciiSPrint (Buf, Size, "LDM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (Write), MRegList (OpCode), USER = (WriteBack)); } else { // A4.1.97 STM{} {!}, // A4.1.98 STM{} , ^ - AsciiSPrint (Buf, Size, "STM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (W), MRegList (OpCode), USER (B)); + AsciiSPrint (Buf, Size, "STM%a%a, %a%a, %a", COND (OpCode), LDM_EXT = (Rn ,(OpCode >> 23) & 3), gReg[Rn], WRITE (Write), MRegList (OpCode), USER = (WriteBack)); } return; } // LDR/STR Address Mode 2 if ( ((OpCode & 0x0c000000) =3D=3D 0x04000000) || ((OpCode & 0xfd70f000= ) =3D=3D 0xf550f000) ) { - offset_12 =3D OpCode & 0xfff; + Offset12 =3D OpCode & 0xfff; if ((OpCode & 0xfd70f000 ) =3D=3D 0xf550f000) { Index =3D AsciiSPrint (Buf, Size, "PLD"); } else { - Index =3D AsciiSPrint (Buf, Size, "%a%a%a%a %a, ", L ? "LDR" : "STR"= , COND (OpCode), BYTE (B), (!(P) && W) ? "T":"", gReg[Rd]); + Index =3D AsciiSPrint (Buf, Size, "%a%a%a%a %a, ", Load ? "LDR" : "S= TR", COND (OpCode), BYTE (WriteBack), (!(Pre) && Write) ? "T":"", gReg[Rd]); } - if (P) { - if (!I) { + if (Pre) { + if (!Imm) { // A5.2.2 [, #+/-] // A5.2.5 [, #+/-] - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a0x%x]%a", gReg[Rn= ], SIGN (U), offset_12, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a0x%x]%a", gReg[Rn= ], SIGN (Up), Offset12, WRITE (Write)); } else if ((OpCode & 0x03000ff0) =3D=3D 0x03000000) { // A5.2.3 [, +/-] // A5.2.6 [, +/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a]%a", gReg[Rn],= SIGN (U), WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a]%a", gReg[Rn],= SIGN (Up), WRITE (Write)); } else { // A5.2.4 [, +/-, LSL #] // A5.2.7 [, +/-, LSL #]! - shift_imm =3D (OpCode >> 7) & 0x1f; - shift =3D (OpCode >> 5) & 0x3; - if (shift =3D=3D 0x0) { + ShiftImm =3D (OpCode >> 7) & 0x1f; + Shift =3D (OpCode >> 5) & 0x3; + if (Shift =3D=3D 0x0) { Type =3D "LSL"; - } else if (shift =3D=3D 0x1) { + } else if (Shift =3D=3D 0x1) { Type =3D "LSR"; - if (shift_imm =3D=3D 0) { - shift_imm =3D 32; + if (ShiftImm =3D=3D 0) { + ShiftImm =3D 32; } - } else if (shift =3D=3D 0x2) { + } else if (Shift =3D=3D 0x2) { Type =3D "ASR"; - } else if (shift_imm =3D=3D 0) { - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, RRX]%a"= , gReg[Rn], SIGN (U), gReg[Rm], WRITE (W)); + } else if (ShiftImm =3D=3D 0) { + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, RRX]%a"= , gReg[Rn], SIGN (Up), gReg[Rm], WRITE (Write)); return; } else { Type =3D "ROR"; } - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, #%d]%a", = gReg[Rn], SIGN (U), gReg[Rm], Type, shift_imm, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%a, %a, #%d]%a", = gReg[Rn], SIGN (Up), gReg[Rm], Type, ShiftImm, WRITE (Write)); } - } else { // !P - if (!I) { + } else { // !Pre + if (!Imm) { // A5.2.8 [], #+/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a0x%x", gReg[Rn],= SIGN (U), offset_12); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a0x%x", gReg[Rn],= SIGN (Up), Offset12); } else if ((OpCode & 0x03000ff0) =3D=3D 0x03000000) { // A5.2.9 [], +/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], S= IGN (U), gReg[Rm]); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], S= IGN (Up), gReg[Rm]); } else { // A5.2.10 [], +/-, LSL # - shift_imm =3D (OpCode >> 7) & 0x1f; - shift =3D (OpCode >> 5) & 0x3; + ShiftImm =3D (OpCode >> 7) & 0x1f; + Shift =3D (OpCode >> 5) & 0x3; - if (shift =3D=3D 0x0) { + if (Shift =3D=3D 0x0) { Type =3D "LSL"; - } else if (shift =3D=3D 0x1) { + } else if (Shift =3D=3D 0x1) { Type =3D "LSR"; - if (shift_imm =3D=3D 0) { - shift_imm =3D 32; + if (ShiftImm =3D=3D 0) { + ShiftImm =3D 32; } - } else if (shift =3D=3D 0x2) { + } else if (Shift =3D=3D 0x2) { Type =3D "ASR"; - } else if (shift_imm =3D=3D 0) { - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, RRX", = gReg[Rn], SIGN (U), gReg[Rm]); + } else if (ShiftImm =3D=3D 0) { + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, RRX", = gReg[Rn], SIGN (Up), gReg[Rm]); // FIx me return; } else { Type =3D "ROR"; } - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, #%d", gR= eg[Rn], SIGN (U), gReg[Rm], Type, shift_imm); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a, %a, #%d", gR= eg[Rn], SIGN (Up), gReg[Rm], Type, ShiftImm); } } return; @@ -292,18 +293,18 @@ DisassembleArmInstruction ( if ((OpCode & 0x0e000000) =3D=3D 0x00000000) { // LDR/STR address mode 3 // LDR|STR{}H|SH|SB|D , - if (L) { - if (!S) { + if (Load) { + if (!Sign) { Root =3D "LDR%aH %a, "; - } else if (!H) { + } else if (!Half) { Root =3D "LDR%aSB %a, "; } else { Root =3D "LDR%aSH %a, "; } } else { - if (!S) { + if (!Sign) { Root =3D "STR%aH %a "; - } else if (!H) { + } else if (!Half) { Root =3D "LDR%aD %a "; } else { Root =3D "STR%aD %a "; @@ -312,28 +313,28 @@ DisassembleArmInstruction ( Index =3D AsciiSPrint (Buf, Size, Root, COND (OpCode), gReg[Rd]); - S =3D (OpCode & BIT6) =3D=3D BIT6; - H =3D (OpCode & BIT5) =3D=3D BIT5; - offset_8 =3D ((OpCode >> 4) | (OpCode * 0xf)) & 0xff; - if (P & !W) { + Sign =3D (OpCode & BIT6) =3D=3D BIT6; + Half =3D (OpCode & BIT5) =3D=3D BIT5; + Offset8 =3D ((OpCode >> 4) | (OpCode * 0xf)) & 0xff; + if (Pre & !Write) { // Immediate offset/index - if (B) { + if (WriteBack) { // A5.3.2 [, #+/-] // A5.3.4 [, #+/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%d]%a", gReg[Rn]= , SIGN (U), offset_8, WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%d]%a", gReg[Rn]= , SIGN (Up), Offset8, WRITE (Write)); } else { // A5.3.3 [, +/-] // A5.3.5 [, +/-]! - AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%]a", gReg[Rn], = SIGN (U), gReg[Rm], WRITE (W)); + AsciiSPrint (&Buf[Index], Size - Index, "[%a, #%a%]a", gReg[Rn], = SIGN (Up), gReg[Rm], WRITE (Write)); } } else { // Register offset/index - if (B) { + if (WriteBack) { // A5.3.6 [], #+/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%d", gReg[Rn], = SIGN (U), offset_8); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%d", gReg[Rn], = SIGN (Up), Offset8); } else { // A5.3.7 [], +/- - AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], = SIGN (U), gReg[Rm]); + AsciiSPrint (&Buf[Index], Size - Index, "[%a], #%a%a", gReg[Rn], = SIGN (Up), gReg[Rm]); } } return; @@ -342,19 +343,19 @@ DisassembleArmInstruction ( if ((OpCode & 0x0fb000f0) =3D=3D 0x01000050) { // A4.1.108 SWP SWP{}B , , [] // A4.1.109 SWPB SWP{}B , , [] - AsciiSPrint (Buf, Size, "SWP%a%a %a, %a, [%a]", COND (OpCode), BYTE (B= ), gReg[Rd], gReg[Rm], gReg[Rn]); + AsciiSPrint (Buf, Size, "SWP%a%a %a, %a, [%a]", COND (OpCode), BYTE (W= riteBack), gReg[Rd], gReg[Rm], gReg[Rn]); return; } if ((OpCode & 0xfe5f0f00) =3D=3D 0xf84d0500) { // A4.1.90 SRS SRS #{!} - AsciiSPrint (Buf, Size, "SRS%a #0x%x%a", gLdmStack[(OpCode >> 23) & 3]= , OpCode & 0x1f, WRITE (W)); + AsciiSPrint (Buf, Size, "SRS%a #0x%x%a", gLdmStack[(OpCode >> 23) & 3]= , OpCode & 0x1f, WRITE (Write)); return; } if ((OpCode & 0xfe500f00) =3D=3D 0xf8100500) { // A4.1.59 RFE {!} - AsciiSPrint (Buf, Size, "RFE%a %a", gLdmStack[(OpCode >> 23) & 3], gRe= g[Rn], WRITE (W)); + AsciiSPrint (Buf, Size, "RFE%a %a", gLdmStack[(OpCode >> 23) & 3], gRe= g[Rn], WRITE (Write)); return; } @@ -369,9 +370,9 @@ DisassembleArmInstruction ( if (((OpCode >> 6) & 0x7) =3D=3D 0) { AsciiSPrint (Buf, Size, "CPS #0x%x", (OpCode & 0x2f)); } else { - imode =3D (OpCode >> 18) & 0x3; + IMod =3D (OpCode >> 18) & 0x3; Index =3D AsciiSPrint (Buf, Size, "CPS%a %a%a%a", - (imode =3D=3D 3) ? "ID":"IE", + (IMod =3D=3D 3) ? "ID":"IE", ((OpCode & BIT8) !=3D 0) ? "A":"", ((OpCode & BIT7) !=3D 0) ? "I":"", ((OpCode & BIT6) !=3D 0) ? "F":""); @@ -390,19 +391,19 @@ DisassembleArmInstruction ( if ((OpCode & 0x0fb00000) =3D=3D 0x01000000) { // A4.1.38 MRS{} , CPSR MRS{} , SPSR - AsciiSPrint (Buf, Size, "MRS%a %a, %a", COND (OpCode), gReg[Rd], B ? "= SPSR" : "CPSR"); + AsciiSPrint (Buf, Size, "MRS%a %a, %a", COND (OpCode), gReg[Rd], Write= Back ? "SPSR" : "CPSR"); return; } if ((OpCode & 0x0db00000) =3D=3D 0x01200000) { // A4.1.38 MSR{} CPSR_, # MSR{} CPSR_, - if (I) { + if (Imm) { // MSR{} CPSR_, # - AsciiSPrint (Buf, Size, "MRS%a %a_%a, #0x%x", COND (OpCode), B ? "S= PSR" : "CPSR", FieldMask ((OpCode >> 16) & 0xf), RotateRight (OpCode & 0xf,= ((OpCode >> 8) & 0xf) *2)); + AsciiSPrint (Buf, Size, "MRS%a %a_%a, #0x%x", COND (OpCode), WriteB= ack ? "SPSR" : "CPSR", FieldMask ((OpCode >> 16) & 0xf), RotateRight (OpCod= e & 0xf, ((OpCode >> 8) & 0xf) *2)); } else { // MSR{} CPSR_, - AsciiSPrint (Buf, Size, "MRS%a %a_%a, %a", COND (OpCode), B ? "SPSR"= : "CPSR", gReg[Rd]); + AsciiSPrint (Buf, Size, "MRS%a %a_%a, %a", COND (OpCode), WriteBack = ? "SPSR" : "CPSR", gReg[Rd]); } return; } @@ -416,35 +417,35 @@ DisassembleArmInstruction ( if ((OpCode & 0x0e000000) =3D=3D 0x0c000000) { // A4.1.19 LDC and A4.1.96 SDC if ((OpCode & 0xf0000000) =3D=3D 0xf0000000) { - Index =3D AsciiSPrint (Buf, Size, "%a2 0x%x, CR%d, ", L ? "LDC":"SDC= ", (OpCode >> 8) & 0xf, Rd); + Index =3D AsciiSPrint (Buf, Size, "%a2 0x%x, CR%d, ", Load ? "LDC":"= SDC", (OpCode >> 8) & 0xf, Rd); } else { - Index =3D AsciiSPrint (Buf, Size, "%a%a 0x%x, CR%d, ", L ? "LDC":"S= DC", COND (OpCode), (OpCode >> 8) & 0xf, Rd); + Index =3D AsciiSPrint (Buf, Size, "%a%a 0x%x, CR%d, ", Load ? "LDC"= :"SDC", COND (OpCode), (OpCode >> 8) & 0xf, Rd); } - if (!P) { - if (!W) { + if (!Pre) { + if (!Write) { // A5.5.5.5 [],