From nobody Mon Feb 9 19:06:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70551+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70551+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611071698; cv=none; d=zohomail.com; s=zohoarc; b=IxjSfl2WOHpMT2zz6rAB+UCkrbSm9z9UVl2jw2K8egp+fUOd8hOBYLbIejJZSEtO6kMEzM/XzX3LP9gfWY6TOho9AoqTyjkz8EpxdNEw/2H/5h4+FOHz+4GVb2JnPw2Y2gFd6Y0pZvJ0ajyVdo5fe0WWZR24Lo0u9aYKPaWBh84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611071698; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=LaoZEWpFQD8qkiUmgIfG9fGI6+TWfek04irPwzOthao=; b=CCFYqd4EvzNEcdM+SdjcrKsS4GYXDPexTkx3y9HhUHjARhiKTmqX9yc2v1+RLSvdg/zjIibmyptzKo1sFDCgRgESbxpvYc772zUpJ2kCABkL8e0gfTI34U5D35yLOcqstSwhddc0nAnE7NNcr6nKEzIqQc79H0DTJ0fV7XhLU9Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70551+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611071698940889.8695146776059; Tue, 19 Jan 2021 07:54:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id eLS9YY1788612xCr79gvmnYI; Tue, 19 Jan 2021 07:54:58 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.12946.1611071695461027094 for ; Tue, 19 Jan 2021 07:54:55 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-l-6t2AAPOsuevTfg51W4Ew-1; Tue, 19 Jan 2021 10:54:50 -0500 X-MC-Unique: l-6t2AAPOsuevTfg51W4Ew-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2DEC3E74B; Tue, 19 Jan 2021 15:54:49 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-176.ams2.redhat.com [10.36.114.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FDC160CCB; Tue, 19 Jan 2021 15:54:47 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Eric Dong , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Rahul Kumar , Ray Ni , Star Zeng Subject: [edk2-devel] [PATCH v2 2/4] UefiCpuPkg/AcpiCpuData: update comments on register table fields Date: Tue, 19 Jan 2021 16:54:38 +0100 Message-Id: <20210119155440.2262-3-lersek@redhat.com> In-Reply-To: <20210119155440.2262-1-lersek@redhat.com> References: <20210119155440.2262-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: w2gZAmQB0TCcaAYKyxvVjYf7x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611071698; bh=LaoZEWpFQD8qkiUmgIfG9fGI6+TWfek04irPwzOthao=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=CummjoB9PLSNpPj/E+64dbytG3Yuj1K9mnZpq07I2ITzPd6iXDTRld5IV/lA5XAVc3m T8KW2ucoGjjqMvDjVo3jLvJDxk5ZxMA7ifHFiXHw1ykixNFgEELbEb6gwbj21x9UGWqOJ bcOaqBAY2/X3cYYh7XoIeeETGYmZG709wKI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" After commit e992cc3f4859 ("UefiCpuPkg PiSmmCpuDxeSmm: Reduce SMRAM consumption in CpuS3.c", 2021-01-11), it is valid for a CPU S3 Data DXE Driver to set "ACPI_CPU_DATA.PreSmmInitRegisterTable" and/or "ACPI_CPU_DATA.RegisterTable" to 0, in case none of the CPUs needs a register table of the corresponding kind, during S3 resume. Document this fact in the "UefiCpuPkg/Include/AcpiCpuData.h" header file. Cc: Eric Dong Cc: Philippe Mathieu-Daud=C3=A9 Cc: Rahul Kumar Cc: Ray Ni Cc: Star Zeng Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3159 Signed-off-by: Laszlo Ersek Reviewed-by: Ray Ni Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Notes: v2: =20 - no changes, pick up feedback tags UefiCpuPkg/Include/AcpiCpuData.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiCpuPkg/Include/AcpiCpuData.h b/UefiCpuPkg/Include/AcpiCpuD= ata.h index b5a69ad80c88..62a01b2c6bac 100644 --- a/UefiCpuPkg/Include/AcpiCpuData.h +++ b/UefiCpuPkg/Include/AcpiCpuData.h @@ -178,6 +178,8 @@ typedef struct { // If TableLength is > 0, then elements of RegisterTableEntry are used to // initialize the CPU that matches InitialApicId, during an ACPI S3 resu= me, // before SMBASE relocation is performed. + // If a register table is not required for any one of the CPUs, then + // PreSmmInitRegisterTable may be set to 0. // EFI_PHYSICAL_ADDRESS PreSmmInitRegisterTable; // @@ -187,6 +189,8 @@ typedef struct { // If TableLength is > 0, then elements of RegisterTableEntry are used to // initialize the CPU that matches InitialApicId, during an ACPI S3 resu= me, // after SMBASE relocation is performed. + // If a register table is not required for any one of the CPUs, then + // RegisterTable may be set to 0. // EFI_PHYSICAL_ADDRESS RegisterTable; // --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70551): https://edk2.groups.io/g/devel/message/70551 Mute This Topic: https://groups.io/mt/79954427/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-