From nobody Mon Feb 9 19:06:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70516+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70516+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1611018911; cv=none; d=zohomail.com; s=zohoarc; b=havOR/r+mPVyPoQmJszj1uoVEiZ5IaDC94bbrcEMXnwACnoldwLvtyFi2t6n00REslxjMWAAr90xCpIcHubDtuaoxJu3gy1jp6bfIp4bBIMg/BtGHQW015xmZHQX4NSdUukH9yy45zrkQAUVXMI7tAqt+Fr+NXHra2O3qVZeFMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611018911; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Pr9eEATsDRt1I1RPh1hvCoohA2qbuSnTGvR96R5zoys=; b=EX33a9Dfl4wZf7LwiskS6NzzVnTbjm5JzpOXaFZcf7euKqBdlrn2rZE634sGqTDWkGK2PyB43KKzuPMPQ3uPOCOd3be4MGmYuyZB6hQmf6reg66keG568j/aeYctOmBJUhytcfzqn7wqr+77z4cTD04E+x4sAzdFDZfyPblugR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70516+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1611018911870586.290115339396; Mon, 18 Jan 2021 17:15:11 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zzkEYY1788612x2yeSh8PUSP; Mon, 18 Jan 2021 17:15:11 -0800 X-Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mx.groups.io with SMTP id smtpd.web10.5397.1611018895126861854 for ; Mon, 18 Jan 2021 17:14:55 -0800 X-Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DKVzH0tMMzj9R0; Tue, 19 Jan 2021 09:13:47 +0800 (CST) X-Received: from localhost (10.174.184.155) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 19 Jan 2021 09:14:46 +0800 From: "Jiahui Cen via groups.io" To: CC: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , Julien Grall , Leif Lindholm , Sami Mujawar , , , Jiahui Cen Subject: [edk2-devel] [PATCH v6 03/11] OvmfPkg/PciHostBridgeLib: List missing PcdLib dependency Date: Tue, 19 Jan 2021 09:12:54 +0800 Message-ID: <20210119011302.10908-4-cenjiahui@huawei.com> In-Reply-To: <20210119011302.10908-1-cenjiahui@huawei.com> References: <20210119011302.10908-1-cenjiahui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,cenjiahui@huawei.com X-Gm-Message-State: MesylKwMD3XxETv4RsYmYxH1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1611018911; bh=HlIS1fJjiZUExmoxENU8p5nsamamks5p3px6iiw4JSQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=TgtCp4jAshF6l8nri+pc5lZjMAoDBhFqtTH8h2PvxLCn02Rb3vRyj4GWKRz7OQElS7U P+0NZK0eBh/qJDiR3nQttM8hYIEENM4zWS81RalmJb+6xWmoYHcyQPk6/JM5uYGXqQ4Ef GGCvPwFFltpmK3n20fu7yhf+PUP/r+eN0hE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" OvmfPkg/PciHostBridgeLib instance fails to list its PcdLib dependency, both between the #include directives, and in the INF file. So let's list the dependency. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3059 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Signed-off-by: Jiahui Cen Reviewed-by: Laszlo Ersek --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 1 + OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 1 + 3 files changed, 3 insertions(+) diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/OvmfPk= g/Library/PciHostBridgeLib/PciHostBridgeLib.inf index 4c56f3c90b3b..cec3f1631a72 100644 --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf @@ -39,6 +39,7 @@ [LibraryClasses] DebugLib DevicePathLib MemoryAllocationLib + PcdLib PciHostBridgeUtilityLib PciLib QemuFwCfgLib diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/= Library/PciHostBridgeLib/PciHostBridgeLib.c index 4a176347fd49..bf32455b9f0d 100644 --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c b/OvmfPkg/Librar= y/PciHostBridgeLib/XenSupport.c index e161f14375ca..95ed0a280b9b 100644 --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include "PciHostBridge.h" --=20 2.29.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70516): https://edk2.groups.io/g/devel/message/70516 Mute This Topic: https://groups.io/mt/79941619/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-