From nobody Sun May 5 00:45:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70371+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70371+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1610691794; cv=none; d=zohomail.com; s=zohoarc; b=a2u1NpTsd5tLobxWYoOXVeV5LYaBVEj1MoxZqI3y+UjjA2ErMF16/5ldMwihFPtNG7IhfJjL4ySEOsPr4MS2uBmpeqNCCSFknrACHyiy4f9EcJPEiyQxyCdDtJC9SQo/WRCUzEQoNPa9IKrbId8+nMOTCkgAHKanVvbWukv/78E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610691794; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=2DvCRseV8LaMieRu/yziECuxHGPCNAFP9thKtOMi5cM=; b=MDxAaghzzXitWjE7g2gcApdx8e2yT4ZQbkd4mlZjQj7CFqr+ibJlit7epZEvpJGtFEL87r+pkPpFBbFZjWBjvk9icKgN5O96gEgfAnPGL+kR98IjJKpxlztwyOvpFWKP1SL3Slx+avOt9fEPFq6iXhascVyxjWbQ5SNyBZ/plrA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70371+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1610691794631707.0054001434787; Thu, 14 Jan 2021 22:23:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id AbCqYY1788612xcmhlid670p; Thu, 14 Jan 2021 22:23:14 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.545.1610691793824655386 for ; Thu, 14 Jan 2021 22:23:13 -0800 IronPort-SDR: jl0Z+YUDjsicCObNgYQ93OK+9AgVZM3zAiLJczRYuf/zDecqr0izO86S3CdhCgt1n2nKJAa67t yl0FajciJyZw== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="177726874" X-IronPort-AV: E=Sophos;i="5.79,348,1602572400"; d="scan'208";a="177726874" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 22:23:10 -0800 IronPort-SDR: 2fauLtDcqUhx4LbDmh7+tVYrUnY2jdw4XOXvNrA+g+Rlm9z+Cl3QanFogTR2zhRqkKkd1tZQGz WYZjPKCm1JGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,348,1602572400"; d="scan'208";a="568391974" X-Received: from chinghux-desk1.gar.corp.intel.com ([10.5.215.141]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 22:23:08 -0800 From: "GregX Yeh" To: devel@edk2.groups.io Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH] NetworkPkg/Library/DxeHttpIoLib: Http boot failure with no initializes timeout value. Date: Fri, 15 Jan 2021 14:22:56 +0800 Message-Id: <20210115062256.17672-1-gregx.yeh@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gregx.yeh@intel.com X-Gm-Message-State: BhOEC1rcRuA0twLaa5vhenyWx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1610691794; bh=xiQQxUzWYcjTg916bEHyH6BfRn57EFUCVqHEO4D2e6M=; h=Cc:Date:From:Reply-To:Subject:To; b=QW3Z8D1g6YVFv07xZqpx66PzF4CLGvtPykax+odArW5Ul5SU6+8DLDcaWi5x1v82Sje YaexmVmmszh7tPuizdoY51TDHBvK9I30KZqY2XTVgsOLqW0NMUtgbhOcSNqYbsSCoai0t /BaY8n5/bogPTa5p1LPaMIwUovei947AKBQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D3170 Using PcdHttpIoTimeout to set default timeout value to HttpIoLib. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: GregX Yeh Reviewed-by: Maciej Rabeda Reviewed-by: Siyuan Fu --- NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c | 1 + NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf | 1 + NetworkPkg/NetworkPkg.dec | 6 +++++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c b/NetworkPkg/Li= brary/DxeHttpIoLib/DxeHttpIoLib.c index 67583fb220..04b01adec5 100644 --- a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c +++ b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c @@ -189,6 +189,7 @@ HttpIoCreateIo ( HttpIo->Http =3D Http; HttpIo->Callback =3D Callback; HttpIo->Context =3D Context; + HttpIo->Timeout =3D PcdGet32 (PcdHttpIoTimeout); =20 if (ConfigData !=3D NULL) { if (HttpIo->IpVersion =3D=3D IP_VERSION_4) { diff --git a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf b/NetworkPkg/= Library/DxeHttpIoLib/DxeHttpIoLib.inf index 25f5eb2ec6..347f8d5508 100644 --- a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf +++ b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf @@ -43,3 +43,4 @@ =20 [Pcd] gEfiNetworkPkgTokenSpaceGuid.PcdMaxHttpChunkTransfer ## SOMETIMES_CONSU= MES + gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout ## SOMETIMES_CONSU= MES diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index 2d0d7fd2dc..87725674e9 100644 --- a/NetworkPkg/NetworkPkg.dec +++ b/NetworkPkg/NetworkPkg.dec @@ -3,7 +3,7 @@ # # This package provides network modules that conform to UEFI 2.4 specifica= tion. # -# Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.
# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP
# # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -96,6 +96,10 @@ ## The maximum size of total HTTP chunk transfer. # @Prompt Max size of total HTTP chunk transfer. the default value is 12= MB. gEfiNetworkPkgTokenSpaceGuid.PcdMaxHttpChunkTransfer|0x0C00000|UINT32|0x= 0000000E + =20 + ## The Timeout value of HTTP IO. + # @Prompt The Timeout value of HTTP Io. Default value is 5000. + gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout|5000|UINT32|0x0000000F =20 [PcdsFixedAtBuild, PcdsPatchableInModule] ## Indicates whether HTTP connections (i.e., unsecured) are permitted or= not. --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70371): https://edk2.groups.io/g/devel/message/70371 Mute This Topic: https://groups.io/mt/79696524/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-