From nobody Sat Apr 27 02:10:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70257+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70257+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1610564479; cv=none; d=zohomail.com; s=zohoarc; b=kwa/V/H10v65jYQqVZvhsBNT8kpCret0LVHjSY112wQXBs+Vb6/TQErphCNya3A8dSSfeXqM0Qaprx8Et9Bz+K9kAIaDHE/XRClkHOfeOgUIRfDUTebA3YJYmHj3w5Ess4vW3B5bPR5mKqiFUmLCfsHzXdUCweRjuh10zdedQ7U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610564479; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=tt9LLz2oTdCXK+UaPRYp/T1vtr8DMVZdr4bezPMn2K8=; b=EL/VmCbfEYEN3wuTu75BbBomRJXWElki/maZnQHU47HQ3NUsrHTEi1+XpG7Q9r5t6x5wJV2dFafF9JOKwNgRuYwWBQQDs8KqMHZ/64xIOUPIsF01sDKop5P7bRrT5SQQWyxB3SJeCHgE3Z6DmS9l/4+0/VVLHdCrG4+22DxAO2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70257+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1610564479675924.6331522130016; Wed, 13 Jan 2021 11:01:19 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id QKryYY1788612xvQkNt4YTBh; Wed, 13 Jan 2021 11:01:19 -0800 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.1163.1610564478485114580 for ; Wed, 13 Jan 2021 11:01:18 -0800 IronPort-SDR: gqSU9SqdhGSGMchS5JzZpJ3yQ9Y4gsDJxMWg/r0o1vFwDhP/1nHGJViiIqR1fZeZ97ETJyAfQb hXvKb25H3UMw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="174748394" X-IronPort-AV: E=Sophos;i="5.79,345,1602572400"; d="scan'208";a="174748394" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 11:01:17 -0800 IronPort-SDR: +l24925BHwozH/rUZYrFIpMbZKQ0HDBB5XgNml/Radc0qJ7Giu/2ehsUsPGvgt/Ci0KI08M8C4 bWlJFpu9yV9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,345,1602572400"; d="scan'208";a="397812313" X-Received: from plxs0284.pdx.intel.com ([10.38.240.7]) by fmsmga004.fm.intel.com with ESMTP; 13 Jan 2021 11:01:17 -0800 X-Received: from younghyu-desk1.jf.intel.com (younghyu-desk1.jf.intel.com [134.134.154.164]) by plxs0284.pdx.intel.com with ESMTP id 10DJ1Ger012273; Wed, 13 Jan 2021 11:01:16 -0800 From: "Park, Aiden" To: hao.a.wu@intel.com, ray.ni@intel.com, devel@edk2.groups.io Cc: aiden.park@intel.com, maurice.ma@intel.com, guo.dong@intel.com Subject: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Date: Wed, 13 Jan 2021 11:01:14 -0800 Message-Id: <20210113190114.19888-1-aiden.park@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aiden.park@intel.com X-Gm-Message-State: oQwVEsCbkvGazbVHOWMB1Pdux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1610564479; bh=NhDuSJDU7uUSvuDVYoPbhtaYwue9X9LXEnmuRfSEvFs=; h=Cc:Date:From:Reply-To:Subject:To; b=mi0OU0zI1WeO/H8Cr8TgH4p7JkfwdCjtDWVe0tWtkj4lu+krsS4sRjoa0IpF1IXiM2J l7czrMfrfNpQ/I70lUk9UEmHd9+ObKR7ERal8OoMx7L6T4GDXPbHC7MogKtO/Ntq+ZCkX ay/wK/X2HvkCil7/ZM8E9yezfZ8jVkzHIJg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Aiden Park The ProcessOptionRomLight() assumes that OpRom has already been processed in the previous full enumeration and updates AllOpRomProcessed flag to TRUE by default. However, this may not be applicable with other pre-stage boot firmwares. This will update AllOpRomProcessed flag properly by checking PciRomGetImageMapping(). Signed-off-by: Aiden Park Reviewed-by: Ray Ni --- MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeMod= ulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c index 1b64924b7b..e8337e865e 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c @@ -1168,12 +1168,7 @@ ProcessOptionRomLight ( ProcessOptionRomLight (Temp); } =20 - PciRomGetImageMapping (Temp); - - // - // The OpRom has already been processed in the first round - // - Temp->AllOpRomProcessed =3D TRUE; + Temp->AllOpRomProcessed =3D PciRomGetImageMapping (Temp); =20 CurrentLink =3D CurrentLink->ForwardLink; } --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70257): https://edk2.groups.io/g/devel/message/70257 Mute This Topic: https://groups.io/mt/79658545/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-