From nobody Mon Feb 9 19:30:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70247+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70247+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1610534048; cv=none; d=zohomail.com; s=zohoarc; b=T8JctLXv9RDBNPmic3UzsNC6buMosmbeCQ5H9MAwDtYO0yrdZ+wOdpKHFa0LIh9lqIrlsFAmZF17YF8377+1ZBpFl2HN6hKalVt8BruxLuhXvuXbnlu4c7Xf+BcR7gTDgQu1OA+RI2vIYMPBidaDom1zMzZXFfK80iz4oBFf7qg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610534048; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=88+59K+7dniZGUS5FmZxiw+yui33kzXkwwqmbE/7vRk=; b=U0YM2uVzgzlOji1asjpdznD0fpu/29UH1Lv/AnMHhw594squbkGkBVx6KKlIyFKV+W9yfd4z8hLhNpQ0VvCvSzOMUHSog6Yow7/EbpRC+t8BVeWJfNEbAVnZHYTBq/vj9LUml2qu0zVwkokJiw3aq+CodUjIMCKKq9vLtFTJPYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70247+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1610534048272697.11871049699; Wed, 13 Jan 2021 02:34:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id q9VUYY1788612xfqPn2V39gO; Wed, 13 Jan 2021 02:34:07 -0800 X-Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mx.groups.io with SMTP id smtpd.web08.6256.1610534047211932749 for ; Wed, 13 Jan 2021 02:34:07 -0800 X-Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DG3fq1tYfzMHTD; Wed, 13 Jan 2021 18:32:35 +0800 (CST) X-Received: from localhost (10.174.184.155) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Wed, 13 Jan 2021 18:33:45 +0800 From: "Jiahui Cen via groups.io" To: CC: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , Julien Grall , Leif Lindholm , Sami Mujawar , , , Jiahui Cen , Yubo Miao Subject: [edk2-devel] [PATCH v5 09/10] ArmVirtPkg/FdtPciHostBridgeLib: Refactor Get/FreeRootBridges() Date: Wed, 13 Jan 2021 18:33:30 +0800 Message-ID: <20210113103331.10375-10-cenjiahui@huawei.com> In-Reply-To: <20210113103331.10375-1-cenjiahui@huawei.com> References: <20210113103331.10375-1-cenjiahui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,cenjiahui@huawei.com X-Gm-Message-State: RH8zt290soH9Diks9CmxbJwhx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1610534047; bh=uz3RU7gDMrSB+PG2IEZruJvD/Bv5Tgsie5rplxonFhw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=awJR/OwJJcmTbV+FlfrygsHk4ykocGzwDyxMWtIBbNWhQEXn8k5vn50SW08iToqz2Hx NU1simhENEArQBzaxl1ckibuXtNy0YBugBR7I6gFG1dmbDZLSXz46JLgFITHvYKmMDIiL RVhCtdhWyWLblePZ+ZdMUlzZrtufk8mvYdk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Rebase ArmVirtPkg/FdtPciHostBridgeLib to the new PciHostBridgeUtilityGetRootBridges()/PciHostBridgeUtilityFreeRootBridges() functions. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3059 Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Jiahui Cen Signed-off-by: Yubo Miao --- ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 24 +++++---= ------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c b= /ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c index 3ec7992b6331..89582ef76eb3 100644 --- a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c +++ b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c @@ -272,8 +272,6 @@ ProcessPciHost ( return Status; } =20 -STATIC PCI_ROOT_BRIDGE mRootBridge; - /** Return all the root bridge instances in an array. =20 @@ -361,8 +359,10 @@ PciHostBridgeGetRootBridges ( PMemAbove4G.Base =3D MAX_UINT64; PMemAbove4G.Limit =3D 0; =20 - Status =3D PciHostBridgeUtilityInitRootBridge ( - Attributes, + *Count =3D 0; + + return PciHostBridgeUtilityGetRootBridges ( + Count, Attributes, AllocationAttributes, TRUE, @@ -373,19 +373,8 @@ PciHostBridgeGetRootBridges ( &Mem, &MemAbove4G, &PMem, - &PMemAbove4G, - &mRootBridge + &PMemAbove4G ); - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: failed to initialize PCI host bridge: %r\n", - __FUNCTION__, Status)); - *Count =3D 0; - return NULL; - } - - *Count =3D 1; - - return &mRootBridge; } =20 /** @@ -402,8 +391,7 @@ PciHostBridgeFreeRootBridges ( UINTN Count ) { - ASSERT (Count =3D=3D 1); - PciHostBridgeUtilityUninitRootBridge (Bridges); + PciHostBridgeUtilityFreeRootBridges (Bridges, Count); } =20 /** --=20 2.29.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70247): https://edk2.groups.io/g/devel/message/70247 Mute This Topic: https://groups.io/mt/79647755/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-